From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 80DBAA0505; Fri, 6 May 2022 03:37:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 36AD04014F; Fri, 6 May 2022 03:37:56 +0200 (CEST) Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2061.outbound.protection.outlook.com [40.107.104.61]) by mails.dpdk.org (Postfix) with ESMTP id BC97040042 for ; Fri, 6 May 2022 03:37:54 +0200 (CEST) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=P1EXpIkcKwYETMIkNWJ95Ocrx+6yGtq2NtVq7PmcHvZXP40jG7TT7L3OHfi9cAG+R6AIBv7CY/kwhXoDpe19nppX6Ga+ay2ui/E+DqU+ikj1vjU6+oMHgXkd6g1QTHzKIx66XBM4ApdQ0UWp+3jgh+WnMzLu2Ol5O4ECrKUjRxWEbzTthSigbUGtzyMzQFdChT4MpEeB/g+8kdlgUkD2ByP5vn1+KTvAAbKolwfztyogO0pWJeh4KmHaNdOOMSXyHwxC8lXEyBTZtwyt1UIj4G7/C8+LF0QuJVtWwHH1jx5bYnMBEOA+OuueMFY7rpyF+ijzCrE2IRL+Ghh53dIzkw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nkbhjFbQ3WOnF3D36v1Lvi/1lLQlsfNnRGs2oKMzEew=; b=goHBXZipUph0KhAPX2b9/OBV9NEvU+nThy5nuHis+jr3JSsISmwYisCx3hSwngNdVkRPY39yEq7n4Yd3zby9DEXJCngw9Fm0Dh+DLMaTGqntulzYPI71kjQkSUvgx1f4Xjmd4mOuTrYHON12v8+0cl2iEOcqxJd/6BA50cqlQEG++Fs3Obf/JAppTPOn8hlDspHPS0YzGKT279LESqLBRt04BHybPcIBI+rJhTS/7HHIZhgP4StOgKXntSc38xNt3OB0mFBn9pOXwkc70ENsvBnd1a1DdqSC2NhkWugphVy64tI3lrYUxrI4TfuiUtBP4KNZ69gJy3V+oGxzEFbQRA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=dpdk.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nkbhjFbQ3WOnF3D36v1Lvi/1lLQlsfNnRGs2oKMzEew=; b=cUEVJd+ru4aqgYXTEQuPpjxrObigibmRCwVKict4ZQULnRUVNU61bcVslaKT7xFtcF46FDCA9SA0AF4AnFAISUF1SIh75O4ARg7xagYDyhdpYcK5VGphkaWZcXFfkIUqzZbiCe3rMPzL5q2CTw3cDpCiLdGjqukbR//vpi6KW6E= Received: from DB6PR0301CA0015.eurprd03.prod.outlook.com (2603:10a6:4:3e::25) by AM0PR08MB4498.eurprd08.prod.outlook.com (2603:10a6:208:13c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.27; Fri, 6 May 2022 01:37:52 +0000 Received: from DBAEUR03FT039.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:3e:cafe::b7) by DB6PR0301CA0015.outlook.office365.com (2603:10a6:4:3e::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.27 via Frontend Transport; Fri, 6 May 2022 01:37:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT039.mail.protection.outlook.com (100.127.142.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Fri, 6 May 2022 01:37:52 +0000 Received: ("Tessian outbound 2d401af10eb3:v118"); Fri, 06 May 2022 01:37:52 +0000 X-CR-MTA-TID: 64aa7808 Received: from bdbe5a749f30.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E4BA68D5-B31F-4850-B008-167EFA12B5B5.1; Fri, 06 May 2022 01:37:46 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bdbe5a749f30.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 06 May 2022 01:37:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X9S7EGYZ5ZIy7p1/NPUCPXqLVdCRsZd+swazMLeIH9uKjLSGRaS/inccx2tZa3UI6POeKw6PoYbwVLfQf3e0rLBWCsZEfsdY56IYxaD6asZQ+y1FoKf1abMiLzvXJEq0UcVhVqHHvzuYmUR96LEq3C7pIyH3ohxaEl/DSnSbV0UllBMXmwB+DXSPshMeyANuMVPHvZxAjmCjyeu80D4lVJYSevrjeL+D4k/GUJQP5x5XVSGLonsanvujppzq03xKF/NSaYozQoKdSArDhhs6g37bmeoPMHJYfh73avJKTXs/4NYpOdBhBIBSz9XH8QT1GdLu68o4kSavm1oPhPcoHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nkbhjFbQ3WOnF3D36v1Lvi/1lLQlsfNnRGs2oKMzEew=; b=FNGUD8NC5FtSRvyUh+GYix7Hy2rRrrPbhrOxLhO8rGyTkzdbjvNWGEDeDUW8dFDyu2V+Y1Sar4BAnyi3pmELXeeoEQbL6X+uqkXs7wWZtUKnxnHhvkWQRRONO85Sa/Qeylcm5EMkgHYpNMO0t1sKQhQmFEwG0ewdpb9OFEr2jxZ8i3GM3jAQ1rV9DIP/7tHdwX1XU/J3/Z0T94smpO2JCbjLmkLn7HUlR/B2AxijEQ7lTzQXGAaxrmzqhJDLJisgUjwzLobmSPreV/8zBWdJJL5fR8Xv3HX4e7tvP4XCW8dUvY41azghVlYLVUf7uFraguwVKjCELvwWq2EQ5e61mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nkbhjFbQ3WOnF3D36v1Lvi/1lLQlsfNnRGs2oKMzEew=; b=cUEVJd+ru4aqgYXTEQuPpjxrObigibmRCwVKict4ZQULnRUVNU61bcVslaKT7xFtcF46FDCA9SA0AF4AnFAISUF1SIh75O4ARg7xagYDyhdpYcK5VGphkaWZcXFfkIUqzZbiCe3rMPzL5q2CTw3cDpCiLdGjqukbR//vpi6KW6E= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by AS8PR08MB7816.eurprd08.prod.outlook.com (2603:10a6:20b:52e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12; Fri, 6 May 2022 01:37:45 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::44cf:1f8d:e477:1f99]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::44cf:1f8d:e477:1f99%6]) with mapi id 15.20.5206.027; Fri, 6 May 2022 01:37:45 +0000 From: Honnappa Nagarahalli To: Stephen Hemminger CC: "dev@dpdk.org" , nd , nd Subject: RE: [RFC] rte_ring: don't use always inline Thread-Topic: [RFC] rte_ring: don't use always inline Thread-Index: AQHYYNHmId4l1/D/6UKz4cX05KFGVK0Q5ZpwgAADX4CAACh60A== Date: Fri, 6 May 2022 01:37:45 +0000 Message-ID: References: <20220505224547.394253-1-stephen@networkplumber.org> <20220505161027.62fa50d8@hermes.local> In-Reply-To: <20220505161027.62fa50d8@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 059179FC8498F94682A22C7FE6BC2A06.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: db609f28-cc89-480b-93da-08da2f010944 x-ms-traffictypediagnostic: AS8PR08MB7816:EE_|DBAEUR03FT039:EE_|AM0PR08MB4498:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 1ydcQ7ahY+OdKlny77pDUjCPhc8bIyziKIGBDGzGFsMlCvPEWNR3Mw9zXy3G+qH3CaGNgMq82+n3vDI1Wq70ZmVXiEq/9VXHcE7HEnfOH9xOm8T220X/SyXoZuHxMjP+X37Hs9WfUELZgkXatibRjACwnMU334tkhyAyWSWeagJYfsZBc9/UKKNR41Y1UzGCYdw+UJqE0vEzQzJoHnScEC/lr4LR/y8JSBl82dhK3Lg+KtHaAsJdii16ywxvsHneF3vPlSYGcOq115QcGQM+OBBGcYap3lPhfqMfrGBfIzMeDHZhEH4x7GhPbLw/uijjHGNGdUrflYbqVXaZ4jQzSPDwiLbnyvG9TRR70OWwx38GMVzviv9EhO59CFud2u4fLmhg1jCP2T8tHEFZyKL7KG+wqskZVVpsFklFtC8IfJdfNl8qFgWmZrgI/9O4jbMRJM8oeMR4V5vjBaZ6qevjr5vFAw8OxWMdW5vRge2UKwnCks59azuP/hA7wyZxvxfj/+W+4y4Lt/KHrEPt1QPoR6Mgj/7VLPoubnWNVR5HIeNfh025NY/P40tzTvPInYe9P5GY/9tS/AuFV3Xqllo5uAb+4ABZDLgf3ctqhkS4Da9Sp8IJWQWtqwacu+9b74mZ3FGl92IK2dECuONABhE0oI/fhOBx084lQcZ78tkjpxEdYri64BQcvFGbQu0ewcnysgbfGNCtT2CnEUYBtehMqg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(55016003)(8936002)(122000001)(316002)(38100700002)(6916009)(38070700005)(54906003)(508600001)(86362001)(7696005)(52536014)(33656002)(53546011)(83380400001)(6506007)(186003)(2906002)(5660300002)(26005)(9686003)(71200400001)(76116006)(66946007)(66556008)(4326008)(8676002)(64756008)(66446008)(66476007); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7816 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7f19267b-56f1-4ede-9dfe-08da2f0104f7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +TKOk5Us3s6UcQ7XlUUcaEffrinrz2A0pOrQXm8zQ4UcVxyXp5fmr7wgz9fpUnPwRNHZ3gvE+WxVao94fzJ7zIKwFDjw+pHh+5WsHWrnswAwEKcAnJaJSGfY7WsVhGjH2hFmSxKpF75CssXSVobLFjVVIqm71E1hxSNNjaS8WP9HY2ZioX8LaXRwLDT5hBGOopBYfCnln+Jo20JgdZs/wf4uePBDPgnd43Wk/I5fmvXW2Se+LcYTQ8jn4jJTcoy+B1ARj504JcOnMIe0VFkFRfppDh5T9WX2Qr/TZTCetpyFLNAHvXZ986bzRwCxdbsX6p4IiIDnGb4cYkdFF4KpMn+KgGaB7VzsQuwzNnynB2ByqFH1ekBbgkjeoakccrHTt1+bfC3GQFkn/nTJ7UzDZEXGXLvT5I3WK2QXzcXUuTRwlG1Azw843ugH/2ZQE7CMLtzxQHFZS06Kbu3GasCqZeZ+WTx9bclIbAhIKF9/o4eVRVcfBiyTcBxv/nBfKmjcVDz4gJXGvJ+z32SRGRLF6UTyekj58n7iUQSyfwLMPSeQdZpU96Em2V6uKsO1LyEcxbyNrPzUiZdl5tLdJPEwc3ud8x/4atxONtnWlzBeQU40F7EJ+q27MnW8FIbaBuAv0ntU+2uVAgBjP/AahRBJKx/EHeQvl7eB3QVTOrqoXuM= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(2906002)(316002)(81166007)(52536014)(5660300002)(8936002)(186003)(82310400005)(356005)(70586007)(7696005)(6506007)(53546011)(36860700001)(70206006)(40460700003)(55016003)(83380400001)(4326008)(6862004)(8676002)(508600001)(33656002)(336012)(47076005)(86362001)(54906003)(9686003)(26005); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 01:37:52.3308 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: db609f28-cc89-480b-93da-08da2f010944 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4498 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org >=20 > > Thanks Stephen. Do you see any performance difference with this change? > > > > > -----Original Message----- > > > From: Stephen Hemminger > > > Sent: Thursday, May 5, 2022 5:46 PM > > > To: dev@dpdk.org > > > Cc: Stephen Hemminger > > > Subject: [RFC] rte_ring: don't use always inline > > > > > > Forcing compiler to inline with always inline can lead to worse and > > > sometimes broken code. Better to use the standard inline keyword and > > > let compiler have some flexibilty. > > > > > > Signed-off-by: Stephen Hemminger > > > --- > > > > > > This is RFC because the use of large scale inlining is debatable. > > > This change may slow things down on some versions of Gcc and > architectures. > > > > > > If you follow Linux kernel list, this has been a debated topic over > > > the years, with opinions for and against inlining. > > > Combined with bad inlining in various Gcc versions. > > > > > > lib/ring/rte_ring.h | 36 ++++++++++++++++++-----------------= - > > > lib/ring/rte_ring_c11_pvt.h | 6 +++--- > > > lib/ring/rte_ring_elem.h | 36 ++++++++++++++++++-----------------= - > > > 3 files changed, 39 insertions(+), 39 deletions(-) > > > > > >=20 > I have not run performance tests and don't have the infrastructure availa= ble to > give a meaningful answer. The application we use doesn't make much use o= f > rings. >=20 > This was more in response to the RISCV issues. The RISC-V issue is due to a compiler bug. Should we be making these change= s due to a compiler bug in one architecture?