From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DD3EEA04B5; Fri, 6 Nov 2020 20:56:49 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6E1B2100C; Fri, 6 Nov 2020 20:56:47 +0100 (CET) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80054.outbound.protection.outlook.com [40.107.8.54]) by dpdk.org (Postfix) with ESMTP id 14B2BF64 for ; Fri, 6 Nov 2020 20:56:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZNG2J5YUBCCDlRYNFa4y3PDQopOOnmyduK/hlOQNr+c=; b=hf4qBlfpcEmJ6EHT9YJzA7n3T+nTblBYeWPP58PezLs0Tp3sY66ifCBWCUAxeNqNewXMgqxY9UuVBdBJL2QHE+vB88k/CVKKt10f2JZZ4k40AvD6THJNB4J0pOdS7DjLcQjbk0SYu9TgCbcVHtqF+N0R72AhrSkW8pLWhnsKZPw= Received: from AM6PR10CA0040.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:80::17) by AM0PR08MB4561.eurprd08.prod.outlook.com (2603:10a6:208:12d::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Fri, 6 Nov 2020 19:56:39 +0000 Received: from AM5EUR03FT009.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:80:cafe::10) by AM6PR10CA0040.outlook.office365.com (2603:10a6:209:80::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21 via Frontend Transport; Fri, 6 Nov 2020 19:56:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT009.mail.protection.outlook.com (10.152.16.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.17 via Frontend Transport; Fri, 6 Nov 2020 19:56:39 +0000 Received: ("Tessian outbound 082214a64d39:v71"); Fri, 06 Nov 2020 19:56:39 +0000 X-CR-MTA-TID: 64aa7808 Received: from a9e4e8ce98b0.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id AD635695-B65A-4984-B4A6-002D26223431.1; Fri, 06 Nov 2020 19:56:34 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a9e4e8ce98b0.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 06 Nov 2020 19:56:34 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P8FNw5IAgMeLhHpBUGDw4GZADjARYSllXNXuXkXbEOCTx6PMJa7XQh85n2/oR5gvT5jp+PUVaocTdI2AOqgb4VvUS0gUSN5z51reeo4cmg7DtTS0iy8syy2hSbFXEvwhjvq/C7UgQS3MRpka2n3OLz14XxhIzxEbOQeIQCUIBB6AvQWUYgtMEVeoB6hA+qUNBdn+CF/HKG2yA8pY6T0dLDlqjARFPhJbuwCVMOhKW/hsd870gjKPQ3xzdd4xrXdDps3Y+GFpEHxWjYIbi4u5aX+18zgCB6tQHMiLsAG7aE2+hTFhL6JY6gdOHMA+KFuaonLWP4MRzkyrrFJCci+uwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZNG2J5YUBCCDlRYNFa4y3PDQopOOnmyduK/hlOQNr+c=; b=ADZpXid9GY7NHHzQpgRBmMMfRng2P/mcNo6CBjd+v9lF128eYYZEdaZ3LWYnRUuZP/LH6COzOqkop+52Mz3vtW7JS7O/r044wZsZt+bPGfa9vbR7HU1aimxzDXvmqLwbHQkOIdLTCYAo35yzFyhZI66i1yzleLk3gnb6QdYSGIktTovrALLezsc1t9Sjr3q7UqQwh5HkYkOIU607NEV0/rOSxsQVFCK/+zYM/QVp9q+shJixuPpFXaztWkNNPvVjJW5/TVh2PGImJqBHAHdZMUY5E3aecZ3/ZtPc15pKlP/Vq3/bCKu0xFYu7FQ9GMd3KVlSVG/MnZ6YJGPa/TSI7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZNG2J5YUBCCDlRYNFa4y3PDQopOOnmyduK/hlOQNr+c=; b=hf4qBlfpcEmJ6EHT9YJzA7n3T+nTblBYeWPP58PezLs0Tp3sY66ifCBWCUAxeNqNewXMgqxY9UuVBdBJL2QHE+vB88k/CVKKt10f2JZZ4k40AvD6THJNB4J0pOdS7DjLcQjbk0SYu9TgCbcVHtqF+N0R72AhrSkW8pLWhnsKZPw= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DBBPR08MB4443.eurprd08.prod.outlook.com (2603:10a6:10:c8::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Fri, 6 Nov 2020 19:56:32 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::7814:9c1:781f:475d]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::7814:9c1:781f:475d%4]) with mapi id 15.20.3541.021; Fri, 6 Nov 2020 19:56:32 +0000 From: Honnappa Nagarahalli To: "thomas@monjalon.net" CC: 'Ferruh Yigit' , Jiawen Wu , "dev@dpdk.org" , "david.marchand@redhat.com" , "konstantin.ananyev@intel.com" , nd , Honnappa Nagarahalli , nd Thread-Topic: [dpdk-dev] [PATCH v4 00/58] net: txgbe PMD Thread-Index: AQHWs1YqGJ+Rz3T5Ekq9s5s5Zk/si6m7ayvwgAAMdYCAAA8scA== Date: Fri, 6 Nov 2020 19:56:32 +0000 Message-ID: References: <20201019085415.82207-1-jiawenwu@trustnetic.com> <3558935.noZgFSCOjD@thomas> <1638514.6lRH5zx6jk@thomas> In-Reply-To: <1638514.6lRH5zx6jk@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 258D9083C50E94458546A3AFC27D034F.0 x-checkrecipientchecked: true Authentication-Results-Original: monjalon.net; dkim=none (message not signed) header.d=none; monjalon.net; dmarc=none action=none header.from=arm.com; x-originating-ip: [107.77.222.32] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: b99169d7-72f0-4712-9631-08d8828e1396 x-ms-traffictypediagnostic: DBBPR08MB4443:|AM0PR08MB4561: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:6108;OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: xqCyDXvrm8cPg8CZKYtiikAz5kJIf8W2rAVTeXsMlFqc8qKupqSHFh0SzsDbcM0onm38ppGpp2OqulX4cDjfaVXAoEAxD9pORVKdOgGZull8N6q7CabERW9gUBe4odhYyMAe3Yk3fQU6EAhJQRXo4XUS+5AfmErHrPXt12kGnHWQYAyZWxwqRi4mYgTIRJRnODdZio5nX2QXbCToiLst5ZgAH2zUG8NwRGyYgNmXNVVT6VfVchA432o97a68MFyVzGol4JH5tJNxX31amqWe8gvSsP5vwq+/Ahg688P1U7DRa7sVqIrws2EPoqmLBT+b7v7trC8A55c9hkfOLdUjKA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(376002)(136003)(346002)(39860400002)(366004)(6916009)(8676002)(2906002)(6506007)(26005)(66946007)(33656002)(76116006)(4744005)(8936002)(66556008)(86362001)(9686003)(64756008)(66476007)(52536014)(66446008)(7696005)(478600001)(186003)(5660300002)(71200400001)(316002)(4326008)(55016002)(54906003)(53546011)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: tDkfy9nVNhbKBbuGGQG9p50y/a9/+lJBa7w4U8YMyfm7FSEzEURyMYeaBOXwFRn+ShUA12DTHkFQsjfuPE8Y5D2GYZ9aCZK7XtQko6Mrn4nMBe/jRhbmdu2mnk0a720CatcG+HJvjnI6caTh7gKM6OkRpm1v1BgQdbQ4kFVgbzKioVfjI6bUkuEpAjpygnx7ULehIvvgD3OjdcXyWgGH/wuxxA0l7dzTl/twpvfC1CUDkjXCu6K7nsQYGh259/vhJZSJrNvy2WoUkyA+NruPE7HdWCvlhDMwlPoBpRavO6Vu/wciwGJuRnm+1/B1SvD6rXBI4Ea4mQrTUC2PC7Lf8yxuAL+l9C5+avhXy2YRjmahyAdwODLb+F4swiv0iP7GQcb8wusx6QwzZPXkUWv0O+fsaXaysRvEyrqdqdTAO1bM3KwCzDRQZ8Vkw2WNuashG3BBpDntSe8DTfcCvL90hfkTxVL4VG+ZISGadBphT56Xdz7NS2Lld3mTR2F/Hw9WSio9N5xjtbmahSTU4zqnZVCwCgDcuRiij9QCrayovLwxQrefULMT8BcwaG8Gl0gz0Kvw86HsMDHgLXMpi5gKHxWpQ/r8mxesM6nQMaiA7v+FSs7iSLOJJsyUfVhYvDeeEvl2jQJip+rpn8MD8k4+YA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4443 Original-Authentication-Results: monjalon.net; dkim=none (message not signed) header.d=none; monjalon.net; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: d3bd3b77-ab2b-43b6-75c6-08d8828e0f05 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zZb1WOVpydby2FLuhqUGXt9jXD4oLy04EmK8nyOgawhzCyRPb3eXzPw5h8XY2iKhKmm8L9BhiAr/YZ4S3Zef9BpoQavBYYD/FiyeUXUX5T4b0tQXxDDdCGY01z9P86x6Q4Te+g2Hib41ZhGvsDoYcvCUkxny1XbwWwn2M/lm1JJQuaaUj08ileMWXSynHNpFx3t27vituqOPzIo/uzmXF+3X3S5d6i3vMh0AiwhuVezyBcI1dq1IsScw/sDcWH1vjp6tnXtxzrN6rxkj4cQ/9lhDBX8dEkrmayEkg1+720K5iSEsJm6PRtsRSUtw18ONzCP48f1Pbsq1/s7wBuP1V/UtJINrFC6mln5d2PSEsv4tt6JdeaHisHs9lv56+xBIElUmcicgRipAPF4Bex575Q== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(376002)(39860400002)(136003)(396003)(346002)(46966005)(6506007)(33656002)(52536014)(6862004)(8936002)(7696005)(53546011)(86362001)(356005)(2906002)(478600001)(70586007)(70206006)(4326008)(47076004)(5660300002)(186003)(82740400003)(26005)(55016002)(36906005)(83380400001)(81166007)(82310400003)(54906003)(8676002)(9686003)(316002)(4744005)(336012); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2020 19:56:39.7928 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b99169d7-72f0-4712-9631-08d8828e1396 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4561 Subject: Re: [dpdk-dev] [PATCH v4 00/58] net: txgbe PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > 06/11/2020 19:21, Honnappa Nagarahalli: > > > 05/11/2020 09:55, Jiawen Wu: > > > > On Thursday, November 5, 2020 9:55 AM, Jiawen Wu wrote: > > > > > On Thursday, November 5, 2020 1:24 AM, Ferruh Yigit wrote: > > > > > > On 11/3/2020 11:08 PM, Thomas Monjalon wrote: > > > > > > > When pulling in the main branch, I see some checkpatches > > > > > > > warnings (in order of criticality): > > > > > > > Using rte_smp_[r/w]mb > > > > > > > Using rte_panic/rte_exit > > > > > > > Using compiler attribute directly > > > > > > > > > > > > > > Please could you fix them (at least first two) before the sec= ond > series? > > > > Thomas, IMO, these should result in errors in checkpatch, not just warn= ings. > > Do you see any issues? >=20 > The problem is that there are too many false positives in checkpatch. These two, mentioned above, should be pretty straight forward. Have you see= n any false positives with these> >=20 >=20