From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E97BA0527; Mon, 9 Nov 2020 23:44:05 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E8B7A6947; Mon, 9 Nov 2020 23:44:02 +0100 (CET) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20074.outbound.protection.outlook.com [40.107.2.74]) by dpdk.org (Postfix) with ESMTP id 6D8B86889 for ; Mon, 9 Nov 2020 23:44:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uiK4+rMqrzFiY0HYcWbg3IzrcpwYX6eyOa70jDzn64Q=; b=MHX0e2yrOzzFxSd64S1RboAky0yWf49GjSotT7f+ExQMwvpOFoD0qsXg9VMsmI4j1Tz3XS1TZgAqNKWqHAQji6a+lf+SOv5o6hPgUUKItcK3ss2QZtIq4f0oa/o0aE0eCg8AABlYu9pEck9IRRW0n18PpWKv0QdljbW1XI3Iekg= Received: from AM7PR03CA0003.eurprd03.prod.outlook.com (2603:10a6:20b:130::13) by AM0PR08MB4004.eurprd08.prod.outlook.com (2603:10a6:208:12a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.27; Mon, 9 Nov 2020 22:43:51 +0000 Received: from AM5EUR03FT016.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:130:cafe::df) by AM7PR03CA0003.outlook.office365.com (2603:10a6:20b:130::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21 via Frontend Transport; Mon, 9 Nov 2020 22:43:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT016.mail.protection.outlook.com (10.152.16.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.17 via Frontend Transport; Mon, 9 Nov 2020 22:43:51 +0000 Received: ("Tessian outbound 13ed5f5344c0:v71"); Mon, 09 Nov 2020 22:43:51 +0000 X-CR-MTA-TID: 64aa7808 Received: from bb5a0873a52f.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CEDFC177-A4D3-4CB8-9DF6-409E9B774056.1; Mon, 09 Nov 2020 22:43:46 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bb5a0873a52f.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 09 Nov 2020 22:43:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iy1M15xSig47UiZ4P0oFh2pZO7dF1gAxGOBDWPejplsTtWs2L0h+M839Ie11XP+0c6P8cQ4xrs7mZn/yXjNpiniHXeTEvhlmqKXr2VA/xKc4rVb8TdB+jNwXHZI6Mi+IeGLBolN5aQeOv01CctLvV47xomhxdkbKhZX6aEY86q/T7JMqvMpV+37QN7HA60PcPo+vM62d34FEexISwI07kX0t730j9+YJkWMZhD5rmCcrOb1e9EApKcH/r0gnPrkbbJuKmaQ6QsI8HkcmE6i1ElKezVg4mCZJ65gXptuOUgxcnuCcHZKWt8xzjKXcvSXmQf9l5DHVmKwl7FSzHvA2rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uiK4+rMqrzFiY0HYcWbg3IzrcpwYX6eyOa70jDzn64Q=; b=l45h+LBEbgpWDTi6lBuytt7/cOw8e32PGDFbyYI6GAPwzyU0kwArLWshaBoU9+A2OkmcNEBkeAC1OqN9UfLBN15tbPgX9MfZHK6k5p1D8LgUjEG/VNChlTLfgmekAEIhgvH1goy0rPYly1P0WS5WrwiDadzd5jkyZVq0KHqvNySFQIN+WZ5kafg2D0ZdASmSZZRnmQN3jSV0Qa20FJ8LvZurgn47pRcqRaSjbAJtV38zVtSiDAwKqtmwuIDBLjLV6YVO4bkTMkpRcNFejAWiz3TN2aCTOoAmCEP4hgwLiaYDD7YaqdVw+7ZLuazBPf0LDEJe0QLvXeGXyYQ9/YZCnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uiK4+rMqrzFiY0HYcWbg3IzrcpwYX6eyOa70jDzn64Q=; b=MHX0e2yrOzzFxSd64S1RboAky0yWf49GjSotT7f+ExQMwvpOFoD0qsXg9VMsmI4j1Tz3XS1TZgAqNKWqHAQji6a+lf+SOv5o6hPgUUKItcK3ss2QZtIq4f0oa/o0aE0eCg8AABlYu9pEck9IRRW0n18PpWKv0QdljbW1XI3Iekg= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DB7PR08MB3881.eurprd08.prod.outlook.com (2603:10a6:10:77::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Mon, 9 Nov 2020 22:43:44 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::7814:9c1:781f:475d]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::7814:9c1:781f:475d%4]) with mapi id 15.20.3541.025; Mon, 9 Nov 2020 22:43:44 +0000 From: Honnappa Nagarahalli To: "Walsh, Conor" , "Ananyev, Konstantin" CC: "dev@dpdk.org" , "Chen, LingliX" , nd , Honnappa Nagarahalli , nd Thread-Topic: [PATCH v1] app/test: zcd needs to be initialised to fix gcc compile error Thread-Index: AQHWsszTRxk6cC6E8kGHmDv39SBl8am4TxpAgAezxQCAAAUUMIAABuCAgAAEwTCAAATNgIAAVRfQ Date: Mon, 9 Nov 2020 22:43:44 +0000 Message-ID: References: <20201104170306.1688771-1-conor.walsh@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 0D645750A5289E4FBE7D327B53564D98.0 x-checkrecipientchecked: true Authentication-Results-Original: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [107.77.222.10] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: f019cb82-579f-4365-69b6-08d88500ee5a x-ms-traffictypediagnostic: DB7PR08MB3881:|AM0PR08MB4004: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:6430;OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: N8eX4mESmzYx5CQ1DZv67/qra+27h5xo5LVEV+hsEf89PR1kwiwOz9AHPz9MoUdm/t7Xbe0cG3mC8rPm6WXSFNNOf9kKYp+gUNDJk06O0kcCHsji1WPZGz45tY4my/BSpX3aiqr9STfbFZoBh+YhnPj6ugRaiOrdkyadZWTwjKLWjiHMpqIGhb5dCATWxXXQDWnoBiVfqJoOn11WEh3oBacVsTSHVRZRHe5pRG7nuocSjdG3gGG+2W32WgqajfhAXBJBfdIQGso6MfNzsc5PN2W4NjAiyVf03Z6XeMPPWuGrai6CbbylNnLetBuTrTLmdCrHHqKvNDtrA2iioY3ctw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39850400004)(366004)(396003)(346002)(376002)(9686003)(7696005)(55016002)(33656002)(5660300002)(26005)(110136005)(54906003)(52536014)(76116006)(186003)(8936002)(66946007)(83380400001)(8676002)(478600001)(71200400001)(66476007)(64756008)(4326008)(2906002)(66556008)(66446008)(6506007)(86362001)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: TyroC76zxYtHaU0WBO1mEXeKBLQj0StFC3xdTNgUU/XxK3syyMHWy0RPku1QQNcIBWXM41ME5seu3pLhcg1oqqpY5bxxtrJN6KzOiDgEmrgE+FAJ3TV6UhgO/bxvHt3kEQLB+tiR8YuN0V+kK2jhRCJXgGmiNuCILHNg9a1KTtpC6c31wC3KYWA5rzOhPzsaHs3p73NBPOgtZhcpSkKkOEIoSRHBpvnqCSkAcMvEpFyv9SPzwxh2juM2BfHDCs0+qX/EZI24n/7C8F7Qhn7LHJ5JJVK1shiwrI117fU5z8ITxJsrzb3NafvgqsQQhmuDRas7Ru7RIdWRj/XuczTsr2Cu/Hk2tV7NO4RK767HXWE1bQJ/aDvXYN5To0sSbu7gLFYICeAUgwjQQIVdl4a3wEDyTCP4c6a+iqo8W0lU5t+mqcbHWtcxPpt8VuvBvgRzJrI9VXtARW8OhLnHQuDPNTaJM1NSR6YgWW6iqJ4xdJEFjXomIjQD8YH2P9WQmSArX1/xGM7I6GjsWnJfdlNZIJZfO87pI1CeYBSNzUFLszqmGwfMWVB7TC53WC9V9q0iyZv5HRCpzaX/Ljge8Zvn7z5XDqrlB41SYrsxIlK88sa7TLmtTS2JvJtCdpo0sOkdXM8M2RERr83shmpMw4IU6RDQAA+HtwpjxXzlmGgVEBNDnqF2YIYacgDUueG2tJtwV/Q5l4v5t95Rs0OU9lhq0ib2bnXz81Sfi0el3V7j7f2OBcTS7qKKm9vTr1nzygGzNtBEIlveRZtlFP3jOIFIjKOJ8B1YuAw6uLdsttb35hhEntqbNMllNIpOl32nKHC+8LQthfayeoM9ddo2MhGxnmiiCOvoX0U8sXr64hAhfSpMsnaJqgb6iA5z4DXLYGQfKA5nYHJPqoUW7yR1fktnwQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3881 Original-Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: b2de5ba1-b943-4c9b-9a36-08d88500e9bd X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AZUby2IPoYCTB/VRxH6T/jxCN/efmlnwbtVJlcuLL/EXHB/OLbCheFeGm+asxmr3YNJvcPvccbLSHG4rjiBv/e90YjuUgoPAaFK3u5uTIIjAX+1DcTHa4xgSqYSX8Xh1qPIz6bIcrH2YukUQ7iefUg061NXdQazuGMqBXVXzzgL7kYAAkLqI1scnk+yhuuW3P+5S3eklJAg07Q5ZHnXoPUu1wjziDszVOCU3nxdmG8F0IwCshFmbfSDePNWGyoewjdVPh90NTuzmju56BPNrgMQI7sTZc6p/zSFV0rqChjy4v8blVlt7ypDRwwVU7YZDP9JyDXt2r9mpReRUepgiOV5x6PDb638xX36DZvlUNdFfySHp+jlL7uBjbCInf2XVwOjJ4Lid38S2AgFI8CFiyw== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(376002)(346002)(396003)(136003)(39850400004)(46966005)(5660300002)(8936002)(9686003)(336012)(86362001)(52536014)(26005)(70586007)(70206006)(186003)(55016002)(54906003)(81166007)(316002)(110136005)(47076004)(36906005)(7696005)(8676002)(33656002)(82740400003)(83380400001)(6506007)(478600001)(82310400003)(2906002)(356005)(4326008); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2020 22:43:51.7712 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f019cb82-579f-4365-69b6-08d88500ee5a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4004 Subject: Re: [dpdk-dev] [PATCH v1] app/test: zcd needs to be initialised to fix gcc compile error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > > > > > [2339/2407] Compiling C object app/test/dpdk- > > > test.p/test_ring_mt_peek_stress_zc.c.o > > > FAILED: app/test/dpdk-test.p/test_ring_mt_peek_stress_zc.c.o > > > gcc -Iapp/test/dpdk-test.p -Iapp/test -I../app/test -Ilib/librte_acl > > > - I../lib/librte_acl -I. -I.. -Iconfig -I../config > > > -Ilib/librte_eal/include - I../lib/librte_eal/include > > > -Ilib/librte_eal/linux/include - I../lib/librte_eal/linux/include > > > -Ilib/librte_eal/x86/include - I../lib/librte_eal/x86/include > > > -Ilib/librte_eal/common - I../lib/librte_eal/common -Ilib/librte_eal > > > -I../lib/librte_eal - > > Ilib/librte_kvargs - > > > I../lib/librte_kvargs -Ilib/librte_metrics -I../lib/librte_metrics - > > > Ilib/librte_telemetry -I../lib/librte_telemetry -Idrivers/bus/pci - > > > I../drivers/bus/pci -I../drivers/bus/pci/linux -Ilib/librte_pci > > > -I../lib/librte_pci > > - > > > Idrivers/bus/vdev -I../drivers/bus/vdev -Ilib/librte_bitratestats - > > > I../lib/librte_bitratestats -Ilib/librte_ethdev > > > -I../lib/librte_ethdev - Ilib/librte_net -I../lib/librte_net > > > -Ilib/librte_mbuf -I../lib/librte_mbuf - Ilib/librte_mempool > > > -I../lib/librte_mempool -Ilib/librte_ring - > > I../lib/librte_ring > > > -Ilib/librte_meter -I../lib/librte_meter -Ilib/librte_bpf > > > -I../lib/librte_bpf - Ilib/librte_cfgfile -I../lib/librte_cfgfile > > > -Ilib/librte_cmdline - > > I../lib/librte_cmdline > > > -Ilib/librte_cryptodev -I../lib/librte_cryptodev > > > -Ilib/librte_distributor - I../lib/librte_distributor > > > -Ilib/librte_efd -I../lib/librte_efd -Ilib/librte_hash - > > > I../lib/librte_hash -Ilib/librte_rcu -I../lib/librte_rcu > > > -Ilib/librte_eventdev - I../lib/librte_eventdev -Ilib/librte_timer > > > -I../lib/librte_timer -Ilib/librte_fib - I../lib/librte_fib > > > -Ilib/librte_rib -I../lib/librte_rib -Ilib/librte_flow_classify - > > > I../lib/librte_flow_classify -Ilib/librte_table > > > -I../lib/librte_table - > > Ilib/librte_port > > > -I../lib/librte_port -Ilib/librte_sched -I../lib/librte_sched > > > -Ilib/librte_ip_frag > > - > > > I../lib/librte_ip_frag -Ilib/librte_kni -I../lib/librte_kni > > > -Ilib/librte_lpm - I../lib/librte_lpm -Ilib/librte_graph > > > -I../lib/librte_graph -Ilib/librte_ipsec - I../lib/librte_ipsec > > > -Ilib/librte_security -I../lib/librte_security - > > > Ilib/librte_latencystats -I../lib/librte_latencystats > > > -Ilib/librte_member - I../lib/librte_member -Ilib/librte_node > > > -I../lib/librte_node - > > Ilib/librte_pipeline > > > -I../lib/librte_pipeline -Ilib/librte_rawdev -I../lib/librte_rawdev > > > - Ilib/librte_reorder -I../lib/librte_reorder -Ilib/librte_stack - > > I../lib/librte_stack - > > > Idrivers/mempool/ring -I../drivers/mempool/ring > > > -Idrivers/mempool/stack > > - > > > I../drivers/mempool/stack -Idrivers/event/skeleton - > > > I../drivers/event/skeleton -Idrivers/net/bonding > > > -I../drivers/net/bonding - Idrivers/net/ring -I../drivers/net/ring > > > -Ilib/librte_power - > > I../lib/librte_power - > > > Ilib/librte_pdump -I../lib/librte_pdump -Idrivers/crypto/scheduler - > > > I../drivers/crypto/scheduler -fdiagnostics-color=3Dalways -pipe - > > > D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -Werror -O1 -include > > > rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat-nonliteral - > > > Wformat-security -Wmissing-declarations -Wmissing-prototypes - > > Wnested- > > > externs -Wold-style-definition -Wpointer-arith -Wsign-compare > > > -Wstrict- prototypes -Wundef -Wwrite-strings -Wno-packed-not-aligned > > > -Wno- > > missing- > > > field-initializers -march=3Dnative -mno-avx512f - > > DALLOW_EXPERIMENTAL_API - > > > Wno-format-truncation -D_GNU_SOURCE -fno-strict-aliasing - > > > DALLOW_INTERNAL_API -MD -MQ app/test/dpdk- > > > test.p/test_ring_mt_peek_stress_zc.c.o -MF app/test/dpdk- > > > test.p/test_ring_mt_peek_stress_zc.c.o.d -o app/test/dpdk- > > > test.p/test_ring_mt_peek_stress_zc.c.o -c > > > ../app/test/test_ring_mt_peek_stress_zc.c > > > ../app/test/test_ring_mt_peek_stress_zc.c: In function > > > '_st_ring_dequeue_bulk': > > > ../app/test/test_ring_mt_peek_stress_zc.c:13:11: error: variable 'm' > > > set > > but > > > not used [-Werror=3Dunused-but-set-variable] > > > uint32_t m; > > > ^ > > > ../app/test/test_ring_mt_peek_stress_zc.c: In function > > > '_st_ring_enqueue_bulk': > > > ../app/test/test_ring_mt_peek_stress_zc.c:31:11: error: variable 'm' > > > set > > but > > > not used [-Werror=3Dunused-but-set-variable] > > > uint32_t m; > > > ^ > > I am not sure why you are seeing the above error. >=20 > m is being set but is only being used in the line that I commented out, i= f that > line needs to be removed then m doesn't need to be set or declared. > E.g. below. >=20 > test_ring_mt_peek_stress_zc.c:9 > static inline uint32_t > _st_ring_dequeue_bulk(struct rte_ring *r, void **obj, uint32_t n, > uint32_t *avail) > { > uint32_t m; > struct rte_ring_zc_data zcd; >=20 > m =3D rte_ring_dequeue_zc_bulk_start(r, n, &zcd, avail); > //n =3D (m =3D=3D n) ? n : 0; > if (n !=3D 0) { Sorry, the above 'if' statement should be as follows: if (m !=3D 0) { > /* Copy the data from the ring */ > test_ring_copy_from(&zcd, obj, -1, n); > rte_ring_dequeue_zc_finish(r, n); > } >=20 > return n; > } >=20 > Thanks for looking into this. >=20 > > > >