From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94D86A0A0F; Fri, 4 Jun 2021 18:12:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5A0EB4068F; Fri, 4 Jun 2021 18:12:19 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2075.outbound.protection.outlook.com [40.107.21.75]) by mails.dpdk.org (Postfix) with ESMTP id 456B340147 for ; Fri, 4 Jun 2021 18:12:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fb5ZcJseQbYel6qxkdslThe/i9zGaj0N7h5PAMVJSTI=; b=4ATlfC6qRUJFK3wPMFXkOu+KjkK5O7M0NT6P3eovmRod85ca4oKAfI2bRSjsSRQPMevHgfZNIujlR8Bv/OKX/bz5bCd7yZlWTiv9FYHnUhEk+pP0muupmcHlkGgW9UFgfT0iKe4eQ0OrmBVGEFhhjiV2HLskVRr1fhaVYZhJjCA= Received: from AS8PR04CA0072.eurprd04.prod.outlook.com (2603:10a6:20b:313::17) by AM8PR08MB5827.eurprd08.prod.outlook.com (2603:10a6:20b:1da::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.22; Fri, 4 Jun 2021 16:12:17 +0000 Received: from VE1EUR03FT025.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:313:cafe::b1) by AS8PR04CA0072.outlook.office365.com (2603:10a6:20b:313::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.22 via Frontend Transport; Fri, 4 Jun 2021 16:12:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT025.mail.protection.outlook.com (10.152.18.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.21 via Frontend Transport; Fri, 4 Jun 2021 16:12:16 +0000 Received: ("Tessian outbound 836922dda4f1:v93"); Fri, 04 Jun 2021 16:12:15 +0000 X-CR-MTA-TID: 64aa7808 Received: from 31ef6fd95bbf.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3BACDF41-D1A6-457D-8ADA-29998498B55C.1; Fri, 04 Jun 2021 16:12:06 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 31ef6fd95bbf.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 04 Jun 2021 16:12:06 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SHbc253slrYmY0/EF0O+47ybn4oIz+wJd8y9OhArVCFBVT7AE+nZKaNAQNJcA9DTzoIsmi7ODFrxzuSc1J4TYS/HSxeq3pjfosoveZKP6OT55BPNyO7sOvAxQL7wY1dGQLIA8wFmcEU+9kSoHKWmUIE22iV4fyya9D3TFHQtVRmscxeq8p2VAkV/NjDhblR1SIz8vdyvBjvtz8DjQTSdoG9E1FNBsLIEsZqKjX1MKUb8a1PEf5qrXI5zXMc4Uim13IxlHxYFYGiYGV7aP9XRsTHrLtggV/nTQB6qgrWi+ADyvg1iEB4+AUQa2JWCplORb0ChKOuz2pshq7obbFhcxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fb5ZcJseQbYel6qxkdslThe/i9zGaj0N7h5PAMVJSTI=; b=Mpg/0ns1FHfs2u2qRAvvaB3lLzdvEv5SY1H9toJCpF4BykN4jbaaGNhH3jtXO2Sk9xXJ2QLzvu0r3pujuXhTKQD267w/y763WEI7sGleIZFO+gy5LsWw6wt/IHNmQhc880z5SIJeKaYtwqmTJHS2yj0i/OxvXVG7AKvkh7IiQcdmdsEJSLPe0/wJf/z1CVz6W+RduVpLIUPbpYv11jzxtKy6H51V4sRRjVorGxQAxU1D9fy3wcUbUJ833G0HjwrqzZF7vAmQ4Z19xLAl2KmYziJsO17PlwYhUl98a/E+Jb3w6mx4aOfuQJhRzC69Jl33blcHi5NWrjm1abZAD/Bqyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fb5ZcJseQbYel6qxkdslThe/i9zGaj0N7h5PAMVJSTI=; b=4ATlfC6qRUJFK3wPMFXkOu+KjkK5O7M0NT6P3eovmRod85ca4oKAfI2bRSjsSRQPMevHgfZNIujlR8Bv/OKX/bz5bCd7yZlWTiv9FYHnUhEk+pP0muupmcHlkGgW9UFgfT0iKe4eQ0OrmBVGEFhhjiV2HLskVRr1fhaVYZhJjCA= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DBBPR08MB5995.eurprd08.prod.outlook.com (2603:10a6:10:20b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.20; Fri, 4 Jun 2021 16:12:03 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::f15f:821c:74c5:2482]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::f15f:821c:74c5:2482%2]) with mapi id 15.20.4195.024; Fri, 4 Jun 2021 16:12:03 +0000 From: Honnappa Nagarahalli To: Joyce Kong , "beilei.xing@intel.com" , "qi.z.zhang@intel.com" , Ruifeng Wang CC: "dev@dpdk.org" , nd , Honnappa Nagarahalli , nd Thread-Topic: [PATCH v1] net/i40e: remove the SMP barrier in HW scanning func Thread-Index: AQHXWRQMSyccfibsvU+3xAtLgQFgXKsEBl+Q Date: Fri, 4 Jun 2021 16:12:03 +0000 Message-ID: References: <20210604073405.14880-1-joyce.kong@arm.com> In-Reply-To: <20210604073405.14880-1-joyce.kong@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: EAA449AF7C176C4E8E660E013A920566.0 x-checkrecipientchecked: true Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [217.140.111.155] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: b34ca81a-33e2-473c-71df-08d92773858b x-ms-traffictypediagnostic: DBBPR08MB5995:|AM8PR08MB5827: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:651;OLM:651; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 6rkIKzCtGe19mKGIUmIMabsxwzKGc9ARvo+vFYtxjwus+aX4VklKoEfWMxYJvpBZfso72wWz5wV4TRO4tsSWvi0xXUtsK/p3RZXG1f3hu0PRvgJQQ7DDB0TLNKb4jbijoFEDq8qiwyWSHC5yDzKqlaFHaqgbvdaip6NymOYBNXIXfEI6UI8ItvODBwMI3a7SYK2EoNdq21O6gYimUvQg/qi2DHgubIoccDIU9wLsn1xnLmewJuywjWDRtHhtfq2CWc2r1+kuoQb4vfhC/f2z9QDjbf4dEzHf7wWaxPJfBUnY7H1llrZo8+BJQd7Y5JqKHVWv9hytwr8VqjzFiA7whfkFIlAVJWl2fz8yE1lPUamt8mav1CTsB8omVgkUaGKQTKkutqBQO8f3zqgFJGDkTT8fDkWwsthZP6OiFIFgaNUfgTT0LLQhvVtERKEq2ItP8PAZFZ5Nt6aL4hGJqs+qOKYfBA+qUYmod2fFYQCbZvOcCA2UvN1NNTGwjVnXHMpEFFScH9LZ24oM2saobFqbvj7+W3Pm2BFLEviBIhqxeSz6OVVVLi3ALnTuhWE+P0GGpm+WOfiwYcJCd1moPyX6Q7lmi8AkhR5mmXjVcu7peBs= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39850400004)(136003)(366004)(376002)(346002)(396003)(4326008)(5660300002)(122000001)(38100700002)(86362001)(71200400001)(83380400001)(478600001)(66946007)(54906003)(9686003)(8676002)(55016002)(33656002)(6636002)(8936002)(66556008)(64756008)(26005)(76116006)(7696005)(6506007)(2906002)(52536014)(66476007)(66446008)(316002)(110136005)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?gUKHwoLarrIXCGPRRdQJn+MatzJM+biuZr8H8imQDfGas6C2C8nmNEbWEiuW?= =?us-ascii?Q?1VqpvXwIlX9XNnMD+BQAvaiVhgiwu5kHaeX3JJrmZcZWoH7C1VswxHvmS27O?= =?us-ascii?Q?fkCAMlCr4A72hc63feU/8DqLzh8Gil8v2diUtA17BdQow8E7gKfu4cRrQ+wi?= =?us-ascii?Q?dh00jDhU5g3N4swygMMWFkuA+fjZbpYhJZx/vHnCL11n7FPpun1gjsZ6CJQo?= =?us-ascii?Q?KB+pjBzkYdIkih2nF4mKAh7DRRHq01U4hPxWvMFjv445cAqS8b1RO/Yf17Wc?= =?us-ascii?Q?avdczFMf6GD3xUkwqYwUZIFBRZ5t8o/AxGXccuTGJayotma2M1a/PJdwcTGl?= =?us-ascii?Q?f4BVWWzo6fC7Tpz/CcQas4VksfnezH3Z1vFHljxqoCUseHYjveEKvJpQQ/af?= =?us-ascii?Q?2QkqZDdxhe4Hv007QsshtZfcLrUoqV+YrjGAojn2MDa+fZyzv6geFMdku0Fi?= =?us-ascii?Q?YTX0UAvNV5Y0eaicofPn5ZQIHc0X+/ImtOd+hgmgVRPryaIGZ/DQ68f53UtO?= =?us-ascii?Q?ZQal+tE1033iVIDtxDsJuyDtRgf+Jpn370kKr9KCWbIAaWTq3FIXsJkQDdtL?= =?us-ascii?Q?C1pkIYi1JRzN4Ug/gjmwGRpTjnc5bCEYcwjbvmM85f9CX0g762bX7RTkBV33?= =?us-ascii?Q?fzcbd3oxtAsTDdNVoAOahUm9ZJsbNx+arzrWhwbu77Z5KMrgdizDr0hUHAW4?= =?us-ascii?Q?Z+ANEQFMHJCpV2EdcJbeBpKTV/G85rCOjJBTzNC6BVIJBCs50VGiaPCqWsGJ?= =?us-ascii?Q?oUJfOivFkpzb4eLO5g/W6D+FYX7pC5DxgnS21k/N4Y0KCQToF5VwZGgkiSJK?= =?us-ascii?Q?6Z+QZJIbk/D+HBYFP8jWxfMrdtcnzNQirdApkC9yngnBMe4nFjkkrKF5z17v?= =?us-ascii?Q?UsDIJFRWhu6cwlANshVg1TKyh5I1sLt5gDNZf11PZ3VdqUTVybDpCjtlQMD6?= =?us-ascii?Q?U/Kxxs8+7NY5Uy9puN2WJeJuRcxikYJi+pi968SDripesBx8dTAh+v8GjF2q?= =?us-ascii?Q?D1ySGc6Z4qc9af3MlxbuJ25kz27cIGpggRiJOslYzrT2g9D7B2Oe3x09/cG0?= =?us-ascii?Q?flOV9R/u902Pv1jJ79953CXIfZLsZvT2s3Z949SM2v9QjtgTr/IOuGbSIAIk?= =?us-ascii?Q?VNDNVqVrGdmF9xO/K1f+KzYhtOzOkS/xacNie4Sgz9LvrMcguLxhQqFAWT+T?= =?us-ascii?Q?aR6DTej7o6tO6m2IgBT27SkKADgaVxELaR9IP1nDm0B3Xdsq44TBUz9aQB/n?= =?us-ascii?Q?9e/SBud9t5GBNap7VvW0RkuhZoDsai4fy25TNOdLPLw8NoPdA7Lt/yD75nz1?= =?us-ascii?Q?NqXgvPx2OZEplkI/wQJwP9tz?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5995 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 3f5075b6-646a-4e68-c933-08d927737e06 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3g/x4OtoOEJhyADKYGGyiKW/haghpGKm3P/1JoP9+H8AA1ERCqpgQ8w2DCmoxSmK4h8T34JVXglCrqjRaGFWTOaxl7gbzA816tULBOrcTgZD6UdHrtWPJdcx6w5LG8nPLz2x56oXFyhIZiZEDBz/FhWmrV7zjgKqMc8rRkdm6mMBNVhxCwEphAeBcGFsZAj4AJAPppLBgB2HHoc1DVfolY2prO8/vi476Y8p96IYkbTwZL3Xk+oR3c4yZOLX5UDhqzfVNXUGk8iXa6tjiALRcdDB3aHHrboetkhasrpNlL07reUeDZqDFXNrR7shIdNgzwaUEMe+50YZKo6FrpZ4QZjVCQKnKP6lQorQnWRpNeOIm0jtkTH52Ay1EQLk2LmjI36pXi5ADpS2u16Ilas0W/38HPO4dntEflRz+71/NdFhSa2AplIoudHTcrQlVo1hXqpKh+IqIqz5PPVxN++FdV7I6khlhOVVlvqnDwZhE5Btg7tu26wK0wdWzsWXs/HVPqik4jsvy/ma/i1Myc9ZwVyU8C9N4zepttFXYkq7AlgxedDivkwX5guHjdl0wpI6AfprfnSVbRQaSifYJuytOKsAX53FrfsAZYxI7eCHbNj6rgOd1tuEO2YPCAfzY+nX6insnLw6MJA3jCfZxAl3UQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(39850400004)(396003)(136003)(346002)(376002)(46966006)(36840700001)(26005)(478600001)(82310400003)(186003)(54906003)(4326008)(6506007)(110136005)(81166007)(7696005)(316002)(82740400003)(356005)(83380400001)(336012)(8676002)(8936002)(2906002)(6636002)(70206006)(70586007)(9686003)(55016002)(5660300002)(33656002)(52536014)(86362001)(47076005)(36860700001); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2021 16:12:16.3548 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b34ca81a-33e2-473c-71df-08d92773858b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5827 Subject: Re: [dpdk-dev] [PATCH v1] net/i40e: remove the SMP barrier in HW scanning func X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > Add the logic to determine how many DD bits have been set for contiguous > packets, for removing the SMP barrier while reading descs. Are there any performance numbers with this change? >=20 > Signed-off-by: Joyce Kong > Reviewed-by: Ruifeng Wang > --- > drivers/net/i40e/i40e_rxtx.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c = index > 6c58decec..410a81f30 100644 > --- a/drivers/net/i40e/i40e_rxtx.c > +++ b/drivers/net/i40e/i40e_rxtx.c > @@ -452,7 +452,7 @@ i40e_rx_scan_hw_ring(struct i40e_rx_queue *rxq) > uint16_t pkt_len; > uint64_t qword1; > uint32_t rx_status; > - int32_t s[I40E_LOOK_AHEAD], nb_dd; > + int32_t s[I40E_LOOK_AHEAD], var, nb_dd; > int32_t i, j, nb_rx =3D 0; > uint64_t pkt_flags; > uint32_t *ptype_tbl =3D rxq->vsi->adapter->ptype_tbl; @@ -482,11 > +482,14 @@ i40e_rx_scan_hw_ring(struct i40e_rx_queue *rxq) > I40E_RXD_QW1_STATUS_SHIFT; > } >=20 > - rte_smp_rmb(); > - > /* Compute how many status bits were set */ > - for (j =3D 0, nb_dd =3D 0; j < I40E_LOOK_AHEAD; j++) > - nb_dd +=3D s[j] & (1 << > I40E_RX_DESC_STATUS_DD_SHIFT); > + for (j =3D 0, nb_dd =3D 0; j < I40E_LOOK_AHEAD; j++) { > + var =3D s[j] & (1 << I40E_RX_DESC_STATUS_DD_SHIFT); > + if (var) > + nb_dd +=3D 1; > + else > + break; > + } >=20 > nb_rx +=3D nb_dd; >=20 > -- > 2.17.1