[dpdk-dev] Typos in Arm xconfig files

[dpdk-dev] Typos in Arm xconfig files

[Thierry Herbelot]

Hello,

There is an inconsistency in the name of variables:
most xconfig files use 'implementer_id'
two still use 'implementor_id'

	Regards

	Thierry

-- 
Thierry Herbelot
Senior Software Engineer
Tel: +33 1 39 30 92 61
http://www.6wind.com/

Follow us:
https://www.linkedin.com/company/6wind/
https://twitter.com/6WINDsoftware
https://www.youtube.com/user/6windsoftware

[dpdk-dev] [PATCH] config/arm: fix typo in meson config

[Ferruh Yigit]

s/implementor/implementer

Fixes: 3d01d65ba0d3 ("config: add aarch64 clang for Ubuntu 18.04")
Fixes: c51401832147 ("config/arm: add Graviton2")
Cc: stable@dpdk.org

Reported-by: Thierry Herbelot <thierry.herbelot@6wind.com>
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: Juraj Linkeš <juraj.linkes@pantheon.tech>
Cc: Ruifeng Wang <ruifeng.wang@arm.com>
Cc: vcchunga@amazon.com
---
 config/arm/arm64_armv8_linux_clang_ubuntu1804 | 4 ++--
 config/arm/arm64_graviton2_linux_gcc          | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/config/arm/arm64_armv8_linux_clang_ubuntu1804 b/config/arm/arm64_armv8_linux_clang_ubuntu1804
index aa5ee0132065..ae3fb30c5da8 100644
--- a/config/arm/arm64_armv8_linux_clang_ubuntu1804
+++ b/config/arm/arm64_armv8_linux_clang_ubuntu1804
@@ -14,7 +14,7 @@ cpu = 'armv8-a'
 endian = 'little'
 
 [properties]
-implementor_id = 'generic'
-implementor_pn = 'default'
+implementer_id = 'generic'
+implementer_pn = 'default'
 c_args = ['-target', 'aarch64-linux-gnu', '--sysroot', '/usr/aarch64-linux-gnu']
 c_link_args = ['-target', 'aarch64-linux-gnu', '-fuse-ld=lld', '--gcc-toolchain=/usr']
diff --git a/config/arm/arm64_graviton2_linux_gcc b/config/arm/arm64_graviton2_linux_gcc
index cfe2397975fc..123f14eed29e 100644
--- a/config/arm/arm64_graviton2_linux_gcc
+++ b/config/arm/arm64_graviton2_linux_gcc
@@ -13,8 +13,8 @@ cpu = 'armv8-a'
 endian = 'little'
 
 [properties]
-implementor_id = '0x41'
-implementor_pn = '0xd0c'
+implementer_id = '0x41'
+implementer_pn = '0xd0c'
 max_lcores = 64
 max_numa_nodes = 1
 numa = false
-- 
2.29.2

Re: [dpdk-dev] [PATCH] config/arm: fix typo in meson config

[Honnappa Nagarahalli]

<snip>

> Subject: [PATCH] config/arm: fix typo in meson config
> 
> s/implementor/implementer
> 
> Fixes: 3d01d65ba0d3 ("config: add aarch64 clang for Ubuntu 18.04")
> Fixes: c51401832147 ("config/arm: add Graviton2")
> Cc: stable@dpdk.org
> 
> Reported-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

Thanks Ferruh. I remember discussing this on the list. I am fine with 'implementEr' as that is what is used in Arm public specs.

> ---
> Cc: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Cc: Ruifeng Wang <ruifeng.wang@arm.com>
> Cc: vcchunga@amazon.com
> ---
>  config/arm/arm64_armv8_linux_clang_ubuntu1804 | 4 ++--
>  config/arm/arm64_graviton2_linux_gcc          | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/config/arm/arm64_armv8_linux_clang_ubuntu1804
> b/config/arm/arm64_armv8_linux_clang_ubuntu1804
> index aa5ee0132065..ae3fb30c5da8 100644
> --- a/config/arm/arm64_armv8_linux_clang_ubuntu1804
> +++ b/config/arm/arm64_armv8_linux_clang_ubuntu1804
> @@ -14,7 +14,7 @@ cpu = 'armv8-a'
>  endian = 'little'
> 
>  [properties]
> -implementor_id = 'generic'
> -implementor_pn = 'default'
> +implementer_id = 'generic'
> +implementer_pn = 'default'
>  c_args = ['-target', 'aarch64-linux-gnu', '--sysroot', '/usr/aarch64-linux-gnu']
> c_link_args = ['-target', 'aarch64-linux-gnu', '-fuse-ld=lld', '--gcc-
> toolchain=/usr'] diff --git a/config/arm/arm64_graviton2_linux_gcc
> b/config/arm/arm64_graviton2_linux_gcc
> index cfe2397975fc..123f14eed29e 100644
> --- a/config/arm/arm64_graviton2_linux_gcc
> +++ b/config/arm/arm64_graviton2_linux_gcc
> @@ -13,8 +13,8 @@ cpu = 'armv8-a'
>  endian = 'little'
> 
>  [properties]
> -implementor_id = '0x41'
> -implementor_pn = '0xd0c'
> +implementer_id = '0x41'
> +implementer_pn = '0xd0c'
>  max_lcores = 64
>  max_numa_nodes = 1
>  numa = false
> --
> 2.29.2

Re: [dpdk-dev] [PATCH] config/arm: fix typo in meson config

[Ruifeng Wang]

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Tuesday, February 2, 2021 6:42 AM
> To: Jan Viktorin <viktorin@rehivetech.com>; Ruifeng Wang
> <Ruifeng.Wang@arm.com>; jerinj@marvell.com; Bruce Richardson
> <bruce.richardson@intel.com>; Juraj Linkeš <juraj.linkes@pantheon.tech>;
> Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>; Vimal Chungath
> <vcchunga@amazon.com>
> Cc: Ferruh Yigit <ferruh.yigit@intel.com>; dev@dpdk.org;
> thomas@monjalon.net; stable@dpdk.org; Thierry Herbelot
> <thierry.herbelot@6wind.com>
> Subject: [PATCH] config/arm: fix typo in meson config
> 
> s/implementor/implementer
> 
> Fixes: 3d01d65ba0d3 ("config: add aarch64 clang for Ubuntu 18.04")
> Fixes: c51401832147 ("config/arm: add Graviton2")

'implementor' -> 'implementer' change was made in 7870ae8994c6.
It seems 7870ae8994c6 missed Graviton2 config file which was added earlier.

With the fix tag update,
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>

> Cc: stable@dpdk.org
> 
> Reported-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Cc: Ruifeng Wang <ruifeng.wang@arm.com>
> Cc: vcchunga@amazon.com
> ---
>  config/arm/arm64_armv8_linux_clang_ubuntu1804 | 4 ++--
>  config/arm/arm64_graviton2_linux_gcc          | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/config/arm/arm64_armv8_linux_clang_ubuntu1804
> b/config/arm/arm64_armv8_linux_clang_ubuntu1804
> index aa5ee0132065..ae3fb30c5da8 100644
> --- a/config/arm/arm64_armv8_linux_clang_ubuntu1804
> +++ b/config/arm/arm64_armv8_linux_clang_ubuntu1804
> @@ -14,7 +14,7 @@ cpu = 'armv8-a'
>  endian = 'little'
> 
>  [properties]
> -implementor_id = 'generic'
> -implementor_pn = 'default'
> +implementer_id = 'generic'
> +implementer_pn = 'default'
>  c_args = ['-target', 'aarch64-linux-gnu', '--sysroot', '/usr/aarch64-linux-gnu']
> c_link_args = ['-target', 'aarch64-linux-gnu', '-fuse-ld=lld', '--gcc-
> toolchain=/usr'] diff --git a/config/arm/arm64_graviton2_linux_gcc
> b/config/arm/arm64_graviton2_linux_gcc
> index cfe2397975fc..123f14eed29e 100644
> --- a/config/arm/arm64_graviton2_linux_gcc
> +++ b/config/arm/arm64_graviton2_linux_gcc
> @@ -13,8 +13,8 @@ cpu = 'armv8-a'
>  endian = 'little'
> 
>  [properties]
> -implementor_id = '0x41'
> -implementor_pn = '0xd0c'
> +implementer_id = '0x41'
> +implementer_pn = '0xd0c'
>  max_lcores = 64
>  max_numa_nodes = 1
>  numa = false
> --
> 2.29.2

Re: [dpdk-dev] [PATCH] config/arm: fix typo in meson config

[Juraj Linkeš]

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Monday, February 1, 2021 11:42 PM
> To: Jan Viktorin <viktorin@rehivetech.com>; Ruifeng Wang
> <ruifeng.wang@arm.com>; Jerin Jacob <jerinj@marvell.com>; Bruce Richardson
> <bruce.richardson@intel.com>; Juraj Linkeš <juraj.linkes@pantheon.tech>;
> Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>; Vimal Chungath
> <vcchunga@amazon.com>
> Cc: Ferruh Yigit <ferruh.yigit@intel.com>; dev@dpdk.org; Thomas Monjalon
> <thomas@monjalon.net>; stable@dpdk.org; Thierry Herbelot
> <thierry.herbelot@6wind.com>
> Subject: [PATCH] config/arm: fix typo in meson config
> 
> s/implementor/implementer
> 
> Fixes: 3d01d65ba0d3 ("config: add aarch64 clang for Ubuntu 18.04")
> Fixes: c51401832147 ("config/arm: add Graviton2")
> Cc: stable@dpdk.org
> 
> Reported-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---

Thanks for submitting this,
Reviewed-by: Juraj Linkeš <juraj.linkes@pantheon.tech>

Re: [dpdk-dev] [PATCH] config/arm: fix typo in meson config

[Ferruh Yigit]

On 2/2/2021 2:19 AM, Ruifeng Wang wrote:
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit@intel.com>
>> Sent: Tuesday, February 2, 2021 6:42 AM
>> To: Jan Viktorin <viktorin@rehivetech.com>; Ruifeng Wang
>> <Ruifeng.Wang@arm.com>; jerinj@marvell.com; Bruce Richardson
>> <bruce.richardson@intel.com>; Juraj Linkeš <juraj.linkes@pantheon.tech>;
>> Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>; Vimal Chungath
>> <vcchunga@amazon.com>
>> Cc: Ferruh Yigit <ferruh.yigit@intel.com>; dev@dpdk.org;
>> thomas@monjalon.net; stable@dpdk.org; Thierry Herbelot
>> <thierry.herbelot@6wind.com>
>> Subject: [PATCH] config/arm: fix typo in meson config
>>
>> s/implementor/implementer
>>
>> Fixes: 3d01d65ba0d3 ("config: add aarch64 clang for Ubuntu 18.04")
>> Fixes: c51401832147 ("config/arm: add Graviton2")
> 
> 'implementor' -> 'implementer' change was made in 7870ae8994c6.
> It seems 7870ae8994c6 missed Graviton2 config file which was added earlier.
> 

Right, I missed the rename patch, so it should be:
Fixes: 7870ae8994c6 ("config/arm: rename variables")

And that rename patch does 'implementor_pn' -> 'part_number', so I will update 
this patch to do the same.

> With the fix tag update,
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> 
>> Cc: stable@dpdk.org
>>
>> Reported-by: Thierry Herbelot <thierry.herbelot@6wind.com>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>> Cc: Juraj Linkeš <juraj.linkes@pantheon.tech>
>> Cc: Ruifeng Wang <ruifeng.wang@arm.com>
>> Cc: vcchunga@amazon.com
>> ---
>>   config/arm/arm64_armv8_linux_clang_ubuntu1804 | 4 ++--
>>   config/arm/arm64_graviton2_linux_gcc          | 4 ++--
>>   2 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/config/arm/arm64_armv8_linux_clang_ubuntu1804
>> b/config/arm/arm64_armv8_linux_clang_ubuntu1804
>> index aa5ee0132065..ae3fb30c5da8 100644
>> --- a/config/arm/arm64_armv8_linux_clang_ubuntu1804
>> +++ b/config/arm/arm64_armv8_linux_clang_ubuntu1804
>> @@ -14,7 +14,7 @@ cpu = 'armv8-a'
>>   endian = 'little'
>>
>>   [properties]
>> -implementor_id = 'generic'
>> -implementor_pn = 'default'
>> +implementer_id = 'generic'
>> +implementer_pn = 'default'
>>   c_args = ['-target', 'aarch64-linux-gnu', '--sysroot', '/usr/aarch64-linux-gnu']
>> c_link_args = ['-target', 'aarch64-linux-gnu', '-fuse-ld=lld', '--gcc-
>> toolchain=/usr'] diff --git a/config/arm/arm64_graviton2_linux_gcc
>> b/config/arm/arm64_graviton2_linux_gcc
>> index cfe2397975fc..123f14eed29e 100644
>> --- a/config/arm/arm64_graviton2_linux_gcc
>> +++ b/config/arm/arm64_graviton2_linux_gcc
>> @@ -13,8 +13,8 @@ cpu = 'armv8-a'
>>   endian = 'little'
>>
>>   [properties]
>> -implementor_id = '0x41'
>> -implementor_pn = '0xd0c'
>> +implementer_id = '0x41'
>> +implementer_pn = '0xd0c'
>>   max_lcores = 64
>>   max_numa_nodes = 1
>>   numa = false
>> --
>> 2.29.2
> 

[dpdk-dev] [PATCH v2] config/arm: fix variable name

[Ferruh Yigit]

A config variable rename seems missed to update all config files and new
config file get with old variable names.

Reflect config variable rename to all config files, changed
'implementor_id' to 'implementer_id',
'implementor_pn' to 'part_number'.

Fixes: 3d01d65ba0d3 ("config: add aarch64 clang for Ubuntu 18.04")
Fixes: 7870ae8994c6 ("config/arm: rename variables")

Reported-by: Thierry Herbelot <thierry.herbelot@6wind.com>
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Reviewed-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
---
Cc: Juraj Linkeš <juraj.linkes@pantheon.tech>
Cc: Ruifeng Wang <ruifeng.wang@arm.com>
Cc: vcchunga@amazon.com

v2:
* Update 'implementor_pn' as 'part_number'
* Fix fixes line
---
 config/arm/arm64_armv8_linux_clang_ubuntu1804 | 4 ++--
 config/arm/arm64_graviton2_linux_gcc          | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/config/arm/arm64_armv8_linux_clang_ubuntu1804 b/config/arm/arm64_armv8_linux_clang_ubuntu1804
index aa5ee0132065..8d8cc50ea4d4 100644
--- a/config/arm/arm64_armv8_linux_clang_ubuntu1804
+++ b/config/arm/arm64_armv8_linux_clang_ubuntu1804
@@ -14,7 +14,7 @@ cpu = 'armv8-a'
 endian = 'little'
 
 [properties]
-implementor_id = 'generic'
-implementor_pn = 'default'
+implementer_id = 'generic'
+part_number = 'default'
 c_args = ['-target', 'aarch64-linux-gnu', '--sysroot', '/usr/aarch64-linux-gnu']
 c_link_args = ['-target', 'aarch64-linux-gnu', '-fuse-ld=lld', '--gcc-toolchain=/usr']
diff --git a/config/arm/arm64_graviton2_linux_gcc b/config/arm/arm64_graviton2_linux_gcc
index cfe2397975fc..edacb79497ad 100644
--- a/config/arm/arm64_graviton2_linux_gcc
+++ b/config/arm/arm64_graviton2_linux_gcc
@@ -13,8 +13,8 @@ cpu = 'armv8-a'
 endian = 'little'
 
 [properties]
-implementor_id = '0x41'
-implementor_pn = '0xd0c'
+implementer_id = '0x41'
+part_number = '0xd0c'
 max_lcores = 64
 max_numa_nodes = 1
 numa = false
-- 
2.29.2

Re: [dpdk-dev] [PATCH v2] config/arm: fix variable name

[Thomas Monjalon]

02/02/2021 09:35, Ferruh Yigit:
> A config variable rename seems missed to update all config files and new
> config file get with old variable names.
> 
> Reflect config variable rename to all config files, changed
> 'implementor_id' to 'implementer_id',
> 'implementor_pn' to 'part_number'.
> 
> Fixes: 3d01d65ba0d3 ("config: add aarch64 clang for Ubuntu 18.04")
> Fixes: 7870ae8994c6 ("config/arm: rename variables")
> 
> Reported-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Reviewed-by: Juraj Linkeš <juraj.linkes@pantheon.tech>

Applied, thanks.

That's why I don't want to merge all the Arm build changes
as a batch in the same release.
Sometimes we need to have some steps.