From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 69E32A034C; Fri, 25 Feb 2022 06:18:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 470F54115C; Fri, 25 Feb 2022 06:18:56 +0100 (CET) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20071.outbound.protection.outlook.com [40.107.2.71]) by mails.dpdk.org (Postfix) with ESMTP id 543594068B for ; Fri, 25 Feb 2022 06:18:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QJlzQ5NOa0YH+aZXKVCHegkIeTNgwQhzOY652pwEVj0=; b=MsLP9sUWRFz9tP9adR4TKfAKm1r6zH2gYthMfvfQDz2iD1gu4uiXFXwz78hqVBtNu4S5uI5sq1dKkgE5W3aT1yG8FaOC9Uu1GSzuZaORPyidbCPUGx/VX/AZVxb62bdcDZ1xz/HflDxLXmwYcFXBxmQ/1wzgfYO9Jo11FmKo3dk= Received: from AS9PR06CA0078.eurprd06.prod.outlook.com (2603:10a6:20b:464::28) by AM7PR08MB5352.eurprd08.prod.outlook.com (2603:10a6:20b:10e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.21; Fri, 25 Feb 2022 05:18:53 +0000 Received: from VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:464:cafe::ec) by AS9PR06CA0078.outlook.office365.com (2603:10a6:20b:464::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.23 via Frontend Transport; Fri, 25 Feb 2022 05:18:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT064.mail.protection.outlook.com (10.152.19.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.20 via Frontend Transport; Fri, 25 Feb 2022 05:18:51 +0000 Received: ("Tessian outbound 826a6d8e58c3:v113"); Fri, 25 Feb 2022 05:18:52 +0000 X-CR-MTA-TID: 64aa7808 Received: from 0665d132b5e1.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1A9525A4-385B-4A79-84B6-17891107173D.1; Fri, 25 Feb 2022 05:18:46 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0665d132b5e1.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 25 Feb 2022 05:18:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fnEMCBlrm5q5mJsPAeUCgR2MStZKiQ+SgWGgFFdd26VCGP/ARQOcwsXK+Qlps+Xg51AtZ9dunQ/irLF+auOTqqrPNjDUlFa0gnKDzP0SHEwousO9fLeghK/M/XOKaF9dRj0qFSMW2ZbW1iGMhfBqLzonEglNb8jHbCBuJX108aJATaL5IEmssOXMyOIIfAXWhIbOM7w2OtjXJV8uv+fWLd8G6EgQWEXBQOjiQTDfYLObMjOUutaAsjv58iLP+CWoxVSpRQIOVa9LoJHoqI4WARGnqQsR7OvhgeKTiCCkPDPsvI7qLl3/rKdBeJ9yE2DDsOn5zst5Zlf01l4P488KRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QJlzQ5NOa0YH+aZXKVCHegkIeTNgwQhzOY652pwEVj0=; b=P66ybCvQ5kGDaJvlWiKGsZ0313uantjCJyinxIW2NQu4Ua2qAO0oSXlX+Snmhpnt/+3MG0UWxv6IjGJcDNx11tEbDTXWA4m86q2Lt7/L7I5Q0mgm7XV7+RUWW0nkf9p+xdPTbLzVWUUY/8UeA+PqrHkUWDmZU/PNeq/Fvt5wlAA2A5ODdL3MNR3EFXXK6eHugt+q7XRV1c9DzKzPbylKiWFjnFTjNrXqjGZuHZCpd9ZyigZ1Y/4bahQWZXfFUVPj+turkqcuAqILvUCyyCYip00MgiDUbTAz63E8+O041/jyeflrFvBH2UhE0q1d+ctHmBx2ULJgg2soH3Lrfs+SGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QJlzQ5NOa0YH+aZXKVCHegkIeTNgwQhzOY652pwEVj0=; b=MsLP9sUWRFz9tP9adR4TKfAKm1r6zH2gYthMfvfQDz2iD1gu4uiXFXwz78hqVBtNu4S5uI5sq1dKkgE5W3aT1yG8FaOC9Uu1GSzuZaORPyidbCPUGx/VX/AZVxb62bdcDZ1xz/HflDxLXmwYcFXBxmQ/1wzgfYO9Jo11FmKo3dk= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by HE1PR0801MB1867.eurprd08.prod.outlook.com (2603:10a6:3:53::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.24; Fri, 25 Feb 2022 05:18:42 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::6d04:5964:7813:4891]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::6d04:5964:7813:4891%5]) with mapi id 15.20.5017.024; Fri, 25 Feb 2022 05:18:42 +0000 From: Honnappa Nagarahalli To: "thomas@monjalon.net" , Stephen Hemminger , "Medvedkin, Vladimir" , "dev@dpdk.org" , "Morrissey, Sean" , "Richardson, Bruce" , "Ananyev, Konstantin" CC: "dev@dpdk.org" , "jerinj@marvell.com" , "Ajit Khaparde (ajit.khaparde@broadcom.com)" , "olivier.matz@6wind.com" , "maxime.coquelin@redhat.com" , "david.marchand@redhat.com" , "ktraynor@redhat.com" , nd , nd Subject: RE: [PATCH v5 0/2] Add config file support for l3fwd Thread-Topic: [PATCH v5 0/2] Add config file support for l3fwd Thread-Index: AQHYKYTz9q3NpIkJx028QzsdZQRb96yjup6g Date: Fri, 25 Feb 2022 05:18:42 +0000 Message-ID: References: <20220126124459.2469838-1-sean.morrissey@intel.com> <2262420.IPqQCg1nHW@thomas> <2122832.NgBsaNRSFp@thomas> In-Reply-To: <2122832.NgBsaNRSFp@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: F2EF96DCC303CC4481D1CED1F6028A53.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: c47c6c5b-969d-4e92-06d4-08d9f81e4f9e x-ms-traffictypediagnostic: HE1PR0801MB1867:EE_|VE1EUR03FT064:EE_|AM7PR08MB5352:EE_ x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Nj/2uWw7rB3UK6ujijLLvh00+1XEWJDhfEt3XhzTzPve9ldBjHiO4AYC7+YPZQnHbJtKm/R8uVYKoBdD5EYmplAql4yDKeQ3YP3biG3C/w+W7vyrOJ+790m5WGWU2AXD8M+4e4d5Z8Jb6/SpSnQfjVd6uKpqog5jkzamXDSWHem9Hln6npOU6N10IFpJaH+lQow/iLPpiG0VueFpVjsza6uBIrv1F7vgdAzGKq2XJk/iWAmUx1oAbRQjCSK3OzxWKrk6T4DJdvQjkjxt6hKY5uZNZ9Cq44wLnjAClhU2NkjjypHmJwIQFS/VNaXVQKZ63uPTObhHXUZ6QobU6Un7pc6QVlc7ifIPmrnaqqV8L8q38QcGmCU+D8XlcoronKOmHz1bdDBOfirtB7TkHg8fdwUFkleklx1oJba7WtZiQayPkPhQnXzoFd2q9xMLCZiAwDM2wtvMOlPIrvAyxVbg/X8dCvSP8ay9YxZWVCTMoPGbPq2Ytj1XtQDr/fetj4EZ29PeB4SvmDTHUHgH1uS5/FTscH2NyyxjsNZEgJpb+iVpX5xx3pa8PyZiXrZggDWBNpweXwTqsVYt0T4J0hhwXEufrOnkHf+MSbRM3G/iKxY2p6R1Jd7P55MM4KXFM5QfYiJg2s5sqmDDOKuGQCy5/b1bsO+1iDOM7pqdsiUZz80q/TgvSCuE8tW496PifVYeqAq6jlYTXguYKYYkbzqWsNWa9r8bUUjI/yU17HbnhBFP9jfB1H7eP8K4knZYVB0b X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(8936002)(38100700002)(52536014)(921005)(2906002)(8676002)(66476007)(66446008)(66556008)(64756008)(66946007)(76116006)(33656002)(4326008)(55016003)(122000001)(38070700005)(71200400001)(86362001)(110136005)(9686003)(186003)(316002)(54906003)(83380400001)(26005)(6506007)(508600001)(7416002)(7696005)(5660300002)(32563001); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1867 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 283b6bd4-4a0e-45da-6632-08d9f81e4a0f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZzMol5GpHcrAzKhtMJrkucvOMYlBBcuq1Q3PETN8+f1fWgoiUn6LVLcbvgU69Zgxy8VBU83SD+o9SPi+qzHIfH18Mnz0cd+FLZx3OZimSh33sPILvxr8om1cWUALpA/bCe4QkDafugP5HvCctFZNYjpFVczS9YtxNBMd5nFYzDIfsGmsg37e14Wn7qqzKSh2j1zXMPxTXlTjTSC2wnm/zjNvo8xghvfka6ZuL7lltGuiRWQzHtZU0awrkhz4auo575ziLncKC+YcBuvJgFj49EMnbbF5QqOkVYqqW/D1dXD5Tq1G/jKRLUa5O7J+eE3PeXIB9FUdvKMazwte41VmFklhyaBc8/zQcPjHO+lgr5+Gsj6U9maAAEwNPkzlKdzjhpwWwdxUG4+CqfCzRitSqbfCDd2CpejGk0gJj7NE0mLRwoeuWcNNEwZo7CkDyxgkl/OP6AfcpjpEleHxYwuSavazSoPEPg9KGYqonnSAvVnraH9tf1ZRcehYEz48kbNQeZRKGLjk14R8BtCseARIPAJFQQa10Apzno7cvp6g2iNPbNx7gQTLXBtbDXKMBS4TGNBwmCa8E1aRrcr7UsbJkXwZ8sR3idmDxiK1s8VpDmUgwd+swLB1HldkmJaL+dmuvg6W69OFvw0lQbST8uhP/AZVx43vuFo3eS0b4bOx4YWDyji/F6AYDq6UP4Ni/rP1DFTc09qHct3dHp103W4Gef3GeBFN6KJdYXQNhnAniac= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(36860700001)(54906003)(110136005)(47076005)(508600001)(83380400001)(55016003)(921005)(356005)(81166007)(7696005)(6506007)(5660300002)(9686003)(33656002)(70206006)(8936002)(316002)(2906002)(40460700003)(26005)(186003)(52536014)(86362001)(336012)(4326008)(70586007)(8676002)(82310400004)(32563001); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 05:18:51.7006 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c47c6c5b-969d-4e92-06d4-08d9f81e4f9e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5352 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org >=20 > 24/02/2022 12:06, Ananyev, Konstantin: > > > > > > > > > > >> Or have a generic library for reading LPM entries. > > > > > > > > > > >> L3fwd is supposed to be as small as possible (it no > > > > > > > > > > >> longer is), and the real work should be done by libr= aries to > make it easier to build other applications. > > > > > > > > > > > > > > > > > > > > > > I never heard users ask about such thing, but if > > > > > > > > > > > there is a demand for that, then I suppose it could b= e > considered. > > > > > > > > > > > CC-ing LPM/FIB maintainers to comment. > > > > > > > > > > > Though I believe it should be a subject of separate > > > > > > > > > > > patch and discussion (I think many questions will > > > > > > > > > > > arise - what format should be, how to support differe= nt types > of user-data, to make it generic enough, etc.). > > > > > > > > > > > > > > > > > > > > Agree, it is very application specific, so it could be > > > > > > > > > > really difficult to make it generic. > > > > > > > > > > > > > > > > > > But several other also have LPM tables, so why not have c= ommon > code for other applications. > > > > > > > > > > > > > > > > > > examples/l3fwd-power/main.c examples/ipsec-secgw/rt.c > > > > > > > > > examples/ip_fragmentation/main.c > > > > > > > > > examples/l3fwd/l3fwd_lpm.c examples/ip_reassembly/main.c > > > > > > > > > > > > > > > > Ah yes, that's good point. > > > > > > > > All these examples (except ipsec-secgw) started as l3fwd > > > > > > > > clones, so all of them have hard-coded LPM (and EM) tables = too. > > > > > > > > Yes it would be good thing to address that problem too, > > > > > > > > and have some common code (and common routes file format) f= or > all of them. > > > > > > > > I don't know is that a good idea to introduce parse file > > > > > > > > function in LPM/FIB library itself, might be better to hav= e > something like examples/common/lpm_parse*. > > > > > > > > Anyway, this is an extra effort, and I think no-one has tim= e for it in > 22.03 timeframe. > > > > > > > > My suggestion would be for 22.03 go ahead with current > > > > > > > > l3fwd patches, then later we can consider to make it common= and > update other examples. > > > > > > > > > > > > > > I don't think this patch is urgent. > > > > > > > I suggest taking time to have common code for all examples > > > > > > > and target a merge in DPDK 22.07. > > > > > > > > > > > > Well, yes, from one perspective it not really a critical one, > > > > > > we do live with hard-coded routes inside l3fwd for nearly 10 ye= ar by > now. > > > > > > Though l3fwd is one of mostly used examples inside DPDK and it > > > > > > is quite a pain to patch/rebuild it each time someone needs to > > > > > > run l3fwd with a different routing table. > > > > > > Merging this patch will allow people to use l3fwd for more > > > > > > realistic test scenarios in a painless manner. > > > > > > So I believe this patch is really helpful and should be benefic= ial for the > whole community. > > > > > > Looking from that perspective, I don't see why it has to be "al= l or > nothing" attitude here. > > > > > > Why we can't move one step at a time instead? > > > > > > That would allow to split and effort in terms of > development/testing/upstreaming/etc. > > > > > > > > > > When a feature is merged, there is less incentives to rework. > > > > > That's why, when a feature is not urgent, it is better to wait > > > > > for the complete work. > > > > > > > > That's true till some extent, though from other side even without > > > > further rework that patch improves situation from what we have > > > > right now. > > > > So I don't see any harm here. > > > > > > It is adding a lot of code to an example which is already too big. > > > There are a lot of complain about the size of l3fwd. > > > That's why I think it makes sense to require this extra code (not > > > demonstrating anything, but just for testing convenience) outside of > > > the example. > > > > Ok, so your main concern is l3fwd code size increase, right? > > Then would it help if for we'll move file parsing code into a separate > > file(s) (under examples/l3fwd) for now? > > Something like examples/l3fwd/(lpm_em)_route_parse.c. >=20 > Yes it would help to isolate the config file parsing code. > What others think? L3fwd is no more a sample application, suggest moving it to app directory. >=20