From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5C8FA04B5; Thu, 10 Sep 2020 03:34:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 657BD1BEB3; Thu, 10 Sep 2020 03:34:29 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2044.outbound.protection.outlook.com [40.107.22.44]) by dpdk.org (Postfix) with ESMTP id C7EB02BA8 for ; Thu, 10 Sep 2020 03:34:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5Yf3/ysy0LYPgUKW6pYnfgCE8bBwN2OvEYhCtJ4M9eE=; b=jsANcrmQbFOGwXaKtYPjEXXVV8zcdlCf7uMX8e8yxZanfaVL74gDC0ikKmnnRcij/jlZCrW8cfVngxi6imWiM4xLtuEb1VNxHXQ1RHULz1e2HdIHKxXorNXZDd8t4EP+OXg0Yhh1Jc9p4IEKWRBVtygbgGsygqcAcbk1x8gm6IE= Received: from AM6PR0202CA0063.eurprd02.prod.outlook.com (2603:10a6:20b:3a::40) by VI1PR0802MB2591.eurprd08.prod.outlook.com (2603:10a6:800:bb::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16; Thu, 10 Sep 2020 01:34:26 +0000 Received: from AM5EUR03FT030.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:3a:cafe::fa) by AM6PR0202CA0063.outlook.office365.com (2603:10a6:20b:3a::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16 via Frontend Transport; Thu, 10 Sep 2020 01:34:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT030.mail.protection.outlook.com (10.152.16.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16 via Frontend Transport; Thu, 10 Sep 2020 01:34:26 +0000 Received: ("Tessian outbound a0bffebca527:v64"); Thu, 10 Sep 2020 01:34:26 +0000 X-CR-MTA-TID: 64aa7808 Received: from cd7e2f905cdc.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 55BED647-DC5C-4753-BEFC-46613099327B.1; Thu, 10 Sep 2020 01:34:21 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cd7e2f905cdc.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 10 Sep 2020 01:34:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kNItS99ezTnktAvrdNoLZCW9Aipqs4x2uV6hEnuYe8bB6wH0BZr94s3aBJ86knUuW3g3EbHMkH9GHxK/K+eiskjT8jtUsCSxPOx3yNy4RQakI8x7ed+PyQPRLC+qS43u0ACBe3EgFBW8OK5zhU7jxy06helx/TXK3aE1XtCdbNeAaqFOsl8865cimXmL7ACLODDK2KZItrcddFQVjoWqto6MrGljqTB3WYk+8+hcxNmvScTSg4KoDr2WYYxCDvujg1pyCKcWJV+BOSRsRTugoXvOdcyeI2jaQ4bbJz8sw4XAS6EA74jUISfkKH8I6I9ofBQowjXVQqdoQfPJNlmPWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5Yf3/ysy0LYPgUKW6pYnfgCE8bBwN2OvEYhCtJ4M9eE=; b=PWhy1ziHkAxAeq2jy8ai29+swGYTVa71CB+EYVaiMK2Xd2J1L2GZJGBziuvv8eOF7ua6WFM9VjLAR5nUSWHeirO0rJz7W+H/HfrgMBjaIWJwVs7AvCnp+n1X399mtNqF04s9MDTgpUdLJMm+CmyxqFv7sLj35HFMfFUOsk6bzwCe34kizzG//L3cEDrhUnAcjYckC00tuaIqIDei7qOas74ev+i1seNMfYaEQZz/ycyyaD71MLozLyrIdzDEGeGTs4jWQ9BKfHqFUalm9ihNPvvvdY5rwXQfOSO4KfK8hW9TxlxYYoxnPqg/fBCyuznbADToS3+SZLRgaeXYzCnrfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5Yf3/ysy0LYPgUKW6pYnfgCE8bBwN2OvEYhCtJ4M9eE=; b=jsANcrmQbFOGwXaKtYPjEXXVV8zcdlCf7uMX8e8yxZanfaVL74gDC0ikKmnnRcij/jlZCrW8cfVngxi6imWiM4xLtuEb1VNxHXQ1RHULz1e2HdIHKxXorNXZDd8t4EP+OXg0Yhh1Jc9p4IEKWRBVtygbgGsygqcAcbk1x8gm6IE= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DB7PR08MB2954.eurprd08.prod.outlook.com (2603:10a6:5:1c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16; Thu, 10 Sep 2020 01:34:18 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::408a:40fb:7402:c805]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::408a:40fb:7402:c805%6]) with mapi id 15.20.3348.019; Thu, 10 Sep 2020 01:34:18 +0000 From: Honnappa Nagarahalli To: Alexander Kozyrev , Phil Yang , Alexander Kozyrev , Matan Azrad , Shahaf Shuler , Slava Ovsiienko CC: "drc@linux.vnet.ibm.com" , nd , "dev@dpdk.org" , Honnappa Nagarahalli , nd Thread-Topic: [dpdk-dev] [PATCH v3] net/mlx5: relaxed ordering for multi-packet RQ buffer refcnt Thread-Index: AQHWYKxdP8SsNQeNKkedAL/6TKcbm6lWBrBggABVYQCACh5scIAA6JOQ Date: Thu, 10 Sep 2020 01:34:18 +0000 Message-ID: References: <20200410164127.54229-7-gavin.hu@arm.com> <1592900807-13289-1-git-send-email-phil.yang@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: EDDBFFCAEB2FF64AA5735956B7081045.0 x-checkrecipientchecked: true Authentication-Results-Original: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [107.77.221.39] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 024a148f-aaa4-4b62-64fa-08d85529a786 x-ms-traffictypediagnostic: DB7PR08MB2954:|VI1PR0802MB2591: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:7691;OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 0B6aEdXJwr2lrkEz6KMS45q/fDTvkdu0JHklJ3c3SLvTV3Fp+9zBsWhvtMvlIWuZQaJixTDqX5RrJjk84MhIEDuqex6kkdbRjMgatgykh5/rLdlSUwFI91W9TykFQggRSGO6Yn2RfJOMFfue6wakZsQOyRH4wHvXSZQt6gUaHlALTqdX1cFG1dk9e8Q8xxgt8qt3+SnmXFpVI6o7kMVBzXdOAsxJKmzNTI1WUF0KAS0HKt86vkxgsxlrUZ7BPIB0BQIZDO06fSzbP6ITkdK4HeYGq6/Zm8e5fXqkICgkBAobamA5SThpue4KuKNuLon3GUavyyNLMG0NOWv6ncDYU/QpsZ5wryZHgAYP661gAhZxLcrxnuWIGbkOpeFjZfU0hA1b/bDd4KHtQeVI/uzuFwDpJ/baMU7QRYZOK/xPGKH+zkP+fq/q6RVBiDnftflfmwFENHZx7xe4Cx2QOrmhQU5w24tnRXO9QJ1Gtt6DVMX78Ooxr0sqpV+g565zo4o+ X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(366004)(376002)(346002)(39860400002)(66446008)(66476007)(66946007)(64756008)(76116006)(966005)(66556008)(86362001)(7696005)(316002)(52536014)(4326008)(71200400001)(33656002)(5660300002)(8936002)(6506007)(54906003)(26005)(55016002)(2906002)(83080400001)(9686003)(478600001)(45080400002)(186003)(110136005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: osIrxYQ+BdDb/QXVcHnLsn1Dg5usX14z58mUE3OMFm3bmRLBeZ0YeiMOfrc9cBrrv5AgrexvMnBPAaOv3H1CrNrDxbJKcz3PsX1lE8mK5oLgi6NE2sEJmcdyhd/Gb+FUuyNL8K6jJnHG1Z2+ALGMLGu4Wnt0+9XFarmQ+emdI+NM/z30mkE1CgZojAZcD8NZTqTwss5cHGZ9CXKrkMmXQ2nDDU/+PKur+haaeePpu4dK7qA2h9NnUbGpVhtrVP+lgLK5meAcw6RYV+sH5M4kCtjpLruNOwypoNzRkRzysWdi+ausl2h03RgFz32vztdYBzmiY42s6J+15k0IFe2TiLexn1MpI8RstqEBaZPB5l3ZwTJbujYKeyKS2iYttsOIp5Uy9Z+FbfBwijwm2pHSiD7N0iMv1t1AWRps+UOIMjs+9UUj5KxWIl39qU3zByDlS+9sc40G8xkEdYxkWVVUcnyydhvK6bVKGZwksGtaKvO+fxyfr8R5QL/vUg7y3KMLPO3zPHKd5BtIBLVY0DlEYqgAU7TPk8+djW7MUlqxgQaohqn623MLPZY8PFWBmi0iEq0ypUwDTc0eIWosBLZEX9r6F1B5oBkVnzWkkBy6cu1jlfv6C35fxmHjHeJQUppdcgtkCwF/w8Iu2WE79NZxtw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB2954 Original-Authentication-Results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: c2af84eb-62cf-4f59-e4ff-08d85529a2dd X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FVWYw61sL1XPIO5Xw9ygWPRH6hxkNdAUNxgf9SCPggp6+mtkV/8QfA30yZPabaEQnoWBWp1Xq5fbdIQVmTl4btd49FXwz7N0C2ySpJMgzZyeCLhCTCrj3WwWIctHbgmuOLaHOQk3wNN5rp178qvNaOK1xelboF0t7+HYXSayHN9dhOqZiZACoiPcPrAiNSq4dFmcLVZETHAhFPqlTKSIRxZI3oH4r9Rmkkkz3zdsa5MwgR+/oZspDewVekhIf5FGjmfXHnYlT0qqDc5GzxfpglTO2xjHpFQsjet16+BePBW7Tj73QIyj3gEHKVkTsLc27DFhTt+h/Dow5FLr/oFC+vSImMfJXs6AgWzgk5DKMkkQFxieFVmpQRAriC+DaOK0A3iaCObZWMXBSHznovoyfGRiZdqKMHruNa0WuSxFixtBdSTOaXrk3MvxBGFEZ08wvZ/UItDV96OS7lUcA40bL1COqpGDLPI0ey2XBKj8j1Cs1LG8bxDihvJS+DrDgTb/zMoVPVrdG/1SoteZWHk9WZHGe0ix5h4J5sVjBwjTFJfGc1Akee6+T4/OFd+PRjDzSSz10ifUbPg8O4H77HZkBg== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(376002)(136003)(346002)(396003)(39860400002)(46966005)(966005)(7696005)(26005)(316002)(36906005)(45080400002)(336012)(33656002)(6506007)(356005)(54906003)(186003)(70206006)(70586007)(110136005)(478600001)(9686003)(81166007)(55016002)(8936002)(4326008)(83080400001)(52536014)(47076004)(2906002)(86362001)(5660300002)(82310400003)(82740400003); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2020 01:34:26.4678 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 024a148f-aaa4-4b62-64fa-08d85529a786 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2591 Subject: Re: [dpdk-dev] [PATCH v3] net/mlx5: relaxed ordering for multi-packet RQ buffer refcnt X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > > Phil, we are seeing much worse degradation on our ARM platform > > > > > unfortunately. > > > > > I don't think that discrepancy in memcpy can explain this behavio= r. > > > > > Your patch is not touching this area of code. Let me collect > > > > > some perf stat on our side. > > > > Are you testing the patch as is or have you made the changes that > > > > were discussed in the thread? > > > > > > > > > > Yes, I made the changes you suggested. It really gets better with the= m. > > > Could you please respin the patch to make sure I got it right in my > > > environment? > > > > Thanks, Alex. > > Please check the new version here. > > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fpatch > > wo > rk.dpdk.org%2Fpatch%2F76335%2F&data=3D02%7C01%7Cakozyrev%40nv > idi > > > a.com%7C2486830050214bac8b9708d84fb4d9f9%7C43083d15727340c1b7d > b39 > > > efd9ccc17a%7C0%7C0%7C637346985463620568&sdata=3DWGw0JZPcbjos > SiI > > UxJuQz3r2pZBYkz%2BIXSqlOXimZdc%3D&reserved=3D0 >=20 > This patch is definitely better, do not see a degradation anymore, thank = you. >=20 > Acked-by: Alexander Kozyrev Can you please add your Acked-by tag in v4 (Phil provided the link above)?