From: Feifei Wang <Feifei.Wang2@arm.com> To: "Wang, Haiyue" <haiyue.wang@intel.com>, "jerinj@marvell.com" <jerinj@marvell.com>, Ruifeng Wang <Ruifeng.Wang@arm.com>, "Guo, Jia" <jia.guo@intel.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>, nd <nd@arm.com>, nd <nd@arm.com> Subject: [dpdk-dev] 回复: [PATCH v1 3/4] net/ixgbe: implement good checksum flag for NEON vector Date: Wed, 18 Nov 2020 08:29:05 +0000 Message-ID: <DBBPR08MB441154359D856A8BEC2FA8A7C8E10@DBBPR08MB4411.eurprd08.prod.outlook.com> (raw) In-Reply-To: <BN8PR11MB3795CC651FF1B7663FE249F0F7E10@BN8PR11MB3795.namprd11.prod.outlook.com> > -----邮件原件----- > 发件人: Wang, Haiyue <haiyue.wang@intel.com> > 发送时间: 2020年11月18日 16:15 > 收件人: Feifei Wang <Feifei.Wang2@arm.com>; jerinj@marvell.com; Ruifeng > Wang <Ruifeng.Wang@arm.com>; Guo, Jia <jia.guo@intel.com> > 抄送: dev@dpdk.org; nd <nd@arm.com>; nd <nd@arm.com> > 主题: RE: [PATCH v1 3/4] net/ixgbe: implement good checksum flag for NEON > vector > > > -----Original Message----- > > From: Feifei Wang <Feifei.Wang2@arm.com> > > Sent: Wednesday, November 18, 2020 15:56 > > To: Wang, Haiyue <haiyue.wang@intel.com>; jerinj@marvell.com; Ruifeng > > Wang <Ruifeng.Wang@arm.com>; Guo, Jia <jia.guo@intel.com> > > Cc: dev@dpdk.org; nd <nd@arm.com>; nd <nd@arm.com> > > Subject: 回复: [PATCH v1 3/4] net/ixgbe: implement good checksum flag > > for NEON vector > > > > Hi, Haiyue > > > > > -----邮件原件----- > > > 发件人: Wang, Haiyue <haiyue.wang@intel.com> > > > 发送时间: 2020年11月18日 15:22 > > > 收件人: Feifei Wang <Feifei.Wang2@arm.com>; jerinj@marvell.com; > Ruifeng > > > Wang <Ruifeng.Wang@arm.com>; Guo, Jia <jia.guo@intel.com> > > > 抄送: dev@dpdk.org; nd <nd@arm.com> > > > 主题: RE: [PATCH v1 3/4] net/ixgbe: implement good checksum flag for > > > NEON vector > > > > > > > -----Original Message----- > > > > From: Feifei Wang <feifei.wang2@arm.com> > > > > Sent: Wednesday, November 18, 2020 14:29 > > > > To: Jerin Jacob <jerinj@marvell.com>; Ruifeng Wang > > > > <ruifeng.wang@arm.com>; Guo, Jia <jia.guo@intel.com>; Wang, Haiyue > > > > <haiyue.wang@intel.com> > > > > Cc: dev@dpdk.org; nd@arm.com; feiwan02 <feifei.wang2@arm.com> > > > > Subject: [PATCH v1 3/4] net/ixgbe: implement good checksum flag > > > > for NEON vector > > > > > > > > From: feiwan02 <feifei.wang2@arm.com> > > > > > > > > Add CKSUM_GOOD flag to distinguish a good checksum from an unknown > > > one > > > > in neon vertor RX function. > > > > > > > > Test Results: > > > > NICs: 82599(igb) > > > > Dirver: ixgbe(vector) > > > > Packet: IPv4_checksum = correct value && UDP_checksum = correct > > > > value > > > > > > > > $:./app/dpdk-testpmd -c 0x3 -w 0002:f9:00.0 -- -i > > > > --port-topology=chained > > > > test-pmd> set fwd rxonly > > > > test-pmd> set verbose 1 > > > > test-pmd> start > > > > > > > > With this patch: > > > > testpmd> port 0/queue 0: received 1 packets > > > > src=00:00:00:00:00:02 - dst=00:00:00:00:00:01 - type=0x0800 - > > > > length=70 - nb_segs=1 > > > > ol_flags: PKT_RX_L4_CKSUM_GOOD PKT_RX_IP_CKSUM_GOOD > > > > > > > > Without this patch: > > > > testpmd> port 0/queue 0: received 1 packets > > > > src=00:00:00:00:00:02 - dst=00:00:00:00:00:01 - type=0x0800 - > > > > length=70 - nb_segs=1 > > > > ol_flags: PKT_RX_L4_CKSUM_UNKNOWN PKT_RX_IP_CKSUM_UNKNOWN > > > > > > > > > > How about to merge "1 & 2" and "3 & 4"? Then you will have the above > > > test result. ;-) > > Do you mean that combine patch 1 and patch 2 into one patch to support > > vlan stripping and bad checksum flag, Then also do the same work for > > patch 3 and patch 4 to support good checksum flag and enable IXGBE > > neon vector when DEV_RX_OFFLOAD_CHECKSUM is set? > > > > Actually, the test results are achieved without patch 4, due to that > > testpmd does not check rxmode- > > >offloads, it will call IXGBE NEON vector function directly. And this > > >change > > is for the default config of l3fwd example. > > > > I was messed by the vector code, sorry. Patch b is for bad checksum, update the > commit message to align your design. Then the patch set is OF for me, thanks! > > Feifei Wang (4): > a). net/ixgbe: add VLAN stripping support for Arm > b). net/ixgbe: support checksum flags for NEON vector > c). net/ixgbe: implement good checksum flag for NEON vector > d). net/ixgbe: enable IXGBE NEON vector PMD when CHECKSUM is set > That's all right. I will update the commit message and then upload the new version. Thanks for your attention. > > Best Regards > > Feifei > > > > > > > Signed-off-by: Feifei Wang <feifei.wang2@arm.com> > > > > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com> > > > > --- > > > > 2.17.1
next prev parent reply other threads:[~2020-11-18 8:29 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-18 6:29 [dpdk-dev] [PATCH v1 0/4] Enable Checksum Offloading " Feifei Wang 2020-11-18 6:29 ` [dpdk-dev] [PATCH v1 1/4] net/ixgbe: add VLAN stripping support for Arm Feifei Wang 2020-11-18 6:29 ` [dpdk-dev] [PATCH v1 2/4] net/ixgbe: support checksum flags for NEON vector Feifei Wang 2020-11-18 6:29 ` [dpdk-dev] [PATCH v1 3/4] net/ixgbe: implement good checksum flag " Feifei Wang 2020-11-18 7:21 ` Wang, Haiyue 2020-11-18 7:55 ` [dpdk-dev] 回复: " Feifei Wang 2020-11-18 8:15 ` [dpdk-dev] " Wang, Haiyue 2020-11-18 8:29 ` Feifei Wang [this message] 2020-11-18 6:29 ` [dpdk-dev] [PATCH v1 4/4] net/ixgbe: enable IXGBE NEON vector PMD when CHECKSUM is set Feifei Wang 2020-12-11 1:52 ` [dpdk-dev] [PATCH v1 0/4] Enable Checksum Offloading for NEON vector Zhang, Qi Z 2020-11-18 7:35 Feifei Wang 2020-11-18 7:35 ` [dpdk-dev] [PATCH v1 3/4] net/ixgbe: implement good checksum flag " Feifei Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=DBBPR08MB441154359D856A8BEC2FA8A7C8E10@DBBPR08MB4411.eurprd08.prod.outlook.com \ --to=feifei.wang2@arm.com \ --cc=Ruifeng.Wang@arm.com \ --cc=dev@dpdk.org \ --cc=haiyue.wang@intel.com \ --cc=jerinj@marvell.com \ --cc=jia.guo@intel.com \ --cc=nd@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git