From: Feifei Wang <Feifei.Wang2@arm.com>
To: "Wang, Haiyue" <haiyue.wang@intel.com>,
"jerinj@marvell.com" <jerinj@marvell.com>,
Ruifeng Wang <Ruifeng.Wang@arm.com>,
"Guo, Jia" <jia.guo@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>, nd <nd@arm.com>
Subject: [dpdk-dev] 回复: [PATCH v1 1/4] net/ixgbe: add VLAN stripping support for Arm
Date: Wed, 18 Nov 2020 10:51:30 +0000 [thread overview]
Message-ID: <DBBPR08MB441194D3561B72FC1A62772FC8E10@DBBPR08MB4411.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <BN8PR11MB3795BADD1F75D0C014E9590CF7E10@BN8PR11MB3795.namprd11.prod.outlook.com>
Hi, Haiyue
> -----邮件原件-----
> 发件人: Wang, Haiyue <haiyue.wang@intel.com>
> 发送时间: 2020年11月18日 16:34
> 收件人: Feifei Wang <Feifei.Wang2@arm.com>; jerinj@marvell.com; Ruifeng
> Wang <Ruifeng.Wang@arm.com>; Guo, Jia <jia.guo@intel.com>
> 抄送: dev@dpdk.org; nd <nd@arm.com>
> 主题: RE: [PATCH v1 1/4] net/ixgbe: add VLAN stripping support for Arm
>
> Hi Feifei,
>
> > -----Original Message-----
> > From: Feifei Wang <feifei.wang2@arm.com>
> > Sent: Wednesday, November 18, 2020 15:35
> > To: Jerin Jacob <jerinj@marvell.com>; Ruifeng Wang
> > <ruifeng.wang@arm.com>; Guo, Jia <jia.guo@intel.com>; Wang, Haiyue
> > <haiyue.wang@intel.com>
> > Cc: dev@dpdk.org; nd@arm.com; Feifei Wang <feifei.wang2@arm.com>
> > Subject: [PATCH v1 1/4] net/ixgbe: add VLAN stripping support for Arm
> >
>
> And the commit message can be more descriptive like:
> http://git.dpdk.org/dpdk/commit/?id=6d28c53bf7a9063caa3197c6cc481e2a69e
> 3be96
>
> No need to add the test result, you can put the result into cover letter.
>
> BR,
> Haiyue
Thanks very much for your advice, the commit message has been changed in the new version.
Best Regards
Feifei
>
> > Implemented PKT_RX_VLAN_STRIPPED for vector PMD on Arm platform.
> >
> > Test Results:
> > NICs: 82599(igb)
> > Driver: ixgbe(vector)
> > Packet: vlan-id=1
> >
> > $:./app/dpdk-testpmd -c 0x3 -w 0002:f9:00.0 -- -i
> > --port-topology=chained \ to enable vlan stripping:
> > --enable-hw-vlan-strip
> > test-pmd> set fwd rxonly
> > test-pmd> set verbose 1
> > test-pmd> start
> >
> > With this patch:
> > %enable vlan stripping:
> > testpmd> port 0/queue 0: received 1 packets
> > src=00:00:00:00:00:02 - dst=00:00:00:00:00:01 - type=0x0800 -
> > length=70 - nb_segs=1 - VLAN tci=0x1
> > ol_flags: PKT_RX_VLAN PKT_RX_VLAN_STRIPPED
> >
> > %disable vlan stripping:
> > testpmd> port 0/queue 0: received 1 packets
> > src=00:00:00:00:00:02 - dst=00:00:00:00:00:01 - type=0x8100 -
> > length=74 - nb_segs=1 - VLAN tci=0x0
> > ol_flags: PKT_RX_VLAN
> >
> > Without this patch:
> > %enable vlan stripping:
> > testpmd> port 0/queue 0: received 1 packets
> > src=00:00:00:00:00:02 - dst=00:00:00:00:00:01 - type=0x0800 -
> > length=70 - nb_segs=1 - VLAN tci=0x1
> > ol_flags: PKT_RX_VLAN
> >
> > %disable vlan stripping:
> > testpmd> port 0/queue 0: received 1 packets
> > src=00:00:00:00:00:02 - dst=00:00:00:00:00:01 - type=0x8100 -
> > length=74 - nb_segs=1 - VLAN tci=0x0
> > ol_flags: PKT_RX_VLAN
> >
>
>
> > Signed-off-by: Feifei Wang <feifei.wang2@arm.com>
> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> > ---
> > drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 36
> > ++++++++++++++++---------
> > 1 file changed, 23 insertions(+), 13 deletions(-)
> >
>
>
> > 2.17.1
next prev parent reply other threads:[~2020-11-18 10:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 7:35 [dpdk-dev] [PATCH v1 0/4] Enable Checksum Offloading for NEON vector Feifei Wang
2020-11-18 7:35 ` [dpdk-dev] [PATCH v1 1/4] net/ixgbe: add VLAN stripping support for Arm Feifei Wang
2020-11-18 8:34 ` Wang, Haiyue
2020-11-18 10:51 ` Feifei Wang [this message]
2020-11-18 7:35 ` [dpdk-dev] [PATCH v1 2/4] net/ixgbe: support checksum flags for NEON vector Feifei Wang
2020-11-18 7:35 ` [dpdk-dev] [PATCH v1 3/4] net/ixgbe: implement good checksum flag " Feifei Wang
2020-11-18 7:35 ` [dpdk-dev] [PATCH v1 4/4] net/ixgbe: enable IXGBE NEON vector PMD when CHECKSUM is set Feifei Wang
2020-11-18 10:48 ` [dpdk-dev] [PATCH v2 0/4] Enable Checksum Offloading for NEON vector Feifei Wang
2020-11-18 10:48 ` [dpdk-dev] [PATCH v2 1/4] net/ixgbe: add new flag of stripped VLAN " Feifei Wang
2020-11-18 11:51 ` Wang, Haiyue
2020-11-18 10:48 ` [dpdk-dev] [PATCH v2 2/4] net/ixgbe: support bad checksum flag " Feifei Wang
2020-11-18 11:51 ` Wang, Haiyue
2020-11-18 10:48 ` [dpdk-dev] [PATCH v2 3/4] net/ixgbe: support good " Feifei Wang
2020-11-18 11:51 ` Wang, Haiyue
2020-11-18 10:48 ` [dpdk-dev] [PATCH v2 4/4] net/ixgbe: enable IXGBE NEON vector when need to checksum Feifei Wang
2020-11-18 11:51 ` Wang, Haiyue
2020-12-11 12:06 ` [dpdk-dev] [PATCH v2 0/4] Enable Checksum Offloading for NEON vector Ferruh Yigit
-- strict thread matches above, loose matches on Subject: below --
2020-11-18 6:29 [dpdk-dev] [PATCH v1 " Feifei Wang
2020-11-18 6:29 ` [dpdk-dev] [PATCH v1 1/4] net/ixgbe: add VLAN stripping support for Arm Feifei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBBPR08MB441194D3561B72FC1A62772FC8E10@DBBPR08MB4411.eurprd08.prod.outlook.com \
--to=feifei.wang2@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=jerinj@marvell.com \
--cc=jia.guo@intel.com \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).