From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B3F2A00C5; Thu, 7 May 2020 18:59:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1323A1DC18; Thu, 7 May 2020 18:59:02 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80058.outbound.protection.outlook.com [40.107.8.58]) by dpdk.org (Postfix) with ESMTP id A33151DC11 for ; Thu, 7 May 2020 18:59:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cxBRYiTqX2FOfpYjHCjYsiCb8YnqoDlNT4M79ET51Ic=; b=h0plTMHlfJGu1rqMQwzl0PFs0zZqYLCvyMQvBKWg2W7VrdFcE5zT3+hL9zSxREjebkN2AHOA7WN7esQn/FW+glWhwWPcAlzGcMk+oBr4Nhy9QGB/42sEj6L67zUilnBSoS4qwgU5yb36PJGuXjVMbkMVlsMg/CEKMIaMZJJhsCY= Received: from MR2P264CA0083.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:32::23) by AM0PR08MB5300.eurprd08.prod.outlook.com (2603:10a6:208:18e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.28; Thu, 7 May 2020 16:58:58 +0000 Received: from VE1EUR03FT012.eop-EUR03.prod.protection.outlook.com (2603:10a6:500:32:cafe::5c) by MR2P264CA0083.outlook.office365.com (2603:10a6:500:32::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.28 via Frontend Transport; Thu, 7 May 2020 16:58:58 +0000 Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT012.mail.protection.outlook.com (10.152.18.211) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.27 via Frontend Transport; Thu, 7 May 2020 16:58:58 +0000 Received: ("Tessian outbound 5abcb386707e:v54"); Thu, 07 May 2020 16:58:57 +0000 X-CR-MTA-TID: 64aa7808 Received: from ac6a52db4462.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4F250BB2-D861-4731-BCD1-4C9ACE010C56.1; Thu, 07 May 2020 16:58:52 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ac6a52db4462.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 07 May 2020 16:58:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EVsMeUgO4AP7nP0nx3YeiMSSsFki3M+YiM3hayFBCDJSgZkmtgaNaVDXa9loxUPANqzWRoEdG0I9G7Wv9XccxvWKGJLrskVRR5nfE9KjCdwSig6rKjgvMi5JI6aXtIA5QLzha0ZQ2myZ0d7ysO8RjkIMiSIDXJHFveCXGhPL6lDkp6PCEtdT49QgQEtUlDkpk9+FU2koaxLqlcGyeMOIFD+IlqngeP4URmfkxEtygiwtu42vxSGWp7v6CoMBwzlrrWx4v1I8ITWIWErE+ZbcnTZoQhpIxoKwnnEeQy/rOk3XTdAuSNqQ9Mysu/zMEPshzRJivON8ni+ZIK32+/vowg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cxBRYiTqX2FOfpYjHCjYsiCb8YnqoDlNT4M79ET51Ic=; b=hPo7aIkmP9GV1ZSYWxHFKs7+C+/eHgIqRh1XxOc9AqE5PFvfsZ9tmVvinDegN10Tla4Ixd/3MCRwMUnJJoAFcSnlLhY3/VRizRO9ZnO3AKwc1RKOFZDoM+vziDk224dR6qrBUPaFNuHi8fuAasxFazNOt1e7YpPJJOUjldMYk3qUQIzKDERj5aPLGGSxVQ6nkSpp6yhVOX14kuGwt+8dvTgMr4hvmL68iuVEbohLliWTv/Iok9BgjW5sbPTJijCb1KsmTLJuFOkIQPQa2KAgTMPotyTVjRGYNtn4WepNd4v9uC7NKLu7WLIzzSQcg9IBWBIWETSB6qWj/97X8OKNXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cxBRYiTqX2FOfpYjHCjYsiCb8YnqoDlNT4M79ET51Ic=; b=h0plTMHlfJGu1rqMQwzl0PFs0zZqYLCvyMQvBKWg2W7VrdFcE5zT3+hL9zSxREjebkN2AHOA7WN7esQn/FW+glWhwWPcAlzGcMk+oBr4Nhy9QGB/42sEj6L67zUilnBSoS4qwgU5yb36PJGuXjVMbkMVlsMg/CEKMIaMZJJhsCY= Received: from DBBPR08MB4646.eurprd08.prod.outlook.com (2603:10a6:10:f5::16) by DBBPR08MB4281.eurprd08.prod.outlook.com (2603:10a6:10:c4::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.29; Thu, 7 May 2020 16:58:51 +0000 Received: from DBBPR08MB4646.eurprd08.prod.outlook.com ([fe80::1870:afc4:b90f:609d]) by DBBPR08MB4646.eurprd08.prod.outlook.com ([fe80::1870:afc4:b90f:609d%5]) with mapi id 15.20.2979.027; Thu, 7 May 2020 16:58:51 +0000 From: Honnappa Nagarahalli To: "Ananyev, Konstantin" , "dev@dpdk.org" CC: Ruifeng Wang , "Feifei Wang (Arm Technology China)" , nd , Honnappa Nagarahalli , nd Thread-Topic: rte_ring work Thread-Index: AdYj2/yEUDvXLCvbSjmLQfkOx8WHHgAfYkpwAA2yNXA= Date: Thu, 7 May 2020 16:58:51 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: c196f96c-b23d-41ac-a365-56f44f30cb18.0 x-checkrecipientchecked: true Authentication-Results-Original: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [70.113.25.165] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 756620f4-6137-408b-825d-08d7f2a7ef37 x-ms-traffictypediagnostic: DBBPR08MB4281:|DBBPR08MB4281:|AM0PR08MB5300: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; x-forefront-prvs: 03965EFC76 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: In0r+ygbpqtEsvryVeezmUGvJv87X4vi1+FxbMPAA7GY4J7+azgnYrLEunatM7D4bim+n9Qh5DIjwk6QQSx6o0M8/+kBqOk51+wIum7x/Gr8iOEGOqA0kGArr+lp0D7QjqIdOsW5Qx23q7OFx2fbPlJX2y2pLdE9jNLMi5xODvKVZ6IvrS5TUQVSdEZs4dpTdwE+OjsaFZImOccZoCVXVKgc7aukZKBjlnR9nbd7EBtQ88kDeairIwuLf+Js60rp3JO8OoJCA71veEWld+ZuYMNgF/WbjsoJn1uO6cPEyJzh6gbSiT6WHfjAwGo7RcFkWZri3v9wVEJV/862MGhSwz89QeZa8be9SVApr1t1eFLobFCjkCtu0FsZhcNHbp+Wcm4/j9Bib8l6lHVMjTxh605LrZcNFvDRr0EL45IIlopSsgwugkI7riCxGDc7UhKKyfpOZz8mgQPlxS1DrKx3C2XyBHR33ScTjsy/hnsdJpXP+/3Ce/47LJfZU6eNA5Okn3WjxLqu3PSI0mzxJVc/8OdKA9YCFSo+JvCfBH/ZxLQlHhgO9MtzreWPbZ3ff6o2 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBPR08MB4646.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(346002)(136003)(376002)(39860400002)(396003)(33430700001)(478600001)(64756008)(76116006)(7696005)(5660300002)(66556008)(8936002)(66946007)(2906002)(8676002)(52536014)(54906003)(71200400001)(83300400001)(316002)(83290400001)(83310400001)(83280400001)(83320400001)(7116003)(33656002)(26005)(86362001)(33440700001)(66476007)(66446008)(9686003)(4326008)(6506007)(186003)(55016002)(110136005)(21314003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: +IJzWfQUKhMPedsSFTPy4YjaGUOTDDN/P+8PtI9u5fQBIdv1frkHwowEXO2nKU8ZMniWVRCqtk6EaD70buSFfmVS7kPVbpa2f/JZP0U+9S3SXAbYoYhelAEpcZG+NCAc5dB2doWk3kaNp3+FxRoD3ihRDnoOK38lw8OZ7yeWxy5Az9+bUnYjcldEr2b8bx6JfvevUyE9TdvyFww/ckISmA+i1+ASarPfmbiX6ITcalQkcSbyWM4yaWw6nCAQCenm50XXuGyHKmkHahQCMH9Sw5KLNX1MGYUAcWESMkN9RndyspOsIpl79uWzYB9xXpER5ttvN2/x0fpt0NcOdESW+yGcH/G13K9MGOD8R+Vdq3Y7KrmtLz72ocq+YyqgSRoYyx18AdiPJgIMmcI9BQ9pAqDcUIjo3EIbE8xIlRhN7KJicn95WMLGzM+Ip4WvS9D5SSJVEvpEHvG47PiIEBI/y4K/L7G1DTyf8Vrs45FqU8Wwwh3mqBD/AO8mCKfWYUHN9y2izLXEUIKfjHN64aEyGM44OUvcud+4tWNo3on4rRKiHFUY5COQjApUvfyQOsIAtqPonzn1CUBZ7wpM8AYQOAxY3WKORqysiPAIgE2zn+gR18R2pZq4pIyxeNQpGgBcT5ERaWs6MZ3uus11YQYCuwf8/U8KIffDNl2EHg40xGBHjlA7oDIk5xmlbFvWEmIuHGZ9XWfxPrNa3mO3GvoN7dG7mJN7bemw+jDI5rgGR+Bvb0TMSXKoSnCG81dnYsIOGA+hdk93SaocCY6I4InkyDx+rhMoY7pxISEsNF530rs= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4281 Original-Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT012.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(4636009)(346002)(376002)(136003)(39860400002)(396003)(46966005)(33430700001)(70206006)(82310400002)(356005)(7116003)(81166007)(82740400003)(8676002)(6506007)(336012)(7696005)(47076004)(186003)(86362001)(26005)(52536014)(33656002)(478600001)(55016002)(4326008)(2906002)(5660300002)(9686003)(54906003)(110136005)(33440700001)(8936002)(36906005)(316002)(70586007)(21314003); DIR:OUT; SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: a926f546-ec78-43b5-99f0-08d7f2a7eaf3 X-Forefront-PRVS: 03965EFC76 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5+/VgH7Roczifu+mmz/Wpy+MbZr91maXpLllHWVaHh5KOCVigjXKsNODkfdJOeYEVOOlJQctKPtA4syy79YOmi2dfATb8UWF+MueGhcJlLfiwVkKNM+dZGUCw/SxNdeovDl6QnG23wYI7C9PTuSmKEEoSILxZi908RM8GL1oflZmInt036pUcy+ooVcl6SGk3M5aHJBVUf6vi6OBH016YsCKfn4/Q2jvIwEvBxE4+CpfLzSx00DNmsBQMdKOJhqDx1NAtqDbfgR4OGBYiWxbz7k5+A7fHWAuRWZs/rSyy0AaQ38ugOpC61QOspIX4i1SAty7DgfRpfrrKl3aEv9Id8m3V0aLGxC8/Q7iYDmYEbNMEw2eSL+NzV5aKoRgDE00Ceaiq29HTVRpvLVYsLKjVohq7cXPsYP2TagKts0jLwQ4KyvblC/QysN2fI+DtJeYeohmLeJlZxLVbJAtFVfTu3/o3qOaX3az//CGwh5AMcRo5WC3HywkhUo7UZsFnBBgd38BrQO0uJZgPcXHaMT3pfga+srqDX66WwBjaOKATzti5d85h4ubDpN6WSi5XSEV6zZjADlim+SrE5FUSaLx5b5TEbBKAlaaHS3WT2EgCuk= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2020 16:58:58.1997 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 756620f4-6137-408b-825d-08d7f2a7ef37 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5300 Subject: Re: [dpdk-dev] rte_ring work X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > Hi Honnappa, >=20 > > > > Hi Konstantin, > > Just to make sure we are coordinating the work on rte_ring, I plan to > > get the following things done for 20.08. Please let me know if you have= any > comments. >=20 > Thanks for sharing your plans. > In general, looks reasonable to me. > Few comments/questions below. > From my side - I have just few rte_ring related plans for 20.08: > 1) Try to integrate hts/rts ring mode into mempool_ring (new flags for > mempool_create or so). > 2) Use peek API into crypto/scheduler PMD. > 3) Plus few ideas how to improve ring performance in particular usage > scenarios. > Don't know yet would it boil to something real or not (might be new sync > mode or so). >=20 > > 1) Remove experimental tag on rte_ring_xxx_elem APIs - they have been > around for 2 releases now. > > 2) Make the legacy APIs use elem APIs > > 3) Check the possibility to remove rte_ring_generic.h implementation. > > This can be done if the legacy API performance between the generic and > C11 implementations is not much. > > 4) Peek APIs for RTS >=20 > Due to nature of RTS I don't think it is possible to implement peek API f= or it. > But might be I am missing something here. I think we have talked about it, probably a patch will make it clear. >=20 > BTW, do you guys plan to continue with WFE API adoption in rte_ring? Yes, we plan to. I thought you might not be interested in it and removed it= here. There are new requirements on the rte_wait_until_xxx API due to the = new sync modes. We might have to revisit the API definition. >=20 > > Some cleanup activity (assuming above things are successful) > > > > 1) Remove the detailed comments on top of the internal functions - it > > is hard to maintain, the parameters are already self-explanatory > > 3) Files need some re-org > > a) rte_ring.h, rte_ring_hts.h, rte_ring_rts.h, rte_ring_peek.h - will > > have legacy format APIs written as wrappers around xxx_elem APIs > > b) rte_ring_elem.h, rte_ring_hts_elem.h, rte_ring_rts_elem.h, > rte_ring_peek_elem.h - will have xxx_elem APIs > > c) ring_elem_pvt.h, ring_hts_elem_pvt.h, ring_rts_elem_pvt.h, > ring_peek_elem_pvt.h > > - these will contain the internal functions including the c11 > functions to manipulate the head/tail pointers. > > The files with xxx_c11_mem.h will disappear. Make sure > private > > functions have __rte prefix >=20 > Basically you'd plan to: > a) rename rte_ring_*_c11_mem.h to rte_ring_*_pvt.h > b) get rid of rte_ring_generic.h > Correct? Yes