From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C855AA00C5; Fri, 8 May 2020 07:13:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0F5FF1DC19; Fri, 8 May 2020 07:13:02 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30086.outbound.protection.outlook.com [40.107.3.86]) by dpdk.org (Postfix) with ESMTP id A8AE31DBBA for ; Fri, 8 May 2020 07:13:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=udYlfnbyxcRTMMjmIFd1qKjnxj6TtuoNosMSUo2UNL4=; b=vRRhoJCuluYb33wEvF/UjiwxXTmzn5LDC8cQgb13/3oMcSH03urnt2GkhfY0901999xpFQ7Y8+FgV3r/eQ3T3mDoR/wXJTGxBM2mZj04kh7xZvlh6r+Y2COU0R0IKIx927pZim1xyMXQMk8qPJ5fZ1ra1q1ZuouyZWtjUUQF8YQ= Received: from MR2P264CA0127.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:30::19) by VE1PR08MB4926.eurprd08.prod.outlook.com (2603:10a6:802:a9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.21; Fri, 8 May 2020 05:12:59 +0000 Received: from VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com (2603:10a6:500:30:cafe::a4) by MR2P264CA0127.outlook.office365.com (2603:10a6:500:30::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.26 via Frontend Transport; Fri, 8 May 2020 05:12:59 +0000 Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT022.mail.protection.outlook.com (10.152.18.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.27 via Frontend Transport; Fri, 8 May 2020 05:12:58 +0000 Received: ("Tessian outbound e88319d7ccd0:v54"); Fri, 08 May 2020 05:12:58 +0000 X-CR-MTA-TID: 64aa7808 Received: from cb26ac5f4184.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FB383B67-96A9-45E0-A4C1-617C9A4F6F9A.1; Fri, 08 May 2020 05:12:53 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cb26ac5f4184.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 08 May 2020 05:12:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ch27kmAruoH4TD4W4WPEFLwEZrUeycZLar4wPGuhYw0vMiCULlbPF/CXUWFmmwfZRmDiJ1FIgrbfeANarHZPJdZpushQu5zEg8jFMj7w8LWzhN/VDPIgwfLljIcV+vFo4oPXMy0TUX+BPcZqKDxBQUjCuuffDWHxMUkqoV2o7UYnd9k1EjeeluepDmsmkdgzDBgOnBOwJL+X+SiTKisCdSum3tQXECA9BeRcfvDJYutOjmaqUtMnBV5cD3dJW0Y7P8AvT1Z5szswXh9YlLlmWFLAZRLKUhjYvMMkhqrG/Bnl7RV6HdxQmtjmHN6RDOXtLotdGCjbuPjqWaFdg6Kf4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=udYlfnbyxcRTMMjmIFd1qKjnxj6TtuoNosMSUo2UNL4=; b=YbGbyFXdlNNAc8sikLq0gj95A7o1o+cK/OySx49almJ9xFsN5tFVcqNWku5m2ncbivluYbjok39VWQ4TK729HxwjIt51sjD1wAQ6TIf3040Z90fKoQAofAXhrwVC0u/8HXMsC+qzfhpsPRQarPDyMcxqLMhjKYIwCXZCarQ6Lrc+jPvsTt4tpIzSHQ6AyK4IwOxKb5l2xDcfhaPNxBCZBoVqds5vgxmo7bsdqFjoTNncqfM6NCqRNf/02vx3muFBkcHyJ1EQ3UYewpph12b12RrzScTOeNvGMSemwRwM4gdwTkXMtHfTONdc2gWddbLr6EUYaR3V68GgyCRytKjoWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=udYlfnbyxcRTMMjmIFd1qKjnxj6TtuoNosMSUo2UNL4=; b=vRRhoJCuluYb33wEvF/UjiwxXTmzn5LDC8cQgb13/3oMcSH03urnt2GkhfY0901999xpFQ7Y8+FgV3r/eQ3T3mDoR/wXJTGxBM2mZj04kh7xZvlh6r+Y2COU0R0IKIx927pZim1xyMXQMk8qPJ5fZ1ra1q1ZuouyZWtjUUQF8YQ= Received: from DBBPR08MB4646.eurprd08.prod.outlook.com (2603:10a6:10:f5::16) by DBBPR08MB5548.eurprd08.prod.outlook.com (2603:10a6:10:c1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.28; Fri, 8 May 2020 05:12:50 +0000 Received: from DBBPR08MB4646.eurprd08.prod.outlook.com ([fe80::1870:afc4:b90f:609d]) by DBBPR08MB4646.eurprd08.prod.outlook.com ([fe80::1870:afc4:b90f:609d%5]) with mapi id 15.20.2979.027; Fri, 8 May 2020 05:12:50 +0000 From: Honnappa Nagarahalli To: "Ananyev, Konstantin" , "dev@dpdk.org" CC: Ruifeng Wang , "Feifei Wang (Arm Technology China)" , nd , Honnappa Nagarahalli , Dharmik Thakkar , nd Thread-Topic: rte_ring work Thread-Index: AdYj2/yEUDvXLCvbSjmLQfkOx8WHHgAfYkpwAA2yNXAAATxDAAAYeeug Date: Fri, 8 May 2020 05:12:50 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 10823e45-f32f-4094-807e-09a8fcf7b284.0 x-checkrecipientchecked: true Authentication-Results-Original: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [70.113.25.165] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: f137f543-84f4-43af-6afb-08d7f30e7969 x-ms-traffictypediagnostic: DBBPR08MB5548:|DBBPR08MB5548:|VE1PR08MB4926: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000; x-forefront-prvs: 039735BC4E X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 1lfi4pYLmc/JLzpIKSh/2GJ3Ll2oxop0H+ae/1q3H/n/VOXZ4NbT7lN5mRs12WUiSljivuBPbLTBFrbTz1n1fc/INwfgyWUUlJsBEuL9iCSgurRMHg3MOUS+0UIghMSGx7c6gSvK24ZzytUSKtT/6TTR+aRi7zE+4WhGL+OYx2g+1cGDpkYxZA+ioYcbIeEwCk1owxQeI3XGfeJovK5A7LWZv2KDSL6kvB3ZgZb1m8RZJyYpwLm+5PUrnDBSrsi61o2qPUr7u8ffZtUzHTK4UcMp+4/P9cjn02NW75obFFWNkve49BC2Z79efeetiPkKun03S1p51/ZqDtz611k2BVug2viNN6Sl+CpTfxpnZA3Xlv+S4GbtQw3ef2UprUy1Mr5jpTMHv64WzywkycPhFFyJFRIuOUAlp0P7oJjHrC6++B6OQi946almXdqzuPfMhFCHL9mcMUne2lA0SpxxCUWxkL396dh1p17hc60S+bOlPL5xTaQpTnalv+xfEq+dWp3XJYxyNcLkyInNESeKsO6VJxp8jNFs5UQBcve7mcrLZUcT2Vr4psIPoz3XIsTv X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBPR08MB4646.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(346002)(366004)(376002)(396003)(136003)(33430700001)(76116006)(33656002)(52536014)(64756008)(66446008)(66556008)(54906003)(66476007)(110136005)(9686003)(2906002)(55016002)(4326008)(6506007)(478600001)(5660300002)(316002)(86362001)(66946007)(71200400001)(8676002)(26005)(83320400001)(83280400001)(83310400001)(83290400001)(186003)(7696005)(33440700001)(8936002)(83300400001)(7116003)(21314003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: PxgLyUve53vgJ3v42r8HvY+fDC91lJrmK+xv8eHpCzmz+tmJWuEkKQmp/T94G8tRs45imc0TAEX9ASJpgwfJWEx5GisKBkqv3Y+xggRk5mkT9YEyLUOIzPcZaqiMy3bIjCyP0aJ1uQUOUZLeP68rcuQ5FmuuM+/FXosSKrldjA+Q1VklbywdXj+uYDevRNG8Q3xS1fGmka6scgZjm20+i9cHDRrueLiMtiRevITxovktzsXwNA+v42I8FDW1GR20IntkAcMEFI2v4AU6WxnTvQTM0buI1KZS8++hRoeQOOpM3m/x+n3BaMMh8bDjcZ1xS7EoZ2hRhxZDL2NISJc4AzeuyFirkFim2qaidDqeYkEzhXtQtMltU6qb6qeUGUYrkKYBQqQ4V/sD2RSJzOtETmu7jZmoeMjNOtKC9QFxl4xJ4BD8QtzAQ5Wpi1K3+CkyWdsZImhx7KHjDt8X9MAvnV5Ty8H31wQRQz1yzBs/wwzfyGZd9qnmlX0afYM49VgG Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5548 Original-Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(346002)(376002)(136003)(396003)(46966005)(33430700001)(336012)(110136005)(86362001)(70206006)(70586007)(82740400003)(316002)(33440700001)(4326008)(36906005)(5660300002)(81166007)(7696005)(356005)(2906002)(52536014)(55016002)(9686003)(54906003)(7116003)(478600001)(6506007)(8936002)(47076004)(8676002)(186003)(26005)(33656002)(82310400002)(21314003); DIR:OUT; SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: ae937f56-48e4-4856-d150-08d7f30e74a1 X-Forefront-PRVS: 039735BC4E X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ule/il8Mge+4KnMRAR62AHFru8P4ZdTY9+k6HI1Je7pp9Pero/d7wM/mYBcUpum8CJxvw229f1vShT8lMOSmO3DaOeKyp4DhZsd4luBYqoVfB6NzYp9Zp79z5QXBEvDbT60YzoEw7J9KQja0Ko7DiEVcQXz+D7ES+54cwYKSqiqjZ2hOZqA0s7Luhoor4bRPrL68Xl6RYO54HLZKKu0UM93dVSeiU5CRCWOWDYnGtrpcM7wOQwawqkNoJUphcXbiyJ8+7ZxEU++W1Snx+L0IDXfy9qvjtQjVsB2vEUYfcnIW3RxLVXYqyTi0xQXEjuI+W3fUvW30Gp4+weQi8hkCKH/KLbNqX1u/81J0svW9RSYb5PcKhn8BdJbRRvY9XWufEYVv2zenmm6lJsp1hJkbqh0g+YTZ32rrf7NykDA00NKsWgx5K8Sk9HIEfkHxiahUcURwi6fZxSDhGsR7fS4LBGcXFglRopOY5V25rM4q7CHjmfs4gL0adnHv7OJmkXz8buZWrIW1y5to7VBBhD6Wi3Hjy/AOQPa6hoXpyxobRKyPiQhUKNDYgz7WgferNwiWYguYRPWcjIRTmlmIMT04RjdErYdPrG8nQJcmVsftJhk= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2020 05:12:58.7189 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f137f543-84f4-43af-6afb-08d7f30e7969 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4926 Subject: Re: [dpdk-dev] rte_ring work X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > > > Hi Honnappa, > > > > > > > > > > > Hi Konstantin, > > > > Just to make sure we are coordinating the work on rte_ring, I > > > > plan to get the following things done for 20.08. Please let me > > > > know if you have any > > > comments. > > > > > > Thanks for sharing your plans. > > > In general, looks reasonable to me. > > > Few comments/questions below. > > > From my side - I have just few rte_ring related plans for 20.08: > > > 1) Try to integrate hts/rts ring mode into mempool_ring (new flags > > > for mempool_create or so). > > > 2) Use peek API into crypto/scheduler PMD. > > > 3) Plus few ideas how to improve ring performance in particular > > > usage scenarios. > > > Don't know yet would it boil to something real or not (might be new > > > sync mode or so). > > > > > > > 1) Remove experimental tag on rte_ring_xxx_elem APIs - they have > > > > been > > > around for 2 releases now. > > > > 2) Make the legacy APIs use elem APIs > > > > 3) Check the possibility to remove rte_ring_generic.h implementatio= n. > > > > This can be done if the legacy API performance between the generic > > > > and > > > C11 implementations is not much. > > > > 4) Peek APIs for RTS > > > > > > Due to nature of RTS I don't think it is possible to implement peek A= PI for it. > > > But might be I am missing something here. > > I think we have talked about it, probably a patch will make it clear. >=20 > Ok, will wait for the patch then. >=20 > > > > > > BTW, do you guys plan to continue with WFE API adoption in rte_ring? > > Yes, we plan to. I thought you might not be interested in it and > > removed it here. There are new requirements on the rte_wait_until_xxx A= PI > due to the new sync modes. We might have to revisit the API definition. > > > > > > > > > Some cleanup activity (assuming above things are successful) > > > > > > > > 1) Remove the detailed comments on top of the internal functions - > > > > it is hard to maintain, the parameters are already > > > > self-explanatory > > > > 3) Files need some re-org > > > > a) rte_ring.h, rte_ring_hts.h, rte_ring_rts.h, rte_ring_peek.h - > > > > will have legacy format APIs written as wrappers around xxx_elem AP= Is > > > > b) rte_ring_elem.h, rte_ring_hts_elem.h, rte_ring_rts_elem.h, > > > rte_ring_peek_elem.h - will have xxx_elem APIs > > > > c) ring_elem_pvt.h, ring_hts_elem_pvt.h, ring_rts_elem_pvt.h, > > > ring_peek_elem_pvt.h > > > > - these will contain the internal functions including the c11 > > > functions to manipulate the head/tail pointers. > > > > The files with xxx_c11_mem.h will disappear. Make sure > > > private > > > > functions have __rte prefix > > > > > > Basically you'd plan to: > > > a) rename rte_ring_*_c11_mem.h to rte_ring_*_pvt.h > > > b) get rid of rte_ring_generic.h > > > Correct? > > Yes >=20 > If there would be no perf drops, I have no objections. Agree > Though recently there was a discussion is it ok to remove > dpdk installable headers (even ones marked as internal). Do you remember any conclusions? I tried to search, could not find the disc= ussion.