DPDK patches and discussions
 help / color / mirror / Atom feed
From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: Ruifeng Wang <Ruifeng.Wang@arm.com>,
	"Feifei Wang (Arm Technology China)" <Feifei.Wang@arm.com>,
	nd <nd@arm.com>, Dharmik Thakkar <Dharmik.Thakkar@arm.com>,
	Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
	nd <nd@arm.com>
Subject: Re: [dpdk-dev] rte_ring work
Date: Fri, 8 May 2020 17:54:09 +0000	[thread overview]
Message-ID: <DBBPR08MB4646F6ACA56C2C4DF60D204298A20@DBBPR08MB4646.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <BYAPR11MB33015F058022D5AE8373E9BF9AA20@BYAPR11MB3301.namprd11.prod.outlook.com>

> > > > > > Some cleanup activity (assuming above things are successful)
> > > > > >
> > > > > > 1) Remove the detailed comments on top of the internal
> > > > > > functions - it is hard to maintain, the parameters are already
> > > > > > self-explanatory
> > > > > > 3) Files need some re-org
> > > > > > 	a) rte_ring.h, rte_ring_hts.h, rte_ring_rts.h,
> > > > > > rte_ring_peek.h - will have legacy format APIs written as wrappers
> around xxx_elem APIs
> > > > > > 	b) rte_ring_elem.h, rte_ring_hts_elem.h, rte_ring_rts_elem.h,
> > > > > rte_ring_peek_elem.h - will have xxx_elem APIs
> > > > > > 	c) ring_elem_pvt.h, ring_hts_elem_pvt.h, ring_rts_elem_pvt.h,
> > > > > ring_peek_elem_pvt.h
> > > > > > 		- these will contain the internal functions including
> the
> > > > > > c11
> > > > > functions to manipulate the head/tail pointers.
> > > > > > 		  The files with xxx_c11_mem.h will disappear. Make
> sure
> > > > > private
> > > > > > functions have __rte prefix
> > > > >
> > > > > Basically you'd plan to:
> > > > > a) rename rte_ring_*_c11_mem.h  to rte_ring_*_pvt.h
> > > > > b) get rid of rte_ring_generic.h Correct?
> > > > Yes
> > >
> > > If there would be no perf drops, I have no objections.
> > Agree
> > > Though recently there was a discussion is it ok to remove dpdk
> > > installable headers (even ones marked as internal).
> > Do you remember any conclusions? I tried to search, could not find the
> discussion.
> 
> http://patches.dpdk.org/patch/69560/
Thank you. rte_ring library has called out clearly if a particular file should be included or not. If the users have included other files despite that, may be DPDK should not be held accountable?

  reply	other threads:[~2020-05-08 17:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-06 19:37 Honnappa Nagarahalli
2020-05-07 11:12 ` Ananyev, Konstantin
2020-05-07 16:58   ` Honnappa Nagarahalli
2020-05-07 17:38     ` Ananyev, Konstantin
2020-05-08  5:12       ` Honnappa Nagarahalli
2020-05-08 12:57         ` Ananyev, Konstantin
2020-05-08 17:54           ` Honnappa Nagarahalli [this message]
2020-05-08 18:04             ` Ananyev, Konstantin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DBBPR08MB4646F6ACA56C2C4DF60D204298A20@DBBPR08MB4646.eurprd08.prod.outlook.com \
    --to=honnappa.nagarahalli@arm.com \
    --cc=Dharmik.Thakkar@arm.com \
    --cc=Feifei.Wang@arm.com \
    --cc=Ruifeng.Wang@arm.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).