From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 6BC5A9A9A for ; Fri, 13 Mar 2015 16:49:51 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP; 13 Mar 2015 08:49:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,395,1422950400"; d="scan'208";a="664869023" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by orsmga001.jf.intel.com with ESMTP; 13 Mar 2015 08:49:35 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.117]) by irsmsx110.ger.corp.intel.com ([169.254.15.236]) with mapi id 14.03.0195.001; Fri, 13 Mar 2015 15:49:35 +0000 From: "Kavanagh, Mark B" To: Neil Horman Thread-Topic: [dpdk-dev] [PATCH v3] ABI: Add abi checking utility Thread-Index: AQHQVpgkwdoqBLEAH0akl46KovWCAJ0aWxJAgAAmngCAAANWsIAACiqAgAAN+TA= Date: Fri, 13 Mar 2015 15:49:33 +0000 Message-ID: References: <1422652596-12777-1-git-send-email-nhorman@tuxdriver.com> <1425486419-12508-1-git-send-email-nhorman@tuxdriver.com> <20150313141020.GD28191@hmsreliant.think-freely.org> <20150313145839.GE28191@hmsreliant.think-freely.org> In-Reply-To: <20150313145839.GE28191@hmsreliant.think-freely.org> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3] ABI: Add abi checking utility X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Mar 2015 15:49:51 -0000 >-----Original Message----- >From: Neil Horman [mailto:nhorman@tuxdriver.com] >Sent: Friday, March 13, 2015 2:59 PM >To: Kavanagh, Mark B >Cc: dev@dpdk.org >Subject: Re: [dpdk-dev] [PATCH v3] ABI: Add abi checking utility > >On Fri, Mar 13, 2015 at 02:25:17PM +0000, Kavanagh, Mark B wrote: >> >On Fri, Mar 13, 2015 at 11:56:59AM +0000, Kavanagh, Mark B wrote: >> >> >> >> >> >> >-----Original Message----- >> >> >From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Neil Horman >> >> >Sent: Wednesday, March 4, 2015 4:27 PM >> >> >To: dev@dpdk.org >> >> >Subject: [dpdk-dev] [PATCH v3] ABI: Add abi checking utility >> >> > >> >> >> (snip) >> >> >> >+log "INFO" "Building DPDK $TAG1. This might take a moment" >> >> >+make O=3D$TARGET > $VERBOSE 2>&1 >> >> >+ >> >> >+if [ $? -ne 0 ] >> >> >+then >> >> >+ log "INFO" "THE BUILD FAILED. ABORTING" >> >> >> >> If the build fails while TAG1 is checked out, the user must check out= their original >> >local branch manually. I'd prefer it if the script checked out $CURRENT= _BRANCH in the >> >'cleanup_and_exit' function. >> >> >> >Sure, its in V4. >> >> Cool. >> >> > >> >> Same applies to TAG2, if the user CTRL-C's out of the script, and to = any other >command >> >that might fail when a particular branch/tag is checked out (for exampl= e, the 'sed' >> >commands fail when I run the script; however, they work when I run them= on the command >> >line - I'm investigating this currently). >> >> >> >What does the log say? Please post it here. If it helps add a set -x = to the >> >top of the script for additional verbosity. >> > >> >> Hey Neil - this is the error, but it's not a problem with the script; pr= esumably I'd >cleaned my DPDK installation directory, so 'sed' couldn't find the defconf= ig file: >> "sed: can't read config/defconfig_x86_64-ivshmem-linuxapp-gcc/: Not a di= rectory" >> >Actually, it looks to me like you added a trailing "/" to the end of the t= hird >argument on the script command line, so sed bombs when it tries to modify = a >directory instead of a file. Try specifying: >x86_64-ivshmem-linuxapp-gcc >instead of >x86_64-ivshmem-linuxapp-gcc/ > >Neil Nice catch - thanks! > >> Thanks, >> Mark >> >> >Neil >> >>