From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id A162E2C0A for ; Fri, 9 Sep 2016 17:43:40 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP; 09 Sep 2016 08:43:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,305,1470726000"; d="scan'208";a="1047920988" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by orsmga002.jf.intel.com with ESMTP; 09 Sep 2016 08:43:38 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.102]) by IRSMSX103.ger.corp.intel.com ([169.254.3.204]) with mapi id 14.03.0248.002; Fri, 9 Sep 2016 16:43:37 +0100 From: "Kavanagh, Mark B" To: "Dey, Souvik" , Yuanhan Liu CC: "dev@dpdk.org" , "stephen@networkplumber.org" Thread-Topic: [PATCH v4]net/virtio: add mtu set in virtio Thread-Index: AQHSCqVo9QrBVjxw+E+LTSeFyfJhrKBxQBXA///45wCAABEqUA== Date: Fri, 9 Sep 2016 15:43:37 +0000 Message-ID: References: <20160907041832.35384-1-sodey@sonusnet.com> <20160909070009.GS23158@yliu-dev.sh.intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzM1YTE3NDktMjNhNi00YTJmLWFhOWQtNzVlYmZkZmQ1ZjJlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InJnN1labUhCOEhyeXlkQzlrVlwvVXBFWEZTcVNkSDBtK002N2pUUFNpQUlvPSJ9 x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4]net/virtio: add mtu set in virtio X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Sep 2016 15:43:41 -0000 > >Hi Mark, > >Yes I thought I did that change. Sorry once again.. making too many mistak= es. Changed it . >Thanks. >The MTU here is L3 MTU. Setting this will help in reducing the fragmented= /multi-segmented >packets and also in case we want to reduce the MTU below 1500, to support = VXLAN or GRE tunnel >for the packets in openstack and cloud environments. > >--- > drivers/net/virtio/virtio_ethdev.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > >diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virti= o_ethdev.c >index 07d6449..da16ad4 100644 >--- a/drivers/net/virtio/virtio_ethdev.c >+++ b/drivers/net/virtio/virtio_ethdev.c > >static int virtio_dev_queue_stats_mapping_set( > __rte_unused struct rte_eth_dev *eth_dev, >@@ -652,6 +653,16 @@ virtio_dev_allmulticast_disable(struct rte_eth_dev *d= ev) > PMD_INIT_LOG(ERR, "Failed to disable allmulticast"); > } > >+static int >+virtio_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) >+{ >+ struct virtio_hw *hw =3D dev->data->dev_private; >+ if (mtu < VIRTIO_MIN_RX_BUFSIZE || mtu > VIRTIO_MAX_RX_PKTLEN) { If MTU is the L3 MTU as you've indicated, then you need to take account of = L2 overhead before performing the comparison above. Say the user supplies 'mtu' as 9728 - the corresponding minimum frame size = is L2_HDR_LEN + 9728 + L2_CRC_LEN =3D 9746 bytes, which is larger than the = NIC can accommodate (note that 9728 is the largest L2 frame size allowed by= the NIC, not the largest IP packet size). >+ PMD_INIT_LOG(ERR, "Mtu should be between VIRTIO_MIN_RX_BUFSIZE and >VIRTIO_MAX_RX_PKTLEN \n"); Two things on this statement: 1) in the context of a log message, VIRTIO_XXX_RX_BUFSIZE most likely means= very little, and as such is not helpful. I suggest going with the format t= hat I included in my earlier mail, which prints the numeric value of the mi= n and max rx defines 2) MTU is an initialization, and should be printed as such in a = log (i.e. all caps) Hope this helps, Mark >+ return -EINVAL; >+ } >+ return 0; >+} >+ > /* > * dev_ops for virtio, bare necessities for basic operation > */ >@@ -664,6 +675,7 @@ static const struct eth_dev_ops virtio_eth_dev_ops =3D= { > .promiscuous_disable =3D virtio_dev_promiscuous_disable, > .allmulticast_enable =3D virtio_dev_allmulticast_enable, > .allmulticast_disable =3D virtio_dev_allmulticast_disable, >+ .mtu_set =3D virtio_mtu_set, > > .dev_infos_get =3D virtio_dev_info_get, > .stats_get =3D virtio_dev_stats_get, >-- > >-- >Regards, >Souvik >-----Original Message----- >From: Kavanagh, Mark B [mailto:mark.b.kavanagh@intel.com] >Sent: Friday, September 9, 2016 11:05 AM >To: Dey, Souvik ; Yuanhan Liu >Cc: dev@dpdk.org; stephen@networkplumber.org >Subject: RE: [PATCH v4]net/virtio: add mtu set in virtio > >> >>Hi Liu, >> >>Yes agreed your comment. I will definitely remove the declaration as it >>is not really required. >> So the latest patch will look like this . Yes I did rush a bit to >>submit the patch last will correct my suite. So sending the patch in a >>reply if we have more comments we can take a look and they re-submit the = final reviewed >patch. Thanks for the help though. >> >>--- >> drivers/net/virtio/virtio_ethdev.c | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >>diff --git a/drivers/net/virtio/virtio_ethdev.c >>b/drivers/net/virtio/virtio_ethdev.c >>index 07d6449..da16ad4 100644 >>--- a/drivers/net/virtio/virtio_ethdev.c >>+++ b/drivers/net/virtio/virtio_ethdev.c >> >>+static int >>+virtio_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) { >>+ struct virtio_hw *hw =3D dev->data->dev_private; >>+ if (mtu < VIRTIO_MIN_RX_BUFSIZE || mtu > VIRTIO_MAX_RX_PKTLEN) { >>+ PMD_INIT_LOG(ERR, "Mtu should be between 64 and 9728\n"); > >Hi Souvik, > >Why hardcode the values in the PMD_INIT_LOG? > >Why not do the following: PMD_INIT_LOG(ERR, "MTU should be between %d and= %d", > VIRTIO_MIN_RX_BUFSIZE, > VIRTIO_MAX_RX_PKTLEN); > >That way, if the values that the macros evaluate to change, the log will u= pdate >correspondingly. > >Also, does 'MTU' in this context relate to the L2 or L3 MTU? > >>+ return -EINVAL; >>+ } >>+ return 0; >>+} >>+ >> /* >> * dev_ops for virtio, bare necessities for basic operation >> */ >>@@ -664,6 +675,7 @@ static const struct eth_dev_ops virtio_eth_dev_ops = =3D { >> .promiscuous_disable =3D virtio_dev_promiscuous_disable, >> .allmulticast_enable =3D virtio_dev_allmulticast_enable, >> .allmulticast_disable =3D virtio_dev_allmulticast_disable, >>+ .mtu_set =3D virtio_mtu_set, >> >> .dev_infos_get =3D virtio_dev_info_get, >> .stats_get =3D virtio_dev_stats_get, >>-- >> >>-- >>Regards, >>Souvik >> >>-----Original Message----- >>From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] >>Sent: Friday, September 9, 2016 3:00 AM >>To: Dey, Souvik >>Cc: dev@dpdk.org; stephen@networkplumber.org >>Subject: Re: [PATCH v4]net/virtio: add mtu set in virtio >> >>On Wed, Sep 07, 2016 at 04:21:30AM +0000, Dey, Souvik wrote: >>> Hi Liu, >>> Submitted the version 4 of the patch as you suggested , >> >>Your patch is looking much better. But not really, you ignored few of my = comments. >> >>> and have removed the Reviewed by line. >>> I have still kept the function definition as to follow the same suit >>> as we have done for >>other eth_dev_ops. >> >>That's because most of the method implementions are after the >>reference, thus the declaration is needed. >> >>For your case, I see no good reason to do that. BTW, if you disagree >>with my comment, you shoud made a reply, instead of rushing to sending a = new version. >> >>> -- >>> Regards, >>> Souvik >>> >>> -----Original Message----- >>> From: Dey, Souvik >>> Sent: Wednesday, September 7, 2016 12:19 AM >>> To: dev@dpdk.org; stephen@networkplumber.org; >>> yuanhan.liu@linux.intel.com >>> Cc: Dey, Souvik >>> Subject: [PATCH v4]net/virtio: add mtu set in virtio >>> >>> >>> Virtio interfaces should also support setting of mtu, as in case of >>> cloud it is expected to >>have the consistent mtu across the infrastructure that the dhcp server >>sends and not hardcoded to 1500(default). >>> >>> Changes in v4: Incorporated review comments. >>> Changes in v3: Corrected few style errors as reported by sys-stv. >>> Changes in v2: Incorporated review comments. >> >>DPDK prefers to put the change log to ... >>> >>> Signed-off-by: Souvik Dey >>> >>> --- >> >>... here. >> >>So that they will be showed in mailing list (for review), but they will b= e gone after apply. >>In another word, we don't like to see those change log in git history, >>but we'd like to see them while review. >> >>> drivers/net/virtio/virtio_ethdev.c | 12 ++++++++++++ >>> 1 file changed, 12 insertions(+) >>> >>> diff --git a/drivers/net/virtio/virtio_ethdev.c >>> b/drivers/net/virtio/virtio_ethdev.c >>> index 07d6449..da16ad4 100644 >>> --- a/drivers/net/virtio/virtio_ethdev.c >>> +++ b/drivers/net/virtio/virtio_ethdev.c >>> @@ -92,6 +92,7 @@ static void virtio_mac_addr_add(struct rte_eth_dev >>> *dev, static void >>virtio_mac_addr_remove(struct rte_eth_dev *dev, uint32_t index); >>static void virtio_mac_addr_set(struct rte_eth_dev *dev, >>> struct ether_addr *mac_addr); >>> +static int virtio_mtu_set(struct rte_eth_dev *dev, uint16_t mtu); >>> >>> static int virtio_dev_queue_stats_mapping_set( >>> __rte_unused struct rte_eth_dev *eth_dev, @@ -652,6 +653,16 @@ >>virtio_dev_allmulticast_disable(struct rte_eth_dev *dev) >>> PMD_INIT_LOG(ERR, "Failed to disable allmulticast"); } >>> >>> +static int >>> +virtio_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) { >>> + struct virtio_hw *hw =3D dev->data->dev_private; >>> + if (mtu < VIRTIO_MIN_RX_BUFSIZE || mtu > VIRTIO_MAX_RX_PKTLEN) { >>> + PMD_INIT_LOG(ERR, "Mtu should be between 64 and 9728\n"); >> >>I still saw those numbers. >> >> --yliu