From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id EF6572BCE for ; Mon, 10 Oct 2016 12:49:25 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP; 10 Oct 2016 03:49:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,324,1473145200"; d="scan'208";a="770832949" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by FMSMGA003.fm.intel.com with ESMTP; 10 Oct 2016 03:49:23 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.196]) by IRSMSX107.ger.corp.intel.com ([169.254.10.95]) with mapi id 14.03.0248.002; Mon, 10 Oct 2016 11:49:22 +0100 From: "Kavanagh, Mark B" To: Yuanhan Liu , Dey CC: "stephen@networkplumber.org" , "dev@dpdk.org" Thread-Topic: [PATCH v7] net/virtio: add set_mtu in virtio Thread-Index: AQHSGpCJDQZFRvYfBk2V8UZwgCllbqCfe1KAgAIWLCA= Date: Mon, 10 Oct 2016 10:49:22 +0000 Message-ID: References: <20160922135643.37636-1-sodey@sonusnet.com> <20160929203130.58712-1-sodey@sonusnet.com> <20161009035251.GN1597@yliu-dev.sh.intel.com> In-Reply-To: <20161009035251.GN1597@yliu-dev.sh.intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDgxODI3MjktMTBiMS00ZjE5LTgxNDYtNzE5MGNhZDZkYjI1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ink5dGNBc1wvUUxSMVBYYlJLZ0VDXC9zMnRub2pJZ2FwcE9wTmZpcHNIU1M2cz0ifQ== x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v7] net/virtio: add set_mtu in virtio X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Oct 2016 10:49:26 -0000 > >On Thu, Sep 29, 2016 at 04:31:30PM -0400, Dey wrote: >> /* >> * dev_ops for virtio, bare necessities for basic operation >> */ >> @@ -677,7 +685,6 @@ static const struct eth_dev_ops virtio_eth_dev_ops = =3D { >> .allmulticast_enable =3D virtio_dev_allmulticast_enable, >> .allmulticast_disable =3D virtio_dev_allmulticast_disable, >> + .mtu_set =3D virtio_mtu_set, >> .dev_infos_get =3D virtio_dev_info_get, >> .stats_get =3D virtio_dev_stats_get, >> .xstats_get =3D virtio_dev_xstats_get, >> -- >> 2.9.3.windows.1 > >Your patch is malformed: I got an error while trying to apply it. > > patch: **** malformed patch at line 167: * dev_ops for virtio, > bare necessities for basic operation > >Seems like the way you were generating the patch is wrong. > >Anyway, I applied it manually, with the "- frame_size" fix as well >as few more minor coding style fixes. > >So applied to dpdk-next-virtio. Hi Yuanhan/Souvik, Given my contributions to this patch (and in particular since comments from= here - http://dpdk.org/ml/archives/dev/2016-September/047208.html - were c= opied directly into the commit message), I think that I should have been ad= ded as co-author of the patch?=20 Let me know if you think that I am mistaken. Thanks in advance, Mark > > --yliu