From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id B01DD6CBD for ; Tue, 11 Oct 2016 10:13:35 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 11 Oct 2016 01:13:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,476,1473145200"; d="scan'208";a="1043079446" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga001.jf.intel.com with ESMTP; 11 Oct 2016 01:13:32 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.196]) by IRSMSX152.ger.corp.intel.com ([169.254.6.13]) with mapi id 14.03.0248.002; Tue, 11 Oct 2016 09:12:26 +0100 From: "Kavanagh, Mark B" To: Yuanhan Liu CC: Dey , "stephen@networkplumber.org" , "dev@dpdk.org" Thread-Topic: [PATCH v7] net/virtio: add set_mtu in virtio Thread-Index: AQHSGpCJDQZFRvYfBk2V8UZwgCllbqCfe1KAgAIWLCCAARDbgIAAVpBg Date: Tue, 11 Oct 2016 08:12:26 +0000 Message-ID: References: <20160922135643.37636-1-sodey@sonusnet.com> <20160929203130.58712-1-sodey@sonusnet.com> <20161009035251.GN1597@yliu-dev.sh.intel.com> <20161011040119.GJ1597@yliu-dev.sh.intel.com> In-Reply-To: <20161011040119.GJ1597@yliu-dev.sh.intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmM0NmViMTUtZGQ5My00OTA5LTk2ZjctNzBiMTcwNTk1NGY2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkpCR2lEMlphanIxanRkU2ppMm9EdW80V0l0UGl6dzhhNVpXWjNGWnRkRlk9In0= x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v7] net/virtio: add set_mtu in virtio X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Oct 2016 08:13:36 -0000 >-----Original Message----- >From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] >Sent: Tuesday, October 11, 2016 5:01 AM >To: Kavanagh, Mark B >Cc: Dey ; stephen@networkplumber.org; dev@dpdk.org >Subject: Re: [PATCH v7] net/virtio: add set_mtu in virtio > >On Mon, Oct 10, 2016 at 10:49:22AM +0000, Kavanagh, Mark B wrote: >> > >> >On Thu, Sep 29, 2016 at 04:31:30PM -0400, Dey wrote: >> >> /* >> >> * dev_ops for virtio, bare necessities for basic operation >> >> */ >> >> @@ -677,7 +685,6 @@ static const struct eth_dev_ops virtio_eth_dev_op= s =3D { >> >> .allmulticast_enable =3D virtio_dev_allmulticast_enable, >> >> .allmulticast_disable =3D virtio_dev_allmulticast_disable, >> >> + .mtu_set =3D virtio_mtu_set, >> >> .dev_infos_get =3D virtio_dev_info_get, >> >> .stats_get =3D virtio_dev_stats_get, >> >> .xstats_get =3D virtio_dev_xstats_get, >> >> -- >> >> 2.9.3.windows.1 >> > >> >Your patch is malformed: I got an error while trying to apply it. >> > >> > patch: **** malformed patch at line 167: * dev_ops for virtio, >> > bare necessities for basic operation >> > >> >Seems like the way you were generating the patch is wrong. >> > >> >Anyway, I applied it manually, with the "- frame_size" fix as well >> >as few more minor coding style fixes. >> > >> >So applied to dpdk-next-virtio. >> >> Hi Yuanhan/Souvik, >> >> Given my contributions to this patch (and in particular since comments f= rom here - >http://dpdk.org/ml/archives/dev/2016-September/047208.html - were copied d= irectly into the >commit message), I think that I should have been added as co-author of the= patch? > >Mark, > >I appreciate your contributions here. But for this case, I think it >might not be enough for adding you as the co-author: you don't co-write >the code with Souvik after all. > >However, I'd suggest you to add your "Reviewed-by" if a patch looks to >you after your review effort. This is another way to recognize your >contributions to a patch. No problem Yuanhan - thanks for clarifying. Reviewed-by: Mark Kavanagh > >Thanks. > > --yliu > > >> >> Let me know if you think that I am mistaken. >> >> Thanks in advance, >> Mark >> > >> > --yliu