From: "Kavanagh, Mark B" <mark.b.kavanagh@intel.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Hu, Jiayu" <jiayu.hu@intel.com>,
"Tan, Jianfeng" <jianfeng.tan@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"thomas@monjalon.net" <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v6 2/6] gso: add TCP/IPv4 GSO support
Date: Wed, 4 Oct 2017 14:59:29 +0000 [thread overview]
Message-ID: <DC5AD7FA266D86499789B1BCAEC715F8D3A1ED78@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB9772585FAA3E3A@IRSMSX103.ger.corp.intel.com>
>From: Ananyev, Konstantin
>Sent: Wednesday, October 4, 2017 3:49 PM
>To: Kavanagh, Mark B <mark.b.kavanagh@intel.com>; dev@dpdk.org
>Cc: Hu, Jiayu <jiayu.hu@intel.com>; Tan, Jianfeng <jianfeng.tan@intel.com>;
>Yigit, Ferruh <ferruh.yigit@intel.com>; thomas@monjalon.net
>Subject: RE: [PATCH v6 2/6] gso: add TCP/IPv4 GSO support
>
>> >> int
>> >> rte_gso_segment(struct rte_mbuf *pkt,
>> >> @@ -41,12 +46,53 @@
>> >> struct rte_mbuf **pkts_out,
>> >> uint16_t nb_pkts_out)
>> >> {
>> >> + struct rte_mempool *direct_pool, *indirect_pool;
>> >> + struct rte_mbuf *pkt_seg;
>> >> + uint64_t ol_flags;
>> >> + uint16_t gso_size;
>> >> + uint8_t ipid_delta;
>> >> + int ret = 1;
>> >> +
>> >> if (pkt == NULL || pkts_out == NULL || gso_ctx == NULL ||
>> >> nb_pkts_out < 1)
>> >> return -EINVAL;
>> >>
>> >> - pkt->ol_flags &= (~PKT_TX_TCP_SEG);
>> >> - pkts_out[0] = pkt;
>> >> + if ((gso_ctx->gso_size >= pkt->pkt_len) || (gso_ctx->gso_types &
>> >> + DEV_TX_OFFLOAD_TCP_TSO) !=
>> >> + gso_ctx->gso_types) {
>> >> + pkt->ol_flags &= (~PKT_TX_TCP_SEG);
>> >> + pkts_out[0] = pkt;
>> >> + return 1;
>> >> + }
>> >> +
>> >> + direct_pool = gso_ctx->direct_pool;
>> >> + indirect_pool = gso_ctx->indirect_pool;
>> >> + gso_size = gso_ctx->gso_size;
>> >> + ipid_delta = (gso_ctx->ipid_flag != RTE_GSO_IPID_FIXED);
>> >> + ol_flags = pkt->ol_flags;
>> >> +
>> >> + if (IS_IPV4_TCP(pkt->ol_flags)) {
>> >> + pkt->ol_flags &= (~PKT_TX_TCP_SEG);
>> >> + ret = gso_tcp4_segment(pkt, gso_size, ipid_delta,
>> >> + direct_pool, indirect_pool,
>> >> + pkts_out, nb_pkts_out);
>> >> + } else {
>> >> + pkt->ol_flags &= (~PKT_TX_TCP_SEG);
>> >
>> >Not sure why do you clean this flag if you don't support that packet type
>> >and no action was perfomed?
>> >Suppose you have a mix ipv4 and ipv6 packets - gso lib would do ipv4 and
>> >someone else
>> >(HW?) can do ipv4 segmentation.
>>
>> I can't say for definite, since I didn't implement this change. However, I
>can only presume that the assumption here is that since
>> segmentation is being done in S/W that the underlying H/W does not support
>TSO.
>> Since the underlying HW can't segment the packet in HW, we should clear the
>flag; otherwise, if an mbuf marked for TCP segmentation is
>> passed to the driver of a NIC that does not support/understand that feature,
>the behavior is undefined.
>> Is this a fair assumption in your opinion, or is it the case that the packet
>would simply be transmitted un-segmented in that case, and so we
>> shouldn't clear the flag?
>
>Yes, I think if we shouldn't clear the flag if we didn't do any segmentation
>(we just encounter a packet type that we don't support).
>Konstantin
Okay, thanks for clarifying - I'll update the code accordingly.
-Mark
>
>>
>> Thanks again,
>> Mark
>>
>> >BTW, did you notice that building of shared target fails?
>> >Konstantin
>>
>> I didn't, but I'll take a look right now - thanks for the catch!
>>
>> >
>> >
>> >> + pkts_out[0] = pkt;
>> >> + RTE_LOG(WARNING, GSO, "Unsupported packet type\n");
>> >> + return 1;
>> >> + }
>> >> +
>> >> + if (ret > 1) {
>> >> + pkt_seg = pkt;
>> >> + while (pkt_seg) {
>> >> + rte_mbuf_refcnt_update(pkt_seg, -1);
>> >> + pkt_seg = pkt_seg->next;
>> >> + }
>> >> + } else if (ret < 0) {
>> >> + /* Revert the ol_flags in the event of failure. */
>> >> + pkt->ol_flags = ol_flags;
>> >> + }
>> >>
>> >> - return 1;
>> >> + return ret;
>> >> }
>> >> --
>> >> 1.9.3
next prev parent reply other threads:[~2017-10-04 15:00 UTC|newest]
Thread overview: 157+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 14:15 [dpdk-dev] [PATCH 0/5] Support TCP/IPv4, VxLAN and GRE GSO in DPDK Jiayu Hu
2017-08-24 14:15 ` [dpdk-dev] [PATCH 1/5] lib: add Generic Segmentation Offload API framework Jiayu Hu
2017-08-30 1:38 ` Ananyev, Konstantin
2017-08-30 7:57 ` Jiayu Hu
2017-08-24 14:15 ` [dpdk-dev] [PATCH 2/5] gso/lib: add TCP/IPv4 GSO support Jiayu Hu
2017-08-30 1:38 ` Ananyev, Konstantin
2017-08-30 2:55 ` Jiayu Hu
2017-08-30 9:25 ` Kavanagh, Mark B
2017-08-30 9:39 ` Ananyev, Konstantin
2017-08-30 9:59 ` Ananyev, Konstantin
2017-08-30 13:27 ` Kavanagh, Mark B
2017-08-30 9:03 ` Jiayu Hu
2017-09-04 3:31 ` Jiayu Hu
2017-09-04 9:54 ` Ananyev, Konstantin
2017-09-05 1:09 ` Hu, Jiayu
2017-09-11 13:04 ` Ananyev, Konstantin
2017-08-24 14:15 ` [dpdk-dev] [PATCH 3/5] lib/gso: add VxLAN " Jiayu Hu
2017-08-24 14:15 ` [dpdk-dev] [PATCH 4/5] lib/gso: add GRE " Jiayu Hu
2017-08-24 14:15 ` [dpdk-dev] [PATCH 5/5] app/testpmd: enable TCP/IPv4, VxLAN and GRE GSO Jiayu Hu
2017-08-30 1:37 ` [dpdk-dev] [PATCH 0/5] Support TCP/IPv4, VxLAN and GRE GSO in DPDK Ananyev, Konstantin
2017-08-30 7:36 ` Jiayu Hu
2017-08-30 10:49 ` Ananyev, Konstantin
2017-08-30 13:32 ` Kavanagh, Mark B
2017-09-05 7:57 ` [dpdk-dev] [PATCH v2 " Jiayu Hu
2017-09-05 7:57 ` [dpdk-dev] [PATCH v2 1/5] gso: add Generic Segmentation Offload API framework Jiayu Hu
2017-09-05 7:57 ` [dpdk-dev] [PATCH v2 2/5] gso: add TCP/IPv4 GSO support Jiayu Hu
2017-09-05 7:57 ` [dpdk-dev] [PATCH v2 3/5] gso: add VxLAN " Jiayu Hu
2017-09-05 7:57 ` [dpdk-dev] [PATCH v2 4/5] gso: add GRE " Jiayu Hu
2017-09-05 7:57 ` [dpdk-dev] [PATCH v2 5/5] app/testpmd: enable TCP/IPv4, VxLAN and GRE GSO Jiayu Hu
2017-09-12 2:43 ` [dpdk-dev] [PATCH v3 0/5] Support TCP/IPv4, VxLAN and GRE GSO in DPDK Jiayu Hu
2017-09-12 2:43 ` [dpdk-dev] [PATCH v3 1/5] gso: add Generic Segmentation Offload API framework Jiayu Hu
2017-09-12 10:36 ` Ananyev, Konstantin
2017-09-13 2:11 ` Jiayu Hu
2017-09-14 18:33 ` Ferruh Yigit
2017-09-15 1:12 ` Hu, Jiayu
2017-09-12 2:43 ` [dpdk-dev] [PATCH v3 2/5] gso: add TCP/IPv4 GSO support Jiayu Hu
2017-09-12 11:17 ` Ananyev, Konstantin
2017-09-13 2:48 ` Jiayu Hu
2017-09-13 9:38 ` Ananyev, Konstantin
2017-09-13 10:23 ` Hu, Jiayu
2017-09-13 14:52 ` Kavanagh, Mark B
2017-09-13 15:13 ` Ananyev, Konstantin
2017-09-14 0:59 ` Hu, Jiayu
2017-09-14 8:35 ` Kavanagh, Mark B
2017-09-14 8:39 ` Ananyev, Konstantin
2017-09-14 9:00 ` Kavanagh, Mark B
2017-09-14 9:10 ` Ananyev, Konstantin
2017-09-14 9:35 ` Kavanagh, Mark B
2017-09-12 14:17 ` Ananyev, Konstantin
2017-09-13 10:44 ` Jiayu Hu
2017-09-13 22:10 ` Ananyev, Konstantin
2017-09-14 6:07 ` Jiayu Hu
2017-09-14 8:47 ` Ananyev, Konstantin
2017-09-14 9:29 ` Hu, Jiayu
2017-09-14 9:35 ` Ananyev, Konstantin
2017-09-14 10:01 ` Hu, Jiayu
2017-09-14 15:42 ` Kavanagh, Mark B
2017-09-14 18:38 ` Ananyev, Konstantin
2017-09-15 7:54 ` Hu, Jiayu
2017-09-15 8:15 ` Ananyev, Konstantin
2017-09-15 8:17 ` Ananyev, Konstantin
2017-09-15 8:38 ` Hu, Jiayu
2017-09-14 8:51 ` Kavanagh, Mark B
2017-09-14 9:45 ` Hu, Jiayu
2017-09-12 2:43 ` [dpdk-dev] [PATCH v3 3/5] gso: add VxLAN " Jiayu Hu
2017-09-12 2:43 ` [dpdk-dev] [PATCH v3 4/5] gso: add GRE " Jiayu Hu
2017-09-12 2:43 ` [dpdk-dev] [PATCH v3 5/5] app/testpmd: enable TCP/IPv4, VxLAN and GRE GSO Jiayu Hu
2017-09-14 18:33 ` Ferruh Yigit
2017-09-15 1:13 ` Hu, Jiayu
2017-09-19 7:32 ` [dpdk-dev] [PATCH v4 0/5] Support TCP/IPv4, VxLAN and GRE GSO in DPDK Jiayu Hu
2017-09-19 7:32 ` [dpdk-dev] [PATCH v4 1/5] gso: add Generic Segmentation Offload API framework Jiayu Hu
2017-09-19 7:32 ` [dpdk-dev] [PATCH v4 2/5] gso: add TCP/IPv4 GSO support Jiayu Hu
2017-09-20 7:03 ` Yao, Lei A
2017-09-19 7:32 ` [dpdk-dev] [PATCH v4 3/5] gso: add VxLAN " Jiayu Hu
2017-09-20 3:11 ` Tan, Jianfeng
2017-09-20 3:17 ` Hu, Jiayu
2017-09-19 7:32 ` [dpdk-dev] [PATCH v4 4/5] gso: add GRE " Jiayu Hu
2017-09-20 2:53 ` Tan, Jianfeng
2017-09-20 6:01 ` Hu, Jiayu
2017-09-19 7:32 ` [dpdk-dev] [PATCH v4 5/5] app/testpmd: enable TCP/IPv4, VxLAN and GRE GSO Jiayu Hu
2017-09-28 22:13 ` [dpdk-dev] [PATCH v5 0/6] Support TCP/IPv4, VxLAN and GRE GSO in DPDK Mark Kavanagh
2017-10-02 16:45 ` [dpdk-dev] [PATCH v6 0/6] Support TCP/IPv4, VxLAN, " Mark Kavanagh
2017-10-02 16:45 ` [dpdk-dev] [PATCH v6 1/6] gso: add Generic Segmentation Offload API framework Mark Kavanagh
2017-10-04 13:11 ` Ananyev, Konstantin
2017-10-04 13:21 ` Kavanagh, Mark B
2017-10-02 16:45 ` [dpdk-dev] [PATCH v6 2/6] gso: add TCP/IPv4 GSO support Mark Kavanagh
2017-10-04 13:32 ` Ananyev, Konstantin
2017-10-04 14:30 ` Kavanagh, Mark B
2017-10-04 14:49 ` Ananyev, Konstantin
2017-10-04 14:59 ` Kavanagh, Mark B [this message]
2017-10-04 13:35 ` Ananyev, Konstantin
2017-10-04 14:22 ` Kavanagh, Mark B
2017-10-02 16:45 ` [dpdk-dev] [PATCH v6 3/6] gso: add VxLAN " Mark Kavanagh
2017-10-04 14:12 ` Ananyev, Konstantin
2017-10-04 14:35 ` Kavanagh, Mark B
2017-10-04 16:13 ` Kavanagh, Mark B
2017-10-04 16:17 ` Ananyev, Konstantin
2017-10-02 16:45 ` [dpdk-dev] [PATCH v6 4/6] gso: add GRE " Mark Kavanagh
2017-10-04 14:15 ` Ananyev, Konstantin
2017-10-04 14:36 ` Kavanagh, Mark B
2017-10-02 16:45 ` [dpdk-dev] [PATCH v6 5/6] app/testpmd: enable TCP/IPv4, VxLAN and GRE GSO Mark Kavanagh
2017-10-04 15:08 ` Ananyev, Konstantin
2017-10-04 16:23 ` Kavanagh, Mark B
2017-10-04 16:26 ` Ananyev, Konstantin
2017-10-04 16:51 ` Kavanagh, Mark B
2017-10-02 16:45 ` [dpdk-dev] [PATCH v6 6/6] doc: add GSO programmer's guide Mark Kavanagh
2017-10-04 13:51 ` Mcnamara, John
2017-10-05 11:02 ` [dpdk-dev] [PATCH v7 0/6] Support TCP/IPv4, VxLAN, and GRE GSO in DPDK Mark Kavanagh
2017-10-05 11:02 ` [dpdk-dev] [PATCH v7 1/6] gso: add Generic Segmentation Offload API framework Mark Kavanagh
2017-10-05 11:02 ` [dpdk-dev] [PATCH v7 2/6] gso: add TCP/IPv4 GSO support Mark Kavanagh
2017-10-05 11:02 ` [dpdk-dev] [PATCH v7 3/6] gso: add VxLAN " Mark Kavanagh
2017-10-05 11:02 ` [dpdk-dev] [PATCH v7 4/6] gso: add GRE " Mark Kavanagh
2017-10-05 11:02 ` [dpdk-dev] [PATCH v7 5/6] app/testpmd: enable TCP/IPv4, VxLAN and GRE GSO Mark Kavanagh
2017-10-05 11:02 ` [dpdk-dev] [PATCH v7 6/6] doc: add GSO programmer's guide Mark Kavanagh
2017-10-05 13:22 ` [dpdk-dev] [PATCH v7 0/6] Support TCP/IPv4, VxLAN, and GRE GSO in DPDK Ananyev, Konstantin
2017-10-05 14:39 ` Kavanagh, Mark B
2017-10-05 15:43 ` [dpdk-dev] [PATCH v8 " Mark Kavanagh
2017-10-05 17:12 ` Ananyev, Konstantin
2017-10-05 20:16 ` Kavanagh, Mark B
2017-10-05 20:36 ` [dpdk-dev] [PATCH v9 " Mark Kavanagh
2017-10-05 22:24 ` Ananyev, Konstantin
2017-10-06 8:24 ` [dpdk-dev] FW: " Kavanagh, Mark B
2017-10-06 10:35 ` [dpdk-dev] " Kavanagh, Mark B
2017-10-06 23:32 ` Ferruh Yigit
2017-10-06 23:34 ` Ferruh Yigit
2017-10-07 14:56 ` [dpdk-dev] [PATCH v10 " Jiayu Hu
2017-10-07 14:56 ` [dpdk-dev] [PATCH v10 1/6] gso: add Generic Segmentation Offload API framework Jiayu Hu
2017-10-07 14:56 ` [dpdk-dev] [PATCH v10 2/6] gso: add TCP/IPv4 GSO support Jiayu Hu
2017-10-07 14:56 ` [dpdk-dev] [PATCH v10 3/6] gso: add VxLAN " Jiayu Hu
2017-10-07 14:56 ` [dpdk-dev] [PATCH v10 4/6] gso: add GRE " Jiayu Hu
2017-10-07 14:56 ` [dpdk-dev] [PATCH v10 5/6] app/testpmd: enable TCP/IPv4, VxLAN and GRE GSO Jiayu Hu
2017-10-07 14:56 ` [dpdk-dev] [PATCH v10 6/6] doc: add GSO programmer's guide Jiayu Hu
2017-10-08 3:40 ` [dpdk-dev] [PATCH v10 0/6] Support TCP/IPv4, VxLAN, and GRE GSO in DPDK Ferruh Yigit
2017-10-05 20:36 ` [dpdk-dev] [PATCH v9 1/6] gso: add Generic Segmentation Offload API framework Mark Kavanagh
2017-10-05 20:36 ` [dpdk-dev] [PATCH v9 2/6] gso: add TCP/IPv4 GSO support Mark Kavanagh
2017-10-05 20:36 ` [dpdk-dev] [PATCH v9 3/6] gso: add VxLAN " Mark Kavanagh
2017-10-05 20:36 ` [dpdk-dev] [PATCH v9 4/6] gso: add GRE " Mark Kavanagh
2017-10-05 20:36 ` [dpdk-dev] [PATCH v9 5/6] app/testpmd: enable TCP/IPv4, VxLAN and GRE GSO Mark Kavanagh
2017-10-05 20:36 ` [dpdk-dev] [PATCH v9 6/6] doc: add GSO programmer's guide Mark Kavanagh
2017-10-06 13:34 ` Mcnamara, John
2017-10-06 13:41 ` Kavanagh, Mark B
2017-10-05 15:43 ` [dpdk-dev] [PATCH v8 1/6] gso: add Generic Segmentation Offload API framework Mark Kavanagh
2017-10-05 15:44 ` [dpdk-dev] [PATCH v8 2/6] gso: add TCP/IPv4 GSO support Mark Kavanagh
2017-10-05 15:44 ` [dpdk-dev] [PATCH v8 3/6] gso: add VxLAN " Mark Kavanagh
2017-10-05 15:44 ` [dpdk-dev] [PATCH v8 4/6] gso: add GRE " Mark Kavanagh
2017-10-05 15:44 ` [dpdk-dev] [PATCH v8 5/6] app/testpmd: enable TCP/IPv4, VxLAN and GRE GSO Mark Kavanagh
2017-10-05 15:44 ` [dpdk-dev] [PATCH v8 6/6] doc: add GSO programmer's guide Mark Kavanagh
2017-10-05 17:57 ` Mcnamara, John
2017-09-28 22:13 ` [dpdk-dev] [PATCH v5 1/6] gso: add Generic Segmentation Offload API framework Mark Kavanagh
2017-09-28 22:13 ` [dpdk-dev] [PATCH v5 2/6] gso: add TCP/IPv4 GSO support Mark Kavanagh
2017-09-29 3:12 ` Jiayu Hu
2017-09-29 9:05 ` Kavanagh, Mark B
2017-09-28 22:13 ` [dpdk-dev] [PATCH v5 3/6] gso: add VxLAN " Mark Kavanagh
2017-09-28 22:13 ` [dpdk-dev] [PATCH v5 4/6] gso: add GRE " Mark Kavanagh
2017-09-28 22:13 ` [dpdk-dev] [PATCH v5 5/6] app/testpmd: enable TCP/IPv4, VxLAN and GRE GSO Mark Kavanagh
2017-09-28 22:13 ` [dpdk-dev] [PATCH v5 6/6] doc: add GSO programmer's guide Mark Kavanagh
2017-09-28 22:18 ` [dpdk-dev] [PATCH v5 2/6] gso: add TCP/IPv4 GSO support Mark Kavanagh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DC5AD7FA266D86499789B1BCAEC715F8D3A1ED78@IRSMSX101.ger.corp.intel.com \
--to=mark.b.kavanagh@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jianfeng.tan@intel.com \
--cc=jiayu.hu@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).