From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 728451B6B8 for ; Wed, 4 Oct 2017 18:51:33 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Oct 2017 09:51:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,478,1500966000"; d="scan'208";a="158826036" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga005.fm.intel.com with ESMTP; 04 Oct 2017 09:51:31 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.22]) by IRSMSX103.ger.corp.intel.com ([169.254.3.49]) with mapi id 14.03.0319.002; Wed, 4 Oct 2017 17:51:30 +0100 From: "Kavanagh, Mark B" To: "Ananyev, Konstantin" , "dev@dpdk.org" CC: "Hu, Jiayu" , "Tan, Jianfeng" , "Yigit, Ferruh" , "thomas@monjalon.net" Thread-Topic: [PATCH v6 5/6] app/testpmd: enable TCP/IPv4, VxLAN and GRE GSO Thread-Index: AQHTO536wTvtSNCNYkydMza/9Sww9KLTvVAAgAAks3D///ExgIAAF3fQ Date: Wed, 4 Oct 2017 16:51:29 +0000 Message-ID: References: <1506636833-25851-1-git-send-email-mark.b.kavanagh@intel.com> <1506962749-106779-1-git-send-email-mark.b.kavanagh@intel.com> <1506962749-106779-6-git-send-email-mark.b.kavanagh@intel.com> <2601191342CEEE43887BDE71AB9772585FAA3E62@IRSMSX103.ger.corp.intel.com> <2601191342CEEE43887BDE71AB9772585FAA3F4D@IRSMSX103.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB9772585FAA3F4D@IRSMSX103.ger.corp.intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzVhNWZlNmUtZTJkOC00ODIyLTg4ZmUtMjc2MGVlNzE0YmVhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImVTNlNXTW9oR1RBZUR0MDBWbnJqOEk3enFQYVRNY3Z0NzVCWkUyVmV6VWc9In0= dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 5/6] app/testpmd: enable TCP/IPv4, VxLAN and GRE GSO X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Oct 2017 16:51:34 -0000 >-----Original Message----- >From: Ananyev, Konstantin >Sent: Wednesday, October 4, 2017 5:27 PM >To: Kavanagh, Mark B ; dev@dpdk.org >Cc: Hu, Jiayu ; Tan, Jianfeng = ; >Yigit, Ferruh ; thomas@monjalon.net >Subject: RE: [PATCH v6 5/6] app/testpmd: enable TCP/IPv4, VxLAN and GRE GS= O > > > >> -----Original Message----- >> From: Kavanagh, Mark B >> Sent: Wednesday, October 4, 2017 5:23 PM >> To: Ananyev, Konstantin ; dev@dpdk.org >> Cc: Hu, Jiayu ; Tan, Jianfeng ; >Yigit, Ferruh ; thomas@monjalon.net >> Subject: RE: [PATCH v6 5/6] app/testpmd: enable TCP/IPv4, VxLAN and GRE = GSO >> >> >> >> >-----Original Message----- >> >From: Ananyev, Konstantin >> >Sent: Wednesday, October 4, 2017 4:09 PM >> >To: Kavanagh, Mark B ; dev@dpdk.org >> >Cc: Hu, Jiayu ; Tan, Jianfeng ; >> >Yigit, Ferruh ; thomas@monjalon.net >> >Subject: RE: [PATCH v6 5/6] app/testpmd: enable TCP/IPv4, VxLAN and GRE= GSO >> > >> > >> > >> >> -----Original Message----- >> >> From: Kavanagh, Mark B >> >> Sent: Monday, October 2, 2017 5:46 PM >> >> To: dev@dpdk.org >> >> Cc: Hu, Jiayu ; Tan, Jianfeng >; >> >Ananyev, Konstantin ; Yigit, >> >> Ferruh ; thomas@monjalon.net; Kavanagh, Mark = B >> > >> >> Subject: [PATCH v6 5/6] app/testpmd: enable TCP/IPv4, VxLAN and GRE G= SO >> >> >> >> From: Jiayu Hu >> >> >> >> This patch adds GSO support to the csum forwarding engine. Oversized >> >> packets transmitted over a GSO-enabled port will undergo segmentation >> >> (with the exception of packet-types unsupported by the GSO library). >> >> GSO support is disabled by default. >> >> >> >> GSO support may be toggled on a per-port basis, using the command: >> >> >> >> "set port gso on|off" >> >> >> >> The maximum packet length (including the packet header and payload) f= or >> >> GSO segments may be set with the command: >> >> >> >> "set gso segsz " >> >> >> >> Show GSO configuration for a given port with the command: >> >> >> >> "show port gso" >> >> >> >> Signed-off-by: Jiayu Hu >> >> Signed-off-by: Mark Kavanagh >> >> --- >> >> app/test-pmd/cmdline.c | 178 >> >++++++++++++++++++++++++++++ >> >> app/test-pmd/config.c | 24 ++++ >> >> app/test-pmd/csumonly.c | 69 ++++++++++- >> >> app/test-pmd/testpmd.c | 13 ++ >> >> app/test-pmd/testpmd.h | 10 ++ >> >> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 46 +++++++ >> >> 6 files changed, 335 insertions(+), 5 deletions(-) >> >> >> >> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c >> >> index ccdf239..05b0ce8 100644 >> >> --- a/app/test-pmd/cmdline.c >> >> +++ b/app/test-pmd/cmdline.c >> >> @@ -431,6 +431,17 @@ static void cmd_help_long_parsed(void >*parsed_result, >> >> " Set max flow number and max packet number per-flow" >> >> " for GRO.\n\n" >> >> >> >> + "set port (port_id) gso (on|off)" >> >> + " Enable or disable Generic Segmentation Offload in" >> >> + " csum forwarding engine.\n\n" >> >> + >> >> + "set gso segsz (length)\n" >> >> + " Set max packet length for output GSO segments," >> >> + " including packet header and payload.\n\n" >> > >> >Probably a good future improvement would be to allow user to specify >gso_type >> >too. >> >> Would you like to see that change implemented in time for the 17.11 rele= ase? > >I think that's too late for such change in 17.11. >My thought was about 18.02 here. >Konstantin No problem - thanks Konstantin.