From: Yongseok Koh <yskoh@mellanox.com>
To: Kevin Traynor <ktraynor@redhat.com>
Cc: Olivier Matz <olivier.matz@6wind.com>,
Shahaf Shuler <shahafs@mellanox.com>, dev <dev@dpdk.org>,
Andrew Rybchenko <arybchenko@solarflare.com>,
Rami Rosen <roszenrami@gmail.com>,
David Marchand <david.marchand@redhat.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v5 2/2] net/mlx5: fix instruction hotspot on replenishing Rx buffer
Date: Fri, 8 Mar 2019 02:05:02 +0000 [thread overview]
Message-ID: <DDF6D894-0A1A-4C2F-B90B-F398679A94EE@mellanox.com> (raw)
In-Reply-To: <d159831c-5964-684f-7e28-a4fb4ad1d2bc@redhat.com>
Oops, I missed this email somehow,
probably out of mind during my long vacation. :-)
I've also encountered this issue with 17.11.6.
http://git.dpdk.org/dpdk-stable/commit/?h=17.11&id=63f06f3fccc87c55adb33248e5c68a0175d213f1
I'll send a backport to you.
Sorry for late reply.
Yongseok
> On Feb 21, 2019, at 11:10 AM, Kevin Traynor <ktraynor@redhat.com> wrote:
>
> Hi Yongseok,
>
> Can you let me know how you want to proceed with the below. I think we
> could just drop as it's a performance optimization, or maybe you have a
> different idea.
>
> thanks,
> Kevin.
>
> On 06/02/2019 15:54, Kevin Traynor wrote:
>> On 01/14/2019 09:16 PM, Yongseok Koh wrote:
>>> On replenishing Rx buffers for vectorized Rx, mbuf->buf_addr isn't needed
>>> to be accessed as it is static and easily calculated from the mbuf address.
>>> Accessing the mbuf content causes unnecessary load stall and it is worsened
>>> on ARM.
>>>
>>> Fixes: 545b884b1da3 ("net/mlx5: fix buffer address posting in SSE Rx")
>>> Cc: stable@dpdk.org
>>>
>>
>> This is using the API introduced in 1/2, so it's not really suitable for
>> backport. Maybe you want to send an alternative for stable?
>>
>>> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
>>> Acked-by: Shahaf Shuler <shahafs@mellanox.com>
>>> ---
>
next prev parent reply other threads:[~2019-03-08 2:05 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 8:54 [dpdk-dev] [PATCH] " Yongseok Koh
2019-01-09 9:38 ` David Marchand
2019-01-09 9:52 ` Olivier Matz
2019-01-09 9:56 ` Yongseok Koh
2019-01-09 10:05 ` David Marchand
2019-01-09 10:11 ` Yongseok Koh
2019-01-09 13:19 ` [dpdk-dev] [PATCH v2 1/2] mbuf: add function returning default buffer address Yongseok Koh
2019-01-09 13:19 ` [dpdk-dev] [PATCH v2 2/2] net/mlx5: fix instruction hotspot on replenishing Rx buffer Yongseok Koh
2019-01-09 13:46 ` [dpdk-dev] [PATCH v2 1/2] mbuf: add function returning default buffer address David Marchand
2019-01-10 1:39 ` Rami Rosen
2019-01-10 18:18 ` Yongseok Koh
2019-01-10 18:22 ` Yongseok Koh
2019-01-10 18:35 ` [dpdk-dev] [PATCH v3 " Yongseok Koh
2019-01-10 18:35 ` [dpdk-dev] [PATCH v3 2/2] net/mlx5: fix instruction hotspot on replenishing Rx buffer Yongseok Koh
2019-01-10 19:10 ` Shahaf Shuler
2019-01-11 8:14 ` [dpdk-dev] [PATCH v3 1/2] mbuf: add function returning default buffer address Andrew Rybchenko
2019-01-11 11:03 ` Yongseok Koh
2019-01-11 11:17 ` Andrew Rybchenko
2019-01-11 11:37 ` Yongseok Koh
2019-01-11 11:57 ` Bruce Richardson
2019-01-11 12:48 ` David Marchand
2019-01-14 15:51 ` Olivier Matz
2019-01-10 22:40 ` [dpdk-dev] [PATCH v4 " Yongseok Koh
2019-01-10 22:40 ` [dpdk-dev] [PATCH v4 2/2] net/mlx5: fix instruction hotspot on replenishing Rx buffer Yongseok Koh
2019-01-11 8:05 ` [dpdk-dev] [PATCH v4 1/2] mbuf: add function returning default buffer address Olivier Matz
2019-01-11 8:11 ` David Marchand
2019-01-11 8:32 ` David Marchand
2019-01-11 11:09 ` Yongseok Koh
2019-01-11 10:25 ` Thomas Monjalon
2019-01-14 21:16 ` [dpdk-dev] [PATCH v5 1/2] mbuf: add function returning " Yongseok Koh
2019-01-14 21:16 ` [dpdk-dev] [PATCH v5 2/2] net/mlx5: fix instruction hotspot on replenishing Rx buffer Yongseok Koh
2019-02-06 15:54 ` Kevin Traynor
2019-02-21 19:10 ` Kevin Traynor
2019-03-08 2:05 ` Yongseok Koh [this message]
2019-01-15 1:35 ` [dpdk-dev] [PATCH v5 1/2] mbuf: add function returning buffer address Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DDF6D894-0A1A-4C2F-B90B-F398679A94EE@mellanox.com \
--to=yskoh@mellanox.com \
--cc=arybchenko@solarflare.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ktraynor@redhat.com \
--cc=olivier.matz@6wind.com \
--cc=roszenrami@gmail.com \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).