From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130043.outbound.protection.outlook.com [40.107.13.43]) by dpdk.org (Postfix) with ESMTP id C28605F62; Fri, 8 Mar 2019 03:05:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dwlJYLaAmGVS+FpoCEI059+scvCG1/+fH+XgmUVkq7M=; b=uifOU7LZuMPpOAQ6AUOevd8G6n8Gqa4YJftyjMI0llpBF8qSZrSUdeX8jMIsbPKkYsbhppuUqoE5a9ZYJEC5S4+XnsmKmHEHhqJmhMhzTiTBn9I0hO9yo2A/7y+pimfM9yeesiQbQnerBABQA+Y+0Xqzp9j+6cs0nO2ZdCEb0QI= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB3961.eurprd05.prod.outlook.com (52.134.70.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.17; Fri, 8 Mar 2019 02:05:02 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::580c:ae7b:8278:cc50]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::580c:ae7b:8278:cc50%3]) with mapi id 15.20.1686.018; Fri, 8 Mar 2019 02:05:02 +0000 From: Yongseok Koh To: Kevin Traynor CC: Olivier Matz , Shahaf Shuler , dev , Andrew Rybchenko , Rami Rosen , David Marchand , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v5 2/2] net/mlx5: fix instruction hotspot on replenishing Rx buffer Thread-Index: AQHUvjQ26PG/L+7X+kSBXTr+XlPdtaXqtbeAgBZ0jYA= Date: Fri, 8 Mar 2019 02:05:02 +0000 Message-ID: References: <20190109085426.39965-1-yskoh@mellanox.com> <20190114211622.6900-1-yskoh@mellanox.com> <20190114211622.6900-2-yskoh@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 36217603-4748-441e-3672-08d6a36a79e9 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB3961; x-ms-traffictypediagnostic: DB3PR0502MB3961: x-ms-exchange-purlcount: 1 x-microsoft-exchange-diagnostics: =?us-ascii?Q?1; DB3PR0502MB3961; 23:zwDnhE2bV/3IuJLe8QGpWfhrGFt7Jt9kazO9643?= =?us-ascii?Q?CAlAa/So7QYw1NHHyd5u9TjFFCodqU9XU3ZbkHoO8XA8ZojUc+Efkb6ILgu3?= =?us-ascii?Q?VYWCHeIdJMZZZNlXIWLrd5oX5h+Y/qXLLYbKF9WmqVn0A2qVTbsAU0xwFni2?= =?us-ascii?Q?um/z1MF89q2hjdwx47yNFK2g8zk3QKp9yRkGSbUbJVeZ+KDX0sGWuKjowzBb?= =?us-ascii?Q?7pbDcDTvSfUJ3qigvHOZEa8DOGcBXrEByTBol+nx2HOZsCzri1drdH00K6ro?= =?us-ascii?Q?YDh9hyoh57nq2Nsz6nb1C7Zlm8eZLyovhh12rjUlCx2yaliN67Lu+YA3cds3?= =?us-ascii?Q?xES8t93JN5dqJkKHNVFgO7OD5wzVZrEW9Xb8t80qvuySJhHBz5vxG4ssgfcq?= =?us-ascii?Q?B/mNlPYfj/YIxa3CGCd0JXaJp49Ir/CVpfcSxkvCc/IZDiDy319oQFVbZyeb?= =?us-ascii?Q?rBXcpDbXhwWW0nhGZloU5+Hr1ktVtg8tZBdDWrDsbTv4Ypnexfdi7cdctFbU?= =?us-ascii?Q?R1/9sjez5TO+83ejFBNwd+SjCkP1xdHbojK+zYCkTjGrCAmbrFxw7LOxGZl9?= =?us-ascii?Q?VgNAJR9CIXfltYB/WJkcIUNgbgFfryoIKtKserZ6kWTO7Xkgoi9kMkaI3tuS?= =?us-ascii?Q?6WGHo6xpfx4T9+cUHn/FYO5yGq56xbf39EgBUCBHsWfdd3n8xvjTMeZEM7pS?= =?us-ascii?Q?LQU3lC9KZlUN4LMb0uBg8O0jtJ3pInaaDbze72p89A9ObPwb364U2W4Gqgni?= =?us-ascii?Q?e3X2ILXDUbyCpudw9lMOgywi1GnbBudFp8X5k9ZNJxZC1dqbEbPEFIXPeWNt?= =?us-ascii?Q?EUcxCgt1r6ZAqbiafN0/lYoIScjQ6WFltC8y4UTV6KBp6drsFEpmZgIFGGFs?= =?us-ascii?Q?D/NA8hdwSeY5biYwIVRGrFeXD/Ew5yhVecY55BD7GBIGi9FVfWU/AGy4P7PE?= =?us-ascii?Q?YPNzJe6724+Mwy9aPoMrDXzZ9U96yT85a6ACrz98ypcIvmv/XSDAkMfqt27l?= =?us-ascii?Q?kKFrrXd+ia6M2U232pte2yB9TuBtBTOtrgPfaDO0NgED/x/2/5hQgDOZ3kX+?= =?us-ascii?Q?KSFoj1BRmF4XwPt1c4vl+pCCO/ZYPWXBUP6gieXPm0OmgI7HHuhmYHqCA/Fv?= =?us-ascii?Q?q5qML5RJ9UsTmC+o6iiwuIldY+1nuSCvyz6o8532NX8EnQQ0Z5HR9I1KRNvD?= =?us-ascii?Q?VdGo1W54mg12LYgA5cQsAgDkrH5Gplb3lKv47D1rpMHar5mjotSFgAfL5hox?= =?us-ascii?Q?20N+Jw613EssWPDia7BMEza5hILCPoHhHSfE9IRFvQiN33soEXqd898wdDKp?= =?us-ascii?Q?rJO3bPowYEoV9kNQkLulD8mw=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 0970508454 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(396003)(136003)(39860400002)(366004)(189003)(199004)(305945005)(6486002)(76176011)(99286004)(81156014)(6436002)(3846002)(53546011)(53936002)(6116002)(6306002)(66066001)(26005)(7736002)(6512007)(186003)(2616005)(446003)(476003)(11346002)(486006)(68736007)(102836004)(6506007)(229853002)(97736004)(8676002)(8936002)(54906003)(4326008)(86362001)(71190400001)(82746002)(6246003)(36756003)(6916009)(256004)(2906002)(5660300002)(83716004)(316002)(14454004)(966005)(25786009)(93886005)(105586002)(478600001)(71200400001)(33656002)(106356001)(81166006); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3961; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: o6ebvbNyKgcBDeq1k8ihIAOd/EfLyRxWraE861D01YivRXgQCU8F7wphYGp+5ZKSMZPKaXjckFAE8mlnFJgyPUdZw1c/PCmpDujqNEsXlgxau+ECFUKrD10oqOSXbDb5c6YmHhmBSleIMa1tHytaJvYnMzpaEiqjoKNYLogjMrBUufvakkuLdz/rjc5RWiHdktL17lEcbIR2dT3mhr37MAYDeEKxAgNZ6ABhVFtiggVvDz+E2UPg8YnAf5gI2/UgaRoOxPdIACmRGKBoRao9eYNGIRrwjgXRI5qrrZJRn7N2SaxvfxoIKQGXhegeKRcX61ks9JQyH+x+XXWFcy602j0U43EZzT0GpQGPPWT5afFfnNOg10FVvAtT+qyKZNdGZQI9DKnU/tnZl//wWlST+3sUopjV6xk34HHWrr0b9Jc= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 36217603-4748-441e-3672-08d6a36a79e9 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2019 02:05:02.5230 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3961 Subject: Re: [dpdk-dev] [PATCH v5 2/2] net/mlx5: fix instruction hotspot on replenishing Rx buffer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Mar 2019 02:05:05 -0000 Oops, I missed this email somehow, probably out of mind during my long vacation. :-) I've also encountered this issue with 17.11.6. http://git.dpdk.org/dpdk-stable/commit/?h=3D17.11&id=3D63f06f3fccc87c55adb3= 3248e5c68a0175d213f1 I'll send a backport to you. Sorry for late reply. Yongseok > On Feb 21, 2019, at 11:10 AM, Kevin Traynor wrote: >=20 > Hi Yongseok, >=20 > Can you let me know how you want to proceed with the below. I think we > could just drop as it's a performance optimization, or maybe you have a > different idea. >=20 > thanks, > Kevin. >=20 > On 06/02/2019 15:54, Kevin Traynor wrote: >> On 01/14/2019 09:16 PM, Yongseok Koh wrote: >>> On replenishing Rx buffers for vectorized Rx, mbuf->buf_addr isn't need= ed >>> to be accessed as it is static and easily calculated from the mbuf addr= ess. >>> Accessing the mbuf content causes unnecessary load stall and it is wors= ened >>> on ARM. >>>=20 >>> Fixes: 545b884b1da3 ("net/mlx5: fix buffer address posting in SSE Rx") >>> Cc: stable@dpdk.org >>>=20 >>=20 >> This is using the API introduced in 1/2, so it's not really suitable for >> backport. Maybe you want to send an alternative for stable? >>=20 >>> Signed-off-by: Yongseok Koh >>> Acked-by: Shahaf Shuler >>> --- >=20