From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0068.outbound.protection.outlook.com [104.47.1.68]) by dpdk.org (Postfix) with ESMTP id 24B7E4C9D; Tue, 14 Aug 2018 18:23:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B9jzomzIIiaZagnypRLKYwX3UEwMi45JwuBlvgd6wUI=; b=VMHR3pp+yTOb0boxSG7KKHv6HbTHOtQhHr+YsDTfXB/U82i3RDSi+JLYXz3byTTfPMb6jQpMglwSAFkM/7+1kh4QHnA38t8kuaTO5EEoFDltt1qhuy6J+HOptS37wf7pWmB5+SnxIUvuhLv0qAUZ3+3c4ZOe8w2ElidbVUOH4hM= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB4011.eurprd05.prod.outlook.com (52.134.72.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1038.25; Tue, 14 Aug 2018 16:23:10 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::112:180c:634a:c61c]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::112:180c:634a:c61c%2]) with mapi id 15.20.1017.022; Tue, 14 Aug 2018 16:23:10 +0000 From: Yongseok Koh To: Shahaf Shuler CC: "dev@dpdk.org" , dpdk stable , =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , Ori Kam Thread-Topic: [PATCH v2] net/mlx5: fix RSS flow action hash type selection Thread-Index: AQHUM8B7kFP/pXINbUycuX6Ck5+u66S/bqyA Date: Tue, 14 Aug 2018 16:23:10 +0000 Message-ID: References: <20180812111441.149234-1-shahafs@mellanox.com> <40237a945a95cad4cd0a422f0975bc03f294b0e7.1534245265.git.shahafs@mellanox.com> In-Reply-To: <40237a945a95cad4cd0a422f0975bc03f294b0e7.1534245265.git.shahafs@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB3PR0502MB4011; 6:gIBzvnPkBoNLxTcliIC7X3iW4YCu5neqaTxnQtI/sbbVaM6T5ZF3pPXyrCQ/xPHK8VGDXNhPinuBsaUaF5O3WwjT23C7NjIsi5AR8nDAmTFqrTX/+upyunh6dF7UO9UBu9rjifuj+S9FhNhmXRS0ya/QljKPjKWYOymuzdhB/y3bL7xqd1rq4OncwYKWjrcHFwKdhpcAS3Z6pCGdBPVgUqcxG+TN8J4AzB+Q3aNjmjmegPVyegDJwi9NXN/8hGRREMijyQjkP5GpRxXM9w6YX85F91VWoEpfrckTiNTOKBQ609FYWO53csQQm7G2o35uCi3C2TBGV6FqD6OKFHt5Ku62HkSIK3wSw7otETPW0CL5K5ItqTa9pFS3+gQV97PBfP04lQry/wIwZkwUHQ9GrOHxXJTOtP6rK6tqw72CCH2H9fir6BnyvhDUpBteaSQvVm3kR2oaLC+EdGVPZ/NTeQ==; 5:5LPf1299RfY3aiHHKYJBNwUDn8njfZfnl2Akx1lyQMA/tDSO/D66TaFdvji8xKHYKkaSU+rp8sG6KTApe9e3skhOK/i+gePIU/KwGXuPVd1i7sAYQDwY8lrMxPcJV8id3S9rZ9yY0aIGCTyHw2rglewhMYH9brZ1d12I0ShKj8A=; 7:/Ztcd9+Xbhmx26oOdMgHnKzeddoAmdOs4Q+PtrnBDWKIrUwxRKaorJG8WcBlzcJGlQn1QkO8bCi61lfWq76gH05Tj/+hMTNga94mja0B4tkzAbJQQnSVwK2cZJC5KT5HUg+jxqg5X1CxGWKRfJyDW7Cujvy+FMVucA1PDb9iZSB5Z8VGsB8GaOEFxil+PFwgESu/F8EbHBYozZZbKLr/j0a2W7aZk1vbbXt4boLOPa5H8ZSQr/70V4is3zdwo0Aa x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 9df15278-fe1b-4bb2-bd02-08d602023a2c x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB4011; x-ms-traffictypediagnostic: DB3PR0502MB4011: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(95692535739014); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231311)(944501410)(52105095)(10201501046)(3002001)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:DB3PR0502MB4011; BCL:0; PCL:0; RULEID:; SRVR:DB3PR0502MB4011; x-forefront-prvs: 0764C4A8CD x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(136003)(366004)(376002)(346002)(199004)(189003)(11346002)(446003)(3846002)(6116002)(105586002)(229853002)(2616005)(6636002)(53936002)(2900100001)(4326008)(36756003)(26005)(106356001)(476003)(6862004)(256004)(37006003)(2906002)(99286004)(6246003)(8936002)(486006)(54906003)(107886003)(6512007)(25786009)(305945005)(53546011)(14454004)(82746002)(8676002)(83716003)(575784001)(7736002)(478600001)(6506007)(76176011)(66066001)(81156014)(33656002)(102836004)(316002)(86362001)(6436002)(6486002)(68736007)(81166006)(5250100002)(5660300001)(97736004); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4011; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: QxFyFSo6M3hqlMPodWecKxXxRsVXzt6ddyAr//rN6RcZWQtNwY2dK7VQIK9lgOgoOhSchEB3kLcDUP81T4+MP41ONSrr2r0F+cFH26IPyf19uWpidYkseBum6JWgC9AYcMR10gvMZ6M5+3oYKznwVITGaOXimwMtqhrTpp8FC1VTGpSaaJt1bX/VhwRlIxqwSL2Dial2vt8iR28MN6H60bRh36hB6/D0OwpHJrHgjvUByfEwxEs4X1ZSeb+d4tY8x/Lq1H8smmocZr0tBBKdpkffC5x//8qzTio673ixkueMRn9YavAAlQDbhLmZiBvV3u+p9EHh76mIGygt9pb2AMrGAF9MW/ARb0Dr8qL/O0Y= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9df15278-fe1b-4bb2-bd02-08d602023a2c X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Aug 2018 16:23:10.7303 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4011 Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix RSS flow action hash type selection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Aug 2018 16:23:12 -0000 > On Aug 14, 2018, at 4:17 AM, Shahaf Shuler wrote: >=20 > On the code after the below commits, the criteria to select the IPV4 or > IPV6 hash functions was the existence of some ETH_RSS_IPV4 RSS types on > the flow rule. >=20 > The check is wrong. For example ETH_RSS_NONFRAG_IPV4_TCP will not select > the IPV4 hash which will cause the packet to be spread in a bad way. >=20 > Fix it by adding the corresponding types needed for each hash selection. >=20 > Fixes: 592f05b29a25 ("net/mlx5: add RSS flow action") > Fixes: fd0b70316bca ("net/mlx5: support inner RSS computation") > Cc: stable@dpdk.org > Cc: nelio.laranjeiro@6wind.com > Cc: orika@mellanox.com >=20 > Reported-by: Yaroslav Brustinov > Signed-off-by: Shahaf Shuler > --- Acked-by: Yongseok Koh =20 Thanks