DPDK patches and discussions
 help / color / mirror / Atom feed
From: Igor Ryzhov <iryzhov@nfware.com>
To: "Van Haaren, Harry" <harry.van.haaren@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] Virtio xstats problem
Date: Fri, 26 Feb 2016 17:35:46 +0300	[thread overview]
Message-ID: <DEB83D36-3C07-44E2-9568-132C123CAF59@nfware.com> (raw)
In-Reply-To: <E923DB57A917B54B9182A2E928D00FA612878A7D@IRSMSX101.ger.corp.intel.com>

Hello, Harry.

Understood about size of packets. It's a bit confusing, because in all other drivers undersized packet is an error. Maybe we should add another one size bin for virtio - 60 to 63 bytes?

I already checked about multicast/broadcast counters - broadcast packets are counted twice:

	vq->multicast += is_multicast_ether_addr(ea);
	vq->broadcast += is_broadcast_ether_addr(ea);

I think it should be something like:

	if (is_multicast_ether_addr(ea)) {
		if (is_broadcast_ether_addr(ea)) {
			vq->broadcast++;
		} else {
			vq->multicast++;
		}
	}

Best regards,
Igor

> 26 февр. 2016 г., в 17:29, Van Haaren, Harry <harry.van.haaren@intel.com> написал(а):
> 
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Igor Ryzhov
>> I found some problem with virtio xstats counters.
>> 
>> Example:
>> 
>> rx_good_packets: 3
>> rx_good_bytes: 180
>> rx_errors: 0
>> 
>> rx_q0_good_packets: 3
>> rx_q0_good_bytes: 180
>> rx_q0_errors: 0
>> 
>> rx_q0_multicast_packets: 3
>> rx_q0_broadcast_packets: 1
>> rx_q0_undersize_packets: 3
> 
>> It means that undersize packets are counted as good packets instead of errors.
> 
> Are you sending 64 byte packets? There are no 4 bytes of CRC on virtual
> interfaces, so 60 bytes per packet is OK.
> 
>> Or maybe
>> size of packet is calculated wrong.
>> I don't have time now to check it more deeply - I can do it sometime later, but maybe
>> someone want to help.
> 
> Are the packets multicast or broadcast?
> It looks like one of the counters there is wrong.
> 
>> PS. Is it a common practice to count broadcast packets twice - in broadcast and multicast
>> counters?
> 
> No packet should be counted twice - it must be put into one bucket of mutli, broad or unicast.
> 
> -Harry

  reply	other threads:[~2016-02-26 14:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-26 13:56 Igor Ryzhov
2016-02-26 14:29 ` Van Haaren, Harry
2016-02-26 14:35   ` Igor Ryzhov [this message]
2016-02-26 15:03     ` Igor Ryzhov
2016-02-26 15:18     ` Kyle Larose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DEB83D36-3C07-44E2-9568-132C123CAF59@nfware.com \
    --to=iryzhov@nfware.com \
    --cc=dev@dpdk.org \
    --cc=harry.van.haaren@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).