From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 927EF11F5 for ; Mon, 29 Sep 2014 04:44:50 +0200 (CEST) Received: from azsmga001.ch.intel.com ([10.2.17.19]) by orsmga101.jf.intel.com with ESMTP; 28 Sep 2014 19:51:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,617,1406617200"; d="scan'208";a="480627993" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by azsmga001.ch.intel.com with ESMTP; 28 Sep 2014 19:51:22 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.195.1; Sun, 28 Sep 2014 19:51:22 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.195.1; Sun, 28 Sep 2014 19:51:21 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.203]) by shsmsx102.ccr.corp.intel.com ([169.254.2.192]) with mapi id 14.03.0195.001; Mon, 29 Sep 2014 10:51:20 +0800 From: "Xu, HuilongX" To: "Zhang, Helin" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 4/5] i40e: set crc stripping in rx queue configuration Thread-Index: AQHP0CsYjXaO8GPs/kKiWa46IuURtJwXeg2A Date: Mon, 29 Sep 2014 02:51:20 +0000 Message-ID: References: <1410706109-30448-1-git-send-email-helin.zhang@intel.com> <1410706109-30448-5-git-send-email-helin.zhang@intel.com> In-Reply-To: <1410706109-30448-5-git-send-email-helin.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 4/5] i40e: set crc stripping in rx queue configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Sep 2014 02:44:51 -0000 Tested-by: HuilongX xu This patch has been verified on FC20 with eagle fountain:4*10G fortville, s= pirit falls 1*40G fortville and 2*40G fortville. The VF is greater by SRIOV, and testpmd should be run on host to support V= F work on VM. CRC stripping function works well in the testpmd app in VM and host. Test environment information detail information as the following: HOST environment: CPU: Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz OS: Linux 3.11.10-301.fc20.x86_64 =20 GCC: 4.8.3 NIC: Eagle Fountain:4*10G fortville, Spirit Falls 1*40G fortville and 2*40G= fortville. VM environment generated by KVM: CPU: Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz OS: Linux 3.11.10-301.fc20.x86_64 GCC: 4.8.2 NIC: VF generated through SRIOV =20 -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Helin Zhang Sent: Sunday, September 14, 2014 10:48 PM To: dev@dpdk.org Subject: [dpdk-dev] [PATCH v2 4/5] i40e: set crc stripping in rx queue conf= iguration It enables/disables the crc stripping in the rx queue contexts, according to the extra configuration carried from VF. v2 changes: * Put setting the crc stripping into a single patch. Signed-off-by: Helin Zhang Reviewed-by: Jingjing Wu Reviewed-by: Jing Chen --- lib/librte_pmd_i40e/i40e_pf.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/librte_pmd_i40e/i40e_pf.c b/lib/librte_pmd_i40e/i40e_pf.c index bc9bfcb..2910fd5 100644 --- a/lib/librte_pmd_i40e/i40e_pf.c +++ b/lib/librte_pmd_i40e/i40e_pf.c @@ -357,7 +357,10 @@ i40e_pf_host_hmc_config_rxq(struct i40e_hw *hw, rx_ctx.tphdata_ena =3D 1; rx_ctx.tphhead_ena =3D 1; rx_ctx.lrxqthresh =3D 2; - rx_ctx.crcstrip =3D 1; + if (qpei) /* For DPDK PF host */ + rx_ctx.crcstrip =3D qpei->crcstrip ? 1 : 0; + else /* For Linux PF host */ + rx_ctx.crcstrip =3D 1; rx_ctx.l2tsel =3D 1; rx_ctx.prefena =3D 1; =20 --=20 1.8.1.4