From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id E6EFDAFDD for ; Tue, 27 May 2014 05:37:48 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 26 May 2014 20:32:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.98,916,1392192000"; d="scan'208,217";a="546901598" Received: from fmsmsx104.amr.corp.intel.com ([10.19.9.35]) by orsmga002.jf.intel.com with ESMTP; 26 May 2014 20:37:58 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX104.amr.corp.intel.com (10.19.9.35) with Microsoft SMTP Server (TLS) id 14.3.123.3; Mon, 26 May 2014 20:37:57 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.7]) by shsmsx102.ccr.corp.intel.com ([169.254.2.190]) with mapi id 14.03.0123.003; Tue, 27 May 2014 11:37:55 +0800 From: "Xu, HuilongX" To: "dev@dpdk.org" , "Burakov, Anatoly" , Thomas Monjalon Thread-Topic: RE: [dpdk-dev] [PATCH v2 13/16] Removed PCI ID table from igb_uio Thread-Index: Ac95XQtZIouVXqpFS36pNJllRxzvyw== Date: Tue, 27 May 2014 03:37:55 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 13/16] Removed PCI ID table from igb_uio X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 May 2014 03:37:49 -0000 Note that since igb_uio no longer has a PCI ID list, it can now be bound to any device, not just those explicitly supported by DPDK. In other words, it now behaves similar to PCI stub, VFIO and other generic PCI drivers. Therefore to bind a new device to igb_uio, the user will now have to first write its PCI ID to "new_id" file inside the igb_uio driver directory, and only then write the PCI ID to "bind". This will be reflected in later changes to PCI binding script as well. Signed-off-by: Anatoly Burakov Test-by: HuilongX Xu Compile pass >>Compile OS: FC20 x86_64 >>Kernel version: 3.13.6-200 >>GCC version: 4.8.2 >>Server: Crownpass --- lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 21 +-------------------- 1 files changed, 1 insertions(+), 20 deletions(-) diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/lin= uxapp/igb_uio/igb_uio.c index 043c0f6..d30c94a 100644 --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c @@ -65,25 +65,6 @@ struct rte_uio_pci_dev { static char *intr_mode =3D NULL; static enum rte_intr_mode igbuio_intr_mode_preferred =3D RTE_INTR_MODE_MSIX= ; -/* PCI device id table */ -static struct pci_device_id igbuio_pci_ids[] =3D { -#define RTE_PCI_DEV_ID_DECL_EM(vend, dev) {PCI_DEVICE(vend, dev)}, -#define RTE_PCI_DEV_ID_DECL_IGB(vend, dev) {PCI_DEVICE(vend, dev)}, -#define RTE_PCI_DEV_ID_DECL_IGBVF(vend, dev) {PCI_DEVICE(vend, dev)}, -#define RTE_PCI_DEV_ID_DECL_IXGBE(vend, dev) {PCI_DEVICE(vend, dev)}, -#define RTE_PCI_DEV_ID_DECL_IXGBEVF(vend, dev) {PCI_DEVICE(vend, dev)}, -#ifdef RTE_LIBRTE_VIRTIO_PMD -#define RTE_PCI_DEV_ID_DECL_VIRTIO(vend, dev) {PCI_DEVICE(vend, dev)}, -#endif -#ifdef RTE_LIBRTE_VMXNET3_PMD -#define RTE_PCI_DEV_ID_DECL_VMXNET3(vend, dev) {PCI_DEVICE(vend, dev)}, -#endif -#include -{ 0, }, -}; - -MODULE_DEVICE_TABLE(pci, igbuio_pci_ids); - static inline struct rte_uio_pci_dev * igbuio_get_uio_pci_dev(struct uio_info *info) { @@ -620,7 +601,7 @@ igbuio_config_intr_mode(char *intr_str) static struct pci_driver igbuio_pci_driver =3D { .name =3D "igb_uio", - .id_table =3D igbuio_pci_ids, + .id_table =3D NULL, .probe =3D igbuio_pci_probe, .remove =3D igbuio_pci_remove, }; -- 1.7.0.7