From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id AF3E8ADA6 for ; Mon, 23 Feb 2015 12:47:45 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP; 23 Feb 2015 03:47:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,630,1418112000"; d="scan'208";a="458293766" Received: from pgsmsx105.gar.corp.intel.com ([10.221.44.96]) by FMSMGA003.fm.intel.com with ESMTP; 23 Feb 2015 03:32:20 -0800 Received: from kmsmsx154.gar.corp.intel.com (172.21.73.14) by PGSMSX105.gar.corp.intel.com (10.221.44.96) with Microsoft SMTP Server (TLS) id 14.3.195.1; Mon, 23 Feb 2015 19:47:42 +0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.110.14) by KMSMSX154.gar.corp.intel.com (172.21.73.14) with Microsoft SMTP Server (TLS) id 14.3.195.1; Mon, 23 Feb 2015 19:47:41 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.161]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.197]) with mapi id 14.03.0195.001; Mon, 23 Feb 2015 19:47:40 +0800 From: "Zhou, Danny" To: Thomas Monjalon , "Gonzalez Monroy, Sergio" Thread-Topic: [dpdk-dev] [PATCH v4 4/5] eal: add per rx queue interrupt handling based on VFIO Thread-Index: AQHQTV7E/DHJ5wnUz0u1M4UeJBEYn5z+IH3Q Date: Mon, 23 Feb 2015 11:47:40 +0000 Message-ID: References: <1424353698-29837-1-git-send-email-danny.zhou@intel.com> <1424353698-29837-5-git-send-email-danny.zhou@intel.com> <6417495.deEVoxQ023@xps13> In-Reply-To: <6417495.deEVoxQ023@xps13> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v4 4/5] eal: add per rx queue interrupt handling based on VFIO X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Feb 2015 11:47:46 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Saturday, February 21, 2015 6:44 AM > To: Zhou, Danny; Gonzalez Monroy, Sergio > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 4/5] eal: add per rx queue interrupt ha= ndling based on VFIO >=20 > 2015-02-19 21:48, Zhou Danny: > > v4 changes: > > - Adjust position of new-added structure fields > > > > v3 changes: > > - Fix review comments > > > > v2 changes: > > - Fix compilation issue for a missed header file > > - Bug fix: free unreleased resources on the exception path before retur= n > > - Consolidate coding style related review comments > > > > This patch does below: > > - Create multiple VFIO eventfd for rx queues. > > - Handle per rx queue interrupt. > > - Eliminate unnecessary suspended DPDK polling thread wakeup mechanism > > for rx interrupt by allowing polling thread epoll_wait rx queue > > interrupt notification. > > > > Signed-off-by: Danny Zhou > > Tested-by: Yong Liu > [...] > > --- a/lib/librte_eal/linuxapp/eal/Makefile > > +++ b/lib/librte_eal/linuxapp/eal/Makefile > > @@ -43,6 +43,7 @@ CFLAGS +=3D -I$(SRCDIR)/include > > CFLAGS +=3D -I$(RTE_SDK)/lib/librte_eal/common > > CFLAGS +=3D -I$(RTE_SDK)/lib/librte_eal/common/include > > CFLAGS +=3D -I$(RTE_SDK)/lib/librte_ring > > +CFLAGS +=3D -I$(RTE_SDK)/lib/librte_mbuf > > CFLAGS +=3D -I$(RTE_SDK)/lib/librte_mempool > > CFLAGS +=3D -I$(RTE_SDK)/lib/librte_malloc > > CFLAGS +=3D -I$(RTE_SDK)/lib/librte_ether >=20 > Why do we need mbuf in EAL? The file eal_interrupts.c includes rte_ethdev.h which defines structure rte= _eth_devices that=20 eal needs to use in order to get per-port intr_handle. The rte_ethdev.h inc= ludes the rte_mbuf.h so the Makefile is updated here.