From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 823569AA7 for ; Mon, 23 Feb 2015 16:11:20 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP; 23 Feb 2015 07:11:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,631,1418112000"; d="scan'208";a="670216632" Received: from kmsmsx152.gar.corp.intel.com ([172.21.73.87]) by fmsmga001.fm.intel.com with ESMTP; 23 Feb 2015 07:11:18 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by KMSMSX152.gar.corp.intel.com (172.21.73.87) with Microsoft SMTP Server (TLS) id 14.3.195.1; Mon, 23 Feb 2015 23:11:16 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.161]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.209]) with mapi id 14.03.0195.001; Mon, 23 Feb 2015 23:11:15 +0800 From: "Zhou, Danny" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v4 2/5] ixgbe: enable rx queue interrupts for both PF and VF Thread-Index: AQHQT1q3ouKidC7EkEKdXkHi2oacB5z+Ftig//+bUICAAKPFMA== Date: Mon, 23 Feb 2015 15:11:14 +0000 Message-ID: References: <1424353698-29837-1-git-send-email-danny.zhou@intel.com> <4552356.3plUBHddm1@xps13> <1735949.6aPZLmAlBh@xps13> In-Reply-To: <1735949.6aPZLmAlBh@xps13> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v4 2/5] ixgbe: enable rx queue interrupts for both PF and VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Feb 2015 15:11:21 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Monday, February 23, 2015 9:20 PM > To: Zhou, Danny > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 2/5] ixgbe: enable rx queue interrupts = for both PF and VF >=20 > 2015-02-23 11:23, Zhou, Danny: > > I noticed the V4 patch conflicts with the latest code on the main branc= h due to lots of code merged, and it > > is mentioned by Jun Xu in previous email, and I will have to rebase the= patch and send out V5 version. >=20 > Maybe you misunderstood my comment. > I'm quoting an usage in patch 2 of max_intr which is defined in patch 4. > You have to better split and order your patches to make them compilable > and not break git bisect. >=20 > Thanks >=20 Will split-off a new patch file for rte_interrupts.h which both patch 2 and= patch 4 depends on. > > > -----Original Message----- > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > Sent: Monday, February 23, 2015 7:20 PM > > > To: Zhou, Danny > > > Cc: dev@dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH v4 2/5] ixgbe: enable rx queue interru= pts for both PF and VF > > > > > > 2015-02-19 21:48, Zhou Danny: > > > > + /* set max interrupt vfio request */ > > > > + pci_dev->intr_handle.max_intr =3D hw->mac.max_rx_queues + > > > > + IXGBE_MAX_OTHER_INTR; > > > > + > > > > > > Compilation is broken here. >=20