From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <danny.zhou@intel.com> Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 9C4FE106B for <dev@dpdk.org>; Fri, 5 Jun 2015 10:59:45 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP; 05 Jun 2015 01:59:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,557,1427785200"; d="scan'208";a="705790880" Received: from pgsmsx108.gar.corp.intel.com ([10.221.44.103]) by orsmga001.jf.intel.com with ESMTP; 05 Jun 2015 01:59:42 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by PGSMSX108.gar.corp.intel.com (10.221.44.103) with Microsoft SMTP Server (TLS) id 14.3.224.2; Fri, 5 Jun 2015 16:59:42 +0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.94]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.23]) with mapi id 14.03.0224.002; Fri, 5 Jun 2015 16:59:35 +0800 From: "Zhou, Danny" <danny.zhou@intel.com> To: "Liang, Cunming" <cunming.liang@intel.com>, "dev@dpdk.org" <dev@dpdk.org> Thread-Topic: [PATCH v11 00/13] Interrupt mode PMD Thread-Index: AQHQn2h9j5WN7261OUmY5wBkqav1G52dnNgA Date: Fri, 5 Jun 2015 08:59:34 +0000 Message-ID: <DFDF335405C17848924A094BC35766CF0ADD5E4D@SHSMSX104.ccr.corp.intel.com> References: <1433228006-24661-1-git-send-email-cunming.liang@intel.com> <1433492410-30832-1-git-send-email-cunming.liang@intel.com> In-Reply-To: <1433492410-30832-1-git-send-email-cunming.liang@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "shemming@brocade.com" <shemming@brocade.com>, "Wang, Liang-min" <liang-min.wang@intel.com> Subject: Re: [dpdk-dev] [PATCH v11 00/13] Interrupt mode PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 05 Jun 2015 08:59:46 -0000 Acked-by: Danny Zhou <danny.zhou@intel.com> > -----Original Message----- > From: Liang, Cunming > Sent: Friday, June 05, 2015 4:20 PM > To: dev@dpdk.org > Cc: shemming@brocade.com; david.marchand@6wind.com; thomas.monjalon@6wind= .com; Zhou, Danny; Wang, Liang-min; > Richardson, Bruce; Liu, Yong; nhorman@tuxdriver.com; Liang, Cunming > Subject: [PATCH v11 00/13] Interrupt mode PMD >=20 > v11 changes > - typo cleanup and check kernel style >=20 > v10 changes > - code rework to return actual error code > - bug fix for lsc when using uio_pci_generic >=20 > v9 changes > - code rework to fix open comment > - bug fix for igb lsc when both lsc and rxq are enabled in vfio-msix > - new patch to turn off the feature by default so as to avoid v2.1 abi b= roken >=20 > v8 changes > - remove condition check for only vfio-msix > - add multiplex intr support when only one intr vector allowed > - lsc and rxq interrupt runtime enable decision > - add safe event delete while the event wakeup execution happens >=20 > v7 changes > - decouple epoll event and intr operation > - add condition check in the case intr vector is disabled > - renaming some APIs >=20 > v6 changes > - split rte_intr_wait_rx_pkt into two APIs 'wait' and 'set'. > - rewrite rte_intr_rx_wait/rte_intr_rx_set. > - using vector number instead of queue_id as interrupt API params. > - patch reorder and split. >=20 > v5 changes > - Rebase the patchset onto the HEAD > - Isolate ethdev from EAL for new-added wait-for-rx interrupt function > - Export wait-for-rx interrupt function for shared libraries > - Split-off a new patch file for changed struct rte_intr_handle that > other patches depend on, to avoid breaking git bisect > - Change sample applicaiton to accomodate EAL function spec change > accordingly >=20 > v4 changes > - Export interrupt enable/disable functions for shared libraries > - Adjust position of new-added structure fields and functions to > avoid breaking ABI >=20 > v3 changes > - Add return value for interrupt enable/disable functions > - Move spinlok from PMD to L3fwd-power > - Remove unnecessary variables in e1000_mac_info > - Fix miscelleous review comments >=20 > v2 changes > - Fix compilation issue in Makefile for missed header file. > - Consolidate internal and community review comments of v1 patch set. >=20 > The patch series introduce low-latency one-shot rx interrupt into DPDK wi= th > polling and interrupt mode switch control example. >=20 > DPDK userspace interrupt notification and handling mechanism is based on = UIO > with below limitation: > 1) It is designed to handle LSC interrupt only with inefficient suspended > pthread wakeup procedure (e.g. UIO wakes up LSC interrupt handling thr= ead > which then wakes up DPDK polling thread). In this way, it introduces > non-deterministic wakeup latency for DPDK polling thread as well as pa= cket > latency if it is used to handle Rx interrupt. > 2) UIO only supports a single interrupt vector which has to been shared b= y > LSC interrupt and interrupts assigned to dedicated rx queues. >=20 > This patchset includes below features: > 1) Enable one-shot rx queue interrupt in ixgbe PMD(PF & VF) and igb PMD(P= F only). > 2) Build on top of the VFIO mechanism instead of UIO, so it could support > up to 64 interrupt vectors for rx queue interrupts. > 3) Have 1 DPDK polling thread handle per Rx queue interrupt with a dedica= ted > VFIO eventfd, which eliminates non-deterministic pthread wakeup latenc= y in > user space. > 4) Demonstrate interrupts control APIs and userspace NAIP-like polling/in= terrupt > switch algorithms in L3fwd-power example. >=20 > Known limitations: > 1) It does not work for UIO due to a single interrupt eventfd shared by L= SC > and rx queue interrupt handlers causes a mess. [FIXED] > 2) LSC interrupt is not supported by VF driver, so it is by default disab= led > in L3fwd-power now. Feel free to turn in on if you want to support bot= h LSC > and rx queue interrupts on a PF. >=20 > Cunming Liang (13): > eal/linux: add interrupt vectors support in intr_handle > eal/linux: add rte_epoll_wait/ctl support > eal/linux: add API to set rx interrupt event monitor > eal/linux: fix comments typo on vfio msi > eal/linux: add interrupt vectors handling on VFIO > eal/linux: standalone intr event fd create support > eal/linux: fix lsc read error in uio_pci_generic > eal/bsd: dummy for new intr definition > ethdev: add rx intr enable, disable and ctl functions > ixgbe: enable rx queue interrupts for both PF and VF > igb: enable rx queue interrupts for PF > l3fwd-power: enable one-shot rx interrupt and polling/interrupt mode > switch > abi: fix v2.1 abi broken issue >=20 > drivers/net/e1000/igb_ethdev.c | 311 ++++++++++-- > drivers/net/ixgbe/ixgbe_ethdev.c | 519 +++++++++++++++= +++++- > drivers/net/ixgbe/ixgbe_ethdev.h | 4 + > examples/l3fwd-power/main.c | 206 ++++++-- > lib/librte_eal/bsdapp/eal/eal_interrupts.c | 19 + > .../bsdapp/eal/include/exec-env/rte_interrupts.h | 81 ++++ > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 5 + > lib/librte_eal/linuxapp/eal/eal_interrupts.c | 361 ++++++++++++-- > .../linuxapp/eal/include/exec-env/rte_interrupts.h | 219 +++++++++ > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 8 + > lib/librte_ether/rte_ethdev.c | 109 +++++ > lib/librte_ether/rte_ethdev.h | 132 ++++++ > lib/librte_ether/rte_ether_version.map | 4 + > 13 files changed, 1853 insertions(+), 125 deletions(-) >=20 > -- > 1.8.1.4