From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0082.outbound.protection.outlook.com [104.47.2.82]) by dpdk.org (Postfix) with ESMTP id 8BB711B448; Wed, 20 Jun 2018 01:23:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CCP7ArFFPT+wezUZuLXFiRDvczwT7kLL9pOEJNNDwrY=; b=wmG4i/NS/fmsXn8MgRtCBBCFEUCvPTCWz2Cy1a5HVINV/hOrrcgFM8CWM0PlqImYcv86jxkwCZAdhHiDq+XkycwYxRtbLiwZqf7CLZdwUdsYdnFNil0VDU8g3PIqb1FTBp4a0kH5KY1q3e6dDxForERGTw5li9qA+YX1qMfdUQM= Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com (10.167.195.147) by VI1PR0501MB1966.eurprd05.prod.outlook.com (10.166.45.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.19; Tue, 19 Jun 2018 23:23:41 +0000 Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::bd68:85f2:e540:99e6]) by VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::bd68:85f2:e540:99e6%5]) with mapi id 15.20.0863.016; Tue, 19 Jun 2018 23:23:41 +0000 From: Yongseok Koh To: Adrien Mazarguil , =?iso-8859-1?Q?N=E9lio_Laranjeiro?= CC: "dev@dpdk.org" , Shahaf Shuler , "stable@dpdk.org" Thread-Topic: [PATCH v2] net/mlx5: fix GRE flow rule Thread-Index: AQHT84ir415ipngFq0qKGrRwBrklFKRoYgsA Date: Tue, 19 Jun 2018 23:23:41 +0000 Message-ID: References: <20180523015157.35716-1-yskoh@mellanox.com> <20180524175648.14255-1-yskoh@mellanox.com> In-Reply-To: <20180524175648.14255-1-yskoh@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0501MB1966; 7:ziXSjsOfR1VaDY7Dfa/90a7bx1+YKL79/+1YPJ1ihtJVwOXeN9E2kZsqtrqtVrInZyAqMxCsc14hG1CTiTzORQcqgdXGd2gKKTeXzVc5pA7/ERhZuPh7O/JGmoPBhd4sNvZFEm4oSxoYM6TvNiKsri8w1lbpr0NJAPdz3LbRYJXSF5DPG8DVsG94u/66fnt/rU8xBeMD6J0350hKf7rGNq2LLTvWx8wIaBnEohnOznUSxeFwMCdCuAT3syKqqJBx x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: b4ba0a69-9fe7-48b0-a097-08d5d63bb1ca x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(48565401081)(2017052603328)(7153060)(7193020); SRVR:VI1PR0501MB1966; x-ms-traffictypediagnostic: VI1PR0501MB1966: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3231254)(944501410)(52105095)(3002001)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123562045)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:VI1PR0501MB1966; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB1966; x-forefront-prvs: 07083FF734 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39380400002)(39860400002)(396003)(376002)(346002)(366004)(199004)(189003)(83716003)(4326008)(36756003)(26005)(8676002)(81156014)(8936002)(68736007)(3660700001)(7736002)(81166006)(99286004)(6246003)(186003)(305945005)(6116002)(25786009)(2616005)(446003)(102836004)(11346002)(97736004)(3846002)(229853002)(86362001)(2900100001)(575784001)(14454004)(476003)(316002)(110136005)(486006)(6506007)(33656002)(5250100002)(3280700002)(54906003)(53546011)(2906002)(82746002)(5660300001)(66066001)(478600001)(106356001)(105586002)(6512007)(53936002)(76176011)(6436002)(6486002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB1966; H:VI1PR0501MB2045.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: atSh9++wYaTWnSqr3zCTbcFFjsMreBJwSIld2bvZ9Aeq0WN0f6golBKmzjYlW7bbsL1Kd/a6x7ytVwiAIl5qGTIOqCPX8a80Tt//11wxr/IsRjaU3zuP2IBZfCpBKtJ4LgpWR+i0R0JxBFFed5qVRVnJjlz6HEMuVJ1Sst8hJno6nLbMLKffA5g8izQpBjjUMA+FldBCqLxKiFW9DumhYKhaZuSRO6sm8ZzR0fx7aFVKQFgNF6+fQkyJuuOA+VU8VqinRKHGsb5s76FWrnjPTaJwO0eL/6/Wdm2+MggdmkjpcV7af7jvhU3QVIN8OaUW spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: b4ba0a69-9fe7-48b0-a097-08d5d63bb1ca X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jun 2018 23:23:41.5923 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB1966 Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix GRE flow rule X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jun 2018 23:23:44 -0000 > On May 24, 2018, at 10:56 AM, Yongseok Koh wrote: >=20 > Creating a flow having pattern from the middle of a packet is allowed. Fo= r > example, >=20 > testpmd> flow create 0 ingress pattern vxlan vni is 20 / end actions ... >=20 > Device can parse GRE protocol number in outer IP header but specifying fr= om > GRE header can't differentiate it from VxLAN tunnel. As a result, the > following rule will be interpreted as a wildcard rule, which always match= es > any packet. >=20 > testpmd> flow create 0 ingress pattern gre / end actions ... >=20 > Fixes: 96c6c65a10d2 ("net/mlx5: support GRE tunnel flow") > Fixes: 1f106da2bf7b ("net/mlx5: support MPLS-in-GRE and MPLS-in-UDP") > Cc: stable@dpdk.org >=20 > Signed-off-by: Yongseok Koh > --- >=20 > v2: > * amend commit message. > * remove GRE entry from the head item regardless of HW support. >=20 > drivers/net/mlx5/mlx5_flow.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index 994be05be..adb995f0d 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -331,8 +331,7 @@ static const struct mlx5_flow_items mlx5_flow_items[]= =3D { > [RTE_FLOW_ITEM_TYPE_END] =3D { > .items =3D ITEMS(RTE_FLOW_ITEM_TYPE_ETH, > RTE_FLOW_ITEM_TYPE_VXLAN, > - RTE_FLOW_ITEM_TYPE_VXLAN_GPE, > - RTE_FLOW_ITEM_TYPE_GRE), > + RTE_FLOW_ITEM_TYPE_VXLAN_GPE), > }, > [RTE_FLOW_ITEM_TYPE_ETH] =3D { > .items =3D ITEMS(RTE_FLOW_ITEM_TYPE_VLAN, > --=20 Taking back this patch as the entire flow engine will be remodeled. But this will be sent again for stable branches. Thanks, Yongseok