DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Loftus, Ciara" <ciara.loftus@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "Richardson, Bruce" <bruce.richardson@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH] net/ice: fix Rx vector offload flags
Date: Thu, 7 Aug 2025 12:42:54 +0000	[thread overview]
Message-ID: <DM3PPF7D18F34A1D78C76357CD3EC36F7AA8E2CA@DM3PPF7D18F34A1.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20250807110843.54385-1-bruce.richardson@intel.com>

> 
> The vector PMD datapaths for ice do not support QinQ, so we need to
> update the vector offload flags to not use the general RX_OFFLOAD_VLAN
> flag (which sets all vlan-related options) and replace it with the
> individually supported VLAN options.
> 
> Fixes: 808a17b3c1e6 ("net/ice: add Rx AVX512 offload path")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  drivers/net/intel/ice/ice_rxtx_vec_common.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/intel/ice/ice_rxtx_vec_common.h
> b/drivers/net/intel/ice/ice_rxtx_vec_common.h
> index 9430a99ba5..e41fd8fc7c 100644
> --- a/drivers/net/intel/ice/ice_rxtx_vec_common.h
> +++ b/drivers/net/intel/ice/ice_rxtx_vec_common.h
> @@ -72,7 +72,8 @@ _ice_rx_queue_release_mbufs_vec(struct ci_rx_queue
> *rxq)
>  #define ICE_RX_VECTOR_OFFLOAD (				\
>  		RTE_ETH_RX_OFFLOAD_CHECKSUM |		\
>  		RTE_ETH_RX_OFFLOAD_SCTP_CKSUM |		\
> -		RTE_ETH_RX_OFFLOAD_VLAN |			\
> +		RTE_ETH_RX_OFFLOAD_VLAN_STRIP |		\
> +		RTE_ETH_RX_OFFLOAD_VLAN_FILTER |	\
>  		RTE_ETH_RX_OFFLOAD_RSS_HASH)
> 
>  #define ICE_VECTOR_PATH		0
> --
> 2.48.1

LGTM.

Acked-by: Ciara Loftus <ciara.loftus@intel.com>


  reply	other threads:[~2025-08-07 12:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-07 11:08 Bruce Richardson
2025-08-07 12:42 ` Loftus, Ciara [this message]
2025-08-07 14:13   ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM3PPF7D18F34A1D78C76357CD3EC36F7AA8E2CA@DM3PPF7D18F34A1.namprd11.prod.outlook.com \
    --to=ciara.loftus@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).