From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93C5AA034F; Fri, 8 Oct 2021 18:08:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 632094014F; Fri, 8 Oct 2021 18:08:27 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id B8CE340143 for ; Fri, 8 Oct 2021 18:08:25 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10131"; a="226437878" X-IronPort-AV: E=Sophos;i="5.85,358,1624345200"; d="scan'208";a="226437878" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2021 09:08:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,358,1624345200"; d="scan'208";a="489518940" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga008.jf.intel.com with ESMTP; 08 Oct 2021 09:08:24 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 8 Oct 2021 09:08:24 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 8 Oct 2021 09:08:24 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.45) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 8 Oct 2021 09:08:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YIvwCFIlxwwWupzpQktusatxj/8n7HImbqxNyqPPptnW0ofgZb2oKnNLRG+qKOMCLWUu3/8aSkyE9DYdEvd7Fy+NEVk9ftPjaEcZjTPl3YKjkC5vs6WtBYXgbNcmL77YcmYWsNt9Boo0Jg7uSo/bAppaJsZcTLHj8UDp9dSpp2lHuPxhgHu2EEVjkqUGGIBpI7Os7LEbvPb5mEEdgr45uv7cGIiYQp3rs/6Kj9GF+ys5/JlcRROreecQTO7DTekqq+E3tZeUCFJyAkLNRJ6zxOAr32Ii/VohKJen6ep0WtJkYq/SSJuoIcSyosloNFpf64gjgBXXy9tEpIBK5DreKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XD2zYkjTC1zqg86ANn3a10gSz1xaHdNPf6RfAi9p5EE=; b=BD2wjVZCodNSjHd4cy57tJKFQxKGPA8JGwEbD1RHblamniIN2ErMCI7zRPCdSYvixZc+93tksJWXJmuWNaE46a0Vyq1pDA1QSjuhuQzU3CDEi3qhCopCslCYh1Rpz/Brlj7XIbrXLy2V0c+I+GD4DVlWIbDtCM7/K68dB/qA4RZXoZ91jl9OVfuQsIYnFInTiQvg5sqxk8ko4GLEtqdg63x6E51roskLI03VRwwAlCVzM0vkmoLHLaUUzZ2v/0oILaEnad1byoMCydF1UZ7HOveEE7cTCFAXfTtycbqqg3cDDhsJyIKJG7vVYxsqxhVJzUcawu5Mpemz5ucFWd5eUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XD2zYkjTC1zqg86ANn3a10gSz1xaHdNPf6RfAi9p5EE=; b=i4m7pZN6ChBDIQv1swMDyn5E820a+Wg285E+teP2yvrczTY3mtnzojk/gEr/1Ted9bRgNSfYRxHQJiYWRXvre3dDhGvnt2Q+CyDX+dZ37BE71gjQpd2k7eBgHFv7esNNoPLW5aU09J7yJ+JTus8NZnd2SrnOMC/HdxA00F3miPQ= Received: from DM4PR11MB5518.namprd11.prod.outlook.com (2603:10b6:5:39f::18) by DM5PR1101MB2137.namprd11.prod.outlook.com (2603:10b6:4:50::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Fri, 8 Oct 2021 16:08:17 +0000 Received: from DM4PR11MB5518.namprd11.prod.outlook.com ([fe80::a1a3:f5ec:2121:415c]) by DM4PR11MB5518.namprd11.prod.outlook.com ([fe80::a1a3:f5ec:2121:415c%7]) with mapi id 15.20.4587.022; Fri, 8 Oct 2021 16:08:17 +0000 From: "Wang, Haiyue" To: William Tu , "dev@dpdk.org" , "Kadam, Pallavi" CC: "david.marchand@redhat.com" Thread-Topic: [PATCH v2] net/e1000: build on Windows Thread-Index: AQHXvEwk1MsZur9mLU+m+5o+314aP6vJQ7lA Date: Fri, 8 Oct 2021 16:08:17 +0000 Message-ID: References: <20211007202451.90271-1-u9012063@gmail.com> <20211008135346.875-1-u9012063@gmail.com> In-Reply-To: <20211008135346.875-1-u9012063@gmail.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7c2e2925-1920-4c2f-baf8-08d98a75d768 x-ms-traffictypediagnostic: DM5PR1101MB2137: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4303; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vQZoDhzKHthI/mhXwEG5iCsan/8Djh9UR8YL0Vp7xF3VtCjRzUKe2DQIbu3NSyz4ZbyvLvwatl7wWHWxTy3Wq6iG2xQFIgA578UIwS2K+W94wB4EYcnq9pfwWZbYfAjTPCVESNWREHC8gVWjOQQD0yEkmw8jrwotjlPS8Pgi1bV+MBR/0FZSMjJIrus64S8KOUrmd9vHDOyOiIUlgWn9vJl5KmiYTQh2/hu8TzX0HwW3RhgD40twkcUp5GVcwUTH+ZBD+0tN1eMMKK8Kwn/Z3QRStjBvoCV4AZ78gOe75r/a54R9HEu4gu2GHh+mPojrJ71yXCidTKTZ+lbKDc61Z95hMcQSMYiTUzUdbPNFFwx4zSjWr6S5PD+4+RpOQVnXzmhEgYeetks8rTiTdb4a2+UdK491MIryvnJ7/kKp/IRdiOp6wncKpizmrXQ++6dMuWJFEamf8mO6mthZ7wv3Za7I70HYRwtt7iwodN/kwkRD3CAW2uUiNvUzsBU+/uOJIwJdQNsOvsuUC3KINNxhSOUGhgrdk+M2flVt5nyoa5CFX4vq5xgXaHsIAP1vOdbOMfyAkRPLN9MCUF43bbdG/KMu1OlAkOY3BivDJhtZ2SMaBRt8MsCvVxn8eztWL3bbDYt5aHasUes8/CWu+j+C1h4Dbr5xyqTUYiCiUHbb6GIBJkNMRvJq7ttP9LAR0wDStfwkmvJK6wOG+17J6AvZqUS2opWtpKUa9D70POT5nyxeyvbwKPYvvshWqxrdHSA44pifHJiYGBMSmPIWF8JRhm0+cIbqNVwXuPOqGbnL1CtAqbdaTp1VO5dDIg34NdEd x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5518.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(26005)(316002)(110136005)(86362001)(38070700005)(2906002)(966005)(508600001)(8936002)(33656002)(6636002)(4326008)(76116006)(38100700002)(53546011)(6506007)(122000001)(8676002)(5660300002)(7696005)(66446008)(83380400001)(64756008)(66556008)(66476007)(55016002)(66946007)(9686003)(71200400001)(186003)(52536014)(460985005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mIiA7EnI81TxnOLm9qySRws7Z/tXVUF9rKR951++ZzqpA4GCkRds6l3bBcZT?= =?us-ascii?Q?o5tsBNClDiGgtxMK4WwS0oPxAdiOPbkwcfTzlHoD6tO1gNXSWv1acPhce8wt?= =?us-ascii?Q?CtCG8ENx5Y5S2Lkp+wLTeGD4stqBok9/GCTdbQPmyyszU7tPVPAVyhqyPVdt?= =?us-ascii?Q?EhCp6RlPce9BI/okHJZXNSMVi2xZXuLLv+/vXmLYg7RvaYfspoUqqUw836P8?= =?us-ascii?Q?wenJ9tZG30slQXpyOiugdM3t4J70HiVjXTrbRi0yY3RU1x7L73IcW5usgVGw?= =?us-ascii?Q?WGeTdKdK8v1dpoNUFkDUnYUpkXQWuvINWZ6QYfGWSl3pTdwo94pRo05cZOuU?= =?us-ascii?Q?EsWyOO/5T6/VZmszxtJD24p2deJflv2mwdzNroSlVNoBYixzYRyT6myOAEd/?= =?us-ascii?Q?IiaGXUKeWtLt40TT7MDnHxP1MIGuyomcXyaFG9+hIe2DVm7sZ4mNnHBBtHXR?= =?us-ascii?Q?zh8kJTo2ep6cxPKyOgF2+I+D7AIPwa9oNTgOMXB9ku8GNhKMt2BSeMvT1RrR?= =?us-ascii?Q?RQReYBcEwnIu3yJEGaDl+JjI4dZGEOxEqV+13p0EiC/p0KzPpm1tauQ2K6nK?= =?us-ascii?Q?yRh1vP+Ek/ZPjlW7Rf40NiqTaI09oPjR60zX3LGdnZcqsPOXhgt2fmRvqmoC?= =?us-ascii?Q?J8oYmtzNzhRV6wWjSuo2fs9BUn9D5NDgyltFQn3R5e30IoOqqk8rLoYKETsh?= =?us-ascii?Q?PZ4R99ptWartCx3LWtUaDJ/q00FAytMEA7JCElW99mUxnPjLxFndIqgz16Aq?= =?us-ascii?Q?Zf8IiZzFu2nW0iDZVggvyil0gZyMETN/dvY6RjubGfTjCTPtSf8nBtaDYEDK?= =?us-ascii?Q?xt2VCmsYTAASaJhNv0C1FNKPlzVxiGojiSJX1kG8k/ptQRNZMjlXxhXF9ySE?= =?us-ascii?Q?x/LSwmgvkYZn6qFgRM4+1UW2EQRGoP6Ws78wN7qCXgaBGlN2xofX1JFtCX3j?= =?us-ascii?Q?E35DN4hkaL0NgP/H7UXuttrj7+Q3tovqin0xT8FVFqr2aSEjW7T+tBMbD4RI?= =?us-ascii?Q?S8iY9MXIyqQXrmIoRhaps6O4A0f9j1dLUZ1NVPnpy1CElJVJyya5sXHwWAoe?= =?us-ascii?Q?aet3ywOzzIluFhBQ2f2hycuTO5pNqMwZjFI0iQAx/PDQyOM1qOaq4uBfrOvF?= =?us-ascii?Q?ALfPLydzcqzf48FHAQjg5CNaDEeXdCvAdCSRTE0ajlSHb/36/xA2wLAfoX1U?= =?us-ascii?Q?PiwjTy49qMMIMdp3WwOUKJmG1Us3Pl0EbrP58+NzQ7taiVZl7btpQlid5qc/?= =?us-ascii?Q?dLKt4+aydsUA5oz+gK0wPGMpRAwJ+M/4ekaq1Y/B4H62BndGOozUStUGeCYe?= =?us-ascii?Q?VxzW50rwPi7YWovL0ZhrfI2w?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5518.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7c2e2925-1920-4c2f-baf8-08d98a75d768 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2021 16:08:17.8372 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qBBctFj5G44WsGPSYS1vgyxpZe7R3RqWCGMiZvgdJ5iun/KVTJjAg+XKeRReDMU3/kFHlW4nmYEW6rWT/B0RyA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2137 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] net/e1000: build on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: William Tu > Sent: Friday, October 8, 2021 21:54 > To: dev@dpdk.org > Cc: Kadam, Pallavi ; david.marchand@redhat.com; = Wang, Haiyue > > Subject: [PATCH v2] net/e1000: build on Windows >=20 > This patch enables building the e1000 driver for Windows. > I tested using two Windows VM on top of VMware Fusion, > creating two e1000 devices with device ID 0x10D3, > verifying rx/tx works correctly using dpdk-testpmd.exe > rxonly and txonly mode. >=20 > Signed-off-by: William Tu > Cc: Haiyue Wang > --- > A short demo: > https://youtu.be/UZ9hm2jQa2Y >=20 > Example when running: > PS C:\dpdk> .\build\app\dpdk-testpmd.exe > EAL: Detected CPU lcores: 4 > EAL: Detected NUMA nodes: 1 > EAL: Multi-process support is requested, but not available. > EAL: WARNING: TSC frequency estimated roughly - clock timings may be less= accurate. > EAL: Probe PCI driver: net_e1000_em (8086:10d3) device: 0000:03:00.0 (soc= ket 0) > EAL: Requested device 0000:1b:00.0 cannot be used > testpmd: create a new mbuf pool : n=3D171456, size=3D2176, soc= ket=3D0 > testpmd: preferred mempool ops selected: ring_mp_mc >=20 > Warning! port-topology=3Dpaired and odd forward ports number, the last po= rt will p > air with itself. > Configuring Port 0 (socket 0) > Port 0: 00:50:56:3A:4D:A6 > Checking link statuses... > Done > No commandline core given, start packet forwarding > allocation mode: native > Logical Core 1 (socket 0) forwards packets on 1 streams: > RX P=3D0/Q=3D0 (socket 0) -> TX P=3D0/Q=3D0 (socket 0) peer=3D02:00:00:= 00:00:00 >=20 > io packet forwarding packets/burst=3D32 > nb forwarding cores=3D1 - nb forwarding ports=3D1 > port 0: RX queue number: 1 Tx queue number: 1 > Rx offloads=3D0x0 Tx offloads=3D0x0 > RX queue: 0 > RX desc=3D256 - RX free threshold=3D0 > TX desc=3D256 - TX free threshold=3D32 > TX offloads=3D0x0 - TX RS bit threshold=3D32 > Press enter to exit >=20 > Telling cores to stop... > Waiting for lcores to finish... >=20 > ---------------------- Forward statistics for port 0 -----------------= - > RX-packets: 40361 RX-dropped: 0 RX-total: 40361 > TX-packets: 40616 TX-dropped: 0 TX-total: 40616 > -----------------------------------------------------------------------= - >=20 > +++++++++++++++ Accumulated forward statistics for all ports+++++++++++ > RX-packets: 40361 RX-dropped: 0 RX-total: 40361 > TX-packets: 40616 TX-dropped: 0 TX-total: 40616 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= + >=20 > --- > doc/guides/nics/e1000em.rst | 13 +++++++++++++ > doc/guides/nics/features/e1000.ini | 1 + > doc/guides/rel_notes/release_21_11.rst | 4 ++++ > drivers/net/e1000/base/e1000_osdep.h | 2 ++ > drivers/net/e1000/e1000_ethdev.h | 1 + > drivers/net/e1000/meson.build | 6 ------ > 6 files changed, 21 insertions(+), 6 deletions(-) >=20 LGTM, thanks! Acked-by: Haiyue Wang Hi @ Pallavi, What do you think about the patch ? Your one more ACK will be nice. ;-) >=20 > -- > 2.33.0.windows.2