From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1DCEDA0A0A; Wed, 24 Mar 2021 02:52:00 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 96A5340151; Wed, 24 Mar 2021 02:51:59 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 2F7E54014F for ; Wed, 24 Mar 2021 02:51:57 +0100 (CET) IronPort-SDR: lgUMQV+A1F701XUMtR3QJ/DiaEJ8i4w8n2sODn3WsgaBV+a+EKnMqmlYzCL0Ms0w75fgjislQa mWzOUzqz/6AA== X-IronPort-AV: E=McAfee;i="6000,8403,9932"; a="190701372" X-IronPort-AV: E=Sophos;i="5.81,272,1610438400"; d="scan'208";a="190701372" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2021 18:51:56 -0700 IronPort-SDR: SOPS6tnTuN7FpPYLyPy39CKe2kv90yfMI/fgwz4q504rlcOCFCmsOtpzp5RJYWF++k15hPo3lV wOypphsuYSYg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,272,1610438400"; d="scan'208";a="441982088" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga002.fm.intel.com with ESMTP; 23 Mar 2021 18:51:56 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 23 Mar 2021 18:51:56 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 23 Mar 2021 18:51:55 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 23 Mar 2021 18:51:55 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Tue, 23 Mar 2021 18:51:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ezKLxx9sMh8byXLRiAN+7hl6+cz4J7KmfPCAEt9h3wKVW2dzqbabj8WWElCbWXZyx2FK/HOLIRcr9Z+pwqbhDs0H9dquTLhANCm1tBqxdUpLBfOc0jwBo8z1KfTJa3VxuhB6DhxYSDhnYUaQS42K5KPOVxpJTC1p/upmzLDsL+S4Aypyg878ffJOG6nsLixe2UNtA31JHxC75ru5YhLTh3aQdHlFkf07m/1suVxf5TstnWK3oRpBaTAl+mvRR+nDT8DRtm25brZXRqzZmm4WCTaYaIM+V4g+exYAUhRbbnqosyafYRoPyfiQF0004xzDqVKjfKAg3aWpUwzyeBFNWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ASMC1n3qvcmtBNhJgHs0c8pnIhvU1iyb9uDTd3Ha7jc=; b=Y+CjWIgTp7lUveJZv5PeAYI+ssMmihX1I44hlKzUyv/wJDQPbBUELkcj9XSW1FW4krtS7iaWmCjBFbG/PcWeWkO8sgTVDrxSl3EtDC6aN7ouPV/2pV0p2kFFSMzQcauaGyk9gLbSH7m9vUcWozUYSKAGQjr8AzVLfqGbAOYMLnIsdMr1Shkyrbr+eIIl3+r76AdmlT1ynIFGToACfLErWzIhge6dmaMX8Waif1NEmzlOp5iP5qPF6OQfqzdSPlefqKasYskhH8McenCTIntT5919XxrBaSvRo8y4oRu4oCdKRpeKF9uGpcJ6uH4joo2C1/jJuo7VYZCAi5kThO0RFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ASMC1n3qvcmtBNhJgHs0c8pnIhvU1iyb9uDTd3Ha7jc=; b=JNx0YHpU4Ek8pj8XpXk7Sm4nARfOmLHRGgv6NGMmSnWX2wroxkDN6sgSqCUJAJ29CpN3SyVKBlVucLBctTAhnbuP53/dtDDd6nKjkDsrz8IMGGZ7LKQKqgF7z4lii+YTgPsD+6D4DxiSfBi8urIl83vCp7wghftQbyLbb0P6nQY= Received: from DM4PR11MB5534.namprd11.prod.outlook.com (2603:10b6:5:391::22) by DM5PR11MB1385.namprd11.prod.outlook.com (2603:10b6:3:9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.23; Wed, 24 Mar 2021 01:51:51 +0000 Received: from DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::79a3:3404:b907:d49c]) by DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::79a3:3404:b907:d49c%6]) with mapi id 15.20.3955.027; Wed, 24 Mar 2021 01:51:51 +0000 From: "Li, Xiaoyun" To: oulijun , "Yigit, Ferruh" CC: "dev@dpdk.org" , "linuxarm@openeuler.org" Thread-Topic: [PATCH 1/3] app/testpmd: fix forwarding configuration when DCB test Thread-Index: AQHXEall9yCC4yIwfUueExjyOksydKqRWaIQgABhr4CAAMBL0A== Date: Wed, 24 Mar 2021 01:51:51 +0000 Message-ID: References: <1614939741-63927-1-git-send-email-oulijun@huawei.com> <1614939741-63927-2-git-send-email-oulijun@huawei.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.54] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1618f255-a7f3-4f9f-f2c1-08d8ee676529 x-ms-traffictypediagnostic: DM5PR11MB1385: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1227; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Em0lGL8ANfY5aOBSSDpkSmZfHRvvtOZ0nE2/xerXDOjWmSPD2bQO+lumb6i3bZg0lKsC9nZTEktPZPG6R+W3LK5WxcvCnELebTCxN63XFcbU0BF2q2/FIUbiOWaZ+nLu8jPAhMrqOL5gxJzF04cl493CDYFE1zrRfSYQbIoh3+Z8IzAKp3sl5uyGimMix4GxxRAbTNftvO+psLYcx1Kov+EIYE49tVVH2MK0WsHWPbjbioOrn7Ih2FDnCm3Inz9Eu8JNRL4n8foH1+XdM1hJHTZHxIttrbvFV6EPGAw/tQFvIgs60gvVLhkAtPl+NBd/frGAvcxVPi1sxocUgcPnqY0KRFxAcDGaCIMQlz/4XMF/d/Y9i8sJ5CQZOg1tkik6j4EqmFFyl3zvtsBCIeBerlDvHEu6GoJUIr5mGsbTThYZ9mJiNTiv/ObbOwsoep2PZxMpTK4tArtZszivIzSLvCKy2ZipIxffXwOPwaztojQqeUZ3akSCtUM0SlOidD/UZztpjrbs/pcv+CUeTOKngz1aZMcIln9hNfI0gGt2GuvxyztxupSyOnjkh754UU+oXYWLL+qgQHebwHU0JvqrGVdvQ9IFVxJ6zboTwqad5xCn3rvwz0O8/xAeN6B+Pv6ndbQnuvTnL6CBDUUU0/3O2O7TRjazoSXROP2wrEDx3Ts= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5534.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(136003)(396003)(366004)(376002)(39860400002)(76116006)(52536014)(9686003)(66476007)(5660300002)(83380400001)(186003)(71200400001)(54906003)(8676002)(110136005)(6636002)(33656002)(55016002)(7696005)(64756008)(86362001)(53546011)(66446008)(38100700001)(6506007)(66556008)(478600001)(316002)(26005)(4326008)(8936002)(2906002)(66946007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?iso-2022-jp?B?Zk00cEtsM2FaeHNOTmVUdzI2cjdQdk5RbG5XWEtsRnVwR2c2Y2NoZWlT?= =?iso-2022-jp?B?TG9BdzlsZW5VSGtrUE1CV2Z2TEhWR29XSXJEVVh0aVJkSnd1M3pyZ2Fx?= =?iso-2022-jp?B?Wmg0Zk9yWmkxWjZPNlBqbmpuTE9JNWNSTFdFK3N6WDBBNzlDMHZuWXhZ?= =?iso-2022-jp?B?UXl3aUVkanVrdWhjNUpiVDhIZjltZjVVUm1ZeFQ1cjh2WEZETW1icjUv?= =?iso-2022-jp?B?U0FBRGdwc0hkcEROZDNCT1Q3alRid0w4MXNEQ2o2djVydzZXb3VaY21u?= =?iso-2022-jp?B?K3NRVTR4cTZ5UWppZUZUWC9aNEEwOGNKaHVad0thUUoxbEFoTGk1cGRi?= =?iso-2022-jp?B?bXJGcWR5bGt5amwzc200QWVwMzQvb3dPYlhmaGlZVmkzSkc0b1pzSGpD?= =?iso-2022-jp?B?dktPOVV5MHF3YkU4d1d5UGpmMU5DZ1ZYOTIxeTBjN2JTaFpxTzdXaHQ2?= =?iso-2022-jp?B?UUNLanVzZXJxQTlPOW9wbFRGR3d2OWZJY3AzVGxibWlXRzgyT3pJRXMv?= =?iso-2022-jp?B?YVZkNnRVVnBvOXYxVUg5VjMvd2R1QWZuMHl4OU1FdUk5bzk0K0VpNE9w?= =?iso-2022-jp?B?ck5JQ0dGaGZ6cGkvZFFpRVExYWxIbjJBVHNZb0xnYkNaeEdDYU9QaTVk?= =?iso-2022-jp?B?TnNValdGTURmcHRJNEt3d2FSdzdvYVJjN1lqTWR1YmhlRis5QTM5OGtN?= =?iso-2022-jp?B?Z1FzRkp5cVNmQUVISE43QnpDamZYT2R5M05HTVRjSzFWNzRvZWx3OHlS?= =?iso-2022-jp?B?OHVYcVdRTktEdVNJdG1LejA3R2M1VE5CRnpNLzJtM1FWaEJybk44VUdm?= =?iso-2022-jp?B?MjZSS3ErVnZmM3oxb2tiY3dFY0l0UUp5ZFJFYUloQ3l4UEVLUVk1U1BT?= =?iso-2022-jp?B?eXJsVmdLMFNFMUdnRGdaL1krYVZydFhKYzMrTGFGdzB0c1pkM2ZhUlE2?= =?iso-2022-jp?B?cEZkaXZ5RHJvbElxOFg4L0NoMS9hRFpQT2VVcTd0Z1RmQTg3N25pWkNy?= =?iso-2022-jp?B?TGNIdHJieHNzMUxrNVZtZGtyMXgrYnZrZmMyTW9qem1admVxUlNQSjJU?= =?iso-2022-jp?B?K3kzT0pSU1dxSjNRZDFrSXAzUWllc3RhMjErUG9zZEFEWHRWVXlyc01B?= =?iso-2022-jp?B?NEtRVnhVTlNlWGZRS21yRitXNWFCN05EeERIVmNSN3RacU5Mb1ZuV1JD?= =?iso-2022-jp?B?a2xTYmNob3VZNUl5dEhoS2VWK1Z0MFI2MzJMQm8rODdlWWlCYUlIdFV2?= =?iso-2022-jp?B?YmIxUzI1Y3BDSTJ5bHhQM3JYSW9mRnAydjRab3RtQmhIVmdNeFhiTlpW?= =?iso-2022-jp?B?Y3pSazc5YlFpYkZ5UklRY1NQT2VrbkdCZi9GN0ttbGZLYlpmSjUvUWZ6?= =?iso-2022-jp?B?U0VMTHcxVDkyTTd3SVU3RUFJM2FXNk9PT09nbzUwK1NNY1B3UUV5V04v?= =?iso-2022-jp?B?d1pXcjNWZkNtZDRtUUc4R01LQmgrUUdzN2xLaTU1VmtKSTJtMWJnZVZS?= =?iso-2022-jp?B?cXVtR2ZzNEVUTnNvWWM5ZU9vbk5VSEFoOFU2OTVlK0tCcHNBaDEvRTBi?= =?iso-2022-jp?B?bWZvY0hJc0prcE1EejdGZDNXc0dMYTVpY1FnSStuNzFnYnJaY3Y5R3JV?= =?iso-2022-jp?B?VmlBMmRnYTNRRlZlZkdib0k3UEFVSVl4Q3V3Q3kyQnZhVlRjRWR6eGxU?= =?iso-2022-jp?B?bTVNZEF2b2gwazFmQUhoSm5qc1RrT3pnaEZ4aC9yd3FHL0d5d2FxQ3ZJ?= =?iso-2022-jp?B?OXRyWjh1T2hRbkp4ak5SR2lKb1EwNkRtTmgxR24xUWxBZkFqMGVubDkr?= =?iso-2022-jp?B?MlRwNlZqb3ljWEpYZlZQeFlRaFhPRTN6alhiSHFBektqdldtWk1qNWJ0?= =?iso-2022-jp?B?Rnl2dkl5bmJ1MEFGZ090K3MxcmdVPQ==?= Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5534.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1618f255-a7f3-4f9f-f2c1-08d8ee676529 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Mar 2021 01:51:51.8050 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GtdxZpus6Er5bQZS9QH+a+eLemyCXCM+T9ZfqcRSyasfTMLojMAiadUuIrHz9Kauh38f/edBbMpIgawISp68YQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1385 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 1/3] app/testpmd: fix forwarding configuration when DCB test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: oulijun > Sent: Tuesday, March 23, 2021 22:18 > To: Li, Xiaoyun ; Yigit, Ferruh > Cc: dev@dpdk.org; linuxarm@openeuler.org > Subject: Re: [PATCH 1/3] app/testpmd: fix forwarding configuration when D= CB > test >=20 >=20 >=20 > =1B$B:_=1B(B 2021/3/23 16:55, Li, Xiaoyun =1B$B > Hi > > > >> -----Original Message----- > >> From: Lijun Ou > >> Sent: Friday, March 5, 2021 18:22 > >> To: Yigit, Ferruh > >> Cc: Li, Xiaoyun ; dev@dpdk.org; > >> linuxarm@openeuler.org > >> Subject: [PATCH 1/3] app/testpmd: fix forwarding configuration when > >> DCB test > >> > >> From: Huisong Li > >> > > The commit message is too long and redundant. Please simplify it. > > > >> +static uint16_t > >> +get_fwd_port_total_tc_num(void) > >> +{ > >> + struct rte_eth_dcb_info dcb_info; > >> + uint16_t total_tc_num =3D 0; > >> + unsigned int i; > >> + > >> + for (i =3D 0; i < nb_fwd_ports; i++) { > >> + (void)rte_eth_dev_get_dcb_info(fwd_ports_ids[i], &dcb_info); > >> + total_tc_num +=3D dcb_info.nb_tcs; > >> + } > >> + > >> + return total_tc_num; > >> +} > > > > It's only 3 lines. Is it really necessary to make it into a function wh= ich is not > called by anyone else? A comment and the loop are enough. > > > To calculate the total number of TCs on all forwarding ports, we have to = call > rte_eth_dev_get_dcb_info(). However, rte_eth_dev_get_dcb_info() has bee= n > called twice by dcb_fwd_config_setup() to setup dcb forwarding configurat= ion. > The dcb_fwd_config_setup() might be more readable if encapsulated, I thin= k. In > addition, variables in "cur_fwd_config" > are initialized more centrally. What do you think? I'm not familiar with dcb. Why does the rxp_dcb_info get from fwd_ports_ids= [0] and txp_dcb_info get from fwd_ports_ids[1]? Is this a have-to-be? Can it be both from port 0 or last port? If it can be port 0 or last port, you can just store the last dcb_info afte= r your loop (loop from 0, i++ or loop from last i--). > >> + > >> -- > >> 2.7.4 > > > > . > >