From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 71C0EA0548; Tue, 17 Aug 2021 03:54:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C17A40143; Tue, 17 Aug 2021 03:54:28 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 7910D40142; Tue, 17 Aug 2021 03:54:25 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10078"; a="195562015" X-IronPort-AV: E=Sophos;i="5.84,327,1620716400"; d="scan'208";a="195562015" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Aug 2021 18:54:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,327,1620716400"; d="scan'208";a="640723925" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga005.jf.intel.com with ESMTP; 16 Aug 2021 18:54:23 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 16 Aug 2021 18:54:23 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 16 Aug 2021 18:54:23 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Mon, 16 Aug 2021 18:54:23 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.173) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Mon, 16 Aug 2021 18:54:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HdPjStlFYHeAwJ7Kz20XuqU8OKEkrSMiywFsUKInAvDtu0z5Z1VlTMgxuli6ed7xnVjgrcGPc+R9RfnEFswZQXlms50QAhBS/3II87sWb7us45qfxSTV1NX7KbRtPMWyTTQTdoBBWebJVobTdFEVoTvZR62wQlohHQGKzVasNcH8CB7TWF4t5F3S8sTcLvCeud3dytFPmbGPeL7iwBgbFjNCyG9mlTtNkok3zlYJf6/3KYAg8wBt9vxJGFYtYL/FJ/nc3NTj+fShQP3H5xH982lTWrjAKThvYffcSZcTn21tJJjyCNXCMZdDYTC59dtaA8OXacdkfUN5maai8T16xQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ceTJau4+LYrXBJoADq1EFODUO5bXiQekDtYAK6PfdsI=; b=FpjaW1b5Gwfo9Bp08dbW0weQA8aWL6rFcfY1tyBRIap76r8W8wZT+wQm859F3kvn+y+Q5gxaGtW3tTvY5wpZowbhsE3hZHElUTV2IOGOdZrw1nHmxD49XdOqbyLQXwWZvmOrsMCN6kOWaUj+Qc0ugUk0oTg6VNAMxARV8/ZfOv+6HhBDwI51aNh9oBkS5mmsPy2jIuhSCfxAKZxyD729qHD4m4C0tTvqIpExdOm1qRUw+2AqJKF8VIn71cS3q7W/2JCaMqVLSwODwk9gAf0BC97PQwy6/KwfMHzsBNxzvjnh/voZFxSKWUbr6iCrkUKy2jGEnNlWi1iyp3s31P3wLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ceTJau4+LYrXBJoADq1EFODUO5bXiQekDtYAK6PfdsI=; b=oEIm6rqStjonvko+NPkHCNvRMLeF0DMVtYkLVdVlnes4zN9EFbnDDU2SWEsUkXPMA8PGqQnOaDcdXswZDTFkShJ90Nw38ln9GyRSYpzTytnyOecek5sviyGYykXm1MhFf92XMLCWU42dI8Iyo2awPjAHkxNB0ZRZ8jUwVvGeVmo= Received: from DM4PR11MB5534.namprd11.prod.outlook.com (2603:10b6:5:391::22) by DM6PR11MB2761.namprd11.prod.outlook.com (2603:10b6:5:c0::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.17; Tue, 17 Aug 2021 01:54:22 +0000 Received: from DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::d019:aaeb:94c0:1c45]) by DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::d019:aaeb:94c0:1c45%8]) with mapi id 15.20.4415.017; Tue, 17 Aug 2021 01:54:22 +0000 From: "Li, Xiaoyun" To: Nithin Dabilpuram CC: "jerinj@marvell.com" , "dev@dpdk.org" , "rasland@mellanox.com" , "stable@dpdk.org" Thread-Topic: [PATCH 2/2] app/testpmd: fix verbose mode dump for Tx Thread-Index: AQHXkm3ha09mVXSFaUiUocVW6kKttqt28JSA Date: Tue, 17 Aug 2021 01:54:22 +0000 Message-ID: References: <20210816070943.26807-1-ndabilpuram@marvell.com> <20210816070943.26807-2-ndabilpuram@marvell.com> In-Reply-To: <20210816070943.26807-2-ndabilpuram@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6ca031fe-ad46-4f19-743d-08d96121ef11 x-ms-traffictypediagnostic: DM6PR11MB2761: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:261; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: e0tAo18LCGQxP6RdZOCbi/8UOOUeG5pXUddC3SoUwn88Jz1aY0zNe/bqMLqGuP51t+FXMz/ITnxE5CnQXWRjncg1PyozxBm5PbYe5BOwtuWiYTHp/cMrBRJjvIb+urYixu/21Jhuzq1HmrP+iOIZFtWFS488FHXtWth0N+ujyZflpxaTfgQEN/4nAUQRJPdxbsHxUUNf3//m71NIEIeKi5Q9ojXo++eSdYLCXjpsSElpuZah21xEFWUXSRAFWs1FRGsw7CeuVXTa/aHJl0s9vVl4oZjaPGcjR1m2kJZGIBz4/Ril+U+X6xbB3ta6DtgnDLwZvJpXz/ZJCJCfJDyTUgHAs5D+XRbosKzkpr3+HeCGaew8NtSuVyNcX0nu+/FOoa6a/zH95AlFOwCvNOeamYxiSi7mHAZkDz5oWNxc8/qbGUFYk8qXdclq/JgPr5KafN8k1z4k4rL/U8kOQBtukgXt2I0dFxzn0lnjCA4QRxf1qLmTbIS/Y2BSV+wIAkNl8WsCxlIBIucw3akyKN3pVQ92CzBqAqK6ANZWtRCjggJ+saRaiZJIZgTtmXT49GkSjNBEtLKeXJBAEQp4/d4dkqtKBmvYk+M9+G+wl47ngbU9/5PrP2lCvF4sOkUuw6rRB4YZoD9Dkdh77YsZpRWqDk5GUqH/atFqAJbDcIBvNyEIxGgWzSy8Na0qW72KrSCy5lAjc02Qop4lLe16w1ioWw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5534.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(376002)(39860400002)(136003)(346002)(366004)(52536014)(6506007)(2906002)(9686003)(86362001)(7696005)(55016002)(54906003)(66946007)(53546011)(26005)(6916009)(5660300002)(66446008)(64756008)(66556008)(66476007)(316002)(478600001)(71200400001)(38100700002)(4326008)(186003)(122000001)(76116006)(33656002)(83380400001)(8936002)(38070700005)(8676002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VyE943u/DBJsFVYVjnGZeXDsXLVXBk2GCrBmqRahBmAcaz4fvMsK5SeXn/Ic?= =?us-ascii?Q?1ALlcmygO3PMsG6jl0jr3RS4ELdEJV+CN5PS5nyctPgRIa3lPkKf53IUf/v8?= =?us-ascii?Q?8jLG+JGHALHk0jyrJDCvGA06M9hmZkcAyoyJrbdAK/l+7Ep/688DNVZ6LblP?= =?us-ascii?Q?J1QsJwrZULpPK4w1MF0Vk7LhpjCatsFFSHAib5yuvMnA6NBWua9iwGZ80RdO?= =?us-ascii?Q?cifwh6LqkUHLfifNIo2uAytL0JfMi+u6YzQuXxKr9DaXs1ODc6/0dGwJ3hlZ?= =?us-ascii?Q?BDc1ZKGM0rsj53AeFP0gaZajJtWH24702QdcGDUpLvVl8t/1hfsappHm4azO?= =?us-ascii?Q?+t1VfmZfBTm8/yUcVptG6Ygg+xWk4AM6agM20OnGpr/lAAG1431xtCOuJQAo?= =?us-ascii?Q?Lo5S0VXU09AzXNZFRch7oCf8Wx5XF7edeHkb3ODdPXC5X+wQlqXVkUbSKdza?= =?us-ascii?Q?/jvmgXqXYU7KYNw3RoL2zj31pMdk7gjM3IFKB7c4N1LjLbl+qzOU1+paZ3jL?= =?us-ascii?Q?xwQNRTCzkTUTPVF0ptJAAXRrFj4Jxc4UAnONF207kBoDLi8Oics3+LKInGMN?= =?us-ascii?Q?wkTZt0o5CWHJDCGt1ob696FCzgVdn0u+VMe45+01a7SbWFy6x1eom3ej5Cbg?= =?us-ascii?Q?GWKdZHho0Mf3SKh5/yOqfJ+mHS/4ylf05amaZ+AxWfQTcJ+GycQ/XwmzX0hx?= =?us-ascii?Q?7VLupeJQYodwmQtbGFOuGZIuhoALaSllZw3XFWF1sWf1ZNFxwxklklayr+ay?= =?us-ascii?Q?jXfaak3kvus86UuYau86CEn8JhoESMS1iv1YKvNogw3dK1tjeRjdX6onoGoe?= =?us-ascii?Q?N9FiICesFEy9/hbBChAZgoJXmsFXR/ezPjpYZiNouPceOALXEKrdjBRMQxih?= =?us-ascii?Q?EhGXD7mVFyEvoA0SorukKHqV1qJt2wUXczyHFEMfrQEkMxQXC41LXn0MIfPp?= =?us-ascii?Q?iKDt9oPPgxAj1U6pkRa0k4uGGqKk88fS9pfzlJphSOH2yf62NGXO8L3hxMCR?= =?us-ascii?Q?yE1jF2UWzc/PKjAtu22ViD9M7k7U5ywoD1JyMZEFbdZQZ7Nm3k6gXnmc91b6?= =?us-ascii?Q?YccfG2QihFsvoZuZ8UxoSQyra27XWBFxCxUtvMGoM3Kue+n+vh6tu3NffU0X?= =?us-ascii?Q?d+6y/FPQhFyTppAtifYPfrN4piPt+YHSsABVFyLJKjqFOJcjyO9/XVtX8RdY?= =?us-ascii?Q?/ajeLokK5JlbKjczYCoDY2CNWmH9HFvCVnLsE2WIzAgDUh27CPEugJ93T4CU?= =?us-ascii?Q?8USL5gqQMPjRkDZPtrxJfjgQG5qzAkpRAnXR1WFxUEJ56CgKeTkaBXrH6XFq?= =?us-ascii?Q?63k=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5534.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ca031fe-ad46-4f19-743d-08d96121ef11 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Aug 2021 01:54:22.1094 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eTZt9VWI7lTz9Yi1tEvna6w1UaFpzOGhx0X+XlmJCaG9WEzRxJNoIjONInv96VybtW2Twe7A9+SjfFa/4MhTqQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2761 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 2/2] app/testpmd: fix verbose mode dump for Tx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Nithin Dabilpuram > Sent: Monday, August 16, 2021 15:10 > To: Li, Xiaoyun > Cc: jerinj@marvell.com; dev@dpdk.org; Nithin Dabilpuram > ; rasland@mellanox.com; stable@dpdk.org > Subject: [PATCH 2/2] app/testpmd: fix verbose mode dump for Tx >=20 > Fix verbose mode dump for Tx to dump tx offload flags instead of Rx offlo= ad > flags. >=20 > Fixes: d862c45b5955 ("app/testpmd: move dumping packets to a separate > function") > Cc: rasland@mellanox.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Nithin Dabilpuram > --- > app/test-pmd/util.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) >=20 > diff --git a/app/test-pmd/util.c b/app/test-pmd/util.c index 5dd7157..14a= 9a25 > 100644 > --- a/app/test-pmd/util.c > +++ b/app/test-pmd/util.c > @@ -275,7 +275,11 @@ dump_pkt_burst(uint16_t port_id, uint16_t queue, > struct rte_mbuf *pkts[], > " - %s queue=3D0x%x", is_rx ? "Receive" : "Send", > (unsigned int) queue); > MKDUMPSTR(print_buf, buf_size, cur_len, "\n"); > - rte_get_rx_ol_flag_list(mb->ol_flags, buf, sizeof(buf)); > + if (is_rx) > + rte_get_rx_ol_flag_list(mb->ol_flags, buf, sizeof(buf)); > + else > + rte_get_tx_ol_flag_list(mb->ol_flags, buf, sizeof(buf)); > + > MKDUMPSTR(print_buf, buf_size, cur_len, > " ol_flags: %s\n", buf); > if (rte_mbuf_check(mb, 1, &reason) < 0) > -- > 2.8.4 Acked-by: Xiaoyun Li