From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2E32A00BE; Tue, 14 Jun 2022 10:23:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A33404068E; Tue, 14 Jun 2022 10:23:46 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 854764067C for ; Tue, 14 Jun 2022 10:23:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655195024; x=1686731024; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=/3stgKrWf/JFK1TxPjpAWnt2VBQngE5yzuXWnEXcqlw=; b=WGt8GxH6+oTejF779+/hvzwJKvDnk/7/vLULxnHh7LYqxshXIdMiJFJQ f4QkwiTHhP9brL7zb0WakZ6nGotir/5yzfqPiylFU/GuMe3d9G1Jugpwe WQChhCvbt+NZSiADJL0ERhccz1ERpN0gb1oHWHQHBqzfXmE+itu3MKsrS zpaLsmS55P4vMtcBmYiKOwx2mYI4z4cuagKxkG0MhNYhlpfGA+swi2ZfE k9T2wbrcdoZIg4b04ZAFv5yMJYbZMGQKmyKCjyTlgCHxnbaNLrj9T/lFI ioaAgW6LteEXdOfJ2QeVS0hphwG+ij/3v2yln0ghlrm3Yf8RI3k0aTQN6 Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10377"; a="303955974" X-IronPort-AV: E=Sophos;i="5.91,299,1647327600"; d="scan'208";a="303955974" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jun 2022 01:23:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,299,1647327600"; d="scan'208";a="761875055" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga005.jf.intel.com with ESMTP; 14 Jun 2022 01:23:43 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 14 Jun 2022 01:23:42 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 14 Jun 2022 01:23:42 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 14 Jun 2022 01:23:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j6Znjq0Rpq5HQHYCPr4Eo6DdmXCHT/hkrFnZMZ1mfnlqufz02FjhGQJX0moJBdmI5o9BTPONubEpIqzEmkahcRqzmKxRkz6BUS5rEBlSzteD31Eww5eX8Z7g20KtHszwZoO75X9DmKu80/A4xOolVFZgXPNVdFFjD7eeROx1Yi2DV4NGnaRGyCrnco888Vfcu1qq+LaPyirXCNFtIRs+rv98ufodhnwP3RTpea5lpQ4WgmdORdXSKewDuboZS2dqiMJpd/k4SGKgajRGL1SPVIcwoF0j1MJ4CbfRrdXem39O3IUIsWxFsg2VK3xt6jD4KQ+CR2QR0+JoaZzDGoXIuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gstcwcnGrVIqJ2b5Jy5cVN5jxrIBAS97jcugTC9bfUc=; b=MAVjqeGpu1uCwqcOd74fiXd1rV3XcGIy/m1Wg7jWEpPjvSCjM5g+bTqDzb8+4/n67HK7Ds6nLSgVdc15A4bhwp1ltf3ecVHaDHxv7/hVHF6EFvOgTLVTe1SnU5u8NaEJ+57+EusIfE+Y4QDBl/mrCpkgngaykgmpZ581jXVeVSp6YthhWD6D1rd6hIR0Bj6J/nbQo/SDWbS+w9Awt4Nw+Gti150TQn/K8Wd5txlJiWfKZCOcyHjhemT/jBSLo+U/MB6hwGWHUvLR+mCJ6E3zFQkPLD+Mue0imVvLLPOUOyQsmMtq02Ve6gUcA5NpCXbZr4k7WFpoSvoTR5lea2udeg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5534.namprd11.prod.outlook.com (2603:10b6:5:391::22) by SN6PR11MB2576.namprd11.prod.outlook.com (2603:10b6:805:5b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.13; Tue, 14 Jun 2022 08:23:40 +0000 Received: from DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::1c95:2989:c188:c142]) by DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::1c95:2989:c188:c142%8]) with mapi id 15.20.5332.022; Tue, 14 Jun 2022 08:23:40 +0000 From: "Li, Xiaoyun" To: "Zhang, Qi Z" , "Loftus, Ciara" , "dev@dpdk.org" Subject: RE: [PATCH] net/af_xdp: allow using copy mode in XSK Thread-Topic: [PATCH] net/af_xdp: allow using copy mode in XSK Thread-Index: AQHYfznTsDPw7kQ6uE2gRJ89hjEHzK1N/uGAgACSVPA= Date: Tue, 14 Jun 2022 08:23:40 +0000 Message-ID: References: <20220613151231.1359592-1-xiaoyun.li@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 358adf3a-4fad-4fe2-9d53-08da4ddf3041 x-ms-traffictypediagnostic: SN6PR11MB2576:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HpEVDSreRhapMpNBT5fOzOpv5U4mrFZ+WXuGmDAcx6yzzFSrW+bOttV2XRZyxZpGhoSFpkwoxNtMIqy+01SIyFJxTqngvnmm3NajBEBMkvtW7O4lvSUA72TKwEIQ/CFUfPn0jZOgWx/fuHmwG1uTCLvMhTANbH+C4kdDfX56w9QO+QXFSPyVdeBag4DaW9hiYDOLMDkxrxxaCiOf0UvYVbdfqiT/f5QKK4FOf97hcEMl9VkZ8NzziESX2t4Ee8a2sIHESfz01/nWvjCDPAqFcWJCg6J7Lgo0H+SyHgsuBi2EJzGVdH3vHSKC3Lq1WpxqNkpF1+dGiPxFUIi9+jHt9QJftMaFJBiPfFzKytm7XgJQVcNXbFz5ZvN/Ehe8bcUrYxhBRzdLuagnhdz3T/04KHDFPWKJzLStqzqk28R/Uqvc/GjSYFR0Hg9RXghdEeDE8wOuzigRD36C/t4v+u7aN/7pmNHcuTv6ODLz076raynz2j1YsVSRKaE5yXA8/DHkd4n/yLnc7m6pZL+RKUx0jjRAcV+AELplb4knTrJlj79NLfcjSJ0xzediHUYhpwQ5vCHyH4gjlksBSGmzF8Y+JDvmdIejvo9vgov06RR8HsVeaYNoLTDH0waPP1ZlrEm4TJnhToAv90FQnASHAQuDtU8y4iFgmnk1kxP+nyIud0ucIVmEzh8nhvOiNGocNTYsAdsM/WReyNH0AKwF7EnMIA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5534.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(76116006)(316002)(5660300002)(66556008)(64756008)(66946007)(66476007)(8676002)(8936002)(33656002)(122000001)(4744005)(82960400001)(86362001)(66446008)(7696005)(9686003)(508600001)(6506007)(52536014)(53546011)(71200400001)(26005)(110136005)(38100700002)(2906002)(83380400001)(55016003)(186003)(38070700005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WWv0hEz9zIJC1pJ62EPG/PgRZPpx/9NU4C1nAhLL4YX3TYfx5Yoh8l7GHHMm?= =?us-ascii?Q?o5ftkfaQAmM5qqx9tQoZA1dT09YNNtBGUflbOyM0yslGP+WyblXi1KUPFr2T?= =?us-ascii?Q?WBBLTWfNaDjZd2uvAgLPoPSnumJqbCBXivv6NJhlhVHUt4xL7IQ4avxHWgrj?= =?us-ascii?Q?wefglJjkAh43d8An4ClvqgpV7PVB4xP+LVtkCPQ/1SdRKWyP98KxC+It1TuH?= =?us-ascii?Q?kmC4ZRIvlMv6aco8AH8GRukoOpdTfq0donSJVAuJvIwxlx3jtDRcqaXu9/bE?= =?us-ascii?Q?VXCjdxnwQs0Hnmx7XQcGZCBwO1EgUT7iOmK0HQAiUfQtLDE4UDYYq/idk2Rd?= =?us-ascii?Q?PouwOaAVc/eoAn71JCpNdSDecUesr5c0ripOhdQrHkitcZamM/io3rNcPzZX?= =?us-ascii?Q?NN/Ne7GwoVNqMI9g7gaygCQRc6SaGViFwbgjPM6dzcolhcUBy/vNYdIOwmrR?= =?us-ascii?Q?Z+IdcYzV8sK2tKWUUmokyJmTOlMYrvVbkyTEylBWL2TqOe/9oJcAAujtvuQk?= =?us-ascii?Q?DmFoRFKSsaardWzkQKw32dkqTSvtOpZmFJIGp9cSa0Csij/n0hsuurDgVuuh?= =?us-ascii?Q?oW5PK5nmGQmX1ecQCTO3uoMt8ywlfbFcyKz5qJM7EIfUbZ4qGsf4+9bYgGWr?= =?us-ascii?Q?2+8XyGBzo+UVDka2XSR/MEeEa6ASNrG3XTpiDe2AJLnTHdbHCJjSbGRqBILA?= =?us-ascii?Q?BmyytjjlYeag8GAiZIo3TtfpX5bMvRqtI53SQM7+3niiWuHNl27O9/hUUF7p?= =?us-ascii?Q?P/w3JVilb0hGgXQDT88Hwbfz8SCMfgmlSytTBPab3LO9QF+rbudPgELxjIce?= =?us-ascii?Q?2i82QvHplkJnEFMB0izmvyQxzfefIqu7oIBmMg7dbv5Ob/ivcFqsbhkH3FG9?= =?us-ascii?Q?rw97XyXYk20cAgqLZD1B05pCaEIh1gwFA5YIKIfdgvsXeMn7/TpFHO5OOgJy?= =?us-ascii?Q?gawU1LVtI8NxUbUmGEvs6uDZ5dFkyZ78tf+FF9LJr2FNn4FdBCC3Qak0qxKg?= =?us-ascii?Q?Yhp2AjIeZsgyqN5ZThvkg9rJpuOMK9uNJHr8HkJLxm3RkhAPnWnrumZUIyQF?= =?us-ascii?Q?+6aWjgmDv5yYOwTlQcmttTR9YTdKNqHb0ujKdyqZF6hO57r7QWa3ptMyMsTH?= =?us-ascii?Q?VU3QswFpqgZY/RZcBviNT3JqjSWTGBroBFFc96dwTmqEN2REEFJ5OpwuhcMf?= =?us-ascii?Q?Gr5eadTKKSEmmZD2t+D/bw2IKCOEa+dDI9D2Ov9md0TMiH1Kkm7hRgwQn/kc?= =?us-ascii?Q?+XMJw46V51A0F+2k6bmkJ9ALHcWh9y0u0dQdNvnxIDuvlZNStTogcjfCW0lH?= =?us-ascii?Q?rKBHIlUNSwPmAL99W1Ps2YHGT6sm6OlLCKkmAqfbyf64xxrClUdM+hp/3KCH?= =?us-ascii?Q?pmZsjC85vqgsa7YVkn64GD+8wMpGQxzoubfqvAlSDtKHN3HfPeXkYlFeaoEt?= =?us-ascii?Q?Gj5z1s9eJ9QhBd8Bn9dybJejBnvkDqDAIZqMyFKRNVXENJdYjNBYklGwXN3Z?= =?us-ascii?Q?xWzzVW5Kmd9ncN69/4d4kQ6ygsRXdvyQWeoG6HEfktn157jODm2nva+8pEwH?= =?us-ascii?Q?PR5+bLFWUz7KX56aCHozUAh3qeiSx4fNGW1Sylty4+CLjBq94KUZsE9Ooxey?= =?us-ascii?Q?WxdHReKslLdPRDqsnXDMksVvV4X0+4ihjQdRKpNN/dbKUQBWMoHiNp89GAy5?= =?us-ascii?Q?K7vJW9vldQBR7pWcGcPcC0DFyxT7kxxX/s8ILay5CEHpHs/VrbAnR2siEOL2?= =?us-ascii?Q?kaY3gGKGPg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5534.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 358adf3a-4fad-4fe2-9d53-08da4ddf3041 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jun 2022 08:23:40.8842 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: E1azUoWR7oqeJZWQfYT6hIYvFVRHiQ6aAoo/EFg8ARNPMV08MLodesHoWqNBT4BGGdQIWGPt2kTmWzkSL3kFpg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2576 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi > -----Original Message----- > From: Zhang, Qi Z > Sent: Tuesday, June 14, 2022 00:38 > To: Li, Xiaoyun ; Loftus, Ciara > ; dev@dpdk.org > Subject: RE: [PATCH] net/af_xdp: allow using copy mode in XSK >=20 >=20 >=20 > > -----Original Message----- > > From: Li, Xiaoyun > > Sent: Monday, June 13, 2022 11:13 PM > > To: Loftus, Ciara ; Zhang, Qi Z > > ; dev@dpdk.org > > Cc: Li, Xiaoyun > > Subject: [PATCH] net/af_xdp: allow using copy mode in XSK > > > > DPDK assumes that users only want AF_XDP socket (XSK) into zero copy > > mode when the kernel supports it. However, sometimes kernel driver > > doesn't support it well and copy mode is more stable and preferred. >=20 > rename "no_zerocopy" to "force_copy" looks better? >=20 > This aligned with the comment on the macro definition in kernel >=20 > #define XDP_COPY (1 << 1) /* Force copy-mode */ >=20 > And also make the below code more smooth. >=20 > if (internals->force_copy) > cfg.bind_flags |=3D XDP_COPY; Sounds good. Thanks. Will do in the next version. >=20 >=20