DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v1] app/testpmd: fix port MAC address after resetting port
@ 2021-07-14  2:20 Yuying Zhang
  2021-07-14 11:43 ` Singh, Aman Deep
  2021-07-15  2:15 ` Li, Xiaoyun
  0 siblings, 2 replies; 4+ messages in thread
From: Yuying Zhang @ 2021-07-14  2:20 UTC (permalink / raw)
  To: dev, xiaoyun.li, qi.z.zhang; +Cc: Yuying Zhang, stable

MAC address of each port in global variable ports hasn't been updated
after resetting. It was the initial one after resetting VF MAC address.
This patch gets correct port MAC address when starting port.

Fixes: a5279d25616d ("app/testpmd: check status of getting MAC address")
Cc: stable@dpdk.org

Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
---
 app/test-pmd/testpmd.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 1cdd3cdd12..204e0d52cd 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -2456,7 +2456,6 @@ start_port(portid_t pid)
 	int peer_pi;
 	queueid_t qi;
 	struct rte_port *port;
-	struct rte_ether_addr mac_addr;
 	struct rte_eth_hairpin_cap cap;
 
 	if (port_id_is_invalid(pid, ENABLED_WARN))
@@ -2627,11 +2626,14 @@ start_port(portid_t pid)
 			RTE_PORT_HANDLING, RTE_PORT_STARTED) == 0)
 			printf("Port %d can not be set into started\n", pi);
 
-		if (eth_macaddr_get_print_err(pi, &mac_addr) == 0)
+		if (eth_macaddr_get_print_err(pi, &port->eth_addr) == 0)
 			printf("Port %d: %02X:%02X:%02X:%02X:%02X:%02X\n", pi,
-				mac_addr.addr_bytes[0], mac_addr.addr_bytes[1],
-				mac_addr.addr_bytes[2], mac_addr.addr_bytes[3],
-				mac_addr.addr_bytes[4], mac_addr.addr_bytes[5]);
+				port->eth_addr.addr_bytes[0],
+				port->eth_addr.addr_bytes[1],
+				port->eth_addr.addr_bytes[2],
+				port->eth_addr.addr_bytes[3],
+				port->eth_addr.addr_bytes[4],
+				port->eth_addr.addr_bytes[5]);
 
 		/* at least one port started, need checking link status */
 		need_check_link_status = 1;
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH v1] app/testpmd: fix port MAC address after resetting port
  2021-07-14  2:20 [dpdk-dev] [PATCH v1] app/testpmd: fix port MAC address after resetting port Yuying Zhang
@ 2021-07-14 11:43 ` Singh, Aman Deep
  2021-07-15  2:15 ` Li, Xiaoyun
  1 sibling, 0 replies; 4+ messages in thread
From: Singh, Aman Deep @ 2021-07-14 11:43 UTC (permalink / raw)
  To: Yuying Zhang, dev, xiaoyun.li, qi.z.zhang; +Cc: stable

Hi Yuying,

On 7/14/2021 7:50 AM, Yuying Zhang wrote:
> MAC address of each port in global variable ports hasn't been updated
> after resetting. It was the initial one after resetting VF MAC address.
> This patch gets correct port MAC address when starting port.
>
> Fixes: a5279d25616d ("app/testpmd: check status of getting MAC address")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
> ---
>   app/test-pmd/testpmd.c | 12 +++++++-----
>   1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index 1cdd3cdd12..204e0d52cd 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -2456,7 +2456,6 @@ start_port(portid_t pid)
>   	int peer_pi;
>   	queueid_t qi;
>   	struct rte_port *port;
> -	struct rte_ether_addr mac_addr;
>   	struct rte_eth_hairpin_cap cap;
>   
>   	if (port_id_is_invalid(pid, ENABLED_WARN))
> @@ -2627,11 +2626,14 @@ start_port(portid_t pid)
>   			RTE_PORT_HANDLING, RTE_PORT_STARTED) == 0)
>   			printf("Port %d can not be set into started\n", pi);
>   
> -		if (eth_macaddr_get_print_err(pi, &mac_addr) == 0)
> +		if (eth_macaddr_get_print_err(pi, &port->eth_addr) == 0)
>   			printf("Port %d: %02X:%02X:%02X:%02X:%02X:%02X\n", pi,
> -				mac_addr.addr_bytes[0], mac_addr.addr_bytes[1],
> -				mac_addr.addr_bytes[2], mac_addr.addr_bytes[3],
> -				mac_addr.addr_bytes[4], mac_addr.addr_bytes[5]);
> +				port->eth_addr.addr_bytes[0],
> +				port->eth_addr.addr_bytes[1],
> +				port->eth_addr.addr_bytes[2],
> +				port->eth_addr.addr_bytes[3],
> +				port->eth_addr.addr_bytes[4],
> +				port->eth_addr.addr_bytes[5]);
>   
>   		/* at least one port started, need checking link status */
>   		need_check_link_status = 1;

Acked-by: Aman Deep Singh <aman.deep.singh@intel.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH v1] app/testpmd: fix port MAC address after resetting port
  2021-07-14  2:20 [dpdk-dev] [PATCH v1] app/testpmd: fix port MAC address after resetting port Yuying Zhang
  2021-07-14 11:43 ` Singh, Aman Deep
@ 2021-07-15  2:15 ` Li, Xiaoyun
  2021-07-24 11:29   ` Thomas Monjalon
  1 sibling, 1 reply; 4+ messages in thread
From: Li, Xiaoyun @ 2021-07-15  2:15 UTC (permalink / raw)
  To: Zhang, Yuying, dev, Zhang, Qi Z; +Cc: stable

> -----Original Message-----
> From: Zhang, Yuying <yuying.zhang@intel.com>
> Sent: Wednesday, July 14, 2021 10:20
> To: dev@dpdk.org; Li, Xiaoyun <xiaoyun.li@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Cc: Zhang, Yuying <yuying.zhang@intel.com>; stable@dpdk.org
> Subject: [PATCH v1] app/testpmd: fix port MAC address after resetting port
> 
> MAC address of each port in global variable ports hasn't been updated after
> resetting. It was the initial one after resetting VF MAC address.
> This patch gets correct port MAC address when starting port.
> 
> Fixes: a5279d25616d ("app/testpmd: check status of getting MAC address")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
> ---
>  app/test-pmd/testpmd.c | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH v1] app/testpmd: fix port MAC address after resetting port
  2021-07-15  2:15 ` Li, Xiaoyun
@ 2021-07-24 11:29   ` Thomas Monjalon
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2021-07-24 11:29 UTC (permalink / raw)
  To: Zhang, Yuying
  Cc: dev, Zhang, Qi Z, stable, Li, Xiaoyun, andrew.rybchenko, ferruh.yigit

> > MAC address of each port in global variable ports hasn't been updated after
> > resetting. It was the initial one after resetting VF MAC address.
> > This patch gets correct port MAC address when starting port.
> > 
> > Fixes: a5279d25616d ("app/testpmd: check status of getting MAC address")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
> 
> Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>

Applied, thanks



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-07-24 11:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-14  2:20 [dpdk-dev] [PATCH v1] app/testpmd: fix port MAC address after resetting port Yuying Zhang
2021-07-14 11:43 ` Singh, Aman Deep
2021-07-15  2:15 ` Li, Xiaoyun
2021-07-24 11:29   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).