From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E8C7A034F; Tue, 23 Mar 2021 04:17:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 23A96140DEB; Tue, 23 Mar 2021 04:17:36 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id D02174067E for ; Tue, 23 Mar 2021 04:17:34 +0100 (CET) IronPort-SDR: y8Eg89wRzqGql0mg8Es8CqYL4yDnD/gPQ3zQkE4TruoxHEtnh1qjMYOqz5qF6AWJNFwKMce/X3 MBDRc6+qqb9A== X-IronPort-AV: E=McAfee;i="6000,8403,9931"; a="170357186" X-IronPort-AV: E=Sophos;i="5.81,270,1610438400"; d="scan'208";a="170357186" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2021 20:17:33 -0700 IronPort-SDR: I7YHZXTFy/txOlvF62vZMTLfQmtqZd5blkluKjci5WVUGRSuX93h+F2tb1JaNn6t/FDymZctbZ LnZF0IEVEVJg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,270,1610438400"; d="scan'208";a="441466315" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga002.fm.intel.com with ESMTP; 22 Mar 2021 20:17:33 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 22 Mar 2021 20:17:33 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 22 Mar 2021 20:17:33 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Mon, 22 Mar 2021 20:17:33 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.170) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Mon, 22 Mar 2021 20:17:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EX37+syIArbFUvPeH+e9ZylDkfBBWlscNwvcqdVmIFc7nADnuZZZbftDRbtwnDm4kenixnLW19/5T+yT4P7tzJZ6vAZcIrKCeMEpAHaLtRx11bBTZHVdOmmFR7NOJk20Zo1yDnKs95mLUNDTfic+ZUXYlaQdpHKosnJlNvv+GI+piMbc+hepnn7RAXHeJkR6k9RGC5G6cpp0D6l+GJWourxYOBgTqotSZ5/aoPVBSTppBaDpwYMYodvUyS/ApyRq8U8KwQcNglWFGXU23NkKsUDrdOA00mdwZqRpg0ZkyRQdYv0DuxTImmdQaSAoyPw3q9fUgdXczf+r7svSzOJnBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WLhiSjTZ+9evjM4VnC2vRv9/AP2cYhfKvWE+5fWkHMg=; b=MGa7C2Y1OwK6lQltu+qgIMlbBgme3sQFh2w0r7DjqVh9DbKaVIrFrORQG+VdoGLFJt0Ys5A4apGt9LkG4hOw4uQ63PlxbAQtIIC7eWAnOTDWhRAT+M59eTX8ebDjsXXOrN4lwv8O0HRhrvQf/gz+hqOrAEozuxjFCrc0JEhPH+bPaPP4rib+DTIGXsJyJ3TMEQdYrqJHl51l8PC0vD3HCBCvfkFu+OyazuCDNCEsQjwz0UnzW/MV889QQkGmVieMHMlINytcXJ3Q2aItvOTMbUBkD5jDMQ8RW0ujo8GRbT2+4Z57BA9XcPXWm8UUjZa0UakBTtAzScvY2wgDNK6Rvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WLhiSjTZ+9evjM4VnC2vRv9/AP2cYhfKvWE+5fWkHMg=; b=xlQWtMlurGHs2h5cWbxRNvaWtVQqdPhj0Urlj5K4kdQWrKGzmP/9xpLzJpfbAQ7Pr11Ta/yRFNwxAbQ/FCoXrKInBWBlexQrxGWYPklYP425zH3YJycmHBrr77w4y3FW3sjF/7k+mBtD1LTLajBqKsXg414enBORMo/XSbE2laA= Received: from DM4PR11MB5534.namprd11.prod.outlook.com (2603:10b6:5:391::22) by DM4PR11MB5533.namprd11.prod.outlook.com (2603:10b6:5:38a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Tue, 23 Mar 2021 03:17:30 +0000 Received: from DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::79a3:3404:b907:d49c]) by DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::79a3:3404:b907:d49c%6]) with mapi id 15.20.3955.027; Tue, 23 Mar 2021 03:17:30 +0000 From: "Li, Xiaoyun" To: "Li, Xiaoyun" , Lijun Ou , "Yigit, Ferruh" , "Tu, Lijuan" CC: "dev@dpdk.org" , "linuxarm@openeuler.org" Thread-Topic: [PATCH 3/3] app/testpmd: use of Rx/Tx in testpmd Thread-Index: AQHXEalhyPNaw+FTrkm6DlQ28b24kaqQ5o0QgAAbaAA= Date: Tue, 23 Mar 2021 03:17:30 +0000 Message-ID: References: <1614939741-63927-1-git-send-email-oulijun@huawei.com> <1614939741-63927-4-git-send-email-oulijun@huawei.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.54] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ff122f6f-4866-4333-859c-08d8edaa3180 x-ms-traffictypediagnostic: DM4PR11MB5533: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Y1YgrNguJ2XD2Z+wQWGodxaGP4/65H0Vq/TE5ERS8pHyi6X5Lg9ms9DvHu/nDFCFbUqnT08jAdZqHrnlE6DD4UF7WsITo6XONCunL4pU/BmhyZeUvQ8BuY5prKaD6s73a3WcxsWVvsNlhSe/MkGJ0ve79u52R1Gn3d8FkAmJuDf8baKbbchtbaE5BRNRQdCRWGzl5UWAf4UmAqu2/h7FIduKL05QBBAguZjmJSyAcjD6wAMMP6uAz20i3U6Jykweu6yRyWmcEjWlkP7hCXQAHmXbpPAlXCvMEZ6JR8RIivCphFaQXHgTrCVpL4GNB0RedTBWFf+8M2mZarCzt2C+nTR5t5srUFwaEZTXIKpau3KTd2iYd8ynlPLtZ+/uKVpDu0ryCN4Jt5il1mmChV3e0QRYaSC73yS7fokncpRBzW9WgID9xd7ZnJLYFW7HD5HshoiANIaycvOyitMSGkfy3q4fLfu4po5URajL+t4biyRXoZvAJzuBC+Wy19KwzHzLFduJr03xcPXpR0CT3h32DQiz9ZsM6rmKTP85GQApyY75Bes+xevBCpnN2oe5HVSPJw8IbbZSIGqwXBPoSPx25SUxquF/atTLWH7o9ksHMFMhe0UC4uHpvu1JEAKGmt8m3g0b+4jVDdFhqQWBUzj6Kkk2MPzq76vfI6T7WKlqpdM= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5534.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(39860400002)(136003)(376002)(366004)(396003)(346002)(9686003)(55016002)(38100700001)(71200400001)(86362001)(4326008)(8676002)(2906002)(33656002)(186003)(83380400001)(54906003)(6636002)(110136005)(8936002)(316002)(26005)(64756008)(52536014)(66446008)(478600001)(5660300002)(66556008)(6506007)(66476007)(7696005)(2940100002)(66946007)(76116006)(53546011); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?XLtr5AO6vPEAk0gSnKt10zM96Vy+bti583Y/fSZNsIiRZzciwI+WU6EtE6UC?= =?us-ascii?Q?0exwbKit2WmqqJzuNmvGp0crfU+Jf/nN2jRGLB1kLMuVLXgQFfTndxv2Uzmx?= =?us-ascii?Q?8cIQuzEmXyUQtP0e7KNLm36EI2Q36K6t05+Hku29t3xHXI08Ht0tGo0rOGAX?= =?us-ascii?Q?reY8IhefRU2XJ+RIc3kH38DKwTvBte1SCoQbQYqHF704PCvzBqQKL9Isqf66?= =?us-ascii?Q?P2D4iLeXzobwiSe2QgTcldaQyDDXQmlHZCt9rZ0CZgk3+6qPxhQHbghtOZFL?= =?us-ascii?Q?22P8lKxPGMMHSeAdo2Y5viXGi5YD/s5NJhiG4r2G8dHV9503lkSq+k0GuxHL?= =?us-ascii?Q?K78PkzFBAsBZu0kMttAzDgGyg7amj3v9J+tNAgvQvya2py5NJCOrEgG2kgUv?= =?us-ascii?Q?ByJ+NmJKOyzBeCXu6QeAntIMjx6Kx1a03TlO5Fo4Q9+CzoYi4+bGlEZk+FpZ?= =?us-ascii?Q?hUvoHcIYq8//lqQ70RzOF7Wyl6lG1Oxzwsjc7kR3a0iWk0gNqgB4sjEMKani?= =?us-ascii?Q?1KJMHK7V1U9nQeP+1gdTTFEcBTCRcFMmo06h9+Ugd8c6uAouLG8pRO8GghfU?= =?us-ascii?Q?Ewxg9ecmPjgyDp0Sk6Jwo3ZStrCilOtF58MaOJmEfpDkfUXptClnJ/QmaN8p?= =?us-ascii?Q?ohQ0td4vKG7sv3PE3hoBwfJFt9hotk7Qc7/C3kVmnHkKj3euflJV8Nw8uIV5?= =?us-ascii?Q?oeZlpIr1yKlWU9/XD3BsHSdmm/lTkExKYB7tpCqU8OXuKFZNSJ7WJdv50k2f?= =?us-ascii?Q?O3jv7zmbBALrMX8ZzoEg5jJIWiEG8VkRww4p1KbFADZR+r6FYKrUfjR7eFz9?= =?us-ascii?Q?EFGy475/g1YZbkE7CMMnIAB6GARpC1ACDdFfNxsSuRY/ATC4RUCUKqdnZvG9?= =?us-ascii?Q?XRyHRmEainDmcJwJ6qVNx0c9roJ0XlGuxOgPuRAwsGCO9BZSLJOOh0p3/IM7?= =?us-ascii?Q?y/OPPTqP88pNX0O/vydZaLkJxcDyjuihPHIMFf608z9yKv971F00EJV+5TVq?= =?us-ascii?Q?+Tl/jLpQkQwWaByUbjW4OGESyJOQgUbYU8yo42mcsd7LEsut7TXfrSAukYoL?= =?us-ascii?Q?qV5kdEQKoUVAjDRz0xiRVW9SEqK0eQRVOLBmjSX0vvKP9sBHewyuKuKRG2n9?= =?us-ascii?Q?v3KvGezWyhIv0AYUMlVBF3c5U6qiuV5ogqq8lsVU0s01JQ1cIRoe6MlZArPo?= =?us-ascii?Q?aFXdaxPeSxYLRQtbu+cgBY7TcVHGiYbf/gFC0PzMoZ7ajaOf163Ea1AZ0eU0?= =?us-ascii?Q?C2GMXXDJK4XpW6Q99PXObxJTOkujIwUYtmGDXwOV9iJpSrM8P2CWk/e8nbhF?= =?us-ascii?Q?r8g=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5534.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ff122f6f-4866-4333-859c-08d8edaa3180 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2021 03:17:30.2131 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /tjxYcFup0g4a25uhCVC73uzU2WNV4HFz4fODyI8iTCSqRR/zIkIfJWaqvKgwQRBfAjEfSVhU5/m5U4CxvbsoA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5533 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 3/3] app/testpmd: use of Rx/Tx in testpmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi > -----Original Message----- > From: Lijun Ou > Sent: Friday, March 5, 2021 18:22 > To: Yigit, Ferruh > Cc: Li, Xiaoyun ; dev@dpdk.org; > linuxarm@openeuler.org > Subject: [PATCH 3/3] app/testpmd: use of Rx/Tx in testpmd > > From: Hongbo Zheng > > In testpmd, when we input "show config rxtx", we can see like this: > > 1: testpmd> show config rxtx > 2: io packet forwarding packets/burst=3D32 > 3: nb forwarding cores=3D1 - nb forwarding ports=3D1 > 4: port 0: RX queue number: 1 Tx queue number: 1 > 5: Rx offloads=3D0x0 Tx offloads=3D0x10000 > 6: RX queue: 0 > 7: RX desc=3D1024 - RX free threshold=3D32 > 8: RX threshold registers: pthresh=3D0 hthresh=3D0 wthresh=3D0 > 9: RX Offloads=3D0x0 > 10: TX queue: 0 > 11: TX desc=3D1024 - TX free threshold=3D928 > 12: TX threshold registers: pthresh=3D0 hthresh=3D0 wthresh=3D0 > 13: TX offloads=3D0x10000 - TX RS bit threshold=3D32 > > We can see RX/Rx/TX/Tx is mixed used. Also in other places in testpmd, > RX/Rx/TX/Tx is mixed used. > > This patch fix the mixed use of RX/Rx/TX/Tx in testpmd by change to > unified use Rx/Tx. The commit log is too redundant. The following is enough to explain what th= is patch does: RX/TX and Rx/Tx are mixed used in testpmd print and comments. This patch un= ifies them as Rx/Tx. Except this, the patch looks good to me. But one big concern, this patch will break all of the CI tests because the = DTS scripts check if the results are the same as expected and this patch ch= ange a lot of the print. So I think the DTS maintainer needs to be aware of this. +Lijuan DTS maintainer And please separate this patch with the other twos. Don't mix them in one p= atchset. It's not for the same purpose. > > Signed-off-by: Hongbo Zheng > Signed-off-by: Lijun Ou > --- > V1->V2: > - fix all RX/TX > - rename patch title > --- > app/test-pmd/cmdline.c | 104 ++++++++++++++++++------------------ > app/test-pmd/config.c | 128 ++++++++++++++++++++++-----------------= ------ > app/test-pmd/csumonly.c | 22 ++++---- > app/test-pmd/icmpecho.c | 2 +- > app/test-pmd/ieee1588fwd.c | 18 +++---- app/test-pmd/parameters.c > | 50 +++++++++--------- > app/test-pmd/testpmd.c | 120 +++++++++++++++++++++------------------= --- > app/test-pmd/testpmd.h | 28 +++++----- > app/test-pmd/txonly.c | 2 +- > 9 files changed, 237 insertions(+), 237 deletions(-) > -- > 2.7.4