From: "Li, Xiaoyun" <xiaoyun.li@intel.com>
To: "Min Hu (Connor)" <humin29@huawei.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support the query of link flow ctrl info
Date: Mon, 19 Apr 2021 02:53:21 +0000 [thread overview]
Message-ID: <DM4PR11MB553445BD4A29C0D75E895D3999499@DM4PR11MB5534.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1618469214-35316-1-git-send-email-humin29@huawei.com>
Hi
> -----Original Message-----
> From: Min Hu (Connor) <humin29@huawei.com>
> Sent: Thursday, April 15, 2021 14:47
> To: dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Li, Xiaoyun <xiaoyun.li@intel.com>
> Subject: [PATCH] app/testpmd: support the query of link flow ctrl info
>
> From: Huisong Li <lihuisong@huawei.com>
>
> This patch supports the query of the link flow control parameter on a port.
>
> The command format is as follows:
> show port <port_id> flow_ctrl
>
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> ---
> app/test-pmd/cmdline.c | 83 +++++++++++++++++++++++++++++
> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 +++
> 2 files changed, 90 insertions(+)
>
<snip>
> + printf("\n%s Flow control infos for port %-2d %s\n",
> + info_border, res->port_id, info_border);
> + printf("FC mode:\n");
> + printf(" Rx: %s\n", rx_fc_en ? "On" : "Off");
> + printf(" Tx: %s\n", tx_fc_en ? "On" : "Off");
> + printf("FC autoneg status: %s\n", fc_conf.autoneg != 0 ? "On" : "Off");
"fc_conf.autoneg ? "On" : "Off"" is enough like the others in this patch.
> + printf("pause_time: 0x%x\n", fc_conf.pause_time);
> + printf("high_water: 0x%x\n", fc_conf.high_water);
> + printf("low_water: 0x%x\n", fc_conf.low_water);
> + printf("Send Xon: %s\n", fc_conf.send_xon ? "On" : "Off");
> + printf("mac ctrl frame fwd: %s\n",
Follow others' format will be better like "Send Xon".
"Forward MAC control frames:"
> + fc_conf.mac_ctrl_frame_fwd ? "On" : "Off");
> + printf("\n%s************** End ***********%s\n",
> + info_border, info_border);
> +}
> +
<snip>
>
> --
> 2.7.4
next prev parent reply other threads:[~2021-04-19 2:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 6:46 Min Hu (Connor)
2021-04-19 2:53 ` Li, Xiaoyun [this message]
2021-04-19 6:40 ` Min Hu (Connor)
2021-04-19 8:04 ` Li, Xiaoyun
2021-04-19 8:28 ` Min Hu (Connor)
2021-04-19 8:28 ` [dpdk-dev] [PATCH v2] " Min Hu (Connor)
2021-04-20 0:10 ` Ferruh Yigit
2021-04-20 1:34 ` Li, Xiaoyun
2021-04-20 1:48 ` Ferruh Yigit
2021-04-19 15:30 ` [dpdk-dev] [PATCH] " Kevin Traynor
2021-04-21 6:18 ` Huisong Li
2021-04-21 7:56 ` Ferruh Yigit
2021-04-21 8:05 ` Ferruh Yigit
2021-04-21 9:42 ` Min Hu (Connor)
2021-04-21 9:41 ` [dpdk-dev] [PATCH v3] " Min Hu (Connor)
2021-04-21 11:12 ` Kevin Traynor
2021-04-21 11:36 ` Ferruh Yigit
2021-04-21 11:41 ` Ferruh Yigit
2021-04-21 11:42 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR11MB553445BD4A29C0D75E895D3999499@DM4PR11MB5534.namprd11.prod.outlook.com \
--to=xiaoyun.li@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=humin29@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).