From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B7BDA0548; Fri, 2 Apr 2021 04:33:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A57C940F35; Fri, 2 Apr 2021 04:33:37 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id AFBA040150 for ; Fri, 2 Apr 2021 04:33:35 +0200 (CEST) IronPort-SDR: edN39N/11UysaSXnkOe8v43NV04NLMMRLWJceiefRjUWy89lSJHJqE2hk7KCfmLGNfxAJV+/sR IBmdK9xIr6fQ== X-IronPort-AV: E=McAfee;i="6000,8403,9941"; a="171791717" X-IronPort-AV: E=Sophos;i="5.81,298,1610438400"; d="scan'208";a="171791717" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 19:33:34 -0700 IronPort-SDR: a+FZRra+UwpPTGUMspB3g2/Xl7KkarEa/LWKxIwKBvGh91yK9s+Kk3SAzdWqvrWKNQlLmWwm/u KmyVBJ9CSImw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,298,1610438400"; d="scan'208";a="596567521" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga005.jf.intel.com with ESMTP; 01 Apr 2021 19:33:33 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 1 Apr 2021 19:33:33 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Thu, 1 Apr 2021 19:33:33 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.171) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Thu, 1 Apr 2021 19:33:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YqW0rmVP3le2D9oBmIzGSmj4xhoCGs5yPrkxIbdZScGJgYXUnaKI7UA4C8CaVQMtkn2HeBXY8+QC1kgKU8PvbvnQknjhvIkTcT2BlUJ4NJUCkdvatcsvtmm/V2EnkkZ/0AG0Vqgsb3mcEX+xzQDVY4NuavB9CLCWNLqayz11Vjo72TzyADrGEMZfudYjwK9lpu63+bTJH6jpFnRrBuaJCVUv1fND6+q6Cnn+z4fn17xDJbYqRoh7qgGiePGKMxQkTSjP/rvuhl6cdZIGKYo70qoMI5aglS3itPOjN4cE9vCHKNI5UzDhGlSMh4r6WOfE1g6Waj4PDZ1ZfYn6cKblNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xt6S4X6Cbq4Rk66Lmiv9ce3zlAC/puv2cNb9YX2yHqY=; b=PWkxPX3754LB5aEIj92m7S5IUAWZ4lNpwMVBu97h0qWOArGNbKDUTKRvQWPZL7pW5lMQomLkvkQY4JFPkJUZiKz7MwfQm9/+3vhfeuhzRo+Y23nZ3+vzoIIFO1jzSEXWEvyx0y1vjeagJaWgHuKGGOAEuk7WVpnk950KDFGAVVb5/CpgJEtgXULJ4FyQwh5TPLD2RRuz4qFftRHBUECuZB8OeTaE0DPjhxtwdCpGHqBj1PIRJDOrbbDhPeJ/5s0km+dzrfyIus/xG2GvsB/hoI4yAbTim+yuqHTEHnbAPnQQVK7DPuaDZ5w7JYiTzA7TWQv8/cPzxu4g1dYRj3D4Sw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xt6S4X6Cbq4Rk66Lmiv9ce3zlAC/puv2cNb9YX2yHqY=; b=N0Atab5cRAZzr0A5DXxCP1TsOAjZbMAHp0mO/mwtqSHbVfWudG3dD/S99Dk5i0vQvzEG1Ajyx9g/dQ/xzQNvuELAUQAZLibHgL2EuNE7aXLpklGLrpTfCOzeDwn/hiTWp9+s3LBMrh+EIRS2wVrDArQMMVduUJxNpt3nyF7srDQ= Received: from DM4PR11MB5534.namprd11.prod.outlook.com (2603:10b6:5:391::22) by DM6PR11MB2636.namprd11.prod.outlook.com (2603:10b6:5:c8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.29; Fri, 2 Apr 2021 02:33:30 +0000 Received: from DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::79a3:3404:b907:d49c]) by DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::79a3:3404:b907:d49c%6]) with mapi id 15.20.3999.028; Fri, 2 Apr 2021 02:33:30 +0000 From: "Li, Xiaoyun" To: oulijun , "Yigit, Ferruh" CC: "dev@dpdk.org" , "linuxarm@openeuler.org" Thread-Topic: [PATCH 2/3] app/testpmd: remove forwarding config from parsing Rx and Tx Thread-Index: AQHXEaldDfAva4xisEaALSlRIYLxeKqRMteQgAE8B4CAAAufEIABqS8AgAYz1eCABkijAIAAAc8A Date: Fri, 2 Apr 2021 02:33:30 +0000 Message-ID: References: <1614939741-63927-1-git-send-email-oulijun@huawei.com> <1614939741-63927-3-git-send-email-oulijun@huawei.com> <6091bdaf-6d23-5471-ff3b-7af673fca23f@huawei.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.51] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8ec01bd3-93e0-4dd0-c087-08d8f57fb45a x-ms-traffictypediagnostic: DM6PR11MB2636: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1468; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UibPlJqDnT1AMYuV8mDk8+ebrsE0j7fJUnnDU4xs8ojetUhClaM/yBZSaCuHBCnH1M5lWRtwxWM6CVjcvM9Mkuiux6qYgujurv0jx78zKkDZKJC3Fd6KN5IVoU2s3RAWAxDjZQMt+wYlnaOkxKG1uPewuf9VgMyWm73dB8MEB3dAUrUBIewUmVnLkAL8Zmoi95v00n3cagitceNWuRfA+KcaAigIhCnHgAAaSmzleX8P7OH5JtPzl3et3F2TpVPTrjuFRSpRO67daPkQpje2t+OW5E3WcKk6wdycmCt0KAXTitY0cBavaotECCA2pzbrci84JiHV4lJBgJIKBlqTaVy53rd24YLcal7/Fs8AotrfW748TgSeMAp5jjUXTsLocTer6hhAdyd/mnYwwtlQQmr0NDl3u4aYhWQ4P2zJKDr/pirispBOo1v+z8XaGCUsdG7SBM6EZJNxs/FP++wQ1VyMCS0Nh7VlXCxWr+JD6oLYIfIFrlACZzYbVU264WZN1MJPhVOsLnnoYEIbLNKaKlruih3fnhAdiznrEcv19jp/nXlt2lx/0xTOuW1G4MJtgRXk1g+v8mgC7i4mkPXsJdSPEPaSvQP4NTg4Xu4XQ3R2zKjTfTJQr7cRE0nx2qKybjVLNCyzlIUMSftiIErwSoTdOikL2Y0NTEo33Gt4ZVw= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5534.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(346002)(39860400002)(396003)(136003)(366004)(7696005)(52536014)(478600001)(4326008)(64756008)(66446008)(66476007)(66556008)(86362001)(110136005)(66946007)(54906003)(76116006)(8936002)(186003)(83380400001)(53546011)(8676002)(71200400001)(26005)(33656002)(316002)(6506007)(9686003)(2906002)(38100700001)(55016002)(6636002)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?iso-2022-jp?B?aENhZUYzUlcxNlg0V2p6OHVTNWN3YURyL2tQcTJyM3d0TzhUdkFrSVV2?= =?iso-2022-jp?B?SHBpTUdJRVA5dnNZVXo3THQvUXplQ1pMUXcyWWNYM2pDdlRmRnh2T1o1?= =?iso-2022-jp?B?akJFdnFSWExLbmhUTTJjeGFna2IrMVNkbEVTc0FMYUtQZ0xSa2J0TW4v?= =?iso-2022-jp?B?UWNCRWVORXdzYzJMRFBYTnBxSzJ6RGsvZmxCekE4U2M4R0paekxvMklm?= =?iso-2022-jp?B?U1JDbVNsK05rZUt6c09ENGhreTc4ZUJCQzFZeU9iQ2cvWFp1SmlEaWt5?= =?iso-2022-jp?B?cWU4LzY2Sk51OTRGYVdEY0gvUk1sYWFYNnoyQlhnMldzdG5Ya0lwL25k?= =?iso-2022-jp?B?RElMRzUzZnpRSTRlNUxXaGplRmVlcXBHTDNZUTZoeW04dXRYZ1RsL1gz?= =?iso-2022-jp?B?citTNkdkcG9QdUh3akpwY0JMNmdpQU4zcUVnOUgyTnZUMUZtTzhrUDhu?= =?iso-2022-jp?B?aWdHdzRmSmgvTDRFQVhDVGNuRXVyQXZnTXBhaXI4dWhpcmlJcnA0TGFy?= =?iso-2022-jp?B?Y2xUajBpZzFxRFI5UnlnbzRYL2Z4ZUZaUG9kOTA3T3htckR1N2VtdmR0?= =?iso-2022-jp?B?cEszblpFNERXSDBlcXg3NmF4QTBTSUlVRDdWZWpoVE9Vc01rSklxRHdK?= =?iso-2022-jp?B?dllyUWVoNXlmazh0L0NaS3BBQ2VFbEhla2Y1a2I1eDJOYWZKUndKVDZF?= =?iso-2022-jp?B?V2VIYjk0dFNsM09wMEVIKzJYWDNRVzVwOWpxYWdFZ094bUhUYWprYndO?= =?iso-2022-jp?B?OVkzNzV6Z0pEV2Yyd25ULzRUWHdNbi85K3doNXh0NEJWb3ZNd3V1d3VZ?= =?iso-2022-jp?B?cFZFL01xTHIrUDNYZUxPeW5VbGovSmxsN0RRN1cxMXZtdVR3Mno0L3hw?= =?iso-2022-jp?B?c3ZWU2lxcndndlBzZ2d0c01FUEJyd1BSNWEvRHFNaVJMVVNZK05hY2Nj?= =?iso-2022-jp?B?VzB5ZTNSamQ2VElSYVJyMG9waStsVFNNeGZ3eldQZk5haEdva0x1dEhk?= =?iso-2022-jp?B?a1kxaVZZdVFWdXhhRkwxTG9wbFhXVUdnU1YwcndjY2pFczRTNm9qd2JN?= =?iso-2022-jp?B?dEsvVmxRZmZWR1haODd0YngyNTU0WGI4Q1hLamtieFRRS0c0dC9NdWdJ?= =?iso-2022-jp?B?Rk8xSWg2WEN4d0YxMTJaRlBHcmxBelhmeGtsQVUrOWlYWVlDVWNqMDQ3?= =?iso-2022-jp?B?bmt5SFNpUHlraXFocndFOUQ5KyszNHZkYnU5d2pVOFpWRkhvaWR3OFJo?= =?iso-2022-jp?B?TFBidkwweEJhZ29TZDZMM284eVpKWmM0aytuNmgybUVWSlM4ejJteVhO?= =?iso-2022-jp?B?b0pqVUtqZWUwN3BjQXl2WDNhbi9JSDJWcU9BUFEvbElDZ0NaYTBBazZ1?= =?iso-2022-jp?B?NVdTZERyY241YTdGQkdBWkF6c1VuTnVuSmk0UDJtWDFyZTl6ekIvWHdN?= =?iso-2022-jp?B?a3JBVDJTK3Q1dE4raVhvT1l0anVWN1hKS0EwbHl0ejRXcnRJUkVNbGpu?= =?iso-2022-jp?B?NkFTeEg5T3FXTUJkUFdDNFkzeFhDbDloaGxjYjdLSDJKak5vby83S2ZD?= =?iso-2022-jp?B?d0RVY0NmQUY3ME5PTDcyeDFCelpDN2lZVS95T2xTMjdGZ1JZVGlWRG5W?= =?iso-2022-jp?B?T0xwZDQ2T1VJRHNiYkVFMWlVbFRaKzJPM2xFZGZpbVJyYWxjbjFNYjMw?= =?iso-2022-jp?B?N05YcnJnUEg5VVFaQUV2d3hhb29XZzNqOTgxR25yME1ZTUpUcXBTeS83?= =?iso-2022-jp?B?U05TUHBoVkhxaCtlMmlEUzlaTjk0T1p2YWs3Q08yWU54ZXNpZU9zWklJ?= =?iso-2022-jp?B?VkptcVkya3FldDZVdnYrWWZYakxFV2J5OGVSWG5RcG0rWUJlTGQ5Y3Ex?= =?iso-2022-jp?B?VEYyUlZYdlc3eXNxRDE1QXlmNXRpNDBnaXdwcCtVeW9GZEtnTHkrcldo?= Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5534.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8ec01bd3-93e0-4dd0-c087-08d8f57fb45a X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2021 02:33:30.7407 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bCv4Ww1M5nWRNKACynx6AeektbLxd/LCtdd+p72Eegmt7KpkBLNj0LCgCAf2qexeHbawUyj5v5Sss3ZOkg39UQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2636 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 2/3] app/testpmd: remove forwarding config from parsing Rx and Tx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: oulijun > Sent: Friday, April 2, 2021 09:45 > To: Li, Xiaoyun ; Yigit, Ferruh > Cc: dev@dpdk.org; linuxarm@openeuler.org > Subject: Re: [PATCH 2/3] app/testpmd: remove forwarding config from parsi= ng > Rx and Tx >=20 >=20 >=20 > =1B$B:_=1B(B 2021/3/29 9:53, Li, Xiaoyun =1B$B > > > > >> -----Original Message----- > >> From: oulijun > >> Sent: Thursday, March 25, 2021 11:04 > >> To: Li, Xiaoyun ; Yigit, Ferruh > >> > >> Cc: dev@dpdk.org; linuxarm@openeuler.org > >> Subject: Re: [PATCH 2/3] app/testpmd: remove forwarding config from > >> parsing Rx and Tx > >> > >> > >> > >> =1B$B:_=1B(B 2021/3/24 9:44, Li, Xiaoyun =1B$B >>> > >>> > >>>> -----Original Message----- > >>>> From: oulijun > >>>> Sent: Wednesday, March 24, 2021 09:01 > >>>> To: Li, Xiaoyun ; Yigit, Ferruh > >>>> > >>>> Cc: dev@dpdk.org; linuxarm@openeuler.org > >>>> Subject: Re: [PATCH 2/3] app/testpmd: remove forwarding config from > >>>> parsing Rx and Tx > >>>> > >>>> > >>>> > >>>> =1B$B:_=1B(B 2021/3/23 15:50, Li, Xiaoyun =1B$B >>>>> Hi > >>>>> > >>>>>> -----Original Message----- > >>>>>> From: Lijun Ou > >>>>>> Sent: Friday, March 5, 2021 18:22 > >>>>>> To: Yigit, Ferruh > >>>>>> Cc: Li, Xiaoyun ; dev@dpdk.org; > >>>>>> linuxarm@openeuler.org > >>>>>> Subject: [PATCH 2/3] app/testpmd: remove forwarding config from > >>>>>> parsing Rx and Tx > >>>>>> > >>>>>> From: Huisong Li > >>>>>> > >>>>> > >>>>> The commit message should be more simple and avoids grammar > mistakes. > >>>>> > >>>> All right, I will simply it. > >>>>>> The "fwd_config_setup()" function does release and apply for > >>>>>> memory of forwarding flows, and re-establish these streams when > >>>>>> rxq/txq or rxd/txd is changed. The function is also called by > >>>>>> "start_packet_forwarding()" when user executes "start" cmd. > >>>>>> All changes for rxq/txq or rxd/txd can be updated uniformly when > >>>>>> this command is executed. Therefore, it is a little redundant in > >>>>>> the > >>>> "cmd_config_rx_tx_parsed" > >>>>>> function. > >>>>> > >>>>> It's not redundant. This command may configure number of rxq/txq. > >>>>> So the > >>>> fwd streams map may change. > >>>>> Then it's common to check the fwd streams after this command using > >>>>> "show > >>>> config fwd". > >>>>> If you remove this fwd stream update, users can't get the correct > >>>>> new fwd > >>>> streams until they start the traffic. > >>>>> But they may change a lot of things and want to check if the > >>>>> setting is correct > >>>> before they start the traffic. > >>>>> > >>>> Yes, you are right. It's really unfriendly. > >>>>>> > >>>>>> In addition, the forwarding stream under one TC is configured > >>>>>> based on number of queues allocated to TC. And number of queues > >>>>>> allocated to TC is updated after calling "rte_eth_dev_configure" > >>>>>> again. If the number of queues is reduced after configuring the > >>>>>> DCB, and then, release and apply for stream memory, and > >>>>>> reinitialize the forwarding stream under the DCB mode based on > >>>>>> the old TC > >> information. > >>>>>> As a result, null pointer may be accessed. > >>>>> > >>>>> I think you should add "rte_eth_dev_configure " into > >>>>> dcb_fwd_config_setup() > >>>> before rte_eth_dev_get_dcb_info(). > >>>>> > >>>>> And the commit message should be similar like the following: > >>>>> Segment fault might happen after configuring queue number to less > >>>>> because > >>>> dcb_fwd_config_setup setup dcb based on old dcb info. > >>>>> And dcb info can only update after rte_eth_dev_configure(). > >>>>> So this patch adds rte_eth_dev_configure() before > >>>>> rte_eth_dev_get_dcb_info() > >>>> to get updated dcb info to fix this issue. > >>>>> > >>>> Thank you for your advice. But the above adjustments may still not > >>>> work for some drivers. The mapping between queues and TCs in these > >>>> drivers is updated in the dev_start stage. > >>>> > >>>> I have an idea. We can move fwd_config_setup() to start_port(), > >>>> which is called by main() and after starting ports This not only > >>>> solves the segment fault, but also does not have the problem you > >>>> mentioned above. I > >> test it and it is ok. > >>>> > >>>> What do you think, xiaoyun? > >>> > >>> How can you fix the issue I mentioned? > >>> You still need to start port first to see the updated fwd config. > >> Yes. But it can make sure that users get the correct new fwd streams > >> before executing the 'start' command. > >>> And for those drivers, why does the mapping has to be updated in > >>> dev_start > >> stage? > >>> What does it need? Can't it be moved to dev_configure? > >> The framework does not require that the configuration parameters > >> transferred by the dev_configure API must be updated in the interface > >> of driver. The driver can verify the correctness of these parameters > >> in the interface, and then complete the update in the dev_start > >> stage. It depends on the design and need of the driver. Maybe it's > >> more appropriate to put it in dev_configure, but now we can't ask all = these > drivers to modify the operation. > > > > I still think it's driver's responsibility to configure DCB in dev_conf= igure. > > > > Calling fwd_config_setup here is because this command changes queue > number. Users just change queue number so want to check fwd setup. It's a > normal and reasonable behavior. > > Starting port will be called in many situations. I don't think it's app= ropriate to > call fwd_config_setup every time calling port_start. And you can't expect= users > know the fwd setup only change after port_start. > > > > These are only my thoughts. If anyone else agrees you, they can give yo= u ack. > >>>> > @Ferruh, what do you think? > Currently, both ixgbe and i40e also have this problem. Even if testpmd ca= n be > modified according to Xiaoyun's suggestion, and the driver is not modifie= d, this > problem still exists in some drivers, such as ixgbe and hns3. NO. I40e and ixgbe DON'T have the issue. I40e tc mapping is done in dev_configure. ixgbe tc mapping is always fixed due to hw design. It only needs dev_config= ure to get dcb_conf info. No matter you configure dcb or not, the mapping i= s always the same. You can check ixgbe_dev_get_dcb_info(). So for i40e and ixgbe, you only need to add dev_configure in dcb_fwd_config= _setup(). > >>>> > >>>>>> > >>>>>> Like: > >>>>>> set nbcore 4 > >>>>>> port stop all > >>>>>> port config 0 dcb vt off 4 pfc on port start all port stop all > >>>>>> port config all rxq 8 port config all txq 8 > >>>>>> > >>>>>> At the moment, a segmentation fault occurs. > >>>>>> > >>>>>> Fixes: ce8d561418d4 ("app/testpmd: add port configuration > >>>>>> settings") > >>>>>> Cc: stable@dpdk.org > >>>>>> > >>>>>> Signed-off-by: Huisong Li > >>>>>> Signed-off-by: Lijun Ou > >>>>>> --- > >>>>>> V1->V2: > >>>>>> - use stream instead of flow > >>>>>> --- > >>>>>> app/test-pmd/cmdline.c | 2 -- > >>>>>> 1 file changed, 2 deletions(-) > >>>>>> > >>>>>> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > >>>>>> index 4df0c32..e316f5c 100644 > >>>>>> --- a/app/test-pmd/cmdline.c > >>>>>> +++ b/app/test-pmd/cmdline.c > >>>>>> @@ -1837,8 +1837,6 @@ cmd_config_rx_tx_parsed(void > *parsed_result, > >>>>>> return; > >>>>>> } > >>>>>> > >>>>>> - fwd_config_setup(); > >>>>>> - > >>>>>> init_port_config(); > >>>>>> > >>>>>> cmd_reconfig_device_queue(RTE_PORT_ALL, 1, 1); > >>>>>> -- > >>>>>> 2.7.4 > >>>>> > >>>>> . > >>>>> > >>> . > >>> > > . > >