From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB7B7A0548; Tue, 27 Apr 2021 13:43:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AC63440150; Tue, 27 Apr 2021 13:43:50 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 9BA914014E for ; Tue, 27 Apr 2021 13:43:48 +0200 (CEST) IronPort-SDR: g9v5JTR6h2Lt7mgY4klY6t2BL/3rCs0+UXqxzgsyxIdLxlHxcPtEBVRDLuIjL2MPrq/VLeDL31 2S22vGWWObig== X-IronPort-AV: E=McAfee;i="6200,9189,9966"; a="196603726" X-IronPort-AV: E=Sophos;i="5.82,254,1613462400"; d="scan'208";a="196603726" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2021 04:43:47 -0700 IronPort-SDR: KcEe3hwE+v1sJqAc9OUqCLWXaG86Gikl3JfnIzOwOBHQRXYhfmWiOSUEN5o1gw1hMKUYSwhpEs tjO5hphJBGsg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,254,1613462400"; d="scan'208";a="526067113" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga001.fm.intel.com with ESMTP; 27 Apr 2021 04:43:47 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 27 Apr 2021 04:43:46 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 27 Apr 2021 04:43:46 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.172) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Tue, 27 Apr 2021 04:43:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m3Q2uzj1bAycT70S9wgZBuIWciSalCx8E5DYKoqCxJyVvDgJ1WM/MHfddl7yGvDMaS3fYhPwQ6Gk2q7zbKrQWC7a4OGbwcq185//v+eSkkiocNVAnPdh3sQRm3a7cqKHC8l+0bPu/6NNZ3gVrYa1qJleB5TpwGsveCfmpKGbxOVQaHZ+BnylMK214hSCcqxC8NTJPtt8pkwDypZOLhltc5+uPCwfT4yPfYOJ1YM/xQyqzKbFqqLp135LkPLjUH0U5S7YvV7GeWgsxStbmCc0rkylJ4RSYe9LxNItFH6dEE5Rt+AuRdciVCDhL7qnm236h/mrZKdOd9O6P99ATzUvGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s4vO5WcM4JmJ+CjW0E50KOacAp5j8kIj7AXT/xBfKsY=; b=UzgQ5yrwNKDaulAAlKQCN8YJCP68zEvw6+tHvLEFaouxiGu3PCI1nBKEWHv+J3CUktEuzImkYpG1ocgjZ7rTyyjjS/rHJSRE9sAeKj96LjWlAiYSCqBf2lApNo/2fQVW6ooYRa7geTyMhCalIV/4h2sv+/VNylpPPGQ2EDLOQPQRenS4jTFUN4yzVQuHEq8a85IrcQ6yG4HQmSldyegGQSrjBhk9o74qpZ/1dqVUkqsUQq5oxrBRNtiLnDXWkusKcdPhSpdKUV6dbo3ygpguP2uFYrEtXk5YpsP9eMw8BfcZS0COtjEDwtjXEoUALI4P12PZB1I2lIpuohJf5e9Fcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s4vO5WcM4JmJ+CjW0E50KOacAp5j8kIj7AXT/xBfKsY=; b=ZARaik3XuzkSxcdILgQ2yG6Dlmzct6hq8h6jHeUnKQaCSqSJd10FLUuamIUOMF3kBtXhaZg7MpV9CYQgzt64Uk2LnegR/rEBQGpMPXrCHFOTwo6PudB3qx47eQEtQA7aFirtwsEpiXUKW2szvqbldjZ//dEyhf4KczbEixsigtU= Received: from DM4PR11MB5534.namprd11.prod.outlook.com (2603:10b6:5:391::22) by DM4PR11MB5342.namprd11.prod.outlook.com (2603:10b6:5:391::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.21; Tue, 27 Apr 2021 11:43:44 +0000 Received: from DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::9034:15e:7cf3:4b78]) by DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::9034:15e:7cf3:4b78%4]) with mapi id 15.20.4087.026; Tue, 27 Apr 2021 11:43:44 +0000 From: "Li, Xiaoyun" To: Huisong Li , "dev@dpdk.org" CC: "Yigit, Ferruh" , "linuxarm@openeuler.org" Thread-Topic: [PATCH V3 6/7] app/testpmd: add forwarding config in start port Thread-Index: AQHXNcPBYq2bU5viIkq2XYTqNLe3NKrIR6jA Date: Tue, 27 Apr 2021 11:43:44 +0000 Message-ID: References: <1614939741-63927-1-git-send-email-oulijun@huawei.com> <1618909266-17584-1-git-send-email-lihuisong@huawei.com> <1618909266-17584-7-git-send-email-lihuisong@huawei.com> In-Reply-To: <1618909266-17584-7-git-send-email-lihuisong@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.54] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9f71a9ad-6aa4-4fd8-eda3-08d90971b672 x-ms-traffictypediagnostic: DM4PR11MB5342: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uqGq7j4R1MjPFNlxJNd4lxZTQD8oeE//FtvrympcOm17FlOdF1UrlJ2UtsJzJmz1RV+J+6hxFoVNBFcmmJAawn78ZyRmhZ6OsjiqiyP2veAIm90ghqREE66+OBzplpMSwrFc/9TNBQb16Hh9dhH3DQX4rK4fvcWg7ueJfzWda5YlKohrTk4fXUukgk+8seSx4ik59Vz8W95iBWPe86T4QiobrkkvECQQXwP883wpOU7LeitH4yhAj1uK68MxDveBomVq4ZsUsRHkc/vwZ+dROvXZpkgSjnXXfX3GIbznox/q5qAGKUIZThOttypTKNvqFaLwwvhg0P3m5WV21JuqKAbaD6DJMO1bSynh/Y8M4nZD0cSh6DLzeBc+kFCCkndMmoaypRMIVHtAKsPfRkmXzjDSL1Gqi5gKsRNW0vYIvcaVHqe1TntsLQpJ7R2+cmV+kyRlIDSO7rNaWx45GywZxigd6H+dMaU7HYRelyWCYhgYpr7CrIpZqQu6NjecvdIBXuS3s705lWLoVzOb2IbowJAbnjiVi6ddw93/7gTS9TVLDHUxDKGlI6NIWYaZa+yzMGy2xtjCkQVhgP4pUUznV8Q6oYEEQiqUUMYx24/Q5t0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5534.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(39850400004)(396003)(376002)(346002)(136003)(366004)(66446008)(66556008)(33656002)(55016002)(71200400001)(8936002)(76116006)(66476007)(66946007)(86362001)(478600001)(26005)(8676002)(64756008)(7696005)(38100700002)(122000001)(6506007)(54906003)(110136005)(53546011)(2906002)(4326008)(52536014)(316002)(186003)(5660300002)(9686003)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?CJbEP8qdKzAtNubtJfvh7IrbpbOa2sfDQWEMzoK+bWsFgf+cUI3ay4wiX0ZY?= =?us-ascii?Q?xrhZAw3u7K8sDtN8lIC9fzcb4LAg3u+FlRTlkI9rI5qxUqp9UDm65bFWhrrO?= =?us-ascii?Q?+KenSPw+Dw4iT5G8sB17Mo2iiuSRIlCONzu+0VwmdSdVrsPQeFbE3twclkhl?= =?us-ascii?Q?D91kLunL44gNy2m7BNwfVgyxhDif4yk5sUaSquB31HpvVvibVt21WQfXMx6D?= =?us-ascii?Q?khqzGZ2AuQsgpM9tOKY0PZyEtUsj2J05jc6N5odMZ3zozSrU1wo9SP3JQ96C?= =?us-ascii?Q?u7fyefg46lO0oEYTDP6MeTgg/QSa6ESWgwxD3mgMCCqiuBlxsKiVbN4rs7Ay?= =?us-ascii?Q?+elqrNLvod7l2rY/7S4ALQErrj1xzzMJVhp2dtJtcJoCe1i87f29HOxUoxQc?= =?us-ascii?Q?uOTkN0Mhm7QVTquYHwVL9xM9A18JaeAU+t2teOr4XOO47D36McHHFqVsJfpT?= =?us-ascii?Q?hnZF6V5UvsKS30Gh/dnxE5uoxx4rJtitwumagFbk+MVHaIW0cAmdAf/mhzUj?= =?us-ascii?Q?lElyhbCsjlbWKc06lPcF+HRXeaJczFSGIQl2m87xt63aEohxguWyf0kpXw3k?= =?us-ascii?Q?b8IHcroBDvnXjNQc5HucVYwcXoHedzTTch6bLTMvE2WCRv4mRcWiCF+BI/dW?= =?us-ascii?Q?hPGfzmYo107+gLauwVHcUakcI0SvDbSwYtmUej1vGfnm89V+a7H9Fa9fO2iO?= =?us-ascii?Q?3zC0WZVSHR7gOMi4mTnzjou+zI6UTGNFO4xhL3XkFwMW+LQQeiNkKXJK0Vud?= =?us-ascii?Q?1RN9xn7Ju9iGNGXPhLp/Q3SMnm0R3LbYF4Jy5RkzaDu/5lYQOuL2wexMW8Aa?= =?us-ascii?Q?sGc1CqJ83LsBw5d+oh2NEqMuFRxgkY/sb3aWG3OrQaoj7E7lWVvLMyKxsOnG?= =?us-ascii?Q?D5lJkiV7Nw6BAz7gMr/thix8r57elQM83q2VbPP2pQZ14ZtzaCZ6tZh7ze3n?= =?us-ascii?Q?kMnx7Oxl703Pk0/W6wIXEC35e2G7axYHaCg9uRhLLSmBhWAAQhESbz2Jdeb2?= =?us-ascii?Q?5a8dfSR5FzP2SDnIPT5YZexQI/tSfZqQ/oj9o03QbiLozUspi0DaARfJRni3?= =?us-ascii?Q?V7Ko9v3AbP/lkLD1YVKgupka+SpT6ZitXkHjjHxDZNEuiRw3u7lBi/oYvYRx?= =?us-ascii?Q?OUcYQqA3F8mv0g91E6VQshWq1BIwayKa0DBf1tybPBRdJHRss0Y6St5ExyJI?= =?us-ascii?Q?pA+AdCJ/WH9ar/iL6rAUqRn2Vmt3BV8QjXAhN94qwosoBCzsVtwCnLkJ7i1I?= =?us-ascii?Q?HVNkm4MUkSjTnobjtNvAqHgU7TwaZFPLCa/P9bxSAc30+8ZXK6uwKI9C4/gz?= =?us-ascii?Q?jj0=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5534.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f71a9ad-6aa4-4fd8-eda3-08d90971b672 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2021 11:43:44.5988 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Va5NPyzc6xQ30GDaDtS90pcUdfMY36xC5oRklTcjK9I+deJ5DA60A1Kb0+WDvdlCECvXu5ohiW7gSfQEYrThLQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5342 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH V3 6/7] app/testpmd: add forwarding config in start port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Huisong Li > Sent: Tuesday, April 20, 2021 17:01 > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Li, Xiaoyun ; > linuxarm@openeuler.org; lihuisong@huawei.com > Subject: [PATCH V3 6/7] app/testpmd: add forwarding config in start port >=20 > Most operations in testpmd that need to update the forwarding streams in > testpmd call fwd_config_setup(). In some scenarios, eg, dev_configure is = called > again, the forwarding streams may not be updated. As a result, the actual > forwarding streams cannot be queried by "show config fwd" cmd. I don't agree on this. Fwd config should be only changed after the user change something like nb-c= ores, queue number, eth-peer in non-dcb mode. These are already done in tho= se commands. You should do fwd_config_setup at the end of cmd_config_dcb_parsed(), I agr= ee on this. But doing it in start port seems to do redundant times of fwd_setup. It's n= ot really needed. >=20 > The procedure is as follows: > set nbcore 4 > port stop all > port config 0 dcb vt off 4 pfc on > port start all > show config fwd >=20 > Signed-off-by: Huisong Li > Signed-off-by: Lijun Ou > --- > app/test-pmd/testpmd.c | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > abcbdaa..f8052b6 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -2678,6 +2678,12 @@ start_port(portid_t pid) > } > } > } > + /* > + * In some scenarios, eg, dev_configure is called again, the forwarding > + * streams may not be updated. As a result, the actual forwarding > + * streams cannot be queried by "show config fwd" command. > + */ > + fwd_config_setup(); >=20 > printf("Done\n"); > return 0; > -- > 2.7.4