From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DFD4EA0548; Tue, 17 Aug 2021 03:43:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 845D540143; Tue, 17 Aug 2021 03:43:38 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 8756240142; Tue, 17 Aug 2021 03:43:36 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10078"; a="215975429" X-IronPort-AV: E=Sophos;i="5.84,327,1620716400"; d="scan'208";a="215975429" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Aug 2021 18:43:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,327,1620716400"; d="scan'208";a="572710743" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga004.jf.intel.com with ESMTP; 16 Aug 2021 18:43:32 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 16 Aug 2021 18:43:29 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 16 Aug 2021 18:43:29 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Mon, 16 Aug 2021 18:43:29 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Mon, 16 Aug 2021 18:43:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kGfT7SWelG/Pzh0LFFGiyJn481ju15yuwMaJw7QVC5IDsXS9CZv/sYpwgNkYCsuf82whEaqDw0wiz7Tj7Dit97AQIH7p9qK+AFOtwnVelowmLK4eIxAQCrdGFSjghG50KZveJsVIERaAob9N+8UDywqJp+dRenGKT9KFIZEEQbPY1xo4PXa7qtqSwA6SaSZFGSz5rTmXjB8HvUsQbXqKa/1li/4EvydGDMZFMsWL66d4ZzjNXXaJc2mB/nPK+VHoOwy96WinZF2Iq7QvQav8zTBEfPTBQSzmyU3QNLxG0ZliKQ6dPzOARqlKCe+KcEaB2Sr7Bhis8T9QbgVHss6SGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yZsr/btC56WOFFYWs8ujWkamdKjiFPwtJbMjpN7wvow=; b=Q7Gw2LVpppKQYYRoIY4F+wbdZ1zL7JFmndfDoOqHnAVoRQFaAADkBIX4kDcBNGldiLLRIr70DGT67OjFZ1Jz5SBALC76+mbLAoP/TKNWFx9+J9JTyRTsRY0avqKOXMyVPZWhLtafLOUu/baTVdN8TmtsI/4EYorWZmGMAEfO7Fc5agfNl520F/Ct2eRWnWRrgQ5kCaAmCJ3FP+CNacbTKxWUVxVvQTpXTDGpGfqdipXpGhbb3Myv+JyfCacwNSxHc0Ajzet5VWavOnYYwakuf/KTdLvpOufJInmU3O7f7feFfoWdkZzkRHI1Q1Skm6yNsQSrxEA0Jvl9UdfVwSegAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yZsr/btC56WOFFYWs8ujWkamdKjiFPwtJbMjpN7wvow=; b=czKEtGwTmERBE5Hcw6OezeOWtR6CSubeEDWJLkzkLvhw2wbGOItjUO4tbwNKZsOoKxHN8kADmpKMOfGrttcYdOzXS0TLvtC6M7PrTcdGUWj001ZDQJOqgqCJgSPYwZeBh0qVoIakgiiG5VYDSmYthZFxCRZ2crDrFWmTqOV++2U= Received: from DM4PR11MB5534.namprd11.prod.outlook.com (2603:10b6:5:391::22) by DM4PR11MB5341.namprd11.prod.outlook.com (2603:10b6:5:390::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.18; Tue, 17 Aug 2021 01:43:27 +0000 Received: from DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::d019:aaeb:94c0:1c45]) by DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::d019:aaeb:94c0:1c45%8]) with mapi id 15.20.4415.017; Tue, 17 Aug 2021 01:43:27 +0000 From: "Li, Xiaoyun" To: Nithin Dabilpuram CC: "jerinj@marvell.com" , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/2] app/testpmd: fix csumonly mode when run without outer chksum Thread-Index: AQHXkm3Ebsm2mHvLNUK7jrrdzrbxFqt1z1DQgAAmSwCAAPcAUA== Date: Tue, 17 Aug 2021 01:43:27 +0000 Message-ID: References: <20210816070943.26807-1-ndabilpuram@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5072930c-c621-4a5d-9f94-08d9612068c0 x-ms-traffictypediagnostic: DM4PR11MB5341: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3968; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8Y829GFn+NG3y7LhU00p0TmMuUBcm7I80373HpTqcZeTGIgB3A8IoanCiMs1MTP3S3coyGkWX0lFCXSA024pF3wPyDQhAast+2pxq40g9hzgh6a6qk5NV7mOymRaSONB13Lkt1gYPlhPL+RUl5yHBk/YOT3LjmRFGasiQ0kQYcXvXFkywN2Ris6QABb8zvbNzcyqWXNlhYHTwvl+59Pc5+9BX79MJ7c4vpVUwcNF2mbVR7EzIhldeQsbZtp2kSiytVjrS10Iwpp3dhNUcDbXOJTKGZWqAOPD39IXh5Ut+P6nJ145Esp6uuLOAw7kVzKxk4usZ9wi8/0fdIrCLtIb0zZVPZZgULBNA7uvq0YcuAQTI9Uhg2uUBdFu5y+4bJLp2lfanH0C9khXt6n75S7ZJ+X9mAvrt1OUnLYekz6PYm3Las5EWghbo/jZKhHAV+N/CM3JEZEGIz5uRNM0UIwCWZjEPX/n16NyIK7movptr9hjD1YvadsCs3KFGVpbsosf9ZZvB2Kxs3OajYtYvJV//Q+noiMgHQfoe0wlwN1uwZOT8MOWrM19yQ6Zp+XWcQQh2Bahda/NGYokthFBUs2MoAJrTX8XJOtMmyPQmuFQjKyCGrQeJWdobHoJhX+MYuGJa+pYnJk+2Ud9erPuE1WoqzS/KegJYq52Jg6+h97cowZ0wNrd/Yx3Gc2fvgQh7oq/8fQ1/EG11+TIBx0VayhOdg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5534.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(8676002)(6916009)(5660300002)(53546011)(6506007)(76116006)(54906003)(8936002)(4326008)(52536014)(66446008)(64756008)(66556008)(66476007)(66946007)(38100700002)(122000001)(316002)(83380400001)(2906002)(9686003)(186003)(7696005)(26005)(71200400001)(38070700005)(33656002)(508600001)(86362001)(55016002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?x5DJDykhXxMflA/IpfTIY4yBRpA75G/1kvYGLgL+Ycb56kd8Kc2kj9RePkSm?= =?us-ascii?Q?U/UeE5z1P7YYX2JXpGgh+Si+264MR7FezKiHSSeMrcyvP3CQCEWzZpAA3F9I?= =?us-ascii?Q?nH1CqMk9OAyd2pB9O8uH2ISsHYjTf/XYMrsuDdwZ0sKaPucBEz4iLflasHiU?= =?us-ascii?Q?zprwXg2a8Hn++AhVAehWCaCCKENFmTEMTWUMw3uSk3wir8HiqRugFpJsGkZe?= =?us-ascii?Q?NREAxSGeUMjLCPCWzHJsrJifkZM/c3htduVWezswkA0GLF29JIIeuyzj3Dau?= =?us-ascii?Q?Ak6YkfaSZt++wnnlP4OCf9wqcuiZA/eYMGFpEYgouZVYPOe1tfKhdsILAUDS?= =?us-ascii?Q?jNhMkmE1NNyCGj3E74ACTrv0279BdNhDYbWBjqXsqv/XEhwLQbda8qnL6Ywj?= =?us-ascii?Q?WUcxL4v/gbeKfD3MdJLXlgUSq5IPT5Cr7jblm0CoCAsqRX9LGSFL3Ih8X68A?= =?us-ascii?Q?ifX0WBMfZiLaOXXi6scC75wd2SQtaH+QJBApIiPejX9va68xAiRMHsrbx80i?= =?us-ascii?Q?iPSLZli+xAGd9/EuMikSIEXTjjQhHoJvm3U3f528guT9fqUulY6mX60Tiewr?= =?us-ascii?Q?56ZRgBVDGkzHSyIfpwUm036usk674PYaPORRYWnxd17WDcEm5J7SZJz34KfT?= =?us-ascii?Q?WYCJOp7NduX8Msk0mP6i8jI+lNNI4YYAEe1q6sGyuYPv5tRRZqBQJydhtksh?= =?us-ascii?Q?qGbV05OdfGOj1K/sXQHJVNocDM0pycOxa2W/yQ7JetqcCAneh26Y6e/u0xjf?= =?us-ascii?Q?y4EyiVb8jxAHZYQJVmE9glef311AtqM/5C9mJtGz0SQeCiPYb4HfOjaRmgiK?= =?us-ascii?Q?nnnsl67FKXZ+QE9yrr76NXFdVG6V11aAZeyg36Y2DRlysm51w/Snzbz5Et8q?= =?us-ascii?Q?m2bdkROT/1iRYd3OzylC8nKGOjk5iNDpCueYaRrtT2VGroBQlEPxS0PqRXxz?= =?us-ascii?Q?FIMeQqGfBoARXc4VuY0EQeR2VaUfodjdc4tGwONHlX3BYKZVf04mEDcQarCt?= =?us-ascii?Q?McvqVpRUBkoyeBKJlho8h/wYXgfvcHAWcapvjeZIam1bmkXelzfSRYmYZ6ow?= =?us-ascii?Q?L9gryG8FLGpw077yWb1ZhxMo9Z03QvbQDbgAYKNQc1CyF2qpMDzaNFcKkGVu?= =?us-ascii?Q?k22TA7R9YOPfID6Vx3OOwAX++wG4OpztC4vXbz+dABNq4cZ9cVdV2K/pIS6D?= =?us-ascii?Q?WND943bt7f1GF95eA3SJ2cA8I2GkLhDUFu4OjnSyi2oHba01zLwLjT20l1H5?= =?us-ascii?Q?A199IMUwcL2EFZNrHoElTY56qiis0cS9xDoiD+q3ACylzYk+s1OSYllb0nnU?= =?us-ascii?Q?U7c=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5534.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5072930c-c621-4a5d-9f94-08d9612068c0 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Aug 2021 01:43:27.2812 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VItZanUe5BmhZpBvkYwoZx3hZ4AG1csuMsF9TC5FnPApytlOXb2pc2XVZ49u2m7G+Iq+Qzbr8TFpB6ykpcbqIQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5341 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 1/2] app/testpmd: fix csumonly mode when run without outer chksum X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Nithin Dabilpuram > Sent: Monday, August 16, 2021 18:56 > To: Li, Xiaoyun > Cc: jerinj@marvell.com; dev@dpdk.org; jia.guo@intel.com; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/2] app/testpmd: fix csumonly mode when r= un > without outer chksum >=20 > On Mon, Aug 16, 2021 at 08:48:20AM +0000, Li, Xiaoyun wrote: > > Hi > > > > > -----Original Message----- > > > From: Nithin Dabilpuram > > > Sent: Monday, August 16, 2021 15:10 > > > To: Li, Xiaoyun > > > Cc: jerinj@marvell.com; dev@dpdk.org; Nithin Dabilpuram > > > ; jia.guo@intel.com; stable@dpdk.org > > > Subject: [PATCH 1/2] app/testpmd: fix csumonly mode when run without > > > outer chksum > > > > > > Donot use outer metadata when neither outer ip checksum nor outer > > > udp checksum is enabled. PMD's will ignore the outer_l2_len and > > > outer_l3_len in cases where none of the outer checksum is enabled > > > and hence only l2_len and l3_len will be used to calculate the offset= s for L2 > or L3 header. > > > > I don't understand. > > In process_outer_chksum, only PKT_TX_OUTER_IPV6 Will be set if it's ipv= 6 > packets. > > So PKT_TX_OUTER_IPV6 means this packet is tunnel ipv6 packet. So it act= ually > needs outer l2 len and outer l3 len put them to hw. > > At least i40e needs outer l2 len and outer l3 len as far as I know. >=20 > Ok, do you mean m->outer_l2_len and m->outer_l3_len will be referred in i= 40e > driver even when both DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM and > DEV_TX_OFFLOAD_OUTER_UDP_CKSUM are not enabled in ethdev Tx offloads ? >=20 > I thought as per spec, those fields will only be used when the Outer offl= oads are > enabled. Checked again. You're right. Tx offloads are enough. >=20 > > > > > > > > Fixes: 3c32113a1aac ("app/testpmd: fix IPv6 tunnel checksum") > > > Cc: jia.guo@intel.com > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Nithin Dabilpuram > > > --- > > > app/test-pmd/csumonly.c | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index > > > 607c889..38cc256 100644 > > > --- a/app/test-pmd/csumonly.c > > > +++ b/app/test-pmd/csumonly.c > > > @@ -961,8 +961,7 @@ pkt_burst_checksum_forward(struct fwd_stream *fs) > > > (tx_offloads & > > > DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM) || > > > (tx_offloads & > > > - DEV_TX_OFFLOAD_OUTER_UDP_CKSUM) || > > > - (tx_ol_flags & PKT_TX_OUTER_IPV6)) { > > > + DEV_TX_OFFLOAD_OUTER_UDP_CKSUM)) { > > > m->outer_l2_len =3D info.outer_l2_len; > > > m->outer_l3_len =3D info.outer_l3_len; > > > m->l2_len =3D info.l2_len; > > > -- > > > 2.8.4 > >