From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 332CBA0C4A; Tue, 13 Jul 2021 07:37:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AF6CF40DDE; Tue, 13 Jul 2021 07:37:42 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 0BBFB4069E; Tue, 13 Jul 2021 07:37:39 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10043"; a="190480910" X-IronPort-AV: E=Sophos;i="5.84,235,1620716400"; d="scan'208";a="190480910" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jul 2021 22:37:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,235,1620716400"; d="scan'208";a="429922122" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga002.jf.intel.com with ESMTP; 12 Jul 2021 22:37:37 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 12 Jul 2021 22:37:37 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 12 Jul 2021 22:37:36 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Mon, 12 Jul 2021 22:37:36 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.43) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Mon, 12 Jul 2021 22:37:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iCuRtCY8K6QBh2L0caY4T217iCMQwRjpKjz8+CL+gjbMiAZWfy3C6jmAH1McU0OlOtoeHzqGaFaU77GQjz7bD4/i/Ak5bz613GyztZ/JX5MPy132zjAf5x6UHk/uvdJS36hfJC5JgrGPgjpKnZZSYl0KiV4Xu8tqMmmMLc+RKv4mrlTtVcFXDzfrpsV1EzSZmWqHrknz+wX/YTtMEJK7wJz2XJitT6LvOP+3rmy3/6KLjYJlAA3BsfF1elRUeqyIR9DvSJg4XIvUbegwlvRBe5r4LmZO3hAlaKbZ1K2mEC5WQOvdkzXDtbpmVh8/UpB6IsljVlGY8hdgaXQEqhO11w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jTvectWQtNy3K3ly9DlAUuA1CXpUjIMKVeCXtEVxrGE=; b=XElDDkpMpdGWB4tyJVEvQFK0pDwc9J+XoX8Y/DiNDXNYdeBFzhsS6l6uRZtdNBctJjsKO34Ci9gZw3OaVMUzZzGOHrVKUdQKC5pB7Gc7rMXWbt7XLqztO+BaILWu/By1czlw6ZYm2tTwxlOiutwq69v8QvaJ5UAxQ4c19qJXT9SOS7qgbKAmw56IYgbI7gNbzxl1w1y2GZdhwPHQNHcxLcYJdLkQvua96ye8JYSao1EwqpUNgh35ArULuP2wRbA7W+wrVTVEYFaid7xK89JHB4fjOpL+f8Fx1EsSwXQQr6Bl9iFQhz/+bX6PTQPz9d5tM9m6AlYhPL02RcL1xrWvXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jTvectWQtNy3K3ly9DlAUuA1CXpUjIMKVeCXtEVxrGE=; b=L72OzsYn6sN4kRv4QN9RvhvJ9m5u4JjtTJce4/rWROvvmIkdCKPHCxYjiE/tjKi0hFjibHrB+boc9NAOg2kS7NsYoCUJS+WkZozKC/c6vhVsIXMAkpgI1/I+FMp0wH2EKmO5t56j5zH7eq0zaB0dGKTpGyfd5aLwP1g4DQCS6nI= Received: from DM4PR11MB5534.namprd11.prod.outlook.com (2603:10b6:5:391::22) by DM8PR11MB5687.namprd11.prod.outlook.com (2603:10b6:8:22::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.22; Tue, 13 Jul 2021 05:37:33 +0000 Received: from DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::87d:1217:a7cc:dd72]) by DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::87d:1217:a7cc:dd72%9]) with mapi id 15.20.4308.027; Tue, 13 Jul 2021 05:37:33 +0000 From: "Li, Xiaoyun" To: Viacheslav Ovsiienko , "dev@dpdk.org" CC: "Singh, Aman Deep" , "arybchenko@solarflare.com" , "stable@dpdk.org" Thread-Topic: [dpdk-stable] [PATCH v3] app/testpmd: fix offloads for the newly attached port Thread-Index: AQHXdxtJFxyGH4trwUKa+4Pyym2K36tAYpyw Date: Tue, 13 Jul 2021 05:37:33 +0000 Message-ID: References: <20210619154012.27295-1-viacheslavo@nvidia.com> <20210712124053.29989-1-viacheslavo@nvidia.com> In-Reply-To: <20210712124053.29989-1-viacheslavo@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6a6d0184-2423-4606-69cc-08d945c050b1 x-ms-traffictypediagnostic: DM8PR11MB5687: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MrqklZgGa4LX32vDWS37r/fxvtc/2e4Hwy/v7AiiCVgdmhBHsBMhhdJDLjFK2kxAfSaoVG1vWThazrUw73vk9cdMdXriKo3w9kO3ysE2xFiHmE3d74JO3v45Ccw9dt25zUTamB9CO1Ft0tf/UOgj0LmAB3Mfpz+cE9/dzyTBCmKMHcmIfEjen6TNZQxs4osVOPbzhUmpyCV/lwM6cV6RL/CRxMESAqiwCHUTcRqaamrmR+GQ+bUnS2vwROpcmxaxZdFro1NZzE/drZCbwMx8MqC8Flq0hpSSw+fwRqtlrjQ0PZzKRUtreZpYPhI+pGnW641CqeJrdcIiOQ4XTD40/+Cofgx0t8w5CxKczXZDmzJg/3sqVZQqp4+S75dBqPjR02L3ie5gMAec+EDIPNyuAGny8tr3ot4apUPStVG968xlJ0qQUjAgpUulHJ5yD1sm2uinl0fvimLRyOCPzY+ggOCA78eCuwvaUWW37RCSzvObHFNS4rmknAdw6sy6nzohb7s7nd/8C0+INZ/xzkBU6M9ELUMf9E99X6NNRf3dq9eflyI6Gcm0ypMWsN8zj3RJZ8sncfm1egeuazp8Fh4C5o9uXBK64XCLOQ/JBeesT6jU39Uep6wITQ8cIorKb5UEy9FLPEWgd74YUCRuIfBiaGRc5OtmJ0Dt53Qoj1Vap52fLUIvXWh4sFoha1BQF5NduPpMWAKEZ6GZcb0/5RD3FyN+pOwc2rUho76qpf09idPJh1klIOULBFjGr9LEltA7L+NItO9B/s0UDdwmn6H9TA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5534.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(346002)(366004)(39860400002)(396003)(376002)(55016002)(52536014)(38100700002)(2906002)(186003)(122000001)(71200400001)(33656002)(26005)(9686003)(478600001)(54906003)(53546011)(6506007)(66946007)(76116006)(66446008)(66556008)(64756008)(316002)(66476007)(8936002)(110136005)(8676002)(86362001)(4326008)(83380400001)(5660300002)(7696005)(966005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?iA6vxH4FFO1Kj56pW39fkXRISAEPOzRa/Y26q+IWd7J+6BL3T1ZWk55uFGZq?= =?us-ascii?Q?fMwor31Xzoe+iUUCh3XKYx5nuYQfblezWB9/X36ExpdhlTmkxz+qr6o9U6zH?= =?us-ascii?Q?Gni0vR6Yb8TKueuNDnNctzHhB+DfU5WwMQqgxJkY2Ks19GhLQyYbPL1NNXWB?= =?us-ascii?Q?suwxDmNgCx3sLTSy+CRqw85EQq7atTOjeoo0yZ2LmtP7kRxJoZXodWrWOuRY?= =?us-ascii?Q?KbI9P+OWQ7LSogfm/o8TxGmhUCfZgWeHfW5Mp4PvbkuQuQ9yYI2vcoYNcfDM?= =?us-ascii?Q?zaXc/HoU6WJND+XeAQjDL8VEG8lNpSideOi2hBj62hVOgklChV4gJ9xE1bC2?= =?us-ascii?Q?tf9pCMPLhS2NTtHeDiPoN7rpawREUg2YlVR4OyuVfF/wY+JjNYHY9OMRkOSt?= =?us-ascii?Q?CSe034CyyZE4TUyBdFA9t3AMx3AkCt8whLxv2OWfVe5LJS2crp3DlwH9763I?= =?us-ascii?Q?y4z8mhTox8QUzIAiZQv2Xhs7FrrIFs9akEGylb4hOI9anBHtl1Yop9uj1qon?= =?us-ascii?Q?1bdD9eYJBGfBhA5AtF02kS0W7dcG+etMsbguTgmDQDXBN7Os2k5/e+gjegNH?= =?us-ascii?Q?E3U6n03oRuyAVUWm5wAvY5FpUq5WE8nzh+nXKR18TVAeEeGH+mC+iaQaKDXv?= =?us-ascii?Q?yWUXRHys//HK4B/3LAdQ3SDrF3U7coRROuDWpNzr88oHBx6I8nWPlZpXkAVY?= =?us-ascii?Q?PbKEaN3dI4IWJL1VzF6m4sLmMm3GMS2BBy81U1/BSLN/vjwbzFNlvXf9Zog5?= =?us-ascii?Q?sHVV7gLlLdswDg/Gf+Ry8I4QJV1ZYYi3Ky8bF9Pbt92WIk3PoNKmGct7o9KH?= =?us-ascii?Q?a1VCdCUetYatvEirgObtFXsTQQBCBBZAwOEicAn2S3GDB4nUXeRbAxV6JY2s?= =?us-ascii?Q?6TkLi8oQuPW29lDShjL9HECkyrod0lsXUx/G6BQb+dIm8kQr+Jr426kKrahf?= =?us-ascii?Q?vzGyIaWCiDKQ0Hqjqxx0tllydoPURv8VhKj1LII9ZMRNULJEijLHPWecEHwT?= =?us-ascii?Q?Z+W4olTYl5uUm3O9F0ygOci69fwvEgHr1F09xdfgHGNhCB3Q0tgX1AvtyndW?= =?us-ascii?Q?j8uSSOOzSsmUqPpjL6814juXCc/tq+Lf65/1hxnSegNmS4gnWI0sBNiTi0jf?= =?us-ascii?Q?VyTjvptT9vIv8p3qfesqRwtuuuySZJ7gnRPp/Yl0G21tsshwj9yg/sRUT1gO?= =?us-ascii?Q?PQePmHMIRvd6l0ygY0a/8NaFpGCtdwOjg006pAo/XhnF1y1+ta5R60xVA9Rz?= =?us-ascii?Q?GtNzO3vU9n0ifPP21UtmHUSXRs/s8pKf40JpJhXad6nOcKq5I1uUVkaFNKCU?= =?us-ascii?Q?J4E=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5534.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6a6d0184-2423-4606-69cc-08d945c050b1 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2021 05:37:33.8496 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RgXDjBYKUf7lq7T7oZvcMAENA/aIo1b331ZIQgU/ywELiqEcnqiYpflcOGDVksaZc0PwamEDxAPDH5U9T1qqRg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5687 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3] app/testpmd: fix offloads for the newly attached port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: stable On Behalf Of Viacheslav Ovsiienko > Sent: Monday, July 12, 2021 20:41 > To: dev@dpdk.org > Cc: Singh, Aman Deep ; > arybchenko@solarflare.com; stable@dpdk.org > Subject: [dpdk-stable] [PATCH v3] app/testpmd: fix offloads for the newly > attached port >=20 > For the newly attached ports (with "port attach" command) the default off= loads > settings, configured from application command line, were not applied, cau= sing > port start failure following the attach. >=20 > For example, if scattering offload was configured in command line and rxp= kts > was configured for multiple segments, the newly attached port start was f= ailed > due to missing scattering offload enable in the new port settings. The mi= ssing > code to apply the offloads to the new device and its queues is added. >=20 > The new local routine init_config_port_offloads() is introduced, embracin= g the > shared part of port offloads initialization code. >=20 > Cc: stable@dpdk.org > Fixes: c9cce42876f5 ("ethdev: remove deprecated attach/detach functions") >=20 > Signed-off-by: Viacheslav Ovsiienko > --- > v1: http://patches.dpdk.org/project/dpdk/patch/20210619154012.27295-1- > viacheslavo@nvidia.com/ > v2: http://patches.dpdk.org/project/dpdk/patch/20210712102440.12491-1- > viacheslavo@nvidia.com/ > - comments addressed - common code is presented as dedicated routine > v3: - uninitialized socket_id issue (reported by CI) > - removed dead code for port_per_socket from init_config() >=20 > app/test-pmd/testpmd.c | 151 +++++++++++++++++++---------------------- > 1 file changed, 68 insertions(+), 83 deletions(-) >=20 Acked-by: Xiaoyun Li