Re: [dpdk-dev] [PATCH] app/testpmd: support the query of link flow ctrl info

["Li, Xiaoyun" <xiaoyun.li@intel.com>]

Hi

> -----Original Message-----
> From: Min Hu (Connor) <humin29@huawei.com>
> Sent: Monday, April 19, 2021 14:41
> To: Li, Xiaoyun <xiaoyun.li@intel.com>; dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>
> Subject: Re: [PATCH] app/testpmd: support the query of link flow ctrl info
> 
> Hi,
> 
> 在 2021/4/19 10:53, Li, Xiaoyun 写道:
> > Hi
> >
> >> -----Original Message-----
> >> From: Min Hu (Connor) <humin29@huawei.com>
> >> Sent: Thursday, April 15, 2021 14:47
> >> To: dev@dpdk.org
> >> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Li, Xiaoyun <xiaoyun.li@intel.com>
> >> Subject: [PATCH] app/testpmd: support the query of link flow ctrl info
> >>
> >> From: Huisong Li <lihuisong@huawei.com>
> >>
> >> This patch supports the query of the link flow control parameter on a port.
> >>
> >> The command format is as follows:
> >> show port <port_id> flow_ctrl
> >>
> >> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> >> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> >> ---
> >>   app/test-pmd/cmdline.c                      | 83
> +++++++++++++++++++++++++++++
> >>   doc/guides/testpmd_app_ug/testpmd_funcs.rst |  7 +++
> >>   2 files changed, 90 insertions(+)
> >>
> > <snip>
> >> +	printf("\n%s Flow control infos for port %-2d %s\n",
> >> +		info_border, res->port_id, info_border);
> >> +	printf("FC mode:\n");
> >> +	printf("   Rx: %s\n", rx_fc_en ? "On" : "Off");
> >> +	printf("   Tx: %s\n", tx_fc_en ? "On" : "Off");
> >> +	printf("FC autoneg status: %s\n", fc_conf.autoneg != 0 ? "On" : "Off");
> >
> > "fc_conf.autoneg ? "On" : "Off"" is enough like the others in this patch.Got it.
> >> +	printf("pause_time: 0x%x\n", fc_conf.pause_time);
> >> +	printf("high_water: 0x%x\n", fc_conf.high_water);
> >> +	printf("low_water: 0x%x\n", fc_conf.low_water);
> >> +	printf("Send Xon: %s\n", fc_conf.send_xon ? "On" : "Off");
> >> +	printf("mac ctrl frame fwd: %s\n",
> >
> > Follow others' format will be better like "Send Xon".
> > "Forward MAC control frames:"
> > I don not catch  your meaning. Is that right?:
> change the statement

I mean change the statement as: 
printf("Send Xon: %s\n", fc_conf.send_xon ? "On" : "Off");
printf("Forward MAC control frames: %s\n",fc_conf.mac_ctrl_frame_fwd ? "On" : "Off");

Keep the same format.

> "
> +	printf("Send Xon: %s\n", fc_conf.send_xon ? "On" : "Off");
> +	printf("mac ctrl frame fwd: %s\n",fc_conf.mac_ctrl_frame_fwd ? "On" :
> "Off")
> "
> to
> 
> "
> +	printf("Send Xon: %s\n", fc_conf.send_xon ? "On" : "Off");
> +	printf("Forward MAC control
> frames: %s\n",fc_conf.mac_ctrl_frame_fwd ?
> "On" : "Off")
> "
> 
> >> +		fc_conf.mac_ctrl_frame_fwd ? "On" : "Off");
> >> +	printf("\n%s**************   End  ***********%s\n",
> >> +		info_border, info_border);
> >> +}
> >> +
> > <snip>
> >>
> >> --
> >> 2.7.4
> >
> > .
> >