From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE7A3A0547; Mon, 19 Apr 2021 10:04:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 338A340683; Mon, 19 Apr 2021 10:04:23 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 3F00040040 for ; Mon, 19 Apr 2021 10:04:21 +0200 (CEST) IronPort-SDR: ZEj2bNBR2O4fV0QoY/QBKeSTYBAl5mVbLNFraN0lDCrFCBBHG2333KvWAu0qmlGCtf19+NiokI OHm6IdHVL8GA== X-IronPort-AV: E=McAfee;i="6200,9189,9958"; a="259244285" X-IronPort-AV: E=Sophos;i="5.82,233,1613462400"; d="scan'208";a="259244285" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2021 01:04:19 -0700 IronPort-SDR: S89gbt78Dd6tEX/YGLdVdyKxBPM+9YQlUw1VJScIs0XkHsNqWLCb9Tm9upIT3SB0BWSJ9/neTS civPVRo+FeiA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,233,1613462400"; d="scan'208";a="384900106" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga006.jf.intel.com with ESMTP; 19 Apr 2021 01:04:19 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 19 Apr 2021 01:04:18 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 19 Apr 2021 01:04:18 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Mon, 19 Apr 2021 01:04:18 -0700 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.54) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Mon, 19 Apr 2021 01:04:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dK/ijbM4yuT+aLswC4b0/ZmAq8fHRtyRiGSOEN7BZpYx1yeSshiolOgHJC54RwcUPQd4l285qHMQpTjMxbHw66CoB72AP0BczEWwkePbRz95apbpMz9vK/Qnax5vIEbemuxt0cai+0rzxXCiJojw9Vco2/ofUmaaRge0sE2A6KWeA2GWrw6yaGK/TpBMwtFSRwq3hRNfdx053p/4QJuPlYfbcXa+TCyNJtQVpnMKTUQHwL0XVl/fcO73ziVfhNCUvFeFgntfJThlmF114hzDWz2FP7dSvX6DXhcxXgGKDEYA1zhFcM5Um3i9bbmr+QOcxITQhsnnctERebCOD2dilA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jjg4O4Khk9+dnvtUYvLKZrCpL2a4XiFTeHvKVob5x1g=; b=jAROhcyDlCTv086RlmVCjYq/hdgsbTNSV22KVQgJjr+bjraVx0mT2dhfZagYIzGxBDs3JGO3z0gMXaBpSNPRxsfobCRDTx7QD/Sh1lj6Opp8g0o/DnKXOHsumlRffYQPWW+O0zMRQ3JAGDcvp4rnLSBgsQIEO1qevN1KFHcvKnNcRJoR5j7vrBVWZOFdoyVQrBrC+CRgQ5ZeNEZRZIXRBK+KVJi+QC4hkGPeNE9+swKbGIe9ZtncLqfyIJBRv10kcmBVwf3F6YMPa4q8w9rZzrnzYsSdER5mDTW0VQlKK9VKHeFFsPdUsikB1XrbZXlH2RHuaD0bgN/LR6sbea03mQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jjg4O4Khk9+dnvtUYvLKZrCpL2a4XiFTeHvKVob5x1g=; b=XiVTiPO2kLD3AYOXfSDe3l+EPS3PveXTvKGrGFE6FSXMWC8DAcPPB8Gt4Szc/SXtsmxnlCk15ebGgXH3+7zPfTpv3AnWvg1GbpJN7J0yZVPgDaebK9kPC+3a2MvH/N27K8WQ0GZl0bgiCgio8qAZ3hvdQQuAiCM8fDqWsOKs8qI= Received: from DM4PR11MB5534.namprd11.prod.outlook.com (2603:10b6:5:391::22) by DM5PR11MB2041.namprd11.prod.outlook.com (2603:10b6:3:d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16; Mon, 19 Apr 2021 08:04:05 +0000 Received: from DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::79a3:3404:b907:d49c]) by DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::79a3:3404:b907:d49c%6]) with mapi id 15.20.4042.024; Mon, 19 Apr 2021 08:04:05 +0000 From: "Li, Xiaoyun" To: "Min Hu (Connor)" , "dev@dpdk.org" CC: "Yigit, Ferruh" Thread-Topic: [PATCH] app/testpmd: support the query of link flow ctrl info Thread-Index: AQHXMcNZTP6BuWtQnU+BRLAEp7/s8Kq7J58ggABCwoCAABabAA== Date: Mon, 19 Apr 2021 08:04:04 +0000 Message-ID: References: <1618469214-35316-1-git-send-email-humin29@huawei.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.54] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b220799f-3620-4a89-2072-08d90309b375 x-ms-traffictypediagnostic: DM5PR11MB2041: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1013; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Fq2m6518Ymj09a19U4n8E5pcJiTvsPEkxjvD4JrwxUZZF7i33nGvvq5pixaKPZD3eMadx6mM+sabZXxEVwihn2Gv/DKaZs3Tldp3pqyeGIqJgRKxcZ96YdgPvery9emaT+IQjGqolvlCJoIDkdd2dU3KN7d1XwL9G6pRGYhY7dzI11VKYc1RTRbbQXEhwh4sg2yLzEWjv/ZMyVGcz4PLvsedSEPnEcufGgO1mowiHpU4q6nyiCI8u20FrhFKHt8irwxULdRl4RfApz6AQdjvgbytPU+Be7xZiTbksFfXhgs9dRy4rgDULjpg4oqn6ZtNLyhE+v3ZZbAWYrnhxrp2TyuOXD3zNjxyBuvfVBj2h/p8uIHWWssgIprGqhvfKyRw52kcDFkGib/bLgzjKLXJwHCsSB9YazyD4cY7AGgDBX6nBilxNbIIjyFVnO8kdySNoG621Qy81vvvqqtdvAMvRVox+IDQc8nav4Dz0lbh8rqCLsa0kao6SPKyDPIJoYeucPFtXhMK0ma49aR8ppFLhuyrOTcsnbsmRe/2Z1LAtwRIhH9vXqalodBah7UreZCHIs6cVKy9LXaFDi1HCL3b/T6lM4cPiKU1+/f+lqJV0sE= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5534.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(376002)(136003)(366004)(396003)(39860400002)(7696005)(76116006)(6506007)(107886003)(8936002)(478600001)(33656002)(53546011)(66946007)(2906002)(66446008)(316002)(5660300002)(122000001)(26005)(38100700002)(83380400001)(8676002)(186003)(66476007)(55016002)(4326008)(110136005)(66556008)(52536014)(86362001)(9686003)(71200400001)(64756008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?iso-2022-jp?B?SGx3dEVVUjc3WUhmamY3RUtOYnpMbzl4NVE4T1VKZnpwNUt0WmdVVkdH?= =?iso-2022-jp?B?MVZUUGlDaXZoaCt0N1k3NjRlMkRCeGRVMWU0d2hqOXhLU2dSUHJ3a0k4?= =?iso-2022-jp?B?SkFQMDY1aURTM1lkWmFic1FJYkZ2dnlSV2dpVDROaUFOU2thZVlEWFJ6?= =?iso-2022-jp?B?a0tkQ25kdHdXTFFEY2c3a0VYamtCSlRuMlJqNHV0RWVrV08yVk1Zbk5v?= =?iso-2022-jp?B?cDF6aW11MjlHVXhaVVNOdmF5Wk5Rdng5L1YxMUdVdlg5OGtzSmUwekM2?= =?iso-2022-jp?B?RXdvSEZWMGJuZlRzK2FSV2hJREx4ekVGaTBTQTdWR3lLSjJCVnZkVlJs?= =?iso-2022-jp?B?S1pSaE1OWis2RkNFcis2SmFuYTJpUmxDa3AxWWZZb1JCRDBuT3NwM1dM?= =?iso-2022-jp?B?ZU9xMnY0anJaTW5id2Nqc2VnbjRpSXptSU5xRGZGZUJRUGJTMGt0MjRh?= =?iso-2022-jp?B?WUNaVW1ud3hVTGN3cStoQzRPWW0zU251KzR4dnJyTWJWckpHV0svUmhH?= =?iso-2022-jp?B?Yy9ObjNYVkJNT3pXUTR3VzRmVnNETEMvQVY2ZW1kQjJHQVlBdDZCL1Y0?= =?iso-2022-jp?B?bTN5STF1UmtGblM1RG5OVXJhWk5BV3Rub3Z6TkQrd05YdEtaWWlPUU9k?= =?iso-2022-jp?B?elF1NEVFUmxTKzNiRWliMHNvNlI5MDMrZUdVZTFZenllY3dla2V3SFEw?= =?iso-2022-jp?B?RXRYdXV2SENNeGR1aEZCOG4rdVhQR0F5ZllBakt3YlNaZHVOMlRvaXV6?= =?iso-2022-jp?B?b0sxWXlrVWFuRGQvZEJGWktvRzNIVkN0d3JzYWxJcmptc1ZBTnB6UHRh?= =?iso-2022-jp?B?VG1TVkhFUUczQVh4NWE1TDR4ZWoxZWhNcGwxSE1zZHJrSjg4U0ZsRk5y?= =?iso-2022-jp?B?T29zSHFtSkc3OHNqallhVnlodkFrVzdnb0pNZ2gvWkt3alEwVFl1bmtB?= =?iso-2022-jp?B?RUMwVjhCdkdLOEdJZmxvL3UzWW1WWDJjL1FqMkRXOEFYazNDR3lHTzNk?= =?iso-2022-jp?B?ZkJ0bkVaY2hORXA0dG1QK1VyWURxZ0s2TDVCcmZLaGhmMjIzV0x5aEF1?= =?iso-2022-jp?B?M0JmQTBXSnVVZmtsYWp1WEc4SmNFV3dENk0vWVB2YkZicnVxN1lFS1hO?= =?iso-2022-jp?B?TytSb2c0YXl6OUl1YlhhVk81cVRPdnZuYWlmaW1sZDhjVWJWZWZGUTlH?= =?iso-2022-jp?B?clpyTHF3cy85TkNWNlJqMXNSM2ZGdzFxUFVubXpJcGEyS1pyT2JnMnBX?= =?iso-2022-jp?B?TGxKR1lGR3BneDJWZDJ1YUtkdURtZjBFQzhSdGFLTkZ5bFFjei9ic3JF?= =?iso-2022-jp?B?NUliOTRKQThIQmg4ajJ1cHl1Mk1HL0RJejMvTHBKRXRaWmdodGNSRkY0?= =?iso-2022-jp?B?aVlreXhHSTk5RGorKzEvSDQ2SkNhSXNac2wrbUhmL1o3SzNhc1NVb1pn?= =?iso-2022-jp?B?dnJzU0c1UmdkS2RaOExTa2dRc2xkK01aRGg3c0hSR3dmN0trWW9wQ2JX?= =?iso-2022-jp?B?NmxvOFVjejQ0VTRDU05taC9iZE80aVNPSmZYQkpNRzl3RmJKQk8rMHFS?= =?iso-2022-jp?B?dFVjNUhrMnFTVFcwZ2o4eUEyU21rd2sxNFJGMEVwbThpdENtdUp4ZTVZ?= =?iso-2022-jp?B?NkhYTnlRcUUyam15SXBTVHpTaUVYcUxBNEZPTDBYL00vMVdoVTVJbWM1?= =?iso-2022-jp?B?aThvL3dzRnYxSVpaanFWVUE4eENaNmJGM1V1UGU0OFRaK2tJdSt2anAr?= =?iso-2022-jp?B?S3Y4cjVsN2h1SEVPYll0aGZzM0J4YlgyblY1aTRhemZZdlN6dm11Rm45?= =?iso-2022-jp?B?cVZXcS9PeU9JRnZMWjNKY1R2Z0tKcGJkT1lVWmM2ZlhHQmFMN2s0V0Z4?= =?iso-2022-jp?B?Zk81TzBxelJ1cGNsNDVibzlUa0ZzPQ==?= Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5534.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b220799f-3620-4a89-2072-08d90309b375 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2021 08:04:04.9285 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wG8rk9A6DmO1haGTTVqP2CoNJXdGLYUnVf81wsM6rTiKmTJQero0qYNmKlG3mSoV7yP9K8cv7aR2J7pHreN8iQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB2041 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support the query of link flow ctrl info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi > -----Original Message----- > From: Min Hu (Connor) > Sent: Monday, April 19, 2021 14:41 > To: Li, Xiaoyun ; dev@dpdk.org > Cc: Yigit, Ferruh > Subject: Re: [PATCH] app/testpmd: support the query of link flow ctrl inf= o >=20 > Hi, >=20 > =1B$B:_=1B(B 2021/4/19 10:53, Li, Xiaoyun =1B$B > Hi > > > >> -----Original Message----- > >> From: Min Hu (Connor) > >> Sent: Thursday, April 15, 2021 14:47 > >> To: dev@dpdk.org > >> Cc: Yigit, Ferruh ; Li, Xiaoyun > >> Subject: [PATCH] app/testpmd: support the query of link flow ctrl info > >> > >> From: Huisong Li > >> > >> This patch supports the query of the link flow control parameter on a = port. > >> > >> The command format is as follows: > >> show port flow_ctrl > >> > >> Signed-off-by: Huisong Li > >> Signed-off-by: Min Hu (Connor) > >> --- > >> app/test-pmd/cmdline.c | 83 > +++++++++++++++++++++++++++++ > >> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 +++ > >> 2 files changed, 90 insertions(+) > >> > > > >> + printf("\n%s Flow control infos for port %-2d %s\n", > >> + info_border, res->port_id, info_border); > >> + printf("FC mode:\n"); > >> + printf(" Rx: %s\n", rx_fc_en ? "On" : "Off"); > >> + printf(" Tx: %s\n", tx_fc_en ? "On" : "Off"); > >> + printf("FC autoneg status: %s\n", fc_conf.autoneg !=3D 0 ? "On" : "O= ff"); > > > > "fc_conf.autoneg ? "On" : "Off"" is enough like the others in this patc= h.Got it. > >> + printf("pause_time: 0x%x\n", fc_conf.pause_time); > >> + printf("high_water: 0x%x\n", fc_conf.high_water); > >> + printf("low_water: 0x%x\n", fc_conf.low_water); > >> + printf("Send Xon: %s\n", fc_conf.send_xon ? "On" : "Off"); > >> + printf("mac ctrl frame fwd: %s\n", > > > > Follow others' format will be better like "Send Xon". > > "Forward MAC control frames:" > > I don not catch your meaning. Is that right?: > change the statement I mean change the statement as:=20 printf("Send Xon: %s\n", fc_conf.send_xon ? "On" : "Off"); printf("Forward MAC control frames: %s\n",fc_conf.mac_ctrl_frame_fwd ? "On"= : "Off"); Keep the same format. > " > + printf("Send Xon: %s\n", fc_conf.send_xon ? "On" : "Off"); > + printf("mac ctrl frame fwd: %s\n",fc_conf.mac_ctrl_frame_fwd ? "On" : > "Off") > " > to >=20 > " > + printf("Send Xon: %s\n", fc_conf.send_xon ? "On" : "Off"); > + printf("Forward MAC control > frames: %s\n",fc_conf.mac_ctrl_frame_fwd ? > "On" : "Off") > " >=20 > >> + fc_conf.mac_ctrl_frame_fwd ? "On" : "Off"); > >> + printf("\n%s************** End ***********%s\n", > >> + info_border, info_border); > >> +} > >> + > > > >> > >> -- > >> 2.7.4 > > > > . > >