From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F29C3A0546; Tue, 27 Apr 2021 11:21:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B564240150; Tue, 27 Apr 2021 11:21:00 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 0035D4003E for ; Tue, 27 Apr 2021 11:20:58 +0200 (CEST) IronPort-SDR: mg3Y73TdgF6zsibpbpn2eeCDrw1gLi6K1KdLQy53OvjNLquuS3Lx1xwmQhJKlikjP5jB81ttut Glf+dgYcQGAA== X-IronPort-AV: E=McAfee;i="6200,9189,9966"; a="183614883" X-IronPort-AV: E=Sophos;i="5.82,254,1613462400"; d="scan'208";a="183614883" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2021 02:20:57 -0700 IronPort-SDR: YZFtiksw2ys5jo9fl5PkrCZloNSrsa7AZYk3tBnlEN9LxgcWOvbEjT0fUDqIjeRVT0mfdEltkf Zwt6WzTXUBrQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,254,1613462400"; d="scan'208";a="422986260" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga008.fm.intel.com with ESMTP; 27 Apr 2021 02:20:57 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 27 Apr 2021 02:20:57 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 27 Apr 2021 02:20:56 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 27 Apr 2021 02:20:56 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.170) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Tue, 27 Apr 2021 02:20:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B1fL2gHC+lqpMYfHDc9MPemjYJNYPV66pbyOgO+7fKjIuI0bH4c058t09XadY5qJh2VONeKqyUtyc1+cRnZYL07CqiMPWRvLvUYo0T5ctq9XcHrC8w4xwy+z5ghJLd7biqJTQwP42BWDk7uQOGjxpQeWEXbXiPR9TTkTBX19yhxgrvgTDtVV4uLM/TQf6DzBaFaa3ILFA9KUX6lySrTQqb5iyn9LYSFvawLwyESCjm8vtYqNJefsYB84OTVBZ1OKHtAr/9KUuEmGw0lMQdPLG8A6FS/uy+6yBq8Rt+bWz4wuPsoOO9xtEPycnvsRYz2G/BrZ3iNIuYGdY70q+n+JvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Bt1wSicX3v6O90DpjpNPXui2l63g17CJXYD36u5KMfQ=; b=P30q/mB168oDkyQLULmCuhfplXXtIZEOWU9r+6U8MAwkDGm+czM/xokAER/Ciib3JhnD6w/pyN1kvxO/3NsyCzwI/FtfvwL1GVXYBiW2aNDiY8sMNpZrjkLdOFuSaUHEFmRzom25JfrnB2KyxvaDsYo8T7/dTOdcQtXxnrlHlSdtIMaBEmjhSPiMG6qYeYtyU80asE6hM/H0/lXD/Yv+HZmuCWtOvoLw1cfzgehVcMHCs5UaaiTo6ZZbTO9S6gk4z6eFAcKusmnL2/M2zrx9JT4jwQ7zijdc7lrmoN9yfkIt8Kp9svJXDVnRboFCS5CLIWkTArS6xyayd/e1NlRBgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Bt1wSicX3v6O90DpjpNPXui2l63g17CJXYD36u5KMfQ=; b=TMbdcW/PB0ZRPBGjj2z72YsJxyHzko53HLnT3ldYjwwJ4ATh11e/TNDowYiqDfuzrMsaGHO+0Yfbr3DuU30JGjbxK29edpQbICzPOBxIOARrWNeqBTeywp7THp/hFGh2FvOYKzaO80faBqZmswhRjdBfEn4qatgYxG5jo898X3k= Received: from DM4PR11MB5534.namprd11.prod.outlook.com (2603:10b6:5:391::22) by DM6PR11MB4490.namprd11.prod.outlook.com (2603:10b6:5:1df::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.23; Tue, 27 Apr 2021 09:20:53 +0000 Received: from DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::9034:15e:7cf3:4b78]) by DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::9034:15e:7cf3:4b78%4]) with mapi id 15.20.4065.027; Tue, 27 Apr 2021 09:20:53 +0000 From: "Li, Xiaoyun" To: Huisong Li , "dev@dpdk.org" CC: "Yigit, Ferruh" , "linuxarm@openeuler.org" Thread-Topic: [PATCH V2 1/7] app/testpmd: fix forward lcores number when DCB test Thread-Index: AQHXNbdbN0Pkp5tNeECUysLE8RF13arIH5aw Date: Tue, 27 Apr 2021 09:20:53 +0000 Message-ID: References: <1614939741-63927-1-git-send-email-oulijun@huawei.com> <1618903926-29099-1-git-send-email-lihuisong@huawei.com> <1618903926-29099-2-git-send-email-lihuisong@huawei.com> In-Reply-To: <1618903926-29099-2-git-send-email-lihuisong@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.53] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2c017066-c183-4dfc-5ba7-08d9095dc195 x-ms-traffictypediagnostic: DM6PR11MB4490: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: j9mwLnpLvM58tiHBDMHT4tthna45NQCAHUKG/gGehxLTiuTFYkqnvBzLUkCn9PKCgCcI6CoHIz7UnTr5+z2rqBCoqUg23uUo/IrC6M4NeaASLUy1h51pog2gfneZL+orTnCoUN7KlAVTP7gvubX08chbkvTy03s6O9Jm/4wNyXL3Vu4QOgEWVpnA+KLOI1mMslRW/gqwdavdIAFkgEwLyTLavIeLAQ0VD7/NwZCfjrTwDZdmD3Wnyj2qJBnvZoJKYV6+XMn6GwYhQsZIbkhKMp8YdpWpmBupD6SDQ/orzEoffXF/QO4mVLYUfXX/MpG5Isw1k1JakLJJu+LP0030NjSHM3Q11JgYLWDpmio7jCv+MTDf5bX9TZxkiA+j2kOpwPB++XwTROtixWU+CqOPGmm6XtBTk9tp1+Z6x4PSGJY+SZh+++FMMZePIdhNBnfC38g2W47xeuYHhVtJwCUmeEx3LhMH3IHw5rj16YyO+8EXNuDmBVV0U7NYVSVRMxH0BDsVZfChi+jY83EVlBp3tZh+E9ZPrz2T4mA5kTYjjk3ypA1qzNXkYcj0juKnLXSVTFGRjPyDlh0dY9qcL9IE4d/DMIi23yyFO7MEScQ86Rk= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5534.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(39860400002)(346002)(376002)(396003)(366004)(33656002)(71200400001)(7696005)(5660300002)(38100700002)(83380400001)(186003)(4326008)(478600001)(26005)(9686003)(66476007)(55016002)(86362001)(66556008)(2906002)(8676002)(8936002)(122000001)(316002)(110136005)(66446008)(66946007)(76116006)(52536014)(53546011)(54906003)(64756008)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?oiuZ97g1jENR6G5JkOPF046BfZOzzA4eZ2h1nX/NR130JQAt7db1QJCvwphm?= =?us-ascii?Q?HYo9w+f/a3klPcAxOGxE3oxOHwnNfmu/gNdkvhgpPgoMpId3yaGkKymTr7lM?= =?us-ascii?Q?a8VtM3XtROqf/6pW/NSC9VLcowZ4xvuk8OsH7/wA/zaujngRGZgNtMSL9Wx5?= =?us-ascii?Q?sREYkFzyaZfbQFgGLlOs+1Y3ZWgnPk6FqqOrZmwlkYw3GRoqVYqjmdZhPvxi?= =?us-ascii?Q?akdZE835uxPmhKu1G3vyJ7XbTuKmk25GcpRogW9pG6ZP/J52LzUXp6OVi5Qf?= =?us-ascii?Q?pHSxTPcE3YZc9fyLW9ZsEhlZFob8OJD1rRmlRzodROUnwACRT6ccuBhv4eN9?= =?us-ascii?Q?5GiedcKhx4FOQgIkToWeo9955vcEtz43/n8Rs97smxq18ksEW+vNJIgJ1APW?= =?us-ascii?Q?ZxnxmdU+8i/zt3Vg8JdXd/ATmadRvMepAwonQPW9UFwFM9V05sMzzJwI4aMt?= =?us-ascii?Q?B2iba+eY8BQEvjxqCTH1pQ8n+KW6nZctJV4WBk5zQPi54B0tcHp9DbqYY8Ii?= =?us-ascii?Q?sM+OEpJBahcAYgUO4Or2XBrpyRTqYxi9tVLl0f9l0bc2wp6bGEtxY1Rm8dh8?= =?us-ascii?Q?uLHpzNdg/l4H/TkuI6MjAPnEch7GAocJS4qDRfmKJnjoPU3qDsC8fKdUTHAS?= =?us-ascii?Q?iFSsL2bhWIw26T2ZSfnHzReOr8Xulnwcihu86/uG9UFlLxf/mUrseC2sBdIT?= =?us-ascii?Q?rgq/4tYoTj0e1FuAeeFyrUrwqD1PcAcB1Z3wIIjw2xpXwhArK01wJ/tdp8dh?= =?us-ascii?Q?L1Y/YZCdO6fpm7ITrbhLzniUdCO0M6UDNssKX108xi9Ga+N01IqJ1HuN8s1D?= =?us-ascii?Q?8K8LKBhQqhfUSbOrXGtFRpQI8zdwyY1QyhLVA+icwJYJY+6iRmQm2XUT6kLD?= =?us-ascii?Q?1M7l5bhrZ6fYknNlFZbK+8PbE3TK6OQBWC/yl6XpKkFDB99Tdcxptds9csh0?= =?us-ascii?Q?hkGVuNh4HJb0tCz/PbGhh7G2yZ2qJ2aLX5K6wTXMMn48454zyiI7cbzBezMy?= =?us-ascii?Q?a9YXg8AH0WHd3gM90k2epfhPXfy85xFyqdBoIcjBtPPFj2veZG+36H6yOg13?= =?us-ascii?Q?g+tZnSFvv4ViQRVC2HS9KflZytTvfCvdxlqvYMQA+0Tq+q3mZJB5P7DiFDDZ?= =?us-ascii?Q?LXFL0gQ2iTh16GX+2lRakClXV5jevrDy592wZyLKcsdrMLJTd5cuOHi+fsx9?= =?us-ascii?Q?rZJWThJgN89WIfaCaRZxcJqYnN3f+KsPsXR56Dr7hAZwxSiQjoAQ7alqoOgZ?= =?us-ascii?Q?HC5DlnzmNbCW7zD5Nm1n9b60m7DMdGW4D8rerX4yk8V25tEKj8A8a8d0lY57?= =?us-ascii?Q?MQlzeRZHkY76XwwhSZ+aU0ut?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5534.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2c017066-c183-4dfc-5ba7-08d9095dc195 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2021 09:20:53.2900 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1aIb3ZnWXf64zSaIZ4y4uc6RsjrYprxKwHW0069S4FWFeNV55LD4H8fX14Pt3fRNVMTL9f1sQe3bf/wn6el8bA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4490 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH V2 1/7] app/testpmd: fix forward lcores number when DCB test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Huisong Li > Sent: Tuesday, April 20, 2021 15:32 > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Li, Xiaoyun ; > linuxarm@openeuler.org; lihuisong@huawei.com > Subject: [PATCH V2 1/7] app/testpmd: fix forward lcores number when DCB t= est >=20 > Currently, 'nb_fwd_lcores' value are both adjusted based on 'nb_fwd_strea= ms' in > rss/simple/icmp_echo_fwd_config_setup. > But the operation is missing in dcb_fwd_config_setup, which may lead to a= bad > behavior in which multiple polling threads operate on the same queue.=20 This patch is OK. But commit log is redundant and confusing. The above is enough to explain what your patch is doing and can even be mor= e simple. >In this > case, the device sends and receives packets, causing unexpected results. = The > procedure is as follows: I don't understand what you're saying here. The commands you're showing is = 8 nbcores dealing with 16 queues. So it's one thread dealing with multiple = queues which doesn't have issues at all. Please remove the useless and confusing commands. > 1/ run testpmd with "--rxq=3D8 --txq=3D8" > 2/ port stop all > 3/ set nbcore 8 > 4/ port config 0 dcb vt off 4 pfc on > 5/ port config all rxq 16 > 6/ port config all txq 16 > 7/ port start all > 8/ set fwd mac > 9/ start >=20 > For the DCB forwarding test, each core is assigned to each traffic class = and each > core is assigned a multi-stream. > Therefore, 'nb_fwd_lcores' value needs to be adjusted based on 'total_tc= _num' > in all forwarding ports. Please refer to the RSS fwd config fix patch to write your own commit log. = Use simple and easy-understanding words to explain yourself. Below is the reference of RSS. commit 017d680a91fcf30da14a6d3a2f96d41f6dda3a0f Author: Pablo de Lara Date: Mon Jun 27 23:35:19 2016 +0100 app/testpmd: limit number of forwarding cores Number of forwarding cores must be equal or less than number of forwarding streams, otherwise two cores would try to use a same queue on a port, which is not allowed. >=20 > Fixes: 900550de04a7 ("app/testpmd: add dcb support") > Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings") > Cc: stable@dpdk.org >=20 > Signed-off-by: Huisong Li > Signed-off-by: Lijun Ou > --- > app/test-pmd/config.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) >=20 > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index > ccb9bd3..03ee40c 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -2961,6 +2961,21 @@ rss_fwd_config_setup(void) > } > } >=20 > +static uint16_t > +get_fwd_port_total_tc_num(void) > +{ > + struct rte_eth_dcb_info dcb_info; > + uint16_t total_tc_num =3D 0; > + unsigned int i; > + > + for (i =3D 0; i < nb_fwd_ports; i++) { > + (void)rte_eth_dev_get_dcb_info(fwd_ports_ids[i], &dcb_info); > + total_tc_num +=3D dcb_info.nb_tcs; > + } > + > + return total_tc_num; > +} > + > /** > * For the DCB forwarding test, each core is assigned on each traffic cl= ass. > * > @@ -2980,12 +2995,16 @@ dcb_fwd_config_setup(void) > lcoreid_t lc_id; > uint16_t nb_rx_queue, nb_tx_queue; > uint16_t i, j, k, sm_id =3D 0; > + uint16_t total_tc_num; > uint8_t tc =3D 0; >=20 > cur_fwd_config.nb_fwd_lcores =3D (lcoreid_t) nb_fwd_lcores; > cur_fwd_config.nb_fwd_ports =3D nb_fwd_ports; > cur_fwd_config.nb_fwd_streams =3D > (streamid_t) (nb_rxq * cur_fwd_config.nb_fwd_ports); > + total_tc_num =3D get_fwd_port_total_tc_num(); > + if (cur_fwd_config.nb_fwd_lcores > total_tc_num) > + cur_fwd_config.nb_fwd_lcores =3D total_tc_num; >=20 > /* reinitialize forwarding streams */ > init_fwd_streams(); > -- > 2.7.4