From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E98EEA0C4B; Sat, 18 Sep 2021 10:20:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B0B2140041; Sat, 18 Sep 2021 10:20:13 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id B4CBE4003D; Sat, 18 Sep 2021 10:20:12 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10110"; a="210016073" X-IronPort-AV: E=Sophos;i="5.85,303,1624345200"; d="scan'208";a="210016073" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2021 01:20:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,303,1624345200"; d="scan'208";a="453524164" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga002.jf.intel.com with ESMTP; 18 Sep 2021 01:20:11 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Sat, 18 Sep 2021 01:20:11 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Sat, 18 Sep 2021 01:20:10 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Sat, 18 Sep 2021 01:20:10 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.173) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Sat, 18 Sep 2021 01:20:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bPkjcejr6GnzygF1Z0ORkQWQbERCqat2B3SiAGgcRKc/Nr61nC6ZU5T4VKZp/NWG0aYkRKClIZ/5Sg/YWILcd/Tz7aLBdkxugFexS7hc9I2L/lVjKPFZG3mLZTTJZqoG1KEkFXq0xneFSyFE/HMZSK/1e3GIE+u9MbN8dtNMGikZXXBdejxcZ9XEu3NVdf0aVK1rygeLYbJj1JdKEnagsQNDRaq3OHE6+qUAcS1pe95A4cMT7vB/FL4Jm98XgXUBoWdHJXpIOW8ZDwDES1oGiJsJ1yzppQ5To1DNYZUNS7VOsTI+Dph+Eq/QY5nkwmY522sUIuKzTRY3/xGC6LU4mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=HVZC8kroBSdto5qqlZt5IbPerqEWKsIskxjvoSLxhUQ=; b=WvGeZ6URipHKx7f2z14O3eQgs0NGIgBCy3Uf0JWlDcHu1oYtXdKkhEOrlNdPZMAGQT+jzI0TAn8JuEwjkvuTxKS49ax2ZEZCKZ41+0A06n8X9PeXzBPGRJva68pTG5xtql4qxATL3EonyRMHgq3mSJ+V9WriMpup5r1MwCc6BJ8Z4dAi/WCSeJsiCvkXnUGyvslPNO0tTrqzzP3+x5IfNrJmFlo3dzVRlr2jlVR/pEFuh0OHHmJQBMobVh4vEOLGkFpQefrKsdE56bA4TvXsMhlNQT3dLhQ1YmAJhJRcltkZYWsAhBhWv+Qg+eVVev0H58TQmudYBFK2OOsrcV4R8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HVZC8kroBSdto5qqlZt5IbPerqEWKsIskxjvoSLxhUQ=; b=T0AHL0IgeSPaM5l+O+vt9Psz/VotsqTgMMOYI9LY7dRNG51Sy25InCCHpWaw0x5GR5UzM/H7TaMmGEZBOeOERQ3GAeg/LN3DbAaWgUhjq9WNytO61NE89htitBMpMc79tKffvtzid+3Ghvv61avoMtQ8+IUdODJd+gFIlo139k4= Received: from DM4PR11MB5534.namprd11.prod.outlook.com (2603:10b6:5:391::22) by DM6PR11MB3529.namprd11.prod.outlook.com (2603:10b6:5:63::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Sat, 18 Sep 2021 08:20:09 +0000 Received: from DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::3d9b:76d7:e274:bad3]) by DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::3d9b:76d7:e274:bad3%3]) with mapi id 15.20.4523.018; Sat, 18 Sep 2021 08:20:09 +0000 From: "Li, Xiaoyun" To: "Zhang, AlvinX" , "Ananyev, Konstantin" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v3 2/2] app/testpmd: fix txonly forwording Thread-Index: AQHXrDpImc8IdLQZzEutqRPrLqaunqupcnTQ Date: Sat, 18 Sep 2021 08:20:09 +0000 Message-ID: References: <20210917013923.4004-1-alvinx.zhang@intel.com> <20210918030659.12448-1-alvinx.zhang@intel.com> <20210918030659.12448-2-alvinx.zhang@intel.com> In-Reply-To: <20210918030659.12448-2-alvinx.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 49fea28d-8e93-4298-4b4c-08d97a7d211f x-ms-traffictypediagnostic: DM6PR11MB3529: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Iw1Pqut4OQiIQLvi2+VxeSqv4A490BbEQkMeMaEyMyYjDApZbPmCtYwUW3/pibaxDzKoEeTu2Q4XkX5u+Fzdy4EnBLvmHalaWxWX2gFB49SJWB5WQ9oZsbCOkraC+OprCDMktUFojYXaKN9FTvgNoOMLkr8ekX5f3VznT2eFva5D0/nAIy33T7SIbWlHZ0QUDrbERl6za0xbJKIuNWqDf3+p76U1Mw9mZ/o3ecPmPFeXUAf/e/r6VLi8J5nifD84wBAyKBKec5yj/qH2sPzKNzqfnZj5ujA/dO6tvVGaOTxcGEjU1HiT+DWRUTwpC/ioX55X0eWb89lll7OhgSuoWwDkopMy0nO1CpYgC+7A3A7WnBUdDclB1WMtZM3a80ZXTsdJmc/4pz47uDwkGj41AK6uRatnmJixHAN3GZMzO6YLkpwwhRjaAmYJo6JaqPXMYX7Dcds47ShEdvVkve4r1G5YPe4VLL3jq28Pxx83P38/XNawaJtseXtqY3fQgPtlejnmZN9z5EZetfDm0WUKllDHGUsfREwNRwF2NbdsPUpP0y+Hddmza7AF/BzAuxYRq9Yi1Iwt+RwJQGNzplqN7R/uQpem820BEz5nEGJe6YFmWD67u9TLIK+2Wffrivf9h1epctCwC5Zi5Gv0F3ksJBx+H9g4sml7wwuxKb3Txxn1YxGfmW1Uk1bCRjc817TnoKJJh8Qyo5FcniuiRKUC+w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5534.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(136003)(366004)(346002)(39860400002)(396003)(26005)(6506007)(7696005)(4326008)(83380400001)(33656002)(52536014)(64756008)(66446008)(66556008)(2906002)(53546011)(5660300002)(6636002)(38100700002)(66946007)(66476007)(86362001)(71200400001)(316002)(76116006)(55016002)(8676002)(8936002)(450100002)(38070700005)(9686003)(110136005)(122000001)(186003)(54906003)(478600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?AS/T1/OAejWiYb2k+rViKi7up/ZyPqoJB7M1urImvZyrw7HsWa/+H3SBvxot?= =?us-ascii?Q?0dg43Cegx/ImWMdDFY3WOAKBT2LhOrZQhTNiIhizl4Z5ue+LfakcN0holrlT?= =?us-ascii?Q?l23OGul0cY+ROHhtGT4AtxdryNvWn/wSU1oEwQEq2QMvqfMhwHnOOd1baWAA?= =?us-ascii?Q?U15ENNtXJlkCqd+Y5bH06bEzrePjhaL9na1GHtLTKbC5eKDFfyVOzT9am2h8?= =?us-ascii?Q?fDmgc3m1AUep/dR8q59LeLo/LC0aS1OYUrspzl855Gm9hmLwZxHQ1Awh6iWz?= =?us-ascii?Q?45i5jWfihEVDZCdizZUTWAWjJRjyRCrD0H4tvr5a0CyOqymv65GvxUfFDSfq?= =?us-ascii?Q?wbJN4YZcU67+4W3ETRqUrbd7LqUT89iDQmIdkI/noX0PwPsJ39HGMKzF24Uv?= =?us-ascii?Q?rbxaXVoz513EGDtTHiSTWF0Vd50+dmEv/Ekq9lYEyy/ifIbFfIznTriK9+yY?= =?us-ascii?Q?DSEafxVY2pHc8dklF01uVpGsYNX4v5g2Vy8wPUdgO/xw4xUByL7XjMB59K0A?= =?us-ascii?Q?JwAEV41WKGLV1Y/hsfWljJVi8nCxpX6UDx9kf3knV4EhM3h//CHVJSAV86Z7?= =?us-ascii?Q?kn7Mcpr1zXjhWsWvO4fpr9Sjj40Ppfqde4Hr6OrEVcEGwzS6ScpQqGb6rTbR?= =?us-ascii?Q?Qi2fhz0Nvfy9ip1GORbgdtm/C5PJL6+DH8JtZngDdBzjZA25HPeEzVyL41/g?= =?us-ascii?Q?sGd9446C/Jg4/eHSL6PQMHCsauPPvh5ZshoE04rBqHpLyjWBmOEbpy43u7T1?= =?us-ascii?Q?gh0ugtLh3Tq7L/aIX9b1QQJC4mbV7u4f5lW/erozByeMk65s8pKlg2p8dT58?= =?us-ascii?Q?DaxOZEn4P4vE9Qx20k+VnrMFTWtbp1OGCGZ3xL9dJI/h5mG1AwZsNG1Dpzfs?= =?us-ascii?Q?wPPookP+ui2VBGMoChyidrOtg4A/8zXTiEMAV8CAjrl4SdK4xDfCLfqQq+cO?= =?us-ascii?Q?qUg0w634N+aBv0NyEzg3+WtB8b4moWd91zBWnDO313muBUeKM42J2es/vi09?= =?us-ascii?Q?HLtsqY1PqdVH146vdAXSl0jeNHfd5H1MCDdYjojiJE9oh0/SoNoEW1RF1xx5?= =?us-ascii?Q?R6ujuxMn0gSF5voIecbgztPwleRsOcNcCL99s4qeHm78rMf3CM/ErtWIqQG9?= =?us-ascii?Q?isO7zXiW3i6hu+eSkMr7pk4KDY8xmor//BQckxIp8fY2Bj4NButHUUE2Vcil?= =?us-ascii?Q?SH6GnosxREeISa06mSmuUqAPy1snysV80s/riZxsZDCwhKv5yFe0uOcCgIIL?= =?us-ascii?Q?zu4VHRt6m5wPS3gJgVdv7jAkVW97WizHfEiK1rYyodOEKPw5m2zlXxi1rgXr?= =?us-ascii?Q?3dxQcrvYv5/A6O3BM2w9LU2X?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5534.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 49fea28d-8e93-4298-4b4c-08d97a7d211f X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Sep 2021 08:20:09.3322 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AL2FWByfVRyfDE2ipGetPn7GsErQcbjNAcGHwZqfhO/ieZyutQE0IG76GPdCmiNyLEp48cQ+c/axB+1Ivg8bfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3529 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: fix txonly forwording X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi > -----Original Message----- > From: Zhang, AlvinX > Sent: Saturday, September 18, 2021 11:07 > To: Li, Xiaoyun ; Ananyev, Konstantin > > Cc: dev@dpdk.org; Zhang, AlvinX ; stable@dpdk.org > Subject: [PATCH v3 2/2] app/testpmd: fix txonly forwording >=20 > When random number of Tx segments is enabled, because the actual number o= f > segments may be only one, the first segment of the Tx packets must > accommodate a complete being sending Eth/IP/UDP packet. >=20 > Besides, if multiple flow is enabled, the forwarding will update the IP a= nd UDP > header, these headers shouldn't cross segments. > This also requires the first Tx segment can accommodate a complete > Eth/IP/UDP packet. >=20 > In addition, if time stamp is enabled, the forwarding need more Tx segmen= t needs > space for time stamp information. >=20 > This patch adds checks in beginning of forward engine to make sure all ab= ove > conditions are meet. are met >=20 > Bugzilla ID: 797 > Fixes: 79bec05b32b7 ("app/testpmd: add ability to split outgoing packets"= ) > Cc: stable@dpdk.org This patch is based on the 1st patch of this patch-set. So if you only send= this patch to stable, there'll be incompatible issues. Either you send both patches to stable or you just fix this for the future = (don't cc to stable). But the patch looks good to me. >=20 > Signed-off-by: Alvin Zhang > --- > app/test-pmd/txonly.c | 67 > ++++++++++++++++++++++++++++++++++++++++++--------- > 1 file changed, 55 insertions(+), 12 deletions(-) >=20