From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95DA0A0A0A; Wed, 24 Mar 2021 03:03:07 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0DD3A40151; Wed, 24 Mar 2021 03:03:07 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 6057E4014F for ; Wed, 24 Mar 2021 03:03:05 +0100 (CET) IronPort-SDR: YpS7GPBtsjcz8bDFLeXdxLv7TA46vkpt4i7WuXEAEKfaKYrMSYEpZXxeXYFonAouSIepH0Shdu a0NcuSIeAJYQ== X-IronPort-AV: E=McAfee;i="6000,8403,9932"; a="190637341" X-IronPort-AV: E=Sophos;i="5.81,272,1610438400"; d="scan'208";a="190637341" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2021 19:03:04 -0700 IronPort-SDR: ZmjNV36rUlf/cXqwFWGZ8MhvvsYNHJ5DMTYxlWxqFHSoblzHJcNdYWdGZvqLyCWHTyZ6Mw9jx7 69wuhKPbpgog== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,272,1610438400"; d="scan'208";a="408611213" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga008.fm.intel.com with ESMTP; 23 Mar 2021 19:03:03 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 23 Mar 2021 19:03:03 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 23 Mar 2021 19:03:03 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.170) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Tue, 23 Mar 2021 19:03:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y/RjMqVEKZt1JNek2nEyMeX4z1MPPLC6xrWn4bVyBRJeF8/5hlhFDnw6f/gsZfipqCBe+8HoDITIka63/fRaCOrPuh6ZqH0StvYf4NaMG61UjtWj0il06WWBUpPaCohesEhnT2681KFFlLiR+nATv23vs63hAkr/GI9rN6yxzThDptLwLfM807sJhRmkRhAc0tKtQtJud9JmA/ToE8bKn8P5fZRkdBjEkhmUCplAYw3EZB0V8AcrQ4TCFNgk3EgSh8/3TNdRmSI2Jy9GH+lhtq7SeN20HaRQst98pzF1IuoiV0SJ8YVYUxZ0iDqPP0+4550nYLrKaRwTcG9Secuv2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QBWXX0ppTWMjNzCfSzsNm/dbXmMWafzpHIGfHCs2yAc=; b=Gp6a7J2OSe4+Mn3G1oQM604v/fywMywA6ZaNUr+7ckrXynmsGVUtx6onslwpmFKiWtF3561FkpSKkd9UAW42bGwtd2hcdJ8mQ4CkYFRfihkyM2MP8NIkJqXIFY9NIlVsVIym3s8/mRlPhXckTPKcwWJAwvjWx+QdCK0pZAjpSr6KBvTIrWNcwXI7inQFE62L2mCxsaZVSh0+SexEAV+ARTkc1SIHCnu5uNRwwrRQxoNx5BjdiiQ4UFNtWfGGY1GYwn9ODAqnOSwJfljdA7fdnVNDyT7sk1IBmTsLhXi2xF78prtzedP3HVOqHTgdLdlJ7H/4N/56D49j0khY6u2oqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QBWXX0ppTWMjNzCfSzsNm/dbXmMWafzpHIGfHCs2yAc=; b=IwibhR6luENnzAiyDS3RR+cEUR0Jnzbuu9X6jMoEENGDHyKZ+WY9Nb8mXd/s4CWJg6wWjz3e1pID3hjaYVcUqKUyXWPhdlB9n2JI8nycnaFKpxjbhcelpudZbqutz2BaJVhrVT0i+YzEolNDCLf0XIQiQYpwazWcLWjxWf9NAzk= Received: from DM4PR11MB5534.namprd11.prod.outlook.com (2603:10b6:5:391::22) by DM6PR11MB4300.namprd11.prod.outlook.com (2603:10b6:5:1dc::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32; Wed, 24 Mar 2021 02:03:01 +0000 Received: from DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::79a3:3404:b907:d49c]) by DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::79a3:3404:b907:d49c%6]) with mapi id 15.20.3955.027; Wed, 24 Mar 2021 02:03:01 +0000 From: "Li, Xiaoyun" To: oulijun , "Yigit, Ferruh" CC: "dev@dpdk.org" , "linuxarm@openeuler.org" Thread-Topic: [PATCH 1/3] app/testpmd: fix forwarding configuration when DCB test Thread-Index: AQHXEall9yCC4yIwfUueExjyOksydKqRWaIQgABh8oCAAMHOoA== Date: Wed, 24 Mar 2021 02:03:01 +0000 Message-ID: References: <1614939741-63927-1-git-send-email-oulijun@huawei.com> <1614939741-63927-2-git-send-email-oulijun@huawei.com> <2a0bee90-2c74-5f07-aaf0-cba8b94944e8@huawei.com> In-Reply-To: <2a0bee90-2c74-5f07-aaf0-cba8b94944e8@huawei.com> Accept-Language: en-US Content-Language: en-US X-Mentions: oulijun@huawei.com,ferruh.yigit@intel.com X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.54] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 90ba7c20-ad98-4662-56a1-08d8ee68f41f x-ms-traffictypediagnostic: DM6PR11MB4300: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xkjUHlCzJVJDPqb9xqaZEm17X5qodG35KSPduQvcwY5xql8jAPmLTJJOEaeTNTQ1ohE928hVb0Z6ggyc4dMOyHwaavSM3Vi+6aw+xbQ+74n2zPRwRXxq7NNvE0u6C5CuZBaCTBcdXz7JYsfS/chsJWRSCqMhGvQm40yGYBWlmDhikwq4dmWNkLIC6xE1YViP46hRThzdrg7mhYhzO8m+8YULVVetxizD8efTuUCHJJwArPUEKclCbpoolsZZftwtu5auiM+cGqZT+O3HmmoCb5iQ1Co+ugrzvrG43wf+q5nf1TvzOTsGby9kxfsBhdmvrNtEHUACytuMJ3eBDjt+DuaCselvSBQcP3Vmz/gtn0Q0u/uzK7FO+F2LRlFqj7LkHi6woKrsz3HstX0gUeO1msGF19eOCQdJh+49dN7Hc45YqqzfQx78ITzyX3X/zZrmJoQEdsmlmQ34Mktog3aoaBZTEJqyJR7xtl0q8GDfh1LhuA1Hn/spkHsjeA6cIZ95j3S2ulYkw/7qYPj+6EchOrj5J/U03mG2vusIEwpzfdFhlN3Kxl8hZqB6AtU8Ii5iIpPuVt3xZPkEQOUBNqwwHgrOk+ByLhBx9OvuPpH480lhLDLhhmc0bva9fsHgM6bFDaf8MS8ZhYDMcX2GCi5R5OAYc8KG/NlQ27ypzUdTDN8= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5534.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(39860400002)(136003)(366004)(346002)(396003)(110136005)(66946007)(55016002)(2906002)(186003)(6506007)(26005)(8936002)(66556008)(8676002)(9686003)(52536014)(316002)(6636002)(54906003)(86362001)(64756008)(71200400001)(76116006)(7696005)(66446008)(66476007)(5660300002)(478600001)(4326008)(53546011)(83380400001)(33656002)(38100700001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?qRK6MqxNrtdYs3sTFRz+L4g74tL9PJ1ZP/yxola4/MrYBte0qlW6CC7Tjcom?= =?us-ascii?Q?hDhiDh0afH1t4ScGqYv8iQUk7LAcPpAVRqzb/xfRFfpEmjD0s3OhPKF+zULE?= =?us-ascii?Q?GXB4kEt2KztppM/R+zVcWOKtk7wFu7ARx5JTBd8ZjdOTvL7p3vqr/pnbtcpN?= =?us-ascii?Q?HAN1RW9+tcJk7/MJZrufsmWVInbjhC83ROiVEZ1t5+IS3bXZBdVCMOQKDrvo?= =?us-ascii?Q?1kZR5dznG61v4zaXAQXhF+NcpJvRvfvYHDuBzYIWQGjh0Rpa7kZBqik9SFuo?= =?us-ascii?Q?iq1Q184v3zcJfujTXuYv0c6LeilIne6VRqkr7xAQVNGCq9+jNoJpfSUVrivo?= =?us-ascii?Q?r8OgblYGHj27QB2XDBdrcCnkUs7BGyNLYLhAdQ2Vrr4jFA8GRV/3n2J5oaHv?= =?us-ascii?Q?vuVkzSezASIkGrP0Q/RGcM2SM8KETuRnfWiOQsK4xrWx/jqMeT758ow1cyp4?= =?us-ascii?Q?AtVSkc1DYWHK2sOEAwNoMhy0PB3mhDR4OxgFEYt9AsZWWma/AkDWMEgAzhzW?= =?us-ascii?Q?caJ8BzCQiUel7wJ7xN5YvAEhgssics78kb25KG0w72cnIoH0Y+w2aWwNnmAh?= =?us-ascii?Q?WRB0rbFQvGPIFKAJy2G1rIa9atQZDitC9mkN1H64BhbieUr5th2hcoctA7/a?= =?us-ascii?Q?wV9mM7y3EZynNgJhD3SFLOurdsUs1KczuJgwLcDPMQFZjC6Dcj8CecMudru0?= =?us-ascii?Q?MN4+jVe2zwRpso3NIISjU1/laoULqYF7KTfKs1yMqMh/pY/pN6b+CRCKNhD4?= =?us-ascii?Q?QI+vd+thosDQ/rXcX8uuJsw0lqs/C4/Avkh1OoBMYvp5QxnRhiLHFliJ4x6P?= =?us-ascii?Q?lVmqSBwlCD1fDGwXmsWlw5jQfsOYNDOhArVwfeNc2oONu9sMYvfhKFEdOtRl?= =?us-ascii?Q?L3SiO0gdrd46jLZXtS2Wumm4uSTBYaMaXB7v8GfRK7JAkaWAip/H3gURXEfX?= =?us-ascii?Q?JlikFM/AHz1INW3kabZHTJSjZfTe7lx3GmciRpIju43t9bhtpPfY8OstEmwu?= =?us-ascii?Q?bmKfMEwv/fyn+c7DQ2D5RjELenKvL+gv8ZoQXYCRyukDeGwQfh6KSibt7Zaw?= =?us-ascii?Q?i03PBMQQOJNjbkuWiDKX/HU65/16ld/yOK9P9AMTX62rl03vjXkWBTFZnZZ6?= =?us-ascii?Q?/bP8XfDjAj8bQbxGmPy1mz0AagM4JiLnOuTiVjz2b6bXmz2m8mv2/IPTzSLM?= =?us-ascii?Q?nQy9zNY24AFEKkhxFFjg96gE8+2yHWjgdC2RbiCvU8sN+l3g0xIxxZEsWVWv?= =?us-ascii?Q?HDhNb6RPyRHh8onmeR7HGaRNVFrDGyWITgt/YkWq1hDZfAs0FLXze/CBfsAn?= =?us-ascii?Q?BcE=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5534.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 90ba7c20-ad98-4662-56a1-08d8ee68f41f X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Mar 2021 02:03:01.1832 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: raCfZgEzZ7vVnOM0Y60ZnOH/v3xRmHqiLF5oQezv1koOvgh7KvKVwr7ks+2eR2DhQrlDh3sEAb3JCxrlIL09Ow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4300 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 1/3] app/testpmd: fix forwarding configuration when DCB test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: oulijun > Sent: Tuesday, March 23, 2021 22:19 > To: Li, Xiaoyun ; Yigit, Ferruh > Cc: dev@dpdk.org; linuxarm@openeuler.org > Subject: Re: [PATCH 1/3] app/testpmd: fix forwarding configuration when D= CB > test >=20 > >> @@ -2707,14 +2707,16 @@ stop_port(portid_t pid) > >> portid_t peer_pl[RTE_MAX_ETHPORTS]; > >> int peer_pi; > >> > >> - if (dcb_test) { > >> - dcb_test =3D 0; > >> - dcb_config =3D 0; > >> - } > >> - > >> if (port_id_is_invalid(pid, ENABLED_WARN)) > >> return; > >> > >> + /* > >> + * In "start_port" function, dcb_test is set to 1 based on dcb_confi= g. > >> + * So it should be cleared when dcb_config is 0. > >> + */ > >> + if (dcb_config =3D=3D 0) > >> + dcb_test =3D 0; > >> + > > > > I don't understand why are you changing this. > > dcb_test will only be set when dcb_config is 1 when starting ports. And= both > dcb_test and dcb_config will be cleared when stopping ports. > > So dcb will only affect when you set port dcb and then start port and w= hen > stop port dcb will be cleared. > > > Yes, I think. The forwarding streams should not be changed from > "dcb_fwd_config_setup" to "rss_fwd_config_setup" after dcb info is config= ured. > But, now, the logical codes do it when stopping ports and then starting p= orts. > > So what's the problem of original codes? > > > > Your change will cause issues that there's no place to set dcb_config a= s 0. If > you config dcb, then it'll be always dcb mode unless restart the whole te= stpmd. > > > As far as I know, the current testpmd only supports switching from the > normal mode to the dcb mode, but does not support the reverse operation. > And " dcb_config" is set to 1, and then "dcb_test" is set to 1 after > config. You're not answering my questions. Why are you changing the behavior of tes= tpmd? Your change will make testpmd stay dcb mode once set dcb mode and can't go = back to normal mode. If users want to go back to normal mode, he/she has to= restart the whole testpmd. It worked as you can set dcb mode and start port. After stopping port, if y= ou still want dcb mode, you need to set dcb mode command again. But at leas= t the old way won't break anything. @Yigit, Ferruh Not sure which behavior is better, what do you think? And @oulijun can you just answer all comments in one thread? > >> printf("Stopping ports...\n"); > >> > >> RTE_ETH_FOREACH_DEV(pi) { > >> -- > >> 2.7.4 > > > > . > >