From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 31BB6A034F; Tue, 23 Mar 2021 04:12:51 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9C514140DEB; Tue, 23 Mar 2021 04:12:50 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 29FB84067E for ; Tue, 23 Mar 2021 04:12:48 +0100 (CET) IronPort-SDR: ZuBLt5MU7fd6Pq/p1Xo12i64Dusk+J2KWKMeu0p6epTYT4BIrTBnr6CEUBCh+tOKu+UJwyzuAF Vl2ARyIeY+dg== X-IronPort-AV: E=McAfee;i="6000,8403,9931"; a="254391223" X-IronPort-AV: E=Sophos;i="5.81,270,1610438400"; d="scan'208";a="254391223" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2021 20:12:47 -0700 IronPort-SDR: LXQECDiDY554TRZcQ7bSywf0d2jrJ2xoxw1/irX6L6BUWmT21U2sHRX4UmWgX4wH/vOFcKSWsP KNC43s2Q1aXg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,270,1610438400"; d="scan'208";a="451963534" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga001.jf.intel.com with ESMTP; 22 Mar 2021 20:12:47 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 22 Mar 2021 20:12:47 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Mon, 22 Mar 2021 20:12:47 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.175) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Mon, 22 Mar 2021 20:12:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ddFoMUD/P6a4DbIqV1/BDMaN0okfmmGIuiXyLX3KOzme7nuFOBd5W9Qjkz3a9VdTqtx1TqRi8/8ND1pxFFojQMPx0fsEN5234x9DL51ZkUsKkKhku8sUfFYmsU3Q9JdTkpAmz76R45w3xmVrjG6t4P3h7lSa5eFVD0XzcvM6uRXJ+uEX04k0syJ7W+866jZZLwfRb2NJSLY9o/9xIrQZYpGPBkiReeBBcOmtKIrn2Ryj+XM5tb0vtvPBrgoxVEu8I8f292X1FX73Jgxq0voDknxrNBz1qXdbMg38PTrwm28f/JwfFKXqt/Glaw2Pt3rZc1wnkOsSBgUYRBsQDuuGuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9NMpHOvI2+3o/bxxjUF8mY38g1SCs1dkDTKvNT9Rw7s=; b=dfCY/39C0KLIT7nKLWWoTQPDXEErerC9yZyRmkJB1GRwvUoBknY7WYZ+fTw5OM3sMofJ6KFRiytR+fl6UKcfCKD4ZoLKoxysYtjjtXlwFEFOH328jENtkQjBAHr9DqvBKUnPuSvnr4y6h9AKbFjq2CDyRug94pcrIZOFzGWstjwLCKFmpN627kRn34kk/y24zRU2kr1s/IXWSTOje3xNjQbCg0cyig+RdtmYotshvdrS7FRHQk5wJiiZFDK/QuS93G8EUnNLIbNry8W7mlWxCQmdkDZrje1PD9pc5lakXyEl9AG0w8CdI9TuSxn3t9Kre0fe6xXVgTJOfu6/318UDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9NMpHOvI2+3o/bxxjUF8mY38g1SCs1dkDTKvNT9Rw7s=; b=I/vN2OwW3UpiwtJj3VNCWk9xcLsfArGw/Y+cTwMNP3w/w+/Ll3Wf9iyl0Cs1xVK0T92V+qEXdklUDmfMNhC/f5okO9uDRqWxIhzR50NcUgnxsLTQvYZhY/CWjsV7XyMpzy0BBx1N3mZh1nLQNr7fRSfpG0oHmWSL490GdTi5UuA= Received: from DM4PR11MB5534.namprd11.prod.outlook.com (2603:10b6:5:391::22) by DM4PR11MB5392.namprd11.prod.outlook.com (2603:10b6:5:397::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Tue, 23 Mar 2021 03:12:43 +0000 Received: from DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::79a3:3404:b907:d49c]) by DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::79a3:3404:b907:d49c%6]) with mapi id 15.20.3955.027; Tue, 23 Mar 2021 03:12:43 +0000 From: "Li, Xiaoyun" To: Lijun Ou , "Yigit, Ferruh" CC: "dev@dpdk.org" , "linuxarm@openeuler.org" Thread-Topic: [PATCH 3/3] app/testpmd: use of Rx/Tx in testpmd Thread-Index: AQHXEalhyPNaw+FTrkm6DlQ28b24kaqQ5o0Q Date: Tue, 23 Mar 2021 03:12:43 +0000 Message-ID: References: <1614939741-63927-1-git-send-email-oulijun@huawei.com> <1614939741-63927-4-git-send-email-oulijun@huawei.com> In-Reply-To: <1614939741-63927-4-git-send-email-oulijun@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.54] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a95506b2-8db0-4bb8-55ba-08d8eda98671 x-ms-traffictypediagnostic: DM4PR11MB5392: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2276; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +G6kGLMUnk8rhZpbcAxm3Z6rXzzkupBpTX/6aHkmbFTHiRX26NvoLwIOvwAzJ4oYqAQ/rsXX06SkCysmhlPZjjWHwNhvi9XaZiT+FPd55uP9PfzJj2UVbcyUTf8XqnNLd6RRt1+J5WM9KIDa+8trVVPcWCnPHaiyqOpi4JE6tq1mN4hkfnvmD15rSBCyvWheNrLQ85aBK1QbZ1w2yHcE7sLeBBmsmAtS+oURpV4f/4ZAW/toXbQuzB2ovg0mSIhJ1hMJAH0Ps0fzkFdVeQ1hOw3pLa8kZ8jcXHP6pkGXCR3T//QpRf5OGeSvEVtC7Dxlt1KzdQr/PJNWELeH2ZNL/ILzVLDziAwA4WgEu2Pgh1sbedCgjtcaTIIHUmsmPTkDaED3ID2K9XhJQ5GgxxPbhNJTkNbW76fBZPfeQoIT10UnfSkjJ2n4ntxlFaRA3915MpYvI7s+sZ3sQUYlTLBA68Ac+3Zf0zptQ+WT99mNJyehC6IMKg+X9TAjsAJzvJEfMMpaMiI4r3vDVCeU42KJd1Pvk1d3qbBv2czI1Eg754sDgK3Yo+Qt/ar7ggZj1H5JTrFBrHSFsuZbbAqUXsMqIjkh6jawlkugqqVzSyyxpNYDPKZ/ornWt17owXgdXpfChuIPq5iNqU1CBhio1Zu6ZJUyHL+87WIy2Rd1UXQOl7s= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5534.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(346002)(136003)(39860400002)(396003)(366004)(53546011)(478600001)(76116006)(5660300002)(6506007)(26005)(54906003)(8676002)(110136005)(9686003)(316002)(186003)(6636002)(55016002)(71200400001)(66946007)(7696005)(8936002)(66446008)(66556008)(66476007)(83380400001)(52536014)(33656002)(38100700001)(86362001)(64756008)(4326008)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?wVb86Ig8U1S55VE/C3PoeQ7ZE44Phy7W/acFGKCWT5a8UM02fySlZ2betcBA?= =?us-ascii?Q?dcuazZUtCVkDoIAWMEOEITFQ/X7RuIBEWG+lLnNCTxti7WOZaV1AfyRIerbP?= =?us-ascii?Q?gqniKfImWGPwy5hiSw7WcR8sDLqbc2DX6qm6kYGjcxCSLSEUxRDT5KP+UE9f?= =?us-ascii?Q?oGZt2wATtGC6V03ula31zDBSawoB3YG/06jDw6eEcQ6ux+gfVc5LoR9TRZri?= =?us-ascii?Q?iGg/y8hqbolCNfcJQv55BhTssPJ47SUFEfmm9XUOrh+BKHTUWHjhODREWr12?= =?us-ascii?Q?lnZm+9NCIo2Qrtd+TBpSwGjDR8a17MAMev2Q6Nv+4YOOD2wLtPBytKjMpR/t?= =?us-ascii?Q?MPlHtIQozU1hXKUaYCibvEMZkdY5xO+SLeIz+Q0fOZpZxL0iIJqkxTNx6Gpj?= =?us-ascii?Q?pBoT/JgipdhkW4jJIw1+3VfHi4/z30aXkf3jt1uC6KjUsJF9g8TgwXMe77MA?= =?us-ascii?Q?5zkfh/uCNdQSxcInhTcCNQIbvaUpsEp1wnvBgqtf0yLNzrzmZBpIVRqKwD8i?= =?us-ascii?Q?+HXSK3pd7I5Ao2Doy8r5JpuqCzVWKT/OKEtUZzpIPplm2JxDCUaDfLI6GWsg?= =?us-ascii?Q?f63RuwXLXgpIN04upKQ+m9EgCyoFy+sK1DMmTa0sNnCXiuO18w7B1bi5ffDw?= =?us-ascii?Q?kvySFqQ8xGEBerV5LwfPxbkEbf4ZDXrn9LNScNBwuS/FzUaAaWLuyjMfzNLE?= =?us-ascii?Q?iFxvjUbDyl4TnLCHNm4cCkupuDpWxm51ysDbLp49l+L75UcTIBz+W2NVlC45?= =?us-ascii?Q?omfSk4Oa9veVVT3O59hFYkrNxytFc+i9vOWkMdXrW+fBLqu46BDr12ao0chV?= =?us-ascii?Q?7BtQ1KRKyAe+y/CD3la8s6jwBe3O8aO8ml4gD3ZjpOUIvzUDnwDfTgV62Ko3?= =?us-ascii?Q?sWYxzjpZdRLnVCk1RFQdicd+CTBWPgUfO2+xq+MfqFNdTmT5G+K96+9gBR0q?= =?us-ascii?Q?PbGdYotedL8pYvKfqoTGvK7T53PL8leJTZ0u5wTptchzgOi5GwjM3capZg6P?= =?us-ascii?Q?quPSRxa0VBM7G2hOCUWTgSpGU3B6IfrrpMYpzJi1RpLM+jhdHRqq7k5/nawF?= =?us-ascii?Q?zna9YFPFiKOp0LWB3eJy1uxDtYqQdEPjx+RFTz6OG19pan9hV5oYhMhbTc/C?= =?us-ascii?Q?7WfnDTrJFebWHixz7+6ufqmKpXE3U9wxDtQ7RNg+1Dkit2Ga1zstKnpUFJmK?= =?us-ascii?Q?aC+uq5ZDEFn7AGJGL4Gft72ajOScA7PqjLbqXhpYQnwxNMnqa+6A8q0dv63Y?= =?us-ascii?Q?rKvTPFzDQMDtLkhTQTspqGFc8LI/kP3jgH9GoUFTdgJlYBHTRGSTnhyfd9dK?= =?us-ascii?Q?fPE=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5534.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a95506b2-8db0-4bb8-55ba-08d8eda98671 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2021 03:12:43.2072 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: D2tJB/2QUDC4E6wBYfDOJm5Yx9qz6Yi+U9e2GesGh3OD3dDGeWCBdazUHS37x0DKBQlZHzwfCrOCtw9NSf+c+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5392 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 3/3] app/testpmd: use of Rx/Tx in testpmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi > -----Original Message----- > From: Lijun Ou > Sent: Friday, March 5, 2021 18:22 > To: Yigit, Ferruh > Cc: Li, Xiaoyun ; dev@dpdk.org; > linuxarm@openeuler.org > Subject: [PATCH 3/3] app/testpmd: use of Rx/Tx in testpmd >=20 > From: Hongbo Zheng >=20 > In testpmd, when we input "show config rxtx", we can see like this: >=20 > 1: testpmd> show config rxtx > 2: io packet forwarding packets/burst=3D32 > 3: nb forwarding cores=3D1 - nb forwarding ports=3D1 > 4: port 0: RX queue number: 1 Tx queue number: 1 > 5: Rx offloads=3D0x0 Tx offloads=3D0x10000 > 6: RX queue: 0 > 7: RX desc=3D1024 - RX free threshold=3D32 > 8: RX threshold registers: pthresh=3D0 hthresh=3D0 wthresh=3D0 > 9: RX Offloads=3D0x0 > 10: TX queue: 0 > 11: TX desc=3D1024 - TX free threshold=3D928 > 12: TX threshold registers: pthresh=3D0 hthresh=3D0 wthresh=3D0 > 13: TX offloads=3D0x10000 - TX RS bit threshold=3D32 >=20 > We can see RX/Rx/TX/Tx is mixed used. Also in other places in testpmd, > RX/Rx/TX/Tx is mixed used. >=20 > This patch fix the mixed use of RX/Rx/TX/Tx in testpmd by change > to unified use Rx/Tx. The commit log is too redundant. The following is enough to explain what th= is patch does: RX/TX and Rx/Tx are mixed used in testpmd print and comments. This patch un= ifies them as Rx/Tx. Except this, the patch looks good to me. But one big concern, this patch will break all of the CI tests because the = DTS scripts check if the results are the same as expected and this patch ch= ange a lot of the print. So I think the DTS maintainer needs to be aware of this. +Lijuan DTS maintainer >=20 > Signed-off-by: Hongbo Zheng > Signed-off-by: Lijun Ou > --- > V1->V2: > - fix all RX/TX > - rename patch title > --- > app/test-pmd/cmdline.c | 104 ++++++++++++++++++------------------ > app/test-pmd/config.c | 128 ++++++++++++++++++++++-----------------= ------ > app/test-pmd/csumonly.c | 22 ++++---- > app/test-pmd/icmpecho.c | 2 +- > app/test-pmd/ieee1588fwd.c | 18 +++---- > app/test-pmd/parameters.c | 50 +++++++++--------- > app/test-pmd/testpmd.c | 120 +++++++++++++++++++++------------------= --- > app/test-pmd/testpmd.h | 28 +++++----- > app/test-pmd/txonly.c | 2 +- > 9 files changed, 237 insertions(+), 237 deletions(-) > -- > 2.7.4