From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ECD2CA0C52; Mon, 16 Aug 2021 10:48:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6B8B540143; Mon, 16 Aug 2021 10:48:27 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 22D404003C; Mon, 16 Aug 2021 10:48:25 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10077"; a="279563589" X-IronPort-AV: E=Sophos;i="5.84,324,1620716400"; d="scan'208";a="279563589" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Aug 2021 01:48:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,324,1620716400"; d="scan'208";a="504821433" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga001.jf.intel.com with ESMTP; 16 Aug 2021 01:48:24 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 16 Aug 2021 01:48:24 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Mon, 16 Aug 2021 01:48:24 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.168) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Mon, 16 Aug 2021 01:48:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X4qv4BrPZowRSMstW3mVbucBT0ANuw0HMcyYuXoBcFaV7Z7bWUtvEDImpEGVjr7C//iQFPuCl4sMVm6aQw+mnps1w3m1sdnnZa3yz9qtP5cdfUGTBbdV9O3gJR28AIKsmxOWK22CIrmqwDph832SKEhy14Oaw7ajpnDXcTTCqHFLGUc3MzP3PQHt3+3mR/R4OUkrMunBGcpCKuzOG9NM2L7WG6g8NSb/COeuDJDT+yZIAzqC+KELEBK+cQpuuDsjNsSz00Mm5CQOcal4DUR+iSNexCFW2kLOcJj7JNC3mM99BjW/pQuYIUze+ffm/wO3a8kPvDuRxWCeegu8ZWjSEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3GCAfgSToS5WQQGSykTrqs0t2rLsqFNGaR9sh/0/MXc=; b=SI8rJcj5YFdBL4nPfGldWSHpvZVxOIPFkt9M+mynbbM6xWZK0Oh0QcOP9+g3i+Z4PUyNWzmcOCqljV1CZtc6ISCCxKSEIWlMqpoS+uxH2Q10w/nNkFl2r2BLz+/uY63WnG1jgSvE+XiOl3HTZRdlZFH4rdpGzA0KkJ4O7FgYq37rxLBdIDf5OgO/FPKPU2Sq5AcUqxm6a4muC7sfi0jiszZt0S0k8lb5odiYgNCLBnS49X46PN+yjdwx1bH8+firLz7Kt2Ik/DkeLbX04ptMXteiBm0rM5kNfqRYaL/0c44FzRXwXifk6ezEyAXPhIJzsImjZ8OFU0HOTW2oDiRB+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3GCAfgSToS5WQQGSykTrqs0t2rLsqFNGaR9sh/0/MXc=; b=cjlJ9JRb7hADzLJa2dOTEyt91+A8YrXqLpy97KWP4hHMBcy0ZpySeUmL63dVEvk0uxZU+meu/P1MUgdQYhQll5BbRJ3Fi7cfKQKF+IYKRNpdkywJFrWHzfEjR6zQvIA0SI3BZ9i/Gk2uaC5SNJzPgfzM69GpfOtVqIDRSHUdLc0= Received: from DM4PR11MB5534.namprd11.prod.outlook.com (2603:10b6:5:391::22) by DM4PR11MB5439.namprd11.prod.outlook.com (2603:10b6:5:39b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.14; Mon, 16 Aug 2021 08:48:20 +0000 Received: from DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::d019:aaeb:94c0:1c45]) by DM4PR11MB5534.namprd11.prod.outlook.com ([fe80::d019:aaeb:94c0:1c45%8]) with mapi id 15.20.4415.017; Mon, 16 Aug 2021 08:48:20 +0000 From: "Li, Xiaoyun" To: Nithin Dabilpuram CC: "jerinj@marvell.com" , "dev@dpdk.org" , "jia.guo@intel.com" , "stable@dpdk.org" Thread-Topic: [PATCH 1/2] app/testpmd: fix csumonly mode when run without outer chksum Thread-Index: AQHXkm3Ebsm2mHvLNUK7jrrdzrbxFqt1z1DQ Date: Mon, 16 Aug 2021 08:48:20 +0000 Message-ID: References: <20210816070943.26807-1-ndabilpuram@marvell.com> In-Reply-To: <20210816070943.26807-1-ndabilpuram@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 092da840-0e72-4a46-6f20-08d9609299a7 x-ms-traffictypediagnostic: DM4PR11MB5439: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6GInDzoS82JQdZMSxWjYuKC1kb0zA6EOJk9KLdqIeuqleTxJApqH8OKw/KHdjPoqEROE/L/Y1vdJrYNEDVZOZpIMWbJpZc2KT4zaXQkJhoKJPSG5CW8hv9tWLAh+0xG3e1kkPM3PdV+tsofjy4CXpUtyjaW1XgKr6K24GKsxiXSMLgEPMWLMglgBAteNa2u3JaxChoNswPYrGAF9qlfGMfN8PtDOdbOcflG9zdMQkSlZRoJdPBdVhONwhiBz244Ck2Pg5AZoBNfXlhS9mHkSHwN1IS9C1lkOSqYEjKvM50g5H+0bEJO3395C4gtDLr/wTTH/GmHKOYQtlF0GZlRcxR+s2bVQapoLXSLL8xUwYwwBkHl0/s0etAOnprZnXPhAWE39A/2QBgdwzle91fYMgsw/qMRRN3YV65yTs71MKreh8GP39ocydxH+FkIrmArFQoiuOxv6RoPhZckhsKI2bYYs50C/g9DOZbS8gUdDlAREiHyEdxWAMYPuqkACBL+YhIoRK+onjQGy7S3klwSdcZ/cnEwcbIl1tmJRSuSciAuYP/C8z/Cnr0P7p8sLTAILZfP22cG0CJKDDZZ4cNYbFeys2POkhVvmZK1ich8BPBv3SvUTgxYD4qrZbUvqdwWwXRilrMbxGvfoJrGQCxKhta9EJULiU+B9LHb8cs4x2WLl7tpRpLcmZ448DuniCUgV58lh/m6Fho5SF2Klej+87Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5534.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(366004)(396003)(39860400002)(136003)(5660300002)(316002)(33656002)(2906002)(66946007)(55016002)(71200400001)(38100700002)(9686003)(4326008)(6916009)(186003)(76116006)(7696005)(122000001)(38070700005)(53546011)(478600001)(6506007)(8936002)(8676002)(52536014)(66556008)(54906003)(66476007)(66446008)(86362001)(64756008)(83380400001)(26005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rl79JT4eKJUBDb5VT2IAje+56ZCBCD1JWRk0cW3XV2rF4YKFr/Oqas+6J+bH?= =?us-ascii?Q?cEK7clsJluTVg5kHi/2F/+oiO9QFqI+2U+o1cBUnwTqQl8xSO0NmP9O3mAoq?= =?us-ascii?Q?wSeOlKY5ActFg/ETVe37ptdxIl/x//vGeqsp0/3fHafR4HLxSBJ+W2ZdTfhP?= =?us-ascii?Q?Bvnqg5tsHmvfJyU3tFqLqIi/JF6StAAQU8dofy2LQmLGuumigFWdtZGuLasS?= =?us-ascii?Q?cKY2oTzJNau+bnHXrGPjjMCEnmGIJWAhIJBEw9Ivn5M7xpjSskxHgIkQysYP?= =?us-ascii?Q?MGreuurBBGvAA90LL/US+xRBk9m60y6OsM4qRl/tEPf1CXSXt733luf3CHyj?= =?us-ascii?Q?cWOMXPtAWft76DzIFxjsaxTa4T1f0EZ9sBLUQ2Gkl5FwLQ7I9C9nBVOoyOjl?= =?us-ascii?Q?uRtJnn0un5ZmOs0gwrc1b8HcYkmRiD+dn56bJwJMUfbfeWhxKAj6EHiMTvOM?= =?us-ascii?Q?bb+b/GooO04WGYImxeZ7Jz6X4oL6mn2ANWmwfUF3DfbcNAOCKahpERgpdl3a?= =?us-ascii?Q?PQ7kgiJuyk240oueE0Z15exQ8WG/74WImEMHhZOcGtF+R6GhNIXQH/Ibv5Cy?= =?us-ascii?Q?5GHQlRMRT3Nq2A4B9w6INEu7bG/rylxel19247uByUpexlXv7uHUmC0bVa0e?= =?us-ascii?Q?V6uIKjHd8SjYNJaPKqZW9WzNcqMqOwIGk23zuMCfwFf9WqXLleRFgA/zwq+C?= =?us-ascii?Q?3OOR/XMLPbgxf8ePhpYOcNPznlN8GlWqtR+nKlWNiMpHZ6J0k/F6Jmx9sMW6?= =?us-ascii?Q?k9Z5ycoQ/ZWdn5AHLqfoR3RDqMZbdM+0ftRUyVxQb+GL7fhbe8Jj8F8IxYjF?= =?us-ascii?Q?DgScxPz2Hbftbl0OS/eOe3ljncLzs/SwJA2YuYG0VfQ9qsHggQVELUY4d05d?= =?us-ascii?Q?/yi2/CZJKqMfjalrOIXL/vtXclaDIDBR76Y4PlrZOsXaJnMCDSK4MFme3Kyq?= =?us-ascii?Q?cFlHuccnXzaMHf8o6k43zlO8HkMBZv9/jSU6nLQgABgAAUKfdxb+FrCzN+RV?= =?us-ascii?Q?c8y7hYFsd3b5i7qedpiEEd4Cu7Sj0Vg37/via5vrGQpAInHOZCuip8rTfae5?= =?us-ascii?Q?w8Cvcg/cRmZh3Qc8IOPrE1ENo5bahu4EFlX1tNuvqOJGJD+ys1kzco2iZovv?= =?us-ascii?Q?ykXS64OnJwjscuEQPWforFXEI1donf9I9K6r69NhKN1EhSxEyfAsRHw2+X5f?= =?us-ascii?Q?ATYt21nPIjJYdkGbW3Aoyacz7vHoovRFKIX6SdTVrrDT5gi6IrKVFp8pBnXi?= =?us-ascii?Q?f8yjXQZwlK4lRPyJHnYfn5SBEXzm272k6t0LfPeg4FDefgToEWVLqOO6LGpF?= =?us-ascii?Q?h3Q=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5534.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 092da840-0e72-4a46-6f20-08d9609299a7 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Aug 2021 08:48:20.8407 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MdZXahjxiI9/Qbkq2L8d/bbIBol0+ubF7TeqlPiJUIwamJk0JIBd4ViDKZHLQ9FWtVOVEuPT97CH/WqIhpFmcw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5439 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 1/2] app/testpmd: fix csumonly mode when run without outer chksum X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi > -----Original Message----- > From: Nithin Dabilpuram > Sent: Monday, August 16, 2021 15:10 > To: Li, Xiaoyun > Cc: jerinj@marvell.com; dev@dpdk.org; Nithin Dabilpuram > ; jia.guo@intel.com; stable@dpdk.org > Subject: [PATCH 1/2] app/testpmd: fix csumonly mode when run without oute= r > chksum >=20 > Donot use outer metadata when neither outer ip checksum nor outer udp > checksum is enabled. PMD's will ignore the outer_l2_len and outer_l3_len = in > cases where none of the outer checksum is enabled and hence only l2_len a= nd > l3_len will be used to calculate the offsets for L2 or L3 header. I don't understand. In process_outer_chksum, only PKT_TX_OUTER_IPV6 Will be set if it's ipv6 pa= ckets. So PKT_TX_OUTER_IPV6 means this packet is tunnel ipv6 packet. So it actuall= y needs outer l2 len and outer l3 len put them to hw. At least i40e needs outer l2 len and outer l3 len as far as I know. >=20 > Fixes: 3c32113a1aac ("app/testpmd: fix IPv6 tunnel checksum") > Cc: jia.guo@intel.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Nithin Dabilpuram > --- > app/test-pmd/csumonly.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index > 607c889..38cc256 100644 > --- a/app/test-pmd/csumonly.c > +++ b/app/test-pmd/csumonly.c > @@ -961,8 +961,7 @@ pkt_burst_checksum_forward(struct fwd_stream *fs) > (tx_offloads & > DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM) || > (tx_offloads & > - DEV_TX_OFFLOAD_OUTER_UDP_CKSUM) || > - (tx_ol_flags & PKT_TX_OUTER_IPV6)) { > + DEV_TX_OFFLOAD_OUTER_UDP_CKSUM)) { > m->outer_l2_len =3D info.outer_l2_len; > m->outer_l3_len =3D info.outer_l3_len; > m->l2_len =3D info.l2_len; > -- > 2.8.4