From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id DCA45A0C46;
	Wed, 22 Sep 2021 07:58:20 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 7A0D94003F;
	Wed, 22 Sep 2021 07:58:19 +0200 (CEST)
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by mails.dpdk.org (Postfix) with ESMTP id 1E1D44003C;
 Wed, 22 Sep 2021 07:58:17 +0200 (CEST)
X-IronPort-AV: E=McAfee;i="6200,9189,10114"; a="284534557"
X-IronPort-AV: E=Sophos;i="5.85,312,1624345200"; d="scan'208";a="284534557"
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 21 Sep 2021 22:58:17 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.85,312,1624345200"; d="scan'208";a="550117247"
Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16])
 by FMSMGA003.fm.intel.com with ESMTP; 21 Sep 2021 22:58:16 -0700
Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by
 ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2242.12; Tue, 21 Sep 2021 22:58:16 -0700
Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by
 ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2242.12; Tue, 21 Sep 2021 22:58:16 -0700
Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by
 orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2242.12 via Frontend Transport; Tue, 21 Sep 2021 22:58:16 -0700
Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by
 edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2242.12; Tue, 21 Sep 2021 22:58:15 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=bT4gSGvKEEJv5MHgsbuzY9eonz12B3zkBigiykRGhhmSWr37EUbC14k1im+XCBtvxAXaAvNQHMo1pWRbZ4VJjB7ps3DDZiaYTREnfRJtCxhl+3IyRuAOn4rydrefikiTFvcOETtYMzSXZ44E22SdLAXIVt7MCb7EhXsJmUW4HyQiq0Ebdu0qw+lXmPTcZ2YgJaMQt2tsNBU7by1oxtuR45rHeQImtC240V9CfQk0XAwGP2mPcuXce5vUFdd8bvEj2doP18fzQ7WwSV3L8nqa7flbFHKifyVeMeTaLifG5HC1q+iiEMCPA+ckGERrV0BPJ7dm9gfncMOFk0ivrtHw/A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; 
 bh=eXaNFR9aXdyzViRexbZdh8ARtYNgm02hfaQYiS6wn68=;
 b=IHAGHKRfCr1XlsgNVLN+VBlU8skBdS8T9CwnlFYdJDi4yp1PdBIZdzMinkcOr+tbU8ozlfmReBu8xP1i9tatg9j/WR0xIjspNpt0vn5h3gAmdXeCnK8Us61ebEjaWZs0nus6wlWzpg+3hzrJKBfjyiUyLma9tHpRroYy3lkFNYiUk/n5rP3Wx2X0mwF/MplXImCN4y4XPq4rmbR9fe+szCqLcDDuWfxrhUo3ySx1TZy/h7fTf70IkWZNIyvbidUgFN2yb0qLG57MRTGp+aNVL0eBiNiKZmNgN4rB4Rfiw1/gnNxYpcMT6hNiougQtOcYPhdyIVDOhI5DkSBXjFoe0w==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; 
 s=selector2-intel-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=eXaNFR9aXdyzViRexbZdh8ARtYNgm02hfaQYiS6wn68=;
 b=bJvvLFALpaVJkh8d1JR8fz+bYXfzO6f8d05VxhAgjTFgzJfmgZ6Tr3X5wRq8fNB11vlAdnK1SCDTijvIEISA0c7XZgsruHR5gyHd9mQTowSCNeYmybLdbJEvu0svaMKskzGNzmeVCBFBWXf+wL628Xc1HVrP9AQC9T5RSd1Gwrs=
Received: from DM4PR11MB5534.namprd11.prod.outlook.com (2603:10b6:5:391::22)
 by DM5PR11MB2041.namprd11.prod.outlook.com (2603:10b6:3:d::7) with Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4523.17; Wed, 22 Sep 2021 05:58:15 +0000
Received: from DM4PR11MB5534.namprd11.prod.outlook.com
 ([fe80::3d9b:76d7:e274:bad3]) by DM4PR11MB5534.namprd11.prod.outlook.com
 ([fe80::3d9b:76d7:e274:bad3%3]) with mapi id 15.20.4523.020; Wed, 22 Sep 2021
 05:58:14 +0000
From: "Li, Xiaoyun" <xiaoyun.li@intel.com>
To: "Zhang, AlvinX" <alvinx.zhang@intel.com>, "Ananyev, Konstantin"
 <konstantin.ananyev@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Thread-Topic: [PATCH v4 2/2] app/testpmd: fix txonly forwording
Thread-Index: AQHXr1yYNIrhU0F7JkGeIJgpsiJzkauvjpgQ
Date: Wed, 22 Sep 2021 05:58:14 +0000
Message-ID: <DM4PR11MB5534F9A79C69A37A60C54B4299A29@DM4PR11MB5534.namprd11.prod.outlook.com>
References: <20210918030659.12448-1-alvinx.zhang@intel.com>
 <20210922024952.11848-1-alvinx.zhang@intel.com>
 <20210922024952.11848-2-alvinx.zhang@intel.com>
In-Reply-To: <20210922024952.11848-2-alvinx.zhang@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: intel.com; dkim=none (message not signed)
 header.d=none;intel.com; dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: ddec382f-90b1-4289-c63f-08d97d8df7b4
x-ms-traffictypediagnostic: DM5PR11MB2041:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <DM5PR11MB20411F59E86CE7A0510C485999A29@DM5PR11MB2041.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6108;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: QeW/FR/tLbs/7ApbqR5obx9TAVj2cditExtmnD2DEZrzXyiFLl3Ah2LBwFIOE3HxN85pLLx60bdH2BK5Ldc6vNHcJuDjCxDNqMgDIxZC3F+RSPILB8BOYTM0UPXrszTwC6KAGLR9VvocoYYNgo9NpdwQesjFKYN+1sQwGgFDCZucMlFCiuQ3VXnV6uMJtlpIpcUvNsSca7mo8xMEQnJS3aUi+KbzLa4qENOqnoys4qNXj5CsFlMeASQCNa+rlxQYgp4ztfN68Nnq0c0cG77E3SrVWsZeT+n67jxYx509EOyNOp0DS7khCpDLxr1SENOLmgp0WFlJQ8MAXrD/uQueVf8ej4h5ybXESdftP3hiFFVgxNx+FvxsKkBqlkvOtz44oviRM3Wpu/XXiqhSnSlncQU9++bbo/A+yuB1qJIzENjKeE8AqvJpQwpcKdEAFmqAiFlhvwv6R59IluKrQS28xFdHUTJSqK4UN7ecoaD+uqxwAIxP2cAclO+kkUIGRn7cou2mfDjWQ5chvrsrUbbHwgweBzHGgW2djKMn4S8iLB/et49+peOXa2evGexDMZyEb/FRNNlmYUeNayX6qxTf0GASppNzg1PxH82UXp0B9BVCimapwVZnWVLcQo3SVVbEYc6WUPJ6h4vOGRg6eVPavFRzC+Hq58faxWBU4b20VfmeRJiCbVFSf/5r7T5dV0LDtvx7xba8eT75nRaUIO97fA==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:DM4PR11MB5534.namprd11.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(4636009)(366004)(26005)(64756008)(66476007)(66946007)(55016002)(122000001)(38100700002)(38070700005)(316002)(66446008)(110136005)(33656002)(2906002)(8936002)(5660300002)(53546011)(186003)(9686003)(52536014)(66556008)(71200400001)(7696005)(8676002)(86362001)(508600001)(83380400001)(450100002)(54906003)(6636002)(4326008)(6506007)(76116006);
 DIR:OUT; SFP:1102; 
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?oUwfQVIdejVFsBQwzmB+L47mPfQhO453vSVotQfLNOuybjA72hf8cOS3t4px?=
 =?us-ascii?Q?tXSOFjerSVy7rf213CeCYfTSpkDTanktCzWEf9E4A9TtXfW1PqAwHNveyXw+?=
 =?us-ascii?Q?OP2kkf7IwOMZG4tDwLV75GUEeMmaP9F2sTqOcY07cztO4hNhvJL7kgH1vSIC?=
 =?us-ascii?Q?pqSzBqfoOTyarER/EF6AEPkXhq3dWZYGanwG68YZI+MyAxOO0dTw7B2f2gOu?=
 =?us-ascii?Q?dsVs9n/D5oI1QU5D2sdmeexDpoAaeTGAN0LnkRTV4cYZDm3GdxzP0g8/Tod+?=
 =?us-ascii?Q?lgJijmWyIRVrjk5MFRW1UFNCS6WNbyXIH1/9mm3BBH4+CMT53+tqBQkgAkCp?=
 =?us-ascii?Q?yGpLvXWeedHUuoJGGl0/8CE7W/aGRFhXTDoIOBh+cj8vqfUM81AVnkPKDZz7?=
 =?us-ascii?Q?2RSWIOgIBdhd/pb/gXFCpcvh+7KxsvXXGe8xsulRxSq93BCbKfLOplDmJVlR?=
 =?us-ascii?Q?+c7ftCSbsVDRDxr+Dsuy+fLDSg2n5sem1JwP/FBngCLYju/g3YSdFW5kZxCu?=
 =?us-ascii?Q?aFezT2fEL6cE6emLAwTEWFIreVCr4PQ9ZPgBaD1dD51EmJ+HDOwbfcHILyfy?=
 =?us-ascii?Q?6e0sfSNb8Zlur/zsPdo9EzRxBDTRaUKxNxXiP2Cig7qcpO0un3NiQB7TDWer?=
 =?us-ascii?Q?im1pllP1MyZb49q/VHYFE9fYWdE1JBdXz3wXVwXICO4PSnPgP9wfq98HE3CU?=
 =?us-ascii?Q?tTKYs6MigmMljaas0BAnKNGmZiE7tNQA42bvXddwl/CSYRdltOfrQdPTT1Wa?=
 =?us-ascii?Q?r3XSs5ZrYQd7sPQIaJhhAJXOiIYz50CfrN3j5vHhemS1bDwvvF53IyvzLRLc?=
 =?us-ascii?Q?M+4Otm5LtaEfIQtDehcKHcE1BbcxFyNMs6bS18W3nB5qIg3yFOYlcFySrVWc?=
 =?us-ascii?Q?AVWZXiD2h/4EngFt+A23DYt2eG9CTgZ8cHNWWGgAUOK+cqf8/Hm/JDVd7g3D?=
 =?us-ascii?Q?vap6ve3MqFGIETr9+DnU2cnhUz4UvcJuqqeu1Da/DUAj9n0BITFeeFZdo9y0?=
 =?us-ascii?Q?DfN+IFYsS5wakOLew9REt0jey6cSvF34E5bx/3zb1GN0W3l98jxLbPidT2Jd?=
 =?us-ascii?Q?ev1ET81GnE+Ffa3sH4hYRA7/sa+mUlja6l8qW5WaGy3H6nUtlaRI5EV2jmca?=
 =?us-ascii?Q?XGLxIRll59XqgWHUFtgpllxheLFb+NOAxbDMFZBCJP3a1tmR6C6k1Eu/GdQU?=
 =?us-ascii?Q?boI8dhBy4dSxdXzrngpi0YqEqHokjTICsATN89XgdzfAUqOc5b8e1/C4AcJu?=
 =?us-ascii?Q?FFpoZwYuoTaxwHq9BNvPqGtTJqlwU34fLgvW69lUV9A8cGqecZjm8OK7SvUB?=
 =?us-ascii?Q?E/M=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5534.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ddec382f-90b1-4289-c63f-08d97d8df7b4
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2021 05:58:14.8041 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: seCkGR3PDZdHDZDpy/ayLgkV9rWmS5csQDoXXA13E93lh8rjKdCA8muCa4QiFhU3zNC3feDiqtuS1efBgU9Raw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB2041
X-OriginatorOrg: intel.com
Subject: Re: [dpdk-dev] [PATCH v4 2/2] app/testpmd: fix txonly forwording
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


> -----Original Message-----
> From: Zhang, AlvinX <alvinx.zhang@intel.com>
> Sent: Wednesday, September 22, 2021 10:50
> To: Li, Xiaoyun <xiaoyun.li@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>
> Cc: dev@dpdk.org; Zhang, AlvinX <alvinx.zhang@intel.com>; stable@dpdk.org
> Subject: [PATCH v4 2/2] app/testpmd: fix txonly forwording
>=20
> When random number of Tx segments is enabled, because the actual number o=
f
> segments may be only one, the first segment of the Tx packets must
> accommodate a complete being sending Eth/IP/UDP packet.
>=20
> Besides, if multiple flow is enabled, the forwarding will update the IP a=
nd UDP
> header, these headers shouldn't cross segments.
> This also requires the first Tx segment can accommodate a complete
> Eth/IP/UDP packet.
>=20
> In addition, if time stamp is enabled, the forwarding needs more Tx segme=
nt
> space for time stamp information.
>=20
> This patch adds checks in beginning of forward engine to make sure all ab=
ove
> conditions are met.
>=20
> Bugzilla ID: 797
> Fixes: 79bec05b32b7 ("app/testpmd: add ability to split outgoing packets"=
)
> Cc: stable@dpdk.org
>=20
> Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>

Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>