DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Zhou, YidingX" <yidingx.zhou@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "ktraynor@redhat.com" <ktraynor@redhat.com>,
	"Yang, Qiming" <qiming.yang@intel.com>,
	"Zhou, YidingX" <yidingx.zhou@intel.com>
Subject: RE: [PATCH v3] net/iavf: revert fix VLAN insertion
Date: Wed, 9 Nov 2022 00:45:40 +0000	[thread overview]
Message-ID: <DM4PR11MB599400C94FF25CFDF1D10259D73E9@DM4PR11MB5994.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20221104061000.1868113-1-yidingx.zhou@intel.com>



> -----Original Message-----
> From: Yiding Zhou <yidingx.zhou@intel.com>
> Sent: Friday, November 4, 2022 2:10 PM
> To: dev@dpdk.org
> Cc: ktraynor@redhat.com; Yang, Qiming <qiming.yang@intel.com>; Zhou,
> YidingX <yidingx.zhou@intel.com>
> Subject: [PATCH v3] net/iavf: revert fix VLAN insertion
> 
> The vector Tx path does not support VLAN insertion via the L2TAG2 field, but
> the scalar path supports. The previous commit was to force to select scalar
> path as soon as kernel driver requests to use L2TAG2.

In which situation, that kernel driver will request to use L2TAG2?
> 
> That logic is incorrect. Because other case like VLAN offloading not required
> but scalar path selected would have a significant performance drop .
> Therefore the following commit needs to revert.

What will happen, if kernel driver request to use L2TAG2, but still vector path is selected?

> 
> commit 0d58caa7d6d1 ("net/iavf: fix VLAN insertion")
> 
> After this commit reverted, the user can select scalar path with the
> parameter '--force-max-simd-bitwidth' if necessary.
> 
> Fixes: 0d58caa7d6d1 ("net/iavf: fix VLAN insertion")
> 
> Signed-off-by: Yiding Zhou <yidingx.zhou@intel.com>
> ---
> v3: rebase and change commit log
> ---
>  drivers/net/iavf/iavf_rxtx_vec_common.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/net/iavf/iavf_rxtx_vec_common.h
> b/drivers/net/iavf/iavf_rxtx_vec_common.h
> index 4ab22c6b2b..a59cb2ceee 100644
> --- a/drivers/net/iavf/iavf_rxtx_vec_common.h
> +++ b/drivers/net/iavf/iavf_rxtx_vec_common.h
> @@ -253,9 +253,6 @@ iavf_tx_vec_queue_default(struct iavf_tx_queue *txq)
>  	if (txq->offloads & IAVF_TX_NO_VECTOR_FLAGS)
>  		return -1;
> 
> -	if (txq->vlan_flag == IAVF_TX_FLAGS_VLAN_TAG_LOC_L2TAG2)
> -		return -1;
> -
>  	if (txq->offloads & IAVF_TX_VECTOR_OFFLOAD)
>  		return IAVF_VECTOR_OFFLOAD_PATH;
> 
> --
> 2.34.1


  parent reply	other threads:[~2022-11-09  0:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-18 10:26 [PATCH] " Yiding Zhou
2022-10-18 12:17 ` Kevin Traynor
2022-10-19  7:54 ` [PATCH v2] " Yiding Zhou
2022-10-19  8:53   ` Kevin Traynor
2022-10-20  1:33     ` Zhou, YidingX
2022-10-20  7:47       ` Kevin Traynor
2022-10-21  2:42         ` Zhou, YidingX
     [not found]           ` <CY4PR1101MB21039FCA7958A8B49BF5521885389@CY4PR1101MB2103.namprd11.prod.outlook.com>
     [not found]             ` <322c348e-3461-c7ab-a845-2782ffce5ef9@redhat.com>
2022-11-03 12:43               ` Kevin Traynor
     [not found]               ` <MWHPR11MB18863EA1EEE5DA7452AF7899E5389@MWHPR11MB1886.namprd11.prod.outlook.com>
2022-11-03 14:42                 ` Kevin Traynor
2022-11-04  6:10 ` [PATCH v3] " Yiding Zhou
2022-11-08  9:26   ` Zhou, YidingX
2022-11-09  0:45   ` Zhang, Qi Z [this message]
2022-11-10  2:10     ` Zhou, YidingX
2022-11-10  9:57       ` Zhang, Qi Z
2022-11-11  8:18 ` [PATCH v4] " Yiding Zhou
2022-11-13 16:30 ` [PATCH v5] " Yiding Zhou
2022-11-14  0:52   ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM4PR11MB599400C94FF25CFDF1D10259D73E9@DM4PR11MB5994.namprd11.prod.outlook.com \
    --to=qi.z.zhang@intel.com \
    --cc=dev@dpdk.org \
    --cc=ktraynor@redhat.com \
    --cc=qiming.yang@intel.com \
    --cc=yidingx.zhou@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).