From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 34862A0093; Wed, 9 Nov 2022 01:45:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D41BE400D7; Wed, 9 Nov 2022 01:45:46 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 29E7E400D4 for ; Wed, 9 Nov 2022 01:45:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667954745; x=1699490745; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=OdNoQk1FfhmvGHuBfDTT8OI0zdBQ0g2+s0e0m6C3iwQ=; b=Kws51WDGQDHVJ/BBXy12Vz1HrrnWzCKCvKYhtvGp2ce6GQO9J3RBQPdh Gk+JFYwUYcUzxcO3zgK8JWmXTV0B24CZNz8l9huFuuogyq12vQOpVWWS/ imvT2fN9orZTGU1MApDiJuLXQZWhpcIWT16gP7QovVCEugnJc+S0a8/0G mTyx3vr3yjz7wYqy21AJoOC5h841T2jnqVIor7h4sJFQCgC8pA/cyxNep Bwv8OHQQpanOWI3Bju46v42q6uki1BcX0drUpxZS8M/WzChm/mHFkmOYT AH2Kx1syh8jSV0PogKLW3OOMkESLvYOhkUSrQEqcnDSxmjtZLJVZYRATF Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10525"; a="310846493" X-IronPort-AV: E=Sophos;i="5.96,149,1665471600"; d="scan'208";a="310846493" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2022 16:45:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10525"; a="700140406" X-IronPort-AV: E=Sophos;i="5.96,149,1665471600"; d="scan'208";a="700140406" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga008.fm.intel.com with ESMTP; 08 Nov 2022 16:45:43 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 8 Nov 2022 16:45:42 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 8 Nov 2022 16:45:42 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 8 Nov 2022 16:45:42 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fk+A2uoyNr8YzLNHs4Q/Sz50OfQf4Oa3Hx9J8WOEnh8upOj7gjQOGpvrDb00vW3VsoUa2EKFj4ghZmfjL6rPwM7C5aAxLN0Ls4l1YPXMJSAm/noqHolvU4QHaxpeY+P9hwFF6i6oZrJIXh18Xg68fm6r353c9FNu9EOT+D2PH5Zcz1eGQbBWGAN1JTpe1dt65kd0mujiBVrXwaz8AmGDgQQPOq8iYd0zksf4owCv9bQf0xVI823YEsZnEhG7NqPinz7b3pEM24SjvCgM2D+OVUqY/OBRNIr63TeL6aL4+g6aiDCiIz8Et8Im8An4d4Shiv4j4u23R/END++ewBjnKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SMpJcX/XsxKTPvoDLDRfHGo/B1caN9RoHpN27DAa6xw=; b=RN8rXR5nHYI2OY3LC5AFLPNBxkoOAQHYeN/ZdJiLfzjRWcF6a+tXGdArCQBt4ikAizsNRg73qBLjfo7u9qQICgIdhCWuDXFAIEIbCo4oB6jnOodhTIiL6yPc7Z8GyEBigjhc3G/X4AOzsL/XTc6dvN+GCVtJdHDCzC2ZsC7OPXVxlR9G0GaTRX0w9Sa6ZydBIF4hUewCS3gfiNUnbtccpAzGhSBpMe5I+t20Z2EZ/LfBceB8fYMlTnZgp9WrObfb87sGEk4OgEUg3TlZU3/oBQKrIuBFq0RrKS10Z0XCTAjr8dKMUxMOsNvQF96yLPmqC+iqUmYRR/YbtJLv2aAkXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by CO1PR11MB4817.namprd11.prod.outlook.com (2603:10b6:303:98::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Wed, 9 Nov 2022 00:45:40 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e2ac:cde3:4d74:3fa7]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e2ac:cde3:4d74:3fa7%3]) with mapi id 15.20.5791.025; Wed, 9 Nov 2022 00:45:40 +0000 From: "Zhang, Qi Z" To: "Zhou, YidingX" , "dev@dpdk.org" CC: "ktraynor@redhat.com" , "Yang, Qiming" , "Zhou, YidingX" Subject: RE: [PATCH v3] net/iavf: revert fix VLAN insertion Thread-Topic: [PATCH v3] net/iavf: revert fix VLAN insertion Thread-Index: AQHY8BOv/ekGxRx3fku15b76gQrira41yL/A Date: Wed, 9 Nov 2022 00:45:40 +0000 Message-ID: References: <20221018102602.217673-1-yidingx.zhou@intel.com> <20221104061000.1868113-1-yidingx.zhou@intel.com> In-Reply-To: <20221104061000.1868113-1-yidingx.zhou@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|CO1PR11MB4817:EE_ x-ms-office365-filtering-correlation-id: 2f5d4655-b3c8-4b58-2c43-08dac1ebba05 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DqbHNBcUX35DEMhmtFZpxwqyVKpVhq4eMFlOL2BUsWYjAXXDLWraiZ/p/jaLyiJ4pGklAMP1pUW7Feutginl0rQB3wUDgpZMK6TsxlRQa/K85SkaRouF8VW9d+iiZw9bY97zB8x6pDIXZ0PbW+8be8UHmN126EiLH9x3G2s2r8QQkOAEtEFJz8UWdRK6CmRwXCJS162d0CnED3RR71/0Fi583SBTU4RX2fVopcF5LjSIksm/+g7CvMuSb5PVgna+Qct7F5WvLDL59LMwYmGgwZJ1+efQ8/NV3VbLSriEJl6DOUjhRTceMXuX9x3w7+dqD3L4rmoKoWJyZ7fbsbeBNQAFMqu2uUO617krdt610v/nRYO1BDc+Z77VvJHwxgwoR7d78mEZY3P3IQIlo4u7Q7jr2ygbSvkQjJiw2Z7bGVShvsiLDKXHoGQo6HQJgICaYjavi9WlvLwOP7NHCVYBBVbg/TKX6Tw7mUsU1F0fW3Ia1MFiladAeG06RXVQvzWzkbVQIM8wEOAtnpON0JwxWQa9n5PnHP3Hknfkgo5glH8rmKFSF/HjFrr0h8h789rKFWuQFdpPvuvBy1KPs5RnE4xWZnjREK5TXhdD14qGMB4zqjtO54IJQl3Djgloy9dOmPxsMs1Cgd6Miv4RpPAwVwT8dMeShsELE6ktz2T9g7DjoYW61s4jW7knGDrSUz1Ogp/grzRi7gZZmJdaQDlrrghZ8S0bZHmr6vNy8jEQ0EU6wIwofyh00FhGtarKW0MUmNG/+Jy0wbUVktwYKIwQdA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(39860400002)(136003)(346002)(396003)(366004)(376002)(451199015)(2906002)(107886003)(5660300002)(316002)(55016003)(110136005)(54906003)(66556008)(66476007)(66446008)(64756008)(66946007)(4326008)(76116006)(8676002)(33656002)(478600001)(52536014)(8936002)(41300700001)(71200400001)(83380400001)(38070700005)(122000001)(38100700002)(82960400001)(6506007)(7696005)(86362001)(53546011)(9686003)(26005)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Qb/3te1LjOOjDz3zCTflaGgLSUfrQCK2vFVoIYyfkWCZklq/3BWgIA8XEcFN?= =?us-ascii?Q?0BHBZMxMKVnYUSDvaQpLCynS44vXBVMEch3N9frBb1XSQ4zZBRiYB4wDaV/B?= =?us-ascii?Q?CmR0ZPoLpnKn2SFfrYf/agbEliu4nFA0AKvFtohUIxZAF0nDsjw2srrPcyRl?= =?us-ascii?Q?TpP8mfBKTisi8Foum3nbD8Myq1MyhMIIKNakR6jMXf6lwgfPMCWRe1kBEEtc?= =?us-ascii?Q?f9dj+TGgNMDqL+7ktfzLOqN58mxhyY9X/njTvSsWWwAazl2WnREG2AX9/P5T?= =?us-ascii?Q?WzjLh90zqdM5YDAx1iTQe4exstG5CLzhoDkCDoQmTrcEreM73CDKwh5TUyDk?= =?us-ascii?Q?eAsYjVsFBqEr7vH/RWXRynSnuT7+iplJkEebehtURVCM+HL4LAeoA8ZhV0zH?= =?us-ascii?Q?B3P64wVGUaSzeWZTovCgAmYu0xYO3tdxBU+5Mo9wvg467Gbwzib+NGfY6qbX?= =?us-ascii?Q?jTSINTpFA1pRs280iWLKsruB0qAwIuEkwBLwAsRU33lW1qrXQmkk8L4N4TR7?= =?us-ascii?Q?Y1nhTHZZztpMlqzA7m2HLtRVcSU014unsXCxhsuIdhq8htKKQNp0S0ErCcj8?= =?us-ascii?Q?Fr2RgEvg8XtvHV50/cMXrwuvPaWsOn6m9P8dIqM6AH1MCQmeg37clwzHA63N?= =?us-ascii?Q?uVrpiZEDwZfDGoWZHTmgNHmTTEhN5UwbHB0tMUVk0ApWy8/nayfDotGXQZu6?= =?us-ascii?Q?JoljDRy/nD2Nd0eRBK6+tprWZzSe5Y7H94ch7FLIOtYa7yPXHZP+E7yVFy6S?= =?us-ascii?Q?DthoISGL43lYQDK+C0lYDzsP8DSBe1Q6witViSsEvbGPYOldV1mC2fec/ZCJ?= =?us-ascii?Q?uPFIiEv+TL/5WIz27+Hl9KgM+YoaJ25X02DovcHcfbVI/QyJvHFvCVLBiHD0?= =?us-ascii?Q?mxHJUhkPwhDrpMcSNb7GOLQypFyvD/yM0e6V+OOAL9T94OUuswU8ZvTVUUmH?= =?us-ascii?Q?9Kg58dfGW2HMSewu6lekYzADXA8aTL+J3C9kcoDc5oOeqrloDJj0OmPJ7cB6?= =?us-ascii?Q?Nz9ok44Bo8mtKBKQ3y9JQR4x1sBilKoZCpVeJLOdginjBumrVSiPJkCUqMUN?= =?us-ascii?Q?F6r9yE02QVl2I7QSkc6fCArxbqGYkIpipNdkJhCNLjeSmXYgLVT7d2dlJOr6?= =?us-ascii?Q?keDT3NLw1iWrjLyjRp2cnDnSpfBv424pchQuxPt9/pUlx0/V+vneYpd7SIo+?= =?us-ascii?Q?dOR02BHyJbtbEnpchmSU+xmd60aoDIwHCa6aizPSEDywPNhE2CCi3GuExoCw?= =?us-ascii?Q?U+IZyZafsTNCRoiGztt1xv3qGTgFmx2OUM4SWCzFR0RVA8aQ9teHSPJXGtiQ?= =?us-ascii?Q?OkNMI4o+OyXQ0TEUMXOYvE2GfmaL2OWEpiqfld2x9hvEMMjLbthMNJDtKcKX?= =?us-ascii?Q?XBu42olKMgWYIQ55Cm9MYPzuOhONOZ3TL2gNkmmAgj1GtziqhRANCTzhdClo?= =?us-ascii?Q?jW9ZyGA6dCGSesP+cXIccqzvTox62QZM+Yk4gFVtCtuofycZfkUsH3uOM1Qm?= =?us-ascii?Q?m9exSieMcTie3BcOk5cQv5XcI+6hbgTzTNIk+uvNHlaIljZZCNtO2ldJs3SZ?= =?us-ascii?Q?bwQGbZPgi4jqbGXQG1UD6lk24EhfVp303AX6ly2a?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2f5d4655-b3c8-4b58-2c43-08dac1ebba05 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2022 00:45:40.8241 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2vqo7VdARwxjJwgLMpPAu2hH+3pyd1fba6nIaRDIPlwm8ghnS0v2COZfeZm3Yd9B2IAM5AlpPKWmhm52yulkQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4817 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Yiding Zhou > Sent: Friday, November 4, 2022 2:10 PM > To: dev@dpdk.org > Cc: ktraynor@redhat.com; Yang, Qiming ; Zhou, > YidingX > Subject: [PATCH v3] net/iavf: revert fix VLAN insertion >=20 > The vector Tx path does not support VLAN insertion via the L2TAG2 field, = but > the scalar path supports. The previous commit was to force to select scal= ar > path as soon as kernel driver requests to use L2TAG2. In which situation, that kernel driver will request to use L2TAG2? >=20 > That logic is incorrect. Because other case like VLAN offloading not requ= ired > but scalar path selected would have a significant performance drop . > Therefore the following commit needs to revert. What will happen, if kernel driver request to use L2TAG2, but still vector = path is selected? >=20 > commit 0d58caa7d6d1 ("net/iavf: fix VLAN insertion") >=20 > After this commit reverted, the user can select scalar path with the > parameter '--force-max-simd-bitwidth' if necessary. >=20 > Fixes: 0d58caa7d6d1 ("net/iavf: fix VLAN insertion") >=20 > Signed-off-by: Yiding Zhou > --- > v3: rebase and change commit log > --- > drivers/net/iavf/iavf_rxtx_vec_common.h | 3 --- > 1 file changed, 3 deletions(-) >=20 > diff --git a/drivers/net/iavf/iavf_rxtx_vec_common.h > b/drivers/net/iavf/iavf_rxtx_vec_common.h > index 4ab22c6b2b..a59cb2ceee 100644 > --- a/drivers/net/iavf/iavf_rxtx_vec_common.h > +++ b/drivers/net/iavf/iavf_rxtx_vec_common.h > @@ -253,9 +253,6 @@ iavf_tx_vec_queue_default(struct iavf_tx_queue *txq) > if (txq->offloads & IAVF_TX_NO_VECTOR_FLAGS) > return -1; >=20 > - if (txq->vlan_flag =3D=3D IAVF_TX_FLAGS_VLAN_TAG_LOC_L2TAG2) > - return -1; > - > if (txq->offloads & IAVF_TX_VECTOR_OFFLOAD) > return IAVF_VECTOR_OFFLOAD_PATH; >=20 > -- > 2.34.1